From nobody Wed Jun 17 01:58:17 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 291533D6CC1 for ; Tue, 21 Apr 2026 13:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779374; cv=none; b=ZotJo03dTLspwRzZxxkh618vNW4Tjkv8dFgL/V8gMUWABDYk5sioL2D80lQBOfb2mIKGRWiBS9BbT4RO49WFYS0J/QyAz/Z3NzSBCvx6ehavtDKHcRpgEzQYzl9gwDi0ext2Djka3rACivcGCoFBOUF1XCsP9w+kIXXdchCGO7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779374; c=relaxed/simple; bh=eU2PqVajCx7C9hG12bCOjfZ2cSR8pQR5MC85pWwkEJM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JTk96wGk5QkHKPQl6vzYaUVOMGUsXlwJrsgzkZLdNnru8Oawb3XscGUot9X1LXZ1hPXSJIzU/wwhqL9Xjw4LOkcNyCVucsJHKtrrQzOxJ4J81qfTAnpu1fzgG72xG9EzhT+X+fue7364/LwNv2E2mXVGeMLNZjT+g1gpXfE76hU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M4jrl6sW; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M4jrl6sW" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48a563e4ef7so6793025e9.0 for ; Tue, 21 Apr 2026 06:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776779371; x=1777384171; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YkmQzi5Gnl//BDK8FQBprWJdIzhvbcB7BpCe6DN/Jac=; b=M4jrl6sWmdKIycdOcrf3MkbusxYOZ3IAHQfF4ZaJEH1azu1bTU4RnuF3KoNXQNUijC feKee3bxVPpEW9aqGU4lwCR+AsR+/Ki9+G2xRJcyJeW4mgJLOeNhbkhmpUdeDAr5Q/eI Mlb359q+J6LouX3KBJE19eFxu23VTaoAr7SLDTEIIfvh3Xd9XzX4CwlyGKCl62KmZel5 9owbh2s9i4qokv7oXxklMw8r03u1rpT8RDs08b9ZO5T9BrwTOvH5ZriN67NHq90w9QNq O5ak9MSGQJus/dX8KEklOURzV2jmXopCCYLZc87AtT2Faz4X0irSEstzTOo3lHA1DbBM aZng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776779371; x=1777384171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YkmQzi5Gnl//BDK8FQBprWJdIzhvbcB7BpCe6DN/Jac=; b=AqDnRpCo7MZnYW7WIfafmCES46Md/BtrY/7ym/NpJs7vMlXqGesJh/ijcttn/bh5NZ r2sSoonZLWKR/vcoOBi4vk3md4qQv4qpJgU3fdgEhT+u4DSaBILeuRdwWA1QDLYHO125 bymzgHa0WDB5fmvSKQT8RYXUV6OOe78wdTKuBKGBfhHBbbdGkJw5kt8eR9iChvF5p9fD EAEeNygX13ib1JDD4iNyX9yFr/0X32AjmgIzQupAXNEWSAZlXnrgsWdLWqOXO4eIZGQj rK1uwnwq+1q1c9gNToy+14hqiqevDsa8aqeeUtpiFpZiBrz6mKqWbC2z5QgxEF/fHy6T 15AA== X-Forwarded-Encrypted: i=1; AFNElJ+E2UKgD4l9HrjYSrg2qbU3UTaNEHwsT8/5g4sTYa6ZMdc5t30gBemsF/U39yLiD3mM1fi1TmisWXmPkTI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5fRetV3WsfIkM9oRlQFnqx1jpOI3B68vaRuQfao8shIFsXIb4 TPPb+0inxcaXmX+Zqzo8/yrbWp6S75pnkOIVMR3ag+UF2bv2fVkwZ1i3RnWX X-Gm-Gg: AeBDiev1q9Bghpx1h/8m6RirTQtL22o8keRjfkram3n69KtWhqQgwhyqRqajmJODe1h sCE5XDkqS+C8QkPWxOtBtJGlw0kKMNXGBZcaVDX2As66i8uB9csQ30/yB2x4GWv0ZlRpcR4Tywc E928eKODeVJM/+uSbNXk+nUANRl1gM0oJK1Z94raozzUIgwdSbDfRaJrC2v4chnw4iUpt1XJJnU 1v5C+SuM22NetDsyolmnW59GPUOBM75xgqfWxbD2AzN76o5Vmgnb0QwmnJBn3w4jHd82HLC6zBz IGhGRaweSfIYo+XzieEqxAY+dxJ6BAta4V4+lfQCi/b0Q1IHXEhU2xXjYWcUMW9KKI+4Pbed66X jFROBsw6ERu6PPE5dD59dwReDbdiMyUMTpt3dldKkMc87yMBiL+UtCE/26PK9CqWw/jsASjP6fU SZHjk= X-Received: by 2002:a05:600c:3e05:b0:486:ffa3:594 with SMTP id 5b1f17b1804b1-488fb78049amr264260995e9.23.1776779371241; Tue, 21 Apr 2026 06:49:31 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891c318636sm168157785e9.7.2026.04.21.06.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 06:49:30 -0700 (PDT) From: Tristan Madani To: Christian Lamparter Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani Subject: [PATCH v3 1/3] wifi: carl9170: bound memcpy length in cmd callback to prevent OOB read Date: Tue, 21 Apr 2026 13:49:26 +0000 Message-ID: <20260421134929.325662-2-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260421134929.325662-1-tristmd@gmail.com> References: <20260421134929.325662-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristan Madani When the firmware sends a command response with a length mismatch, carl9170_cmd_callback() logs the mismatch and calls carl9170_restart() but then falls through to memcpy(ar->readbuf, buffer + 4, len - 4). Since len comes from the firmware and can exceed ar->readlen, this copies more data than the readbuf was allocated for. Bound the memcpy to min(len - 4, ar->readlen) so that the response is still completed -- avoiding repeated restarts from queued garbage -- while preventing an overread past the response buffer. Fixes: a84fab3cbfdc ("carl9170: 802.11 rx/tx processing and usb backend") Signed-off-by: Tristan Madani --- Changes in v3: - Regenerated from wireless-next with proper git format-patch to produce valid index hashes (v2 had post-processed index lines). Changes in v2: - No code changes from v1. drivers/net/wireless/ath/carl9170/rx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/= ath/carl9170/rx.c index 6833430130f4c..f6855efc05c0f 100644 --- a/drivers/net/wireless/ath/carl9170/rx.c +++ b/drivers/net/wireless/ath/carl9170/rx.c @@ -150,7 +150,8 @@ static void carl9170_cmd_callback(struct ar9170 *ar, u3= 2 len, void *buffer) spin_lock(&ar->cmd_lock); if (ar->readbuf) { if (len >=3D 4) - memcpy(ar->readbuf, buffer + 4, len - 4); + memcpy(ar->readbuf, buffer + 4, + min_t(u32, len - 4, ar->readlen)); =20 ar->readbuf =3D NULL; } --=20 2.47.3 From nobody Wed Jun 17 01:58:17 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C34C73D7D87 for ; Tue, 21 Apr 2026 13:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779375; cv=none; b=N9f8lh/K9GYL99qmqK+RIs48ff8LOOXB9QV4WR5b3dFaRLAGQ0fujVzc5BWYrKv026+py0NmqDNAhOPrwPavEBUU5wPfOufLW6XW8FmY7g0Y4+DNHpI0I+XvjL0qNChvKPGW1w2d2GrklsI7LAFqR6fD+3ev9f+hEUEU2iVPN0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779375; c=relaxed/simple; bh=C4CFfRMF+3s24k+rhrCDQR+uVdUTHr9rVtxeNjumJ48=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T9cfG/L23sYxUlMs0UZrvai+bOOjfb75PRpHvzgSI5uxSp+Kn5yq0p/oBuEKHQ6TIYSHhkrdBcRoqDucX0ZUQG2l3mHHuPijp74Hc59a9pW+04ViViqEC2eov2m9mbvC5V/hjNTwHLCxLiFCF35DhkaAyb84k20kxtNVRRvgXTI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dmlz6TXz; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dmlz6TXz" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso57579075e9.3 for ; Tue, 21 Apr 2026 06:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776779372; x=1777384172; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rOBaqxwAYj1dQn8NQqyR4iLTgA49hrzkake6CNNEDys=; b=dmlz6TXzJExaehm4AFO/VV8YW5qWFclnc+kWjcGu7MFWPuVvMhCOLMUmsodAerHUPZ 27B4elwj+cgt2cD89C3L8Y/hkHD6Da1S3JM29G97IskE1ji8yhxHq6HeIxmULQXdlXaM MaGuc5h7paxOM3ukvhfq7Sq1ktjiepe/9T6M1DDedAWPFn3hiSH9Fq1Q/jOJwFyFMA8z hdehKGYSa8eyGQg7SkBji8VTWMzVB3kZwS2iNPce+LT7rZHEKw3fZBpYgh5sovWztUek ntkQd07jDOEp6wsQ0hTuaE6kOmV5SOm61Jjby2KJL4U4I+tixT7Kw1nJOf7DuCaYJgM4 MIhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776779372; x=1777384172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rOBaqxwAYj1dQn8NQqyR4iLTgA49hrzkake6CNNEDys=; b=W4p4tUjS4+KzsndC3M5KZ32s2uj7wqKkyseqquAjwK7qEkFy+lIxXzX0EiYLdOy0rO Ao/eGpUXGyTURZ9VjJ5cFkNUr50lALV1FIwZJMk0emQcKP15D5cEbldVMr1UUfYM8Esc DDzyhh++iIQsGjxAlISB535EqclJuZJ/uSYyZkzGS1stMjRMMzbHgpp0I8x2GknfghpA XZu2D/AFOFW34YWtLEgdduhUt5DnuKHCB7OqHBWinnSkCpPeF8N60m+VIKzSaZHm4cAi jHZ4Do87CbziSuCb7ua9BZ1mZV6xVR7+3eMOqkmaNliIIz8vea4fsKOMCsJ4cSDgPrNI MChg== X-Forwarded-Encrypted: i=1; AFNElJ/9kCn0Htb9xm8z+ph72fvQsF/Dg+npEHzMQGI/FiZ8aRAk1k3W4APjvdDR8JCgpS+9U2nSP0H4zL/5dSM=@vger.kernel.org X-Gm-Message-State: AOJu0YyMa3yf5CRQBE8jJ6ZDO5ulnLo4rpojidCVHUEBHJcoeCQmcbKd i8AnzxFcYUO0SHPOla5eq6eXt/8FPBCD82FBf4DcKYwrS4j8KZNtxy3D4j/t X-Gm-Gg: AeBDiesWpsT5UUZP1ECmfb8EufOyPRaja+8frQsHQQyNbhsBI2cUSRoWbG7J6twbeD5 +inzVpoEFl+733HZqcLlJdarK5EoJakTXwGajCWRQXdVkWBirDFTOxmwNkAJJ58hYmqfKZcvTNi xxhWLKweFHtZ+yzGv95QzP8roC1XaK1uTyY1CnSizKxqFb3XspzlHM8BS50Z2e0LWs/1g6GaAHg 1GyoTjdluYT5U3vu5KWoVRtQ2RnoxuiHRQtax2lMqOG/W3em0jhQ7LbzIrNLVSfl0TnFbVX9e8z zMxSbsGfRmzfsirzA1Z2TA9U1L2Ahi7r9tHxWhQhnGsb09GVZu0kP6ktZ4izhZua5TrJnecWid7 P9Ld1nhAptKs+2GVSMfBfnMZw6CRlm1mbeGSK5Og/HIeaw70Dz0sexLQ3FqDUaYM4qyoh0RDLTR 6HGm855UruQtsGsw== X-Received: by 2002:a05:600c:3483:b0:486:fba7:b150 with SMTP id 5b1f17b1804b1-488fb7787d7mr240927445e9.15.1776779372074; Tue, 21 Apr 2026 06:49:32 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891c318636sm168157785e9.7.2026.04.21.06.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 06:49:31 -0700 (PDT) From: Tristan Madani To: Christian Lamparter Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani Subject: [PATCH v3 2/3] wifi: carl9170: fix OOB read from off-by-two in TX status handler Date: Tue, 21 Apr 2026 13:49:27 +0000 Message-ID: <20260421134929.325662-3-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260421134929.325662-1-tristmd@gmail.com> References: <20260421134929.325662-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristan Madani The bounds check in carl9170_tx_process_status() uses `i > ((cmd->hdr.len / 2) + 1)` which is off by two, allowing 2 extra iterations past valid _tx_status entries when the firmware- controlled hdr.ext exceeds hdr.len/2. Fix by using the correct comparison `i >=3D (cmd->hdr.len / 2)`. Fixes: a84fab3cbfdc ("carl9170: 802.11 rx/tx processing and usb backend") Signed-off-by: Tristan Madani --- Changes in v3: - Regenerated from wireless-next with proper git format-patch to produce valid index hashes (v2 had post-processed index lines). Changes in v2: - No code changes from v1. drivers/net/wireless/ath/carl9170/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/carl9170/tx.c b/drivers/net/wireless/= ath/carl9170/tx.c index 59caf1e4b1589..06aaf281655b1 100644 --- a/drivers/net/wireless/ath/carl9170/tx.c +++ b/drivers/net/wireless/ath/carl9170/tx.c @@ -692,7 +692,7 @@ void carl9170_tx_process_status(struct ar9170 *ar, unsigned int i; =20 for (i =3D 0; i < cmd->hdr.ext; i++) { - if (WARN_ON(i > ((cmd->hdr.len / 2) + 1))) { + if (WARN_ON(i >=3D (cmd->hdr.len / 2))) { print_hex_dump_bytes("UU:", DUMP_PREFIX_NONE, (void *) cmd, cmd->hdr.len + 4); break; --=20 2.47.3 From nobody Wed Jun 17 01:58:17 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A049A3D88EA for ; Tue, 21 Apr 2026 13:49:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779376; cv=none; b=hlbMa/Y9MVWPYsvAcWU0cRKGVMBkbjrMapZBwbYjkBvVYN4lLorNEzWd47YwleRboxd78EUNfll6zxjqe7joL8mkiUct7JdpYNr8EQclg9T5CerTSzAoZr8y0R0BWAMAsFwoFKBhARC+FO8H33JWzlkUlCrGUwqtbMQseRWmwlE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779376; c=relaxed/simple; bh=kYvWMaR/h7jQFecF2mQH90g51Vwmu+kwPEDpTh4He54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VIXXVAoDV9qQ9WFMPKNsEwGVzLPv1PdXvCYNurzKG89YPMXdmfg3VzZK8nlxpAOBk4bVBL8aq/LToZKVO2xfn6OgJ7s4QKGNdPSXEeGTvUpdXETP8HSBX5wb/4CguNK7Y3v9vsnLZXKGOvNi5sAw8WVqN8hJPPHxd+v2VQs8iUU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=enzZt690; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="enzZt690" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-488e1a8ac40so54572895e9.2 for ; Tue, 21 Apr 2026 06:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776779373; x=1777384173; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VkPIrWAw2BJnj1bF5bBeqq1kiMLomS8oH1yW25eMUD8=; b=enzZt690wIPTv8rUnsAFMXS8anbekKv5SfZ6ttWmeKmxORRtH697jxdLj5xN1oQMH4 2t27rlT4/iCOGYmnYIhQ3rgK/i55ehAmZhh2kXy4IQK+5hibGipTALO+IoPqdB24id3e s84MFWWIHmPmPvCwUDhxtpC9gEWGE0cTbFNGEHpraYWUezYKVMngiZnxlH6ZmvaFrJRc NuQnLUqgdX0Bvsb5kThFeRNm/EzYmNztqxrWmhxdUjUOnYVz5aPm0udHr5wHPEnO7XjN awx+gQ+7zdhljwzXfo8Q69tRkpNV6TRXdTxHNJLGaptC35QofJhIf136Imcx7fCFmWM4 qixQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776779373; x=1777384173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VkPIrWAw2BJnj1bF5bBeqq1kiMLomS8oH1yW25eMUD8=; b=PjcZJl/A6pRVFDiJVQkcYDc+Wc+EvhAUBsIwyAfWuNmKGEPeoj9/NjnVSeYWPw9VG3 7uxhbCI8pAFDKaGao7EEIVfuBYOX4fi3RMEejXaSizEAj/vmy9+l2JhguiOEIkX2B5hR DTx4atpk5Ey+i6j3eCYFBMtWc+EEqO1QXS7wpEwmEUch/wfywSCHG5N1zPoDy/ydI9ni x1MA1tCuGYX4nJwK+uMXePU4svAk4WD6AeoKJhFRQwVZ+FQOWYGZXMygovcVA+kiW1FG xqHiogmntSyePDdp9+qC4WuJ12FTRo6JmjgZ0RzQz19A0KKjcxWVfCbiqXZbQiAyhCOS Gi4g== X-Forwarded-Encrypted: i=1; AFNElJ8f9uhCeiX4aFkYtNqAXKg53t+7C5ZweKGkBVm+rvXrfItJfiYNSsVkuXY2TYAbLB3sWrAw/a7/O0InDaE=@vger.kernel.org X-Gm-Message-State: AOJu0YxPhsaak3UrLQljGg5vNbFrZLIlkX3bY9gnS/Wzxafiq+KHMIk5 yLJ3wBqTWYXbck+khckuVZMhDctLUeW0HwglkEYKtqNsiEAvDgWDxW0= X-Gm-Gg: AeBDieuQIpjW8KiZ3Yjzv63lhuUPI0RfGt8VOjkGlW0tkR/mmT1WxlhQZX/45w7klcp UqUC0vMmxVVG6gpTj/5RKT+hJvA7D47AvNqtP6ajy15v+AKcKGGoQvVYCe9gEYdTk1h8yUOtMC/ gjgInTWFWGgDNyDX5LSunAMyYeV4wtqmskvE+4urMuvAiG9MzDTV75LxE6EBLdkQJrRISDMaK2r +gIdG/z6bKUwbf8JW84WZHB3i3nkjUinKfxPK2Oaks+9wNOu2Qyg6KBYl/8QeOuvnyjv3YJx5lc yv3wLW+yTWWpfjWq+9BaEVNZAxTWb236r6SUL9v/o/vJ/IVPADrDqY7uHsIckKHyP2/WXJL5ykp 4iXzHPuNxCHBQzjD1uvNLYhNiq239UcKJbaeGkhSb+9+QDJ5VYaMVEbwnecfFtQgrBWpfRPbMjI j9yJ0= X-Received: by 2002:a05:600c:c090:b0:488:9e54:94c0 with SMTP id 5b1f17b1804b1-488fb74e130mr187792215e9.8.1776779373034; Tue, 21 Apr 2026 06:49:33 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891c318636sm168157785e9.7.2026.04.21.06.49.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 06:49:32 -0700 (PDT) From: Tristan Madani To: Christian Lamparter Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani Subject: [PATCH v3 3/3] wifi: carl9170: fix buffer overflow in rx_stream failover path Date: Tue, 21 Apr 2026 13:49:28 +0000 Message-ID: <20260421134929.325662-4-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260421134929.325662-1-tristmd@gmail.com> References: <20260421134929.325662-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristan Madani The failover continuation in carl9170_rx_stream() copies the full tlen from the second USB transfer instead of capping at rx_failover_missing bytes. When both transfers are near maximum size, the total exceeds the 65535-byte failover SKB, triggering skb_over_panic. Limit the copy size to the missing byte count. Fixes: a84fab3cbfdc ("carl9170: 802.11 rx/tx processing and usb backend") Signed-off-by: Tristan Madani --- Changes in v3: - Regenerated from wireless-next with proper git format-patch. Changes in v2: - Use min_t() instead of separate if-check, per Christian Lamparter. drivers/net/wireless/ath/carl9170/rx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/= ath/carl9170/rx.c index f6855efc05c0f..ccadc46385240 100644 --- a/drivers/net/wireless/ath/carl9170/rx.c +++ b/drivers/net/wireless/ath/carl9170/rx.c @@ -918,7 +918,9 @@ static void carl9170_rx_stream(struct ar9170 *ar, void = *buf, unsigned int len) } } =20 - skb_put_data(ar->rx_failover, tbuf, tlen); + skb_put_data(ar->rx_failover, tbuf, + min_t(unsigned int, tlen, + ar->rx_failover_missing)); ar->rx_failover_missing -=3D tlen; =20 if (ar->rx_failover_missing <=3D 0) { --=20 2.47.3