From nobody Wed Jun 17 01:32:49 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 239B13D647B; Tue, 21 Apr 2026 13:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776538; cv=none; b=tDSup4lr6jgC2qnKKaDxaXpH3wXfUjDEZ4YEX4xKajt9RL9S0Mvhn1uiVr26cOMrmmDGmQvdnLp7rmAdc7AoaTk3H80QTc+auqN6z2sXWHtjcCx1i9Be2V+Dqf/3FsRHVwvKcv9kk80GyZmEGhyREDONSlbiihap1a1vTbbOryQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776538; c=relaxed/simple; bh=CkfDx8VuNVH8TbkuU+p989cQvobVMXMonGaGvMeEicw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KJn6dvNLf6Bb21vr4a8yaQ8qTxni7HBGdM57setWRwDOkNRhIRvrkf/laNieNORiCXqnoNcxrAhodAedX+rqWZjLYNjs+YvBNsdkH+0Zlf2jwISzPCrkXvBqH5i04RJ9uj9zkW8nKvMj3ZZ/3Nzaap2Xetc4y186kUKxnqpxwx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LjD9CAl2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LjD9CAl2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEDA2C2BCB6; Tue, 21 Apr 2026 13:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776776537; bh=CkfDx8VuNVH8TbkuU+p989cQvobVMXMonGaGvMeEicw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LjD9CAl21jtzi80KbT94A+a0cZihcpR2cDp4RmCzaq2mH5koDnhfDu3M0UHXZoKLn pcUpoJSZEtzkPWn63oHHfvT4MLGwS4hwudh8Vi8xq+UXuYlvHEp73eLYXvjVAwQngz 2E0IZQ00Rde6RF7AcrN3dRX5eWUB+DbvfyPkFtp0unXHC9S8cJ2TVCagOKUjytDKZX NNDAiPDP8JJz9wt10aJZjDTPsmL1FdXLvi4F1bIAxEn4N8ZTM9WMYNWpdHbN0mf1Wc fbzEIR879aCHr36GOUu7FK7N4V89yRiw4g/tfQywdD3erNyRVB/9Djvxv3f1z44OTX aBUd1dpYcHB3Q== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wFAk3-00000006S0r-2mUh; Tue, 21 Apr 2026 15:02:15 +0200 From: Johan Hovold To: Mark Brown Cc: Russell King , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 1/3] spi: orion: fix runtime pm leak on unbind Date: Tue, 21 Apr 2026 15:02:09 +0200 Message-ID: <20260421130211.1537628-2-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260421130211.1537628-1-johan@kernel.org> References: <20260421130211.1537628-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to balance the runtime PM usage count on driver unbind so that the controller can be suspended when a driver is rebound. Also restore the autosuspend setting. This issue was flagged by Sashiko when reviewing a controller deregistration fix. Fixes: 5c6786945b4e ("spi: spi-orion: add runtime PM support") Cc: stable@vger.kernel.org # 3.17 Cc: Russell King Link: https://sashiko.dev/#/patchset/20260414134319.978196-1-johan%40kernel= .org?part=3D6 Signed-off-by: Johan Hovold --- drivers/spi/spi-orion.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c index c54cd4ef09bd..c61ebfd1d18d 100644 --- a/drivers/spi/spi-orion.c +++ b/drivers/spi/spi-orion.c @@ -811,6 +811,9 @@ static void orion_spi_remove(struct platform_device *pd= ev) spi_controller_put(host); =20 pm_runtime_disable(&pdev->dev); + pm_runtime_put_noidle(&pdev->dev); + pm_runtime_set_suspended(&pdev->dev); + pm_runtime_dont_use_autosuspend(&pdev->dev); } =20 MODULE_ALIAS("platform:" DRIVER_NAME); --=20 2.52.0 From nobody Wed Jun 17 01:32:49 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 238513D646C; Tue, 21 Apr 2026 13:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776538; cv=none; b=VZyDAwMMBXjD4zIxPJ9ANE+7a3pPG8OJ1ldzOPdkq+nAcMowm6sPh7AMOPl0N2Ci376i+x+7AU/8dl/bMmBQGaVyVVXAyRMkszA5fJHDmiZzYvkiJQxcmY3Pe0JkLFn+A/hXBXsStJsLO2leRgA6snWzrkmAH4gZEHjWj9rJrQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776538; c=relaxed/simple; bh=846VjW4Nlxcmbqblp8RsOVDvtgBdU72+KDiNQFuM5N4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eEXoQQqYl1mouNh8GGg+RfaaqhkjzTZ4kpsK8yxjJRvJYYuxoQdHJRK4g4bKsg6Tsg9y0+dUcSr+GeENoSgiWTzrBK4PoMTxvXA2D/yT9BQLpbMXbiSRdC+szSarKlZ4/uMusN/gdRQMx3VqZc/76+YZaVc5lpXF/eK1rQsSso8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pop12fNt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pop12fNt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5399C2BCB3; Tue, 21 Apr 2026 13:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776776537; bh=846VjW4Nlxcmbqblp8RsOVDvtgBdU72+KDiNQFuM5N4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pop12fNtlEo5mTj9MG2/vYAFTxfDarVlpUqIrWn1RZ/plOv4m/D9YM9ILZbHjIt+s o6/W0dpb8e86vvyxaVW9XvwyPQeJ+JlBKrANHB5XExHe3RkTKAq2/nXIO2e+zQlDcF bXGv8mvBizoIUMZuyX7bfKsJ7bsmYL4fQx1xSRWY2uH6Gp6HZlOBQe7qPjMiKUud8x LfR6pvslmPm5LeZJJRoJO9gUlJXj2yZ0KKMKmuF+H6JwDqrVZCIRGnKrRrDbnK/LyO U+fhoFaOM3VuUxDTFObB0W/Kkg3dylAENcVF6Cml2zaylDBvq+jtTR4M3Mv9njFCJn 9q752APmMxoYw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wFAk3-00000006S0t-2oue; Tue, 21 Apr 2026 15:02:15 +0200 From: Johan Hovold To: Mark Brown Cc: Russell King , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/3] spi: orion: fix clock imbalance on registration failure Date: Tue, 21 Apr 2026 15:02:10 +0200 Message-ID: <20260421130211.1537628-3-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260421130211.1537628-1-johan@kernel.org> References: <20260421130211.1537628-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure that the controller is not runtime suspended before disabling clocks on probe failure. Also restore the autosuspend setting. Fixes: 5c6786945b4e ("spi: spi-orion: add runtime PM support") Cc: stable@vger.kernel.org # 3.17 Cc: Russell King Signed-off-by: Johan Hovold --- drivers/spi/spi-orion.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c index c61ebfd1d18d..a5ce970ff5a8 100644 --- a/drivers/spi/spi-orion.c +++ b/drivers/spi/spi-orion.c @@ -774,6 +774,7 @@ static int orion_spi_probe(struct platform_device *pdev) pm_runtime_set_active(&pdev->dev); pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_set_autosuspend_delay(&pdev->dev, SPI_AUTOSUSPEND_TIMEOUT); + pm_runtime_get_noresume(&pdev->dev); pm_runtime_enable(&pdev->dev); =20 status =3D orion_spi_reset(spi); @@ -784,10 +785,15 @@ static int orion_spi_probe(struct platform_device *pd= ev) if (status < 0) goto out_rel_pm; =20 + pm_runtime_put_autosuspend(&pdev->dev); + return status; =20 out_rel_pm: pm_runtime_disable(&pdev->dev); + pm_runtime_put_noidle(&pdev->dev); + pm_runtime_set_suspended(&pdev->dev); + pm_runtime_dont_use_autosuspend(&pdev->dev); out_rel_axi_clk: clk_disable_unprepare(spi->axi_clk); out: --=20 2.52.0 From nobody Wed Jun 17 01:32:49 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 239173D6477; Tue, 21 Apr 2026 13:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776538; cv=none; b=TytayxEH2P9+B8B3vVdYEeUEutCvdkySm78EttJ3DsynneKcsrpLr07Zgn8VV/na4d7oHQtuhn+MU5cz8QHauRtPk0YTRhGmupZglojkOZR6QRsWyd04+5opVaXCWw5tqPcDigXVosutnvVLIlH1bz/iWrfSgYEyszAXZF2QLTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776538; c=relaxed/simple; bh=v4LO/R9E8L+NQkiU87dhjklnNzNeABBuy62XXKFekjI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iCRx9pvselj6ZNzv8NKBW0KbqCrrCegSL7rGAUoXSxkrhO3NHpX6wHKysyHZ+NpJxNgwqcgAbnSbBMGmHmMXALqFJOa0ovSI1NPYUVcNRJFrWTrJsoOlTBg/EL6TW0ft53lFjIpoM2SwyFHIJfrX6cwE9+OazX3cHBsOVLh1WE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WdjIbX4K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WdjIbX4K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C568CC2BCB7; Tue, 21 Apr 2026 13:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776776537; bh=v4LO/R9E8L+NQkiU87dhjklnNzNeABBuy62XXKFekjI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WdjIbX4Kq5bo0qkYTPbTBLxdF09Z4mAFrDBB0IJCyH3hayL90nPUTa1Bn19XcDKPP tZ2CYtEypYXsKU7O0bgu4JJQq1tyFQA7s11sxJORfsvrvzfu8Ir7I+szhnYe1ezyTD meAHF0CkZfXmMpuG+x0Z5HoI4vdNf2wbbXaoPtCkh9abMdvIRLmoIHDPhR2ck2Q6CH zq6l3PbiL0sL5xQ3OyJLmbzWkId1yi9d35RxfI/Xd5JsgVDAmRLTGXzizIOgbP7Jo/ 8M2rDDvduyMYusSV436XLp+0CG3W9A0TPHtG8XvXQubr5Viheef3Y0Rrq3obXIb+Vv GYldZ5zuuCiOg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wFAk3-00000006S0v-2rQq; Tue, 21 Apr 2026 15:02:15 +0200 From: Johan Hovold To: Mark Brown Cc: Russell King , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 3/3] spi: orion: clean up probe return value Date: Tue, 21 Apr 2026 15:02:11 +0200 Message-ID: <20260421130211.1537628-4-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260421130211.1537628-1-johan@kernel.org> References: <20260421130211.1537628-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop the redundant initialisation and return explicit zero on successful probe to make the code more readable. Signed-off-by: Johan Hovold --- drivers/spi/spi-orion.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c index a5ce970ff5a8..64bf215c1804 100644 --- a/drivers/spi/spi-orion.c +++ b/drivers/spi/spi-orion.c @@ -648,8 +648,8 @@ static int orion_spi_probe(struct platform_device *pdev) struct orion_spi *spi; struct resource *r; unsigned long tclk_hz; - int status =3D 0; struct device_node *np; + int status; =20 host =3D spi_alloc_host(&pdev->dev, sizeof(*spi)); if (host =3D=3D NULL) { @@ -787,7 +787,7 @@ static int orion_spi_probe(struct platform_device *pdev) =20 pm_runtime_put_autosuspend(&pdev->dev); =20 - return status; + return 0; =20 out_rel_pm: pm_runtime_disable(&pdev->dev); --=20 2.52.0