From nobody Wed Jun 17 01:32:59 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04A1E3D090F; Tue, 21 Apr 2026 12:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776774994; cv=none; b=deUrl9L+L3Ucog4gNkznDjOzpIHBXoxZGa38GlLsa7y0az+i/JyhnzzVcfgeY3kMWMhJVd4pGOLF0Y62dQ9P1RIiZlYf6mY9jp7kajufwxl9cdTAQfiY954QG1o9bsdz2XHL4JZ1vRGX44QtdVFeiQVkB0tWUYhCtfw7/1KesJc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776774994; c=relaxed/simple; bh=wBk+O+ghtBtCmOFC6LjLHlTBkNea+9jcEd2jANWY4E0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fycvcb97xFxCGxDnhiORim10Sgd2an+/I+9Qzj732qmZelge8eNhldsphg2GcBDP9EEDhS8mNgbAdxr/fMLpg8v5Qiwqm0iXfQoqQ00VWMeCms5lsWDiVLS32V9icVbJ42cNsdEwWzCWPQFnRea9eJ8rG208drr7vR2BI0XJtw8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nR5oTOCc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nR5oTOCc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDB7CC2BCB9; Tue, 21 Apr 2026 12:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776774993; bh=wBk+O+ghtBtCmOFC6LjLHlTBkNea+9jcEd2jANWY4E0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nR5oTOCcqIxh1HJxhQ+I/GX/GtHAudnucA+Dt83/ppuva38fI6xh+Mgc2miaYVHrd 8VursFV/0SQRdwe5iacMfwv278l6heh6FlgCZseWmXN9FdaCQtcdpZHz2ZWyrN/2W3 t9X0V/8VCOL/Kk6+YV82zPE+XWcBgHX87wU4LYDm+X7zHTZ7PLoBvURmoDJ5WYRnm0 pJTaDpQ/g2DnsMPXJU+65MsOL8D2WqQj4IxeSM3JmeiB4RQ6FKNo1vSrbzAsXaYA3Q IUs1Hi27V12aHyO3eBHRJ7HW/+1e262LdQeD9EGjhebYj690J+No5jkdNuhTemY8jH rfDPbxbkA1hUA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wFAL9-00000006QyD-2LE7; Tue, 21 Apr 2026 14:36:31 +0200 From: Johan Hovold To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Shubhrajyoti Datta Subject: [PATCH 1/4] spi: cadence: fix unclocked access on unbind Date: Tue, 21 Apr 2026 14:36:12 +0200 Message-ID: <20260421123615.1533617-2-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260421123615.1533617-1-johan@kernel.org> References: <20260421123615.1533617-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure that the controller is runtime resumed before disabling it during driver unbind to avoid unclocked register access and unbalanced clock disable. Also restore the autosuspend setting. This issue was flagged by Sashiko when reviewing a controller deregistration fix. Fixes: d36ccd9f7ea4 ("spi: cadence: Runtime pm adaptation") Cc: stable@vger.kernel.org # 4.7 Cc: Shubhrajyoti Datta Link: https://sashiko.dev/#/patchset/20260414134319.978196-1-johan%40kernel= .org?part=3D1 Signed-off-by: Johan Hovold --- drivers/spi/spi-cadence.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 08d7dabe818d..bf4a7cf6b142 100644 --- a/drivers/spi/spi-cadence.c +++ b/drivers/spi/spi-cadence.c @@ -776,16 +776,23 @@ static void cdns_spi_remove(struct platform_device *p= dev) { struct spi_controller *ctlr =3D platform_get_drvdata(pdev); struct cdns_spi *xspi =3D spi_controller_get_devdata(ctlr); + int ret =3D 0; + + if (!spi_controller_is_target(ctlr)) + ret =3D pm_runtime_get_sync(&pdev->dev); =20 spi_controller_get(ctlr); =20 spi_unregister_controller(ctlr); =20 - cdns_spi_write(xspi, CDNS_SPI_ER, CDNS_SPI_ER_DISABLE); + if (ret >=3D 0) + cdns_spi_write(xspi, CDNS_SPI_ER, CDNS_SPI_ER_DISABLE); =20 if (!spi_controller_is_target(ctlr)) { pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); + pm_runtime_put_noidle(&pdev->dev); + pm_runtime_dont_use_autosuspend(&pdev->dev); } =20 spi_controller_put(ctlr); --=20 2.52.0 From nobody Wed Jun 17 01:32:59 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28ECE3D16EA; Tue, 21 Apr 2026 12:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776774994; cv=none; b=r8PaMVyQnzvQaCkCZZMtVNVjVmkQ09XH2NHgM7f87atdIREIdWYh398o25Du6vD4/ZQUljaEhuqtLOcjaojDLiM1R1rJFbzzLP/b1Ue+L+L/JQN10uUMYcsleB+zEXBeVcNYhg2wNadTsdxq2mGmC5vha7inhvHsS9aKG61sqns= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776774994; c=relaxed/simple; bh=KxiawPPhW975UovztG38WmdbOcmtGvwrgRAh0YqH+ng=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A9LC0t4Lk5WASO9oFFseizezL63HG0Jjhylrs8ADiVMGt+2Ls7KuY55KYjSdc+6zVnR98sApSADRRAMpmeMGLQXdW/F+ymNhGuPUWDN6Z+xDUbcTsIKeDDOQJi7bD7j4mDVj9LKX8re9UUiRGmKyh+kUCI7Eb83oRXH9xmzImaU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RMDPq5KK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RMDPq5KK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E01D9C2BCB8; Tue, 21 Apr 2026 12:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776774993; bh=KxiawPPhW975UovztG38WmdbOcmtGvwrgRAh0YqH+ng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RMDPq5KK4DbP0H4ntVeEr4o1ITOzm7zATIT0tjyKscH0VnmEOQEl0NRvYdaEOzymc ibnYMxNAg1UpqIE7RMbDMznjevY2YuYH6AKJjvCXv15aI9xq5ZjnRnVtoPZXih799/ RNRS0es+fw2C/efuZ6cSINvI8rEHRQF5sRYnQwsH+K+p8W9zeSIrGwf/cfCiOuKdof U8C5hrDFEth8YO0H4zOsHAaIz/KWJ73hjVH2zhAm4LxpA1thHtXVYxaSM/ukZ14d3S AYZFUewYGUF6jYhMk5V5foAghfaaCYn+2Z+/mogTx1eMcLoWo+KpJ1kvNxLB6Uk1Cp cMPYB3NBrrxEw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wFAL9-00000006QyF-2Nc2; Tue, 21 Apr 2026 14:36:31 +0200 From: Johan Hovold To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Shubhrajyoti Datta Subject: [PATCH 2/4] spi: cadence: fix clock imbalance on probe failure Date: Tue, 21 Apr 2026 14:36:13 +0200 Message-ID: <20260421123615.1533617-3-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260421123615.1533617-1-johan@kernel.org> References: <20260421123615.1533617-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure that the controller is active before disabling clocks on probe failure to avoid unbalanced clock disable. Also drop the usage count before returning (so that the controller can be suspended after a probe deferral) and restore the autosuspend setting. Fixes: d36ccd9f7ea4 ("spi: cadence: Runtime pm adaptation") Cc: stable@vger.kernel.org # 4.7 Cc: Shubhrajyoti Datta Signed-off-by: Johan Hovold --- drivers/spi/spi-cadence.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index bf4a7cf6b142..891e2ba36958 100644 --- a/drivers/spi/spi-cadence.c +++ b/drivers/spi/spi-cadence.c @@ -741,7 +741,6 @@ static int cdns_spi_probe(struct platform_device *pdev) /* Set to default valid value */ ctlr->max_speed_hz =3D xspi->clk_rate / 4; xspi->speed_hz =3D ctlr->max_speed_hz; - pm_runtime_put_autosuspend(&pdev->dev); } else { ctlr->mode_bits |=3D SPI_NO_CS; ctlr->target_abort =3D cdns_target_abort; @@ -752,12 +751,17 @@ static int cdns_spi_probe(struct platform_device *pde= v) goto clk_dis_all; } =20 + if (!spi_controller_is_target(ctlr)) + pm_runtime_put_autosuspend(&pdev->dev); + return ret; =20 clk_dis_all: if (!spi_controller_is_target(ctlr)) { pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); + pm_runtime_put_noidle(&pdev->dev); + pm_runtime_dont_use_autosuspend(&pdev->dev); } remove_ctlr: spi_controller_put(ctlr); --=20 2.52.0 From nobody Wed Jun 17 01:32:59 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28E393D0938; Tue, 21 Apr 2026 12:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776774994; cv=none; b=NZKcyFhD1ogecr7hqK7BVlJpakdfo2R/znO/Hidlf4ckwKswmt5uXK0DjMhHDzKg1sk5n+A68RI4gGOs+6KRI7gT0kUbjBMguFmwjnaT9igmbAqEyNH8nVvPbDJyfjhIh2EJC+J82+mnxckJOO5czHjKfN4gkqZK5W9F0dJKcSg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776774994; c=relaxed/simple; bh=cdetVG3iR83UeCj9+yCjdATmJLyhGT47JJFMDyYz61E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PHxKhQIEQjb9tfokZUS/7zJzGOrgl1a9L6N16Kqeu9qKuUuF/dmG+qSO9iXJozYCzgJDMW3+MSTQXWLJflUEtI3xWCU3dcZdrupk/gZBNCK6tY4gnJJmEJO1W1oWBXPRtdzBCqbRf7AD4TV0Fk38yTe+HVpwusG5qZfBpfBRt6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S7G/hrVt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S7G/hrVt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB5CEC2BCB6; Tue, 21 Apr 2026 12:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776774993; bh=cdetVG3iR83UeCj9+yCjdATmJLyhGT47JJFMDyYz61E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S7G/hrVtbYp4Ki6RMP2WpNNZWcSPDzh8B/SdtRTeekfJ5lMAODNv6TDobfjlMhBEm BfC0kufoLtNQSuem1b7i/d3vHSxoeOhadIoJccGQ0iULx28FRb2eu/rLh5WA8VgjF9 0ISCvy4Obg5dq8bUROpPyNKT5lN4yFExEJ8/lyPajXhtqdeKX9lqZYdeMnBSoeDcsO 19bWLVVLIXh0hn46f7s4Pffjx74gamdGH4JDy/kbhhsF8b7NAvmWfqpsdhmaFRUXCB eQNrsfT5RzQ9asW3OtVVaPXUIBD7aoNGwf6a3hL2u/53aXKdhma4Rp9ZqOaEJYRq7I h7I7BVPUpGEwQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wFAL9-00000006QyH-2Pq6; Tue, 21 Apr 2026 14:36:31 +0200 From: Johan Hovold To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 3/4] spi: cadence: rename probe error labels Date: Tue, 21 Apr 2026 14:36:14 +0200 Message-ID: <20260421123615.1533617-4-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260421123615.1533617-1-johan@kernel.org> References: <20260421123615.1533617-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "clk_dis_all" error label is not used to disable clocks since commit f64b1600f92e ("spi: spi-cadence: Use helper function devm_clk_get_enabled()"). Similarly, "remove_ctlr" drops a reference rather than deregisters the controller. Rename the labels after what they do. Signed-off-by: Johan Hovold --- drivers/spi/spi-cadence.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 891e2ba36958..f27586151ca9 100644 --- a/drivers/spi/spi-cadence.c +++ b/drivers/spi/spi-cadence.c @@ -656,21 +656,21 @@ static int cdns_spi_probe(struct platform_device *pde= v) xspi->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(xspi->regs)) { ret =3D PTR_ERR(xspi->regs); - goto remove_ctlr; + goto err_put_ctlr; } =20 xspi->pclk =3D devm_clk_get_enabled(&pdev->dev, "pclk"); if (IS_ERR(xspi->pclk)) { dev_err(&pdev->dev, "pclk clock not found.\n"); ret =3D PTR_ERR(xspi->pclk); - goto remove_ctlr; + goto err_put_ctlr; } =20 xspi->rstc =3D devm_reset_control_get_optional_exclusive(&pdev->dev, "spi= "); if (IS_ERR(xspi->rstc)) { ret =3D dev_err_probe(&pdev->dev, PTR_ERR(xspi->rstc), "Cannot get SPI reset.\n"); - goto remove_ctlr; + goto err_put_ctlr; } =20 reset_control_assert(xspi->rstc); @@ -680,7 +680,7 @@ static int cdns_spi_probe(struct platform_device *pdev) if (IS_ERR(xspi->ref_clk)) { dev_err(&pdev->dev, "ref_clk clock not found.\n"); ret =3D PTR_ERR(xspi->ref_clk); - goto remove_ctlr; + goto err_put_ctlr; } =20 if (!spi_controller_is_target(ctlr)) { @@ -710,7 +710,7 @@ static int cdns_spi_probe(struct platform_device *pdev) irq =3D platform_get_irq(pdev, 0); if (irq < 0) { ret =3D irq; - goto clk_dis_all; + goto err_disable_rpm; } =20 ret =3D devm_request_irq(&pdev->dev, irq, cdns_spi_irq, @@ -718,7 +718,7 @@ static int cdns_spi_probe(struct platform_device *pdev) if (ret !=3D 0) { ret =3D -ENXIO; dev_err(&pdev->dev, "request_irq failed\n"); - goto clk_dis_all; + goto err_disable_rpm; } =20 ctlr->use_gpio_descriptors =3D true; @@ -748,7 +748,7 @@ static int cdns_spi_probe(struct platform_device *pdev) ret =3D spi_register_controller(ctlr); if (ret) { dev_err(&pdev->dev, "spi_register_controller failed\n"); - goto clk_dis_all; + goto err_disable_rpm; } =20 if (!spi_controller_is_target(ctlr)) @@ -756,14 +756,14 @@ static int cdns_spi_probe(struct platform_device *pde= v) =20 return ret; =20 -clk_dis_all: +err_disable_rpm: if (!spi_controller_is_target(ctlr)) { pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); pm_runtime_dont_use_autosuspend(&pdev->dev); } -remove_ctlr: +err_put_ctlr: spi_controller_put(ctlr); return ret; } --=20 2.52.0 From nobody Wed Jun 17 01:32:59 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2900F3D16F9; Tue, 21 Apr 2026 12:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776774994; cv=none; b=LuTtrioO91mRQlsMcsNaHAdyXGIXjwIrXEemxoZf8czE0zPlnVmRHxoFJYIuNHqb7Pw8H38MKdlg55zjwNl4gJtHVNMjJyOz8V2ZJp0+8QZBil8PjuKZabpWECl/hImk8R4Gbn18QYxEYH4wxyZ3d+7lWb85P3QsXxjm3ysD/To= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776774994; c=relaxed/simple; bh=5hLWyRBX5d6zZi74k8bRsxo55wmQFDVEYsYNZen8B0A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uvFO0ZTUTDNPQshEtyQEZLaA/lnWfZg1O35hKe81tVsdIjbITMoE0edNA3HrjqcHky8ZDNwRbdF8qEWABw/Ko/2gCfzAJqjuMIlbBYOxfSc+06uYETSztKZRb8oa7lLt4qr3YY/F41eC/7OlOycG0xd/XAuXHuEaLLLRleTKiJ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SWMeScRq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SWMeScRq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8F12C2BCB3; Tue, 21 Apr 2026 12:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776774993; bh=5hLWyRBX5d6zZi74k8bRsxo55wmQFDVEYsYNZen8B0A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SWMeScRqvPoDqiMlG7yM8kSpzKHlGqpywFzgjhL6xvN0WB247rKw80En7VhVa/Pbd 7lFmX05RAc6L+V7OaHOTUjHXptbnnlLv3sPUawyl5MXlroSedmJQG2RYyvrcPvYGav IRLHJ95Q39rtOIPj8U626NwfvRFNvG+dFjjVg86453yXQUJxzKKX9m0Lb0E9NBPp1C DF4t63QcKgffMQQqjCk7y+97HI8pxkt4SGjGmhmR0B/7yXvZrGicVQYLvRZyjkUArw aOdNZepMEQrGoOmwf+e14EZIDpABU6Pk97aVnO6dyL1XlgKQx02igTrfZCfJGZzFYT SSUzFV5rxCgjQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wFAL9-00000006QyJ-2S9n; Tue, 21 Apr 2026 14:36:31 +0200 From: Johan Hovold To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 4/4] spi: cadence: clean up probe return value Date: Tue, 21 Apr 2026 14:36:15 +0200 Message-ID: <20260421123615.1533617-5-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260421123615.1533617-1-johan@kernel.org> References: <20260421123615.1533617-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop the redundant initialisation and return explicit zero on successful probe to make the code more readable. Signed-off-by: Johan Hovold --- drivers/spi/spi-cadence.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index f27586151ca9..d108e89fda22 100644 --- a/drivers/spi/spi-cadence.c +++ b/drivers/spi/spi-cadence.c @@ -635,7 +635,7 @@ static int cdns_target_abort(struct spi_controller *ctl= r) */ static int cdns_spi_probe(struct platform_device *pdev) { - int ret =3D 0, irq; + int ret, irq; struct spi_controller *ctlr; struct cdns_spi *xspi; u32 num_cs; @@ -754,7 +754,7 @@ static int cdns_spi_probe(struct platform_device *pdev) if (!spi_controller_is_target(ctlr)) pm_runtime_put_autosuspend(&pdev->dev); =20 - return ret; + return 0; =20 err_disable_rpm: if (!spi_controller_is_target(ctlr)) { --=20 2.52.0