From nobody Wed Jun 17 01:38:04 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A1253BC675 for ; Tue, 21 Apr 2026 10:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776768820; cv=none; b=g0MHx0tAbKd5CqArOWFw4tets8wkutXv6h41Mkfws/lfelIKgx/0NdnDZrp+ZzUlfIaGSoYjoGWVjFuk9QzXf6+cpUeNj7Go71AsVng3TVa2A0u2a1IcjS5iZMKDay4BjrhuTb+rvasYuvMQJfqi0zHBDOK00zSciYb3zLzWoVA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776768820; c=relaxed/simple; bh=4arHkBK/QG1CKack3ghyB/MW0B/BiaIGWmuPw9wirKc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Flnqr0VkqLstpayXWfUAJrqybc9Xb2l1eo3CFU7R5ABPfvJj/QCHtsxHRdf9FI/MIViOiNWKL3SVvP8EFATW4XVeNt5msELr2QifHwfDNI1xOTy31rHiYun7NCfwzdKNZMRyEdDwESGeJKm8k2cOa0us7jsHCDakEOWpEEWfzPw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a0e9WaKO; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a0e9WaKO" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso37246365e9.3 for ; Tue, 21 Apr 2026 03:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776768818; x=1777373618; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YaPuNs+tJR3dOut9FEswGyzi6MZaKkaW/JljGXmpchI=; b=a0e9WaKOdiiZpRfLqLHqMkUSuob7NugBegoVQja/gH3nYRp4g75trXO7SYl2I5SirS fdDY3LA6iHavMfRFvf3pNJS5IZjA8jgPWFv7ArigTha4l8PbcPsHvTXY9gU22cRgCL1Y uY6OHNuEvrebRKvfqOIj7Q/Ad3tXv3UlWNHTThHyAMZGeaFnSlRYmTQ/QH5OsHxVB3dd XytNiBwR+T+xkuT/HRJZT0SPIGJx7FPkX8uj5YtXyfRl1Ow2kl6j+Q8KIIQ6vHatlVdK JtCRwIto40dFTOUyYVXYvShX1y79Rcwoi+xtovbpAfRON4QIapRl9fvb/UMgHY8/2cu8 8JYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776768818; x=1777373618; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YaPuNs+tJR3dOut9FEswGyzi6MZaKkaW/JljGXmpchI=; b=c44xVRSBEnpSW4K9te1TIlt/Y7dFjn7JszQ+fh8VOqYJ74GFv36kPT1s+j+nqK4zgW 5A7xrj6G/czhwZ1fmW+m+pSnwF0GGg5bgBLzB8Wem0zqFeMiIObn8eDsCb1zmvnpgjRM YkIg7lqBbFZKwhhIySbyVX49aDiMPQj9aWC7v/s4MOXAMLhQh/eN8MMkPYSq5yODW2GM 6YTv2KssjWCNi1Vj8vNmlRrIi5f+w8CFgNdu0svGmQGGo+2qpBD742smpoI4j319Nh28 Qluw48Wj2felJC33NsqOOn/YUff7m6kwW1iNVgtc9HA4cSjHopJ9ADFjbOxitO3wQooP HeCA== X-Forwarded-Encrypted: i=1; AFNElJ9QIt4RtcPSBPoaH+WUCNSr/HgebUtzPsIQ6+3SqAFPLctwvJ8hEhKZ2HUTlU9kUipleU9hxml31UsRYvI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1iK9yAEDX3A5kK2h4uEJ5M2bGUoETHNfLZnBK1hMUEgAmPzIA eCqbsXtUs4ASJZyWZyizc7/kW2ZPEBFYD21T1p7SJrtKdkVJoAE7MoyR X-Gm-Gg: AeBDiesohEc8V0OoYJa5nARiNAzNdo2RNmSK1jYz8TJtSrSEZSEznkIB8N0YPTGLad9 2vLVBc0iEZvcfeHun4aSKshAiTuSPYev/nLhGIczkbBfeCeYECVpOgeEZaUCuE2+w3XjmLSsMJc 7/z9VT1IinElWYx1EX87iIMT1qmcu8ZcmBq7mNa/VFkUCNMXmWyJw1e/zTvb3RVANH8nFIzcvCt jcPKpWo+2Zg6AewxVS2p36rzbN89iSuQ/GoaCgRk67y69lW6N1LKuAQ7TawEkUjlO63x6LeLKOf OkQoWrGqkmFGaDAcTFjNk68FkiQ5SS73HwNcTo43nNlgmCnGmKEdr1TaOIwk0wkSaME+Tyhyrzc LhGzyv8Nko3rzyB5dZNL34vHspDwgxJ1XYec+Sxvyw/9rNUl2L+EgZjnruhF2l0HNzkN3XrlpOH tTK4rLXG6/8qZeIzl1/JrZ9dwVQntq5U0EdWpJtGbDXko9z5RpOnmZjWhLRuw= X-Received: by 2002:a05:600c:b90:b0:488:b99b:4177 with SMTP id 5b1f17b1804b1-488fb78ee4emr240117025e9.25.1776768817358; Tue, 21 Apr 2026 03:53:37 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:de57:c37d:677b:c772]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc1c773fsm403219355e9.12.2026.04.21.03.53.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 03:53:36 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Biju Das , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH v3] drm/bridge: ite-it6263: Support power cycle in runtime Date: Tue, 21 Apr 2026 11:53:32 +0100 Message-ID: <20260421105334.43411-1-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das On the RZ/G3L SMARC EVK, suspend to RAM powers down the ITE IT6263 chip. The display controller driver's system PM callbacks invoke drm_mode_config_helper_{suspend,resume}, which in turn call the bridge's atomic_{disable,enable} callbacks to handle suspend/resume for the bridge without dedicated PM ops. To support proper reinitialization after power loss, move reset_gpio into the it6263 struct so it is accessible beyond probe time. Relocate it6263_hw_reset(), it6263_lvds_set_i2c_addr(), it6263_lvds_config() and it6263_hdmi_config() from probe to atomic_enable, ensuring the chip is fully reset and reconfigured on every enable, including after a suspend/resume cycle. Signed-off-by: Biju Das --- Tested s2idle, s2ram and hotplug on Renesas RZ/G3L SMARC EVK platform. v2->v3: * Updated commit header and description. * Dropped it6263_bridge_{init,uninit}(). * Restored regulator_bulk_enable in probe(). * Dropped the variable powered, supplies and num_supplies from struct it6263. * Added reset, I2C address configuration, and LVDS/HDMI initialisation to the atomic_enable callback so that the hardware is fully reinitialised after each power cycle. Correspondingly, remove these steps from probe, since they are no longer needed there. * Dropped the remove callback as it is not needed. v1->v2: * Dropped system PM callbacks instead using bridge's atomic_{disable,enable} callbacks to handle suspend/resume. --- drivers/gpu/drm/bridge/ite-it6263.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/i= te-it6263.c index 4f3ebb7af4d4..efb8aacef8ff 100644 --- a/drivers/gpu/drm/bridge/ite-it6263.c +++ b/drivers/gpu/drm/bridge/ite-it6263.c @@ -200,6 +200,7 @@ struct it6263 { struct regmap *lvds_regmap; struct drm_bridge bridge; struct drm_bridge *next_bridge; + struct gpio_desc *reset_gpio; int lvds_data_mapping; bool lvds_dual_link; bool lvds_link12_swap; @@ -603,6 +604,15 @@ static void it6263_bridge_atomic_enable(struct drm_bri= dge *bridge, bool pclk_high; int i, ret; =20 + it6263_hw_reset(it->reset_gpio); + + ret =3D it6263_lvds_set_i2c_addr(it); + if (ret) + dev_err(it->dev, "failed to set I2C addr\n"); + + it6263_lvds_config(it); + it6263_hdmi_config(it); + connector =3D drm_atomic_get_new_connector_for_encoder(state, bridge->encoder); crtc =3D drm_atomic_get_new_connector_state(state, connector)->crtc; @@ -840,7 +850,6 @@ static const struct drm_bridge_funcs it6263_bridge_func= s =3D { static int it6263_probe(struct i2c_client *client) { struct device *dev =3D &client->dev; - struct gpio_desc *reset_gpio; struct it6263 *it; int ret; =20 @@ -858,9 +867,9 @@ static int it6263_probe(struct i2c_client *client) return dev_err_probe(dev, PTR_ERR(it->hdmi_regmap), "failed to init I2C regmap for HDMI\n"); =20 - reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(reset_gpio)) - return dev_err_probe(dev, PTR_ERR(reset_gpio), + it->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(it->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(it->reset_gpio), "failed to get reset gpio\n"); =20 ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(it6263_supplies), @@ -872,12 +881,6 @@ static int it6263_probe(struct i2c_client *client) if (ret) return ret; =20 - it6263_hw_reset(reset_gpio); - - ret =3D it6263_lvds_set_i2c_addr(it); - if (ret) - return dev_err_probe(dev, ret, "failed to set I2C addr\n"); - it->lvds_i2c =3D devm_i2c_new_dummy_device(dev, client->adapter, LVDS_INPUT_CTRL_I2C_ADDR); if (IS_ERR(it->lvds_i2c)) @@ -890,9 +893,6 @@ static int it6263_probe(struct i2c_client *client) return dev_err_probe(dev, PTR_ERR(it->lvds_regmap), "failed to init I2C regmap for LVDS\n"); =20 - it6263_lvds_config(it); - it6263_hdmi_config(it); - i2c_set_clientdata(client, it); =20 it->bridge.of_node =3D dev->of_node; --=20 2.43.0