From nobody Wed Jun 17 01:34:37 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DB583AE6F3 for ; Tue, 21 Apr 2026 09:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776764706; cv=none; b=DWiE9fTrlSKemS+/D3l8QixJxqKKZUjGOVtTQLYyideZjniWz35mrCT14SOdO55UmmGLxWQ30CLyXpMKnN3rlDRToqZGz46IrH72+oqTR0QkDARXw6cFEsU/TfoDud5nEO2EV+7XQVMNvseBwDGFmhcwugUkBhYNGTzXj7mezh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776764706; c=relaxed/simple; bh=wWRC36KWWwFbbnT4QloUdLOrZzDIPevpQj8nJ48WPek=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fK/LhmYGW2PeAa76J2Ys1UwZkgg5Gxeb5HDlWxjMYaJ9k6kMY4UDa5HucHrigaYu0SZt2sUuVl7uYTr5ZC5JDHg1dxvC1kJ1sLwMkDKy9iYa7GyoCp8Vdar2d3z82Sd1ItX4A+pUOJ0MzY8ETB9/teGHjKiuBJP5PU4B8QAloOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ma4xpiJG; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ma4xpiJG" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-82f9fdfc965so1335266b3a.1 for ; Tue, 21 Apr 2026 02:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776764705; x=1777369505; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eVBypKJw+Ak0MJauOtJvmP4dIZgy02ZaGmQO+Q25Zt4=; b=ma4xpiJG43I3hFkAf0AS1AVWGTqa5YFZbKXKZP6v+rCDRvxVdjxZgEF+4bm2HlvS/u VR64tGugpOjsQVoiHm1S/1+HtBjpAjPqaKZ8kMpM35e9Xab6asQagfOBmzTALQpRq3Sv W6ALSBw68HzkxG40upRvgyoFU17uZMcnBY6PnsgfsyI4FdqmFzA19uEMaJ8xOIVJGaLl a5O30xWkRvMhqg1vzpg4D92VlQYd5O5qwK7H3W/QM0PVU4Jnsp6YPafpqR2JG6Bf/NJ7 1yc1Xb37qGf2uOyRPMrlYeyPoUq+gVG/5PaD2PJMlAWl6Wsc6cSqWlITXS8cvFmPfHat Kd/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776764705; x=1777369505; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eVBypKJw+Ak0MJauOtJvmP4dIZgy02ZaGmQO+Q25Zt4=; b=D1LityaUFNfiPpFlI8JGB8CUQQvLlV1iii+GSeeYmwnXGjr0/gBRwiCkBUtS/WvHOb ecU/uVwFLTECkVa9rxxNjO4FJlTrtfxW+K7+M6L09Twu+AtxsGtr3ozIOtqPUElUT4Uf PAsMHKbF83tp7dC42213aldI9RgcdxiZHyTEO1fL/U/85C2n9kXyzPyr6F9scm6DbX53 utPQMabzUo3UoJPMdfZzaCEyhegWf56dSoSL9sqrwu4QUq/bKuFf9MUY9UiiNJYdy4+I rivj/hLYkanfmdNLnoSLO+v0NTcNmyoenRsGNhXVz7Zt/S7aoU1pAZfeLU0QmLLMuwUX 8Lfw== X-Forwarded-Encrypted: i=1; AFNElJ/jYEtmtudUqBpxYMohhijA/vlQJT7nZ93/IGhkZ0cXAE/ckXOmC3d1qav6W6r4WHG1UfWGpGTK5A9ZnUU=@vger.kernel.org X-Gm-Message-State: AOJu0YzNoz4544BfzPMgDsAFKQBPlvpETxu/Pob4l6WuixxeTVic5IN3 gL/MT4RVcxFvdqZOhR8lBZxkhC1TGfFKW95mnUOOyDbsPQ0WTeQhbfuy X-Gm-Gg: AeBDies/Ayhu2j9j0lztybN1oxKWPsoZEd3AwkFu2fVUofdO+zd87Gx6wVPef3bKPwf tlzX1llx4Mc6gsPIDf2kWU+h39P0/W1UgaOdeTgpBaYGAB8q74G7dFUGKA5aNV6cmBnpIv0CZBz k5+jFNrHsQPj5w/j50X14pitW8QyBLR2awYR4Pst6qs3qLOQLjHrbS9ax8NwrHu8QSU8/wz1+3G 76ZsAFUpzUGV3Dhsn6O/ALpgdW+vg36hdyqqfR8CAWMirCAmDVYVm1GK6klUoKTMHk1nurRLsrp iCCaoQVEvH+NWW/InaoJyQvzbj9Smi3YAHE9Trl76u43MZwkxRv5tL0zsFEAwC3sDBMM9rBfRwU 0GfX6D8FXM/56XnygkofAGmSqQGpjrf+eXy0lIkXXJUDkVVzCvdKRuoQTcVKDTiNY/Dn4cgONfT t1FCxlqe4plL78aKcFw1wBdEbw4kqg70nqwHHpITB1kaWMvbMcbFlJrbR3cP0N87I= X-Received: by 2002:a05:6a00:2d03:b0:829:9f46:280d with SMTP id d2e1a72fcca58-82f8c87db23mr17788188b3a.1.1776764704749; Tue, 21 Apr 2026 02:45:04 -0700 (PDT) Received: from LAPTOP-CUCB24GH.tail9a93e7.ts.net ([175.159.176.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebb3fa2sm13292215b3a.29.2026.04.21.02.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 02:45:04 -0700 (PDT) From: Ruoyu Wang To: clabbe@baylibre.com, linusw@kernel.org, kaloz@openwrt.org, herbert@gondor.apana.org.au, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] crypto: ixp4xx: Fix null-pointer dereference in chainup_buffers() Date: Tue, 21 Apr 2026 17:39:17 +0800 Message-ID: <20260421093917.1001688-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" chainup_buffers() builds a linked list of buffer descriptors for a scatterlist. If dma_pool_alloc() fails while constructing the list, the current code sets buf to NULL and later dereferences it unconditionally at the end of the function: buf->next =3D NULL; buf->phys_next =3D 0; This can lead to a null-pointer dereference on allocation failure. If the failure happens after part of the descriptor chain has already been allocated and DMA-mapped, the partially constructed chain also needs to be released. Fix this by unwinding the partially constructed chain, resetting the caller-provided hook descriptor, and returning NULL on allocation failure. Signed-off-by: Ruoyu Wang --- drivers/crypto/intel/ixp4xx/ixp4xx_crypto.c | 24 +++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/intel/ixp4xx/ixp4xx_crypto.c b/drivers/crypto/i= ntel/ixp4xx/ixp4xx_crypto.c index fcc0cf4df637..63ef28cd5766 100644 --- a/drivers/crypto/intel/ixp4xx/ixp4xx_crypto.c +++ b/drivers/crypto/intel/ixp4xx/ixp4xx_crypto.c @@ -874,6 +874,11 @@ static struct buffer_desc *chainup_buffers(struct devi= ce *dev, struct buffer_desc *buf, gfp_t flags, enum dma_data_direction dir) { + struct buffer_desc *first =3D buf; + + first->next =3D NULL; + first->phys_next =3D 0; + for (; nbytes > 0; sg =3D sg_next(sg)) { unsigned int len =3D min(nbytes, sg->length); struct buffer_desc *next_buf; @@ -883,10 +888,15 @@ static struct buffer_desc *chainup_buffers(struct dev= ice *dev, nbytes -=3D len; ptr =3D sg_virt(sg); next_buf =3D dma_pool_alloc(buffer_pool, flags, &next_buf_phys); - if (!next_buf) { - buf =3D NULL; - break; - } + if (!next_buf) + goto err_unwind; + + /* + * Keep the chain well-formed even on partial construction, + * so free_buf_chain() can safely unwind it on failure. + */ + next_buf->next =3D NULL; + next_buf->phys_next =3D 0; sg_dma_address(sg) =3D dma_map_single(dev, ptr, len, dir); buf->next =3D next_buf; buf->phys_next =3D next_buf_phys; @@ -899,6 +909,12 @@ static struct buffer_desc *chainup_buffers(struct devi= ce *dev, buf->next =3D NULL; buf->phys_next =3D 0; return buf; + +err_unwind: + free_buf_chain(dev, first->next, first->phys_next); + first->next =3D NULL; + first->phys_next =3D 0; + return NULL; } =20 static int ablk_setkey(struct crypto_skcipher *tfm, const u8 *key, --=20 2.43.0