From nobody Fri Jun 19 22:18:33 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 400AD39BFEF for ; Tue, 21 Apr 2026 08:22:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776759755; cv=none; b=OKefU1Xkb3EYufaMIm4nAoCvpdi49zx5+RttxB87N5cLqrF5oeav5Exu25HcPwv9IDDAK4DEC6m5eu9823eeK06GijHaBxrsCkrTR4/591fy5W+B6XrOI7V29GiojXdDWWcslHcF71uAIeAmbmP//i1EuP02JvrRyHmCYYjLmfM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776759755; c=relaxed/simple; bh=Uki0VyIZzWUgEtTUOFrRDxzi83GZ+WYr6QhD2SFJK58=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g00Z4sKV1i2Iwxwm7dUFYXBU+cJtJlkQILih1xi8j6T9ze2zOLhvKVVztv5yqx1PMfdLhlDskHpm/1wzmdkMzdjUW2ABBTDJvpVwnCps6AQjfhVprfPRrvE+B8hKFvlolqWA912Znx1eqLOlQv0dW6KFCFjEBTuAUzeit7bU5UU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RIvpcJLr; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RIvpcJLr" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2adff872068so18655435ad.1 for ; Tue, 21 Apr 2026 01:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776759754; x=1777364554; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J/hj4BKK23dESNGIUvYCIJ9j5Rat32Tto+NKgW2HPuo=; b=RIvpcJLrXNdls9k9lxQ6b/Jbs8lmSWy9gXCgFSkyyii5dhcF1fOu7MEVqn05dVL0UC TilGGlbrA4GCtAhgHzPUeFM5xEM6INJOXhCk4PyQQquAT8WhnuFiMVXAwRsbBQlwonZO W/UCrPO/1dOHrWRz+0G7b5+roRDEtlxOR/FsQ56bsL1xuf4dPMXioTforywn9nOdMagZ pSurdEa7/hImEFCcOTU7CHKQXndQRzMfnqeX31pns9GUwAyE35/L96kWuefCeIGYRcdT c89wHuL+36VGU65f9R+UPGwGoICdbOcCApNvjYh4isW/bf9ACzpnT0KYzH3pf2J6gE2L 1jGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776759754; x=1777364554; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J/hj4BKK23dESNGIUvYCIJ9j5Rat32Tto+NKgW2HPuo=; b=WKLks633jbGd9Hn9PGMDMplpelPJ7JtrrMoDmXDWa5DUK81ZheQE9HLSJefTa80Vld bHcgoOzKhVD/eIn10NBSVjut6HVwkzK3NfVqW1cAREUxFUsF3nf0f9HGnZuSRF4Bc0OG 1Xz7+KHzl6uaXlGBGrZo9mv/EuplyijvwbfZQ+xMI4IQvz/NvjMyfVHHJnKpMT3qG5hL QA51DZpuzHZnsdU7Ww5XIAtTmFg35QD5jpxqYgL9Z5mtqxHLTyU391LKeRR7vjW28/qN Gzsi/5rYp9QrK4xQQLlDEa8Rrj6x+VtP4EajL+9yphP9IIT0FEUzcqdNXfV9D7AhcJYe X93w== X-Forwarded-Encrypted: i=1; AFNElJ9mRqNj7O0M6qv62+poH0aSQnf2O1cbvzDmOwJnPX0G6mEFy48oL25/9k9r+SBbIFaZGNFNYNQZKN1BH7s=@vger.kernel.org X-Gm-Message-State: AOJu0YyG9xdNgwyWNYyWllP6XQ3cGCs1SWEs1w9fB2FE4BMJf3o+LBlW Wun4M3lSX3dRqastHF9zM17S9fP4+u3RXbLaBFsJkL82VZKz8h2FJ3zO X-Gm-Gg: AeBDieuSsspGGPl+TCh6gAJdrnKNHAyzyn+i9LxDtEF7VXE73VDa8Ae9PZuJaQv789L qyMpgemXiXf6BWdiGH0mz/pWhllYkROI1G5iT6JkDjGVCveLfZcR+qgxV4fjMAwt753OFSszuT0 NTpP9K057lhwQununAt+4gtg6ckvk8/MPQ72jMQWzO7HZM3iPWVjgVgYLleLJe9NdbXGe4WU9Ox ZAdDbxmYTazD7ZbKsGcteCVhDmR6+A4VVGmak2d0pJy4OSP1XUcbRiZpiRckuqxagxOuI9pJHws duc/KSfgN3ofzpo42KYJk3B/HbjUSSOqrzX8BndOTvwxvWkRO2fDT/ADDfJdVVJUxUqiwD6Qyy9 wROA9empTys4NkYE/06YshAc6Z2KOdM8vxf4Griqbj+ygxvv0fn41FFdjAi3Z4odCR64MUDJClk r3qG0bUSFxzvl4SNRLJRH4IjUKGk+Z84/6zFFRrD+zYwasv2AMrktT X-Received: by 2002:a17:903:200d:b0:2b2:5597:bad4 with SMTP id d9443c01a7336-2b5f9ffa730mr130394005ad.30.1776759753630; Tue, 21 Apr 2026 01:22:33 -0700 (PDT) Received: from arch.localdomain ([103.182.132.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab2114bsm121369215ad.60.2026.04.21.01.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 01:22:33 -0700 (PDT) From: Debjeet Banerjee To: andy.shevchenko@gmail.com, hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org Cc: andy@kernel.org, sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, debjeetbanerjee48@gmail.com Subject: [PATCH v3] media: atomisp: csi2: Fix DPCM decompression for source pad format Date: Tue, 21 Apr 2026 13:52:11 +0530 Message-ID: <20260421082211.74041-1-debjeetbanerjee48@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The CSI2 source pad format was set by blindly copying the sink pad format, regardless of whether the sink pad is receiving a DPCM-compressed mbus code. This was marked with a FIXME comment. When a sensor transmits DPCM-compressed data over MIPI CSI-2 (e.g. MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8), the Atom ISP hardware decompresses it before passing it to the ISP pipeline. Therefore the source pad must expose the uncompressed format (e.g. MEDIA_BUS_FMT_SGRBG10_1X10), not the compressed one. atomisp_subdev_uncompressed_code() already implements this mapping via the compressed_codes[] table in atomisp_subdev.c, which pairs each DPCM mbus code with its uncompressed counterpart. For codes that are not DPCM-compressed, the function returns the code unchanged, so this change is a no-op for all non-DPCM formats. Signed-off-by: Debjeet Banerjee --- v3: - Drop "staging:" prefix in subject (per Andy Shevchenko) v2: - Rebased onto latest media tree (fix CI apply failure) - Fix missing linux-staging recipient (typo in v1) - Fix indentation --- drivers/staging/media/atomisp/pci/atomisp_csi2.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2.c b/drivers/sta= ging/media/atomisp/pci/atomisp_csi2.c index 95b9113d75e9..e723304bec80 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_csi2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_csi2.c @@ -107,10 +107,17 @@ int atomisp_csi2_set_ffmt(struct v4l2_subdev *sd, &tmp_ffmt); } =20 - /* FIXME: DPCM decompression */ - *actual_ffmt =3D *ffmt =3D *__csi2_get_format(csi2, sd_state, which, - CSI2_PAD_SINK); - + /* + * The source pad must expose the uncompressed format even when the sink + * pad receives DPCM-compressed data. The hardware decompresses DPCM + * (e.g. SGRBG10_DPCM8_1X8 -> SGRBG10_1X10) between sink and source, + * so propagate the sink format but map the mbus code to its uncompressed + * equivalent. atomisp_subdev_uncompressed_code() returns the code + * unchanged for formats that are not DPCM-compressed. + */ + *actual_ffmt =3D *__csi2_get_format(csi2, sd_state, which, CSI2_PAD_SINK); + actual_ffmt->code =3D atomisp_subdev_uncompressed_code(actual_ffmt->code); + *ffmt =3D *actual_ffmt; return 0; } =20 --=20 2.53.0