From nobody Tue Jun 16 20:38:41 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41AD1283CAF for ; Tue, 21 Apr 2026 07:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776756835; cv=none; b=LzfN6Ri7/RqnCq7x2IZc+cYxzRSCT04e98WpnGNDb6TR7BFgyBLAk8YEnuXAjVh0gFmZva4KvgmMq7ZwQMiqKEOm+75WDWqy7uvph5dONiNG4ZRyf2k3bLwIPMatCKBTfWS5CJGOeF1I9MC6cz4XyfpUo2rLuGv3iUFGloCkB4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776756835; c=relaxed/simple; bh=kacipmRh/ARA/yj251suNKvUgkiVHzItJyjKIF1jCv8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=FBHb5HuZRPu1dLdox3/eEl/MJ02xlRCLI+saNGogI285+eYPa7p07R5QH2pV3l74vn0f6AuJTzRqGvUvP24V2tnszJSntVwdqZ4IIeOwV7FYPKFrAZD/Vv/+0nDd6gq8Ibzenee3Rq63kmqY/z/WTsHfPESi0gJM/D7eWvVO6FE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XvB2zik+; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XvB2zik+" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-35d971fb6f1so3065603a91.0 for ; Tue, 21 Apr 2026 00:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776756834; x=1777361634; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1tN5kwaSs4mUzaWaK2mJMmR2b/ZFzAdC6nGIO7bzkSw=; b=XvB2zik+You16ZAqXsdCCWXx9ivmehqG4NGlR1hGiIdeluO3DKYjN3qkYYmVvsBwmY ia6oqVGIdWrxxT2lmQ2XdbAXrEwnVvrd6mqNCA9m9+ppJUxS0qxkmRsGBcxkK9mfg7Us 28Y26XviCjkbVV73NUsimZpofjkuaKNIqQ2Ddw1/jvG0nUceikMFUHTj5JUeGbh5aOH4 cJ9xHok2gmQkCEYPEKDvgKZHVzsKsXAf9sGd5HviNASSqf2DTdCeP4ysicHQHRo3pNEo SH4Ae44vLrae0OTLGA5sWzPuzElh1NLH0OPDZpTvwksgpAEu91D0SAKK0ThdJfX2OSss 4QgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776756834; x=1777361634; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1tN5kwaSs4mUzaWaK2mJMmR2b/ZFzAdC6nGIO7bzkSw=; b=Slixw2Mic/pLVn6Sl3NbptYr3d7Pi+VXiDXS6jSNiQMSw/hARMieKOa6URJYgzfWme Dh0zS3+QkTE0uQsVutaOkJpZGjcJNPAXWcMk9ybUXZJTXeFjh1B7yF2x8IQ3O2LNApl8 KxBwBtyYdsPMMpA7Baw4O/PkQpAjpQ9BO9s9htCkfUqPPWsnBs2kS2C8p9NxFtDo29jV tf2edf2o5ZWFfosUvCkp7cA7Wmqvj1PGT3yycVjCOPBXoVLIdltGiuRL6bpBj6yQe69h xKzGQ/BeDOvVHn3wMCPR8bDd5PJ/SYgAiP3KX94gwX/5UQXIpV4A2LAwW/QnuRb9gU4H WVsA== X-Forwarded-Encrypted: i=1; AFNElJ/P2NxE2Jze/Ktvvwc/aMVqVwTkD22OiKaUxrw63UbLufd1oczIc6fGxgLfzFYmh51cgHRRSaMFVnu72+k=@vger.kernel.org X-Gm-Message-State: AOJu0YwRH1d+Lb63t+O/v0hcefoszCtjdgw4/fT5E+4V8hp8UPbDEdNB 1uazKCg6757XYwt+WsW24Wky6cxrrw/Hci1M7YJY6u0O1JFYYdVoQt/X X-Gm-Gg: AeBDiesKtlQFXQN+KjLVaKY/CY4ZwoQXm2DkTtRznguobSM8C3PW9LrdtTqvc2ntufK Wrz5/exNRU3rAhRiNSrZ5yr4w+x3nQLroX24uJvJ7joNn9VqIqT8ZE6GwywGz60L2CGxHCVvIUz /K16xmxQ3MruHCfTA7x7yQpY6YT+fH0Sftk0Hj0/gQpwUIjafpCo+GY3Bt+OjcLG8bBGhCFGD8V zz+M5ma2LrAKh1H6PW4G2LfntHRG99flnDXZjYcg8cqrQV/YILCxc0w6cIKJGBbt4BS8Av+t7Yj pfwVwanEa0ySeQJ05OrO04VrCMHi/Yv7mmFfZy7jBbqvOqv+QJ5MO95EkmrqBQQQUrK0tHwk0U4 jYQxe5SFQvweP8SUKEN6dUqUNUjvE7FEUasl64KGC817O0yZ9wK4Vwmg+1LMUc2zVavTW3elBdV 5rnoF5e4vsxA1Zg1VA5bzBm/jftXe+ZYukoi5XkihZa9EIod6+PkfuN2tc5hmZT/q1eL/b9REJm o1swahtZ1o= X-Received: by 2002:a17:90b:5865:b0:35e:27ec:dea with SMTP id 98e67ed59e1d1-36140493410mr18530382a91.23.1776756833615; Tue, 21 Apr 2026 00:33:53 -0700 (PDT) Received: from localhost.localdomain ([115.110.225.242]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3614195a8f0sm12411902a91.12.2026.04.21.00.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 00:33:53 -0700 (PDT) From: Shitalkumar Gandhi X-Google-Original-From: Shitalkumar Gandhi To: alex.aring@gmail.com, stefan@datenfreihafen.org, miquel.raynal@bootlin.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Shitalkumar Gandhi Subject: [PATCH] ieee802154: ca8210: fix cas_ctl leak on spi_async failure Date: Tue, 21 Apr 2026 13:02:59 +0530 Message-Id: <20260421073259.2259783-1-shitalkumar.gandhi@cambiumnetworks.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ca8210_spi_transfer() allocates cas_ctl with kzalloc_obj(GFP_ATOMIC) and relies entirely on the SPI completion callback ca8210_spi_transfer_complete() to free it. The spi_async() API only invokes the completion callback on successful submission. On failure it returns a negative error code without ever queuing the callback, which leaves cas_ctl and its embedded spi_message and spi_transfer orphaned. Every kfree(cas_ctl) in the driver is inside the completion callback, so there is no other reclamation path. ca8210_spi_transfer() is called from ca8210_spi_exchange(), the interrupt handler ca8210_interrupt_handler(), and from the retry path inside the completion callback itself. The exchange and interrupt handler paths loop on -EBUSY, so under sustained SPI bus contention every retry iteration leaks a fresh cas_ctl (~600 bytes per occurrence). Fix it by freeing cas_ctl on the spi_async() error path. While here, correct the misleading error string: the function calls spi_async(), not spi_sync(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Signed-off-by: Shitalkumar Gandhi Reviewed-by: Miquel Raynal --- drivers/net/ieee802154/ca8210.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca821= 0.c index ed4178155a5d..bf837adfebb2 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -919,9 +919,10 @@ static int ca8210_spi_transfer( if (status < 0) { dev_crit( &spi->dev, - "status %d from spi_sync in write\n", + "status %d from spi_async in write\n", status ); + kfree(cas_ctl); } =20 return status; --=20 2.25.1