From nobody Tue Jun 16 12:44:02 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB23F382292 for ; Tue, 21 Apr 2026 03:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776741659; cv=none; b=aifvYH9EvYYxg9rqI6xNBVC6tNvj/Lu2fZZmA4rUcHKzUYkmT55a7CTyeQSZFUjp4c15rWSOqa8L5BW1eb2SHK8AGtKIExN0Uw885PETDjkguih1UQ22BH0ixYng551fhNBq63skWo7v0nbcGab8Zu6wTbeLNEied6cullCCvus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776741659; c=relaxed/simple; bh=O2E4CdfZ7Usp5PY9isuYsA7nHK5C9A8Hkp3iAd5U0Pk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tYVdzF4oj1YB91yIpJ64z/Ie2FmcNJwylz/VY2NqyKfWqxh41Vwghj5AYoEUpEq5vBo6kdXGcvjgO88mUN0sd+xe/p9bDwMGrqIHwvqIkx3Lr2WVhqUKlVqFUksNtu6ruETBKdSgPZ+zfuGS2xVJ32bQvRe3kTvCnEmgy9cyZhs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JBfG/8Ho; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JBfG/8Ho" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82faf871346so1501111b3a.0 for ; Mon, 20 Apr 2026 20:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776741657; x=1777346457; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ubMnOeDkqTk2dHHLJbjBEoJK4qf4ceJn4yhDeONpxwI=; b=JBfG/8HocRcEihDnBYoRI1Uk03ykMJJbG1kb/1SgY81k+ZE1dMI0BrzE2u8TEMJ8VI PGXT7NuJTrryT7UCkUIY0SYstRGkhqEIWgvLXmDTxEBnBIa10NtoJintInvPmNqZXnj8 A1KaJ6XbZ5wXsXCPidOSwZb8RQDTZCzenihJwBlCtz/nmdiNaCHix46uUDj6/3xnumgS uZqSdYV61tDRiqQMxutfXbu3yi7VeRCl5JBOJ5jYDqtecsbwdjhkAtFjl8xFzI19kkwZ O+KMBwqx07xa2wQv67T8Jjb/WJNfcHFD+ECxzIvzp0P+9C2snpo1UJJ/hxjPT4VwVaJ0 dAlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776741657; x=1777346457; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ubMnOeDkqTk2dHHLJbjBEoJK4qf4ceJn4yhDeONpxwI=; b=EZ1HzY46zJ6ufC6yjjeLzTPPTD0RuFIWuX4emQLq51Wqfwg70dTbpRh4lx09GRl48D sGNTFqPXbrwFe0fqOEKhk8++/np4f/Ylz7dP08pxLTRDgpabUSYQKhdNmtbEQtJOq8Xg IfdTphUlcpbyTlIeGwxoRph9OHMVvY8qfIdRk7diuIC9By5QU/hRHqAhkCuNEutJizB8 wSJiPL5dM3cWllmhXfMGHbLr7qlSkR/wNq/YxmH0qBBcDBE+EaPXxWcnBqYDmGkNJMfW /UojYLQ8pe3YvFhlo+0+1LzCVeM+Al6n5LiRxm/SN0OVv2CG5kAo1p2d2P6OW/h74HZe dGKg== X-Forwarded-Encrypted: i=1; AFNElJ+HscThuW2yr79aUsjxAfX98yJRiHemZAy1qP0EDNeAUIfl39ZvWC5q/fLoAhN2XZgWpscNjYlD0TUeAEc=@vger.kernel.org X-Gm-Message-State: AOJu0YyZ2XbgkmENXsdboW2vQ3uqEKAYA+LULPTc9KEw5XPlHe/4+4jG R8jaEE7vurqhPPpyiPzRb4GkeStqAFyQsbl/cECjNvyOu5lVX6xDmpLo X-Gm-Gg: AeBDieshIlqTTqFIwYyc4nxsiaQdqJdhFAbMCZkxet7MMl5H8YK+1WPp0Ta/vs0BshP ngbLtY5NhC2eZyb/VvgHSJEHzPeZsQI+nNou6x3I3rvOzDG/ahIeMdqZQWXNELCMOzdH+vTZIPU zJNNeB2hmn4SrRiFwigWyqt7mjbpI1hjm76wo+pdLNFGtP033OaTInkoSec5bOMDL9kkWIJwpDn Nvz0+E+nyukkgmPtgjK+/91MBTeoM801b1jJlvw5Z7Pn5BZFItywA/lTbHw6uardo1uubgnUe09 gMf4clvE29gn/lmrhpjB0sMVvCHRKkvxvj8V81wqtw6p+AMsSM2Okcjn0A0fh53CKR4PfYI5WNJ OqJlPRxp75FdW2Dz6IUhE/19KjgdUQgD8YzivUQVaD0HR9Jj5pICXY16Me74EnACmaxRbnJx1hX 6soJ/1FgC6NRmOeqVfS8V3ZXEu+isgglGwLOytRgDG1D28bv3HzMt6ypBirivVf3ct80E= X-Received: by 2002:a05:6a00:bd0a:b0:82c:9897:70e6 with SMTP id d2e1a72fcca58-82f8c8e8aaemr17361158b3a.34.1776741657347; Mon, 20 Apr 2026 20:20:57 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.24]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9f7735sm12385858b3a.21.2026.04.20.20.20.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 20 Apr 2026 20:20:56 -0700 (PDT) From: neilfsun X-Google-Original-From: neilfsun To: 18255117159@163.com Cc: bhelgaas@google.com, hans.zhang@cixtech.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, loyou85@gmail.com, neilfsun@tencent.com, shawn.lin@rock-chips.com, tglx@kernel.org Subject: [PATCH v2 v2] PCI/MSI: Fix memory leak in pci_alloc_irq_vectors_affinity INTx path Date: Tue, 21 Apr 2026 11:20:44 +0800 Message-ID: <20260421032044.55948-1-neilfsun@tencent.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <2caa071e-85ee-4e76-bb33-8f27a4579fac@163.com> References: <2caa071e-85ee-4e76-bb33-8f27a4579fac@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the INTx fallback path of pci_alloc_irq_vectors_affinity(), affinity masks are created and never freed. Signed-off-by: neilfsun Signed-off-by: Sun Feng Reviewed-by: Hans Zhang <18255117159@163.com> --- v2: use __free to auto-release pointers --- drivers/pci/msi/api.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/msi/api.c b/drivers/pci/msi/api.c index c18559b6272c..994f12813ce3 100644 --- a/drivers/pci/msi/api.c +++ b/drivers/pci/msi/api.c @@ -285,8 +285,10 @@ int pci_alloc_irq_vectors_affinity(struct pci_dev *dev= , unsigned int min_vecs, * the device driver can adjust queue configuration * for the single interrupt case. */ - if (affd) - irq_create_affinity_masks(1, affd); + if (affd) { + struct irq_affinity_desc *masks __free(kfree) =3D + irq_create_affinity_masks(1, affd); + } pci_intx(dev, 1); return 1; } --=20 2.52.0