From nobody Tue Jun 16 20:36:26 2026 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F0B88F4A for ; Tue, 21 Apr 2026 01:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776733854; cv=none; b=aNe11fONFNV9vGPNwd+jvgsaWpF3r30Red9IqA90zxLssYASFSDhe0MaLZA7Kbx6AN/rZORfVIiW5zjR0UpUuKjnx0XEWOyR+PC5BmC7KN9iygXbI5JBsgnBHTuzsZR1nHOvpFRKecY29mVcaMlpuBhq/QdRO+1hJlRu1NBD5cM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776733854; c=relaxed/simple; bh=hsKxNpeUkexX8+o1GXKZtskbM4H2iqD5beQanDV4qWE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=r8i9zszfAI40F2OStOjA7KPu/WDuW6cUJBqa5EqW8Wfw1DSGdDCqpYUWmS5DKYjM7sE7W/m5BI/Dynw5wci6klESYioq5Opqwc0RVFRavC2zmeCbGIA6hmRfGzHcrMXpErwK3/YhaD2XWC8mUWc76xKhCnRK+FhhBRVO6JwgxZk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nmS9GewA; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nmS9GewA" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-479932ccbc8so2278177b6e.3 for ; Mon, 20 Apr 2026 18:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776733851; x=1777338651; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=w6UNueZCYaVxV9NTuR5KCCVe4O4ODh3xoZKmGq8PGYU=; b=nmS9GewAP0aXh3bCLDRlkZYFCTOJpsn4Htl3sxh2w2sy1ogfxeRTv4mK/r/EIXy+6+ ZN4F7QgXE8/LzzH9FSwZhWdGNorvxeFYjAVrMN86lPz9ynAqhGduOtdvrg7ZNTEp3M39 4R6Z/8tLamRT2T33ujiG0stHnUEeFXh61F0mBm8CkZotKfT9Idd2twGN6MgN6n67OWly dqepfJhyTrdHE9ORGplhi51IhhfO1GMQip7OygryTXDPUbYG/A9h/7+c43WAeOyYLcpT aBSQ6oLhfSIulTQAW4TbVOXG86rJeWPxohjno5a7SEipfZdpnOGv/TmLmzViLi5jTfRK 1FPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776733851; x=1777338651; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w6UNueZCYaVxV9NTuR5KCCVe4O4ODh3xoZKmGq8PGYU=; b=dRdt9lFdtKLQUOIOWm2MdGosNh3LKS79wDca+kzrm74P2oaB/kixNro2aUvb82Nzi/ RQNhiF8e7Y6U6miraEJh7YCV9EoxqpK6cadvo/OI7ySXs+6JKbV406WW4+R36FtuPMQf vKVlRoqXDgD+OBltW+UXWvCoFxbn6Bn9PfJiXkiyIwrqKsF1ZT1jkECQz7xcsfYyVKAm lRiuxuN3YDSSZAHmTb+ZR4AyAUCWQDgPnfQSfxf7Yu5kqeN8TtlBnfwEsO18Nid3F1xx RqsC9dAMS0aTb3e4PeCnh9NszsvVEuxMwJjA0UsYQIFSFF/AQ3TEZMvIrRLUuhuCtpia eiMA== X-Forwarded-Encrypted: i=1; AFNElJ8Od4jQqjfZtiM3o8Lhrrt/nBd7zjhxnM8B3Crww+enQQu1X+SrzDK2vdKjTIg1VvCPJgkAecWeNNjSZEo=@vger.kernel.org X-Gm-Message-State: AOJu0YwlbzDpkloUTXpbtPIyYZx8hZjBwkVFTfVgC1zBXFmN9HmtX9nc R1DRolpPGpt52Aclo/q0z/qSGI5/3HqJyR3FSyAy2JSRuHcZeIFtgtre X-Gm-Gg: AeBDievk95m5r5RrxM/sjz78YvpRtuUqKiDCOcLI1ZnP3dKeJXgZzdP7W8yAC8vsJw/ ShH46apJ5r+rstwDHBayaYdDKHswKMOausWdkK7uZCIrnCrX0c5UY7KrxY4VqNBbqMPJCKOU13Z 4QeKr5HLQOUwdTbGo/FqNC7lTFuLquSUdYfsTjg8AnxgbsfRm3uu3pyNCMZEd7icu9nIuQzPkDd /TrydaYe6BwiJLiRBe9RWp8N9UZYFMbP1X/UoxM7JjCECQRUDoNp4cBf72kkJIFrGkh8qHzf7DU UJUNCKEGpxw6ZvL5uYAd+azlaBebgTgolQ6xDPhA5PZ4+DE4QMQlWwJBeD/r7fxC0MEh9cq5L2c u0AdyZPl2C6hBTT4n43Dj1czUzTx7+6b8JaBxCTj+Gbe9kLlWrWch7GRUv2kZWMBaUg87jzkKhJ Wam0VzF/lzMTRo9NTo2fZveZ1haSVhtBga3ZpSeGpakYmYITP4FnrEx5vjjATjZhO7ufD8 X-Received: by 2002:a05:6808:22a1:b0:479:ed26:fbd5 with SMTP id 5614622812f47-479ed271b6dmr664393b6e.21.1776733851454; Mon, 20 Apr 2026 18:10:51 -0700 (PDT) Received: from linuxescape.lan (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dcc892c515sm2909613a34.21.2026.04.20.18.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 18:10:50 -0700 (PDT) From: Maxwell Doose To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] i3c: master: replace sprintf() with sysfs_emit() and sysfs_emit_at() Date: Mon, 20 Apr 2026 20:10:49 -0500 Message-ID: <20260421011049.63899-1-m32285159@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch replaces sprintf() function calls with sysfs_emit() and sysfs_emit_at() function calls where appropriate. While the current code is functional, this patch will help harden the driver and help modernize it. While at it, this patch also adds missing newlines at the end of some sysfs_emit() (formerly sprintf()) calls. Signed-off-by: Maxwell Doose --- drivers/i3c/master.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 9e6be49bebb2..c0d19eae06b9 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -174,7 +174,7 @@ static ssize_t bcr_show(struct device *dev, =20 i3c_bus_normaluse_lock(bus); desc =3D dev_to_i3cdesc(dev); - ret =3D sprintf(buf, "0x%02x\n", desc->info.bcr); + ret =3D sysfs_emit(buf, "0x%02x\n", desc->info.bcr); i3c_bus_normaluse_unlock(bus); =20 return ret; @@ -191,7 +191,7 @@ static ssize_t dcr_show(struct device *dev, =20 i3c_bus_normaluse_lock(bus); desc =3D dev_to_i3cdesc(dev); - ret =3D sprintf(buf, "0x%02x\n", desc->info.dcr); + ret =3D sysfs_emit(buf, "0x%02x\n", desc->info.dcr); i3c_bus_normaluse_unlock(bus); =20 return ret; @@ -208,7 +208,7 @@ static ssize_t pid_show(struct device *dev, =20 i3c_bus_normaluse_lock(bus); desc =3D dev_to_i3cdesc(dev); - ret =3D sprintf(buf, "%llx\n", desc->info.pid); + ret =3D sysfs_emit(buf, "%llx\n", desc->info.pid); i3c_bus_normaluse_unlock(bus); =20 return ret; @@ -225,7 +225,7 @@ static ssize_t dynamic_address_show(struct device *dev, =20 i3c_bus_normaluse_lock(bus); desc =3D dev_to_i3cdesc(dev); - ret =3D sprintf(buf, "%02x\n", desc->info.dyn_addr); + ret =3D sysfs_emit(buf, "%02x\n", desc->info.dyn_addr); i3c_bus_normaluse_unlock(bus); =20 return ret; @@ -256,7 +256,7 @@ static ssize_t hdrcap_show(struct device *dev, if (!hdrcap_strings[mode]) continue; =20 - ret =3D sprintf(buf + offset, offset ? " %s" : "%s", + ret =3D sysfs_emit_at(buf, offset, offset ? " %s" : "%s", hdrcap_strings[mode]); if (ret < 0) goto out; @@ -264,7 +264,7 @@ static ssize_t hdrcap_show(struct device *dev, offset +=3D ret; } =20 - ret =3D sprintf(buf + offset, "\n"); + ret =3D sysfs_emit_at(buf, offset, "\n"); if (ret < 0) goto out; =20 @@ -290,10 +290,10 @@ static ssize_t modalias_show(struct device *dev, ext =3D I3C_PID_EXTRA_INFO(devinfo.pid); =20 if (I3C_PID_RND_LOWER_32BITS(devinfo.pid)) - return sprintf(buf, "i3c:dcr%02Xmanuf%04X", devinfo.dcr, + return sysfs_emit(buf, "i3c:dcr%02Xmanuf%04X\n", devinfo.dcr, manuf); =20 - return sprintf(buf, "i3c:dcr%02Xmanuf%04Xpart%04Xext%04X", + return sysfs_emit(buf, "i3c:dcr%02Xmanuf%04Xpart%04Xext%04X\n", devinfo.dcr, manuf, part, ext); } static DEVICE_ATTR_RO(modalias); @@ -578,9 +578,9 @@ static ssize_t mode_show(struct device *dev, if (i3cbus->mode < 0 || i3cbus->mode >=3D ARRAY_SIZE(i3c_bus_mode_strings) || !i3c_bus_mode_strings[i3cbus->mode]) - ret =3D sprintf(buf, "unknown\n"); + ret =3D sysfs_emit(buf, "unknown\n"); else - ret =3D sprintf(buf, "%s\n", i3c_bus_mode_strings[i3cbus->mode]); + ret =3D sysfs_emit(buf, "%s\n", i3c_bus_mode_strings[i3cbus->mode]); i3c_bus_normaluse_unlock(i3cbus); =20 return ret; @@ -595,7 +595,7 @@ static ssize_t current_master_show(struct device *dev, ssize_t ret; =20 i3c_bus_normaluse_lock(i3cbus); - ret =3D sprintf(buf, "%d-%llx\n", i3cbus->id, + ret =3D sysfs_emit(buf, "%d-%llx\n", i3cbus->id, i3cbus->cur_master->info.pid); i3c_bus_normaluse_unlock(i3cbus); =20 @@ -611,7 +611,7 @@ static ssize_t i3c_scl_frequency_show(struct device *de= v, ssize_t ret; =20 i3c_bus_normaluse_lock(i3cbus); - ret =3D sprintf(buf, "%ld\n", i3cbus->scl_rate.i3c); + ret =3D sysfs_emit(buf, "%ld\n", i3cbus->scl_rate.i3c); i3c_bus_normaluse_unlock(i3cbus); =20 return ret; @@ -626,7 +626,7 @@ static ssize_t i2c_scl_frequency_show(struct device *de= v, ssize_t ret; =20 i3c_bus_normaluse_lock(i3cbus); - ret =3D sprintf(buf, "%ld\n", i3cbus->scl_rate.i2c); + ret =3D sysfs_emit(buf, "%ld\n", i3cbus->scl_rate.i2c); i3c_bus_normaluse_unlock(i3cbus); =20 return ret; --=20 2.53.0