From nobody Wed Jun 17 02:51:34 2026 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5964F2343BE for ; Wed, 22 Apr 2026 01:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776820078; cv=none; b=f1phgzluG81svEFUgXZ5tenAGzm6Lw7iFejNcHpgrQzsVLgj2Q/ALA96VOXGPDMA1CnroWrG6o4oD775PJ0qE7zHv/tkH6d+dmoGi04nHvYh9bq0GkrdFFDoDFJobvQ6aHy+6TVODOA1oW3ltYEV6hb26kF2rhQJFNcA9WbgQzw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776820078; c=relaxed/simple; bh=DmvQdbnSVkU390Uki7nhoRgUGLW/SfBTGzh+vLC9FdE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=C7aqSBw958XabVSTMxNjAniYJkVzzfv1/PN36enHoVE6nng3tj8zMeLTcbA3BcUqMOvAHSvPfsGyTj6Anng9o554jkMxr0VFjCWLJHWzUsN+C6GF2kLymbYKmD+jg4XFNlBkiVKA+QN38LwQkGsqmm3T5FwqzsiNfPW9YSWUMzw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ECrmDrMS; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ECrmDrMS" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2b4520f6b32so6334824eec.0 for ; Tue, 21 Apr 2026 18:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776820075; x=1777424875; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=UAr7c0jVgzuAHNJ5czeyIB1hhcntc/AZfRD30ixgZSs=; b=ECrmDrMSyjgggLD1EG7dgg7XKM8x51S4Ct46jhfFB4zWlwF0skale0ssqnKvs/5dGs pgpEz2X+gP7ub8DqT9xUfLurepXeTnldvekth5E3zDjvlaqZN/Gb0hf/Klse003Gaiq5 6Zg4QPGJs9AZSrHAX1myMO4YJv5nxj5YNSyU8u/58IzEBQyw7eQyYyLfPzzODLQe+sFC ctB0uW2AK83DvRfeF3caF7KCF+T/RUKJnfjOqFlGm+j7iBkO+8g+03M6F9T4Zv6BF4HY Wdefd4CbTG83Z8c7unYu+94aIJA8HL3cpK4vY8LxMAeNWjfYIXzjaEszK83Q0opk7wWh pHdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776820075; x=1777424875; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UAr7c0jVgzuAHNJ5czeyIB1hhcntc/AZfRD30ixgZSs=; b=n1rXEkJs708K9iDKO/D72nw0dae2kpAw5PQJ0taP00A+wehHCGDIJO0QrRDpqI4m1n VZVhZ7qs3/f8U8Jh7UJuw2MZtu7Y3sgE7NFSjn4Zogzf24qNbdAJZfww37Vz6CnlTZJQ dzKRKW6xqtsCsNwwaZFFKd+7RPFAZHcb0rr1uG8lFk8pRpDzNdRjQrrin3ToIU5FJWng lf4ar0rojcO8N+ptfN2fTf2LSM9xDFL2BS2/6hSASHTRh8MkRuLFKeuDAsin8gp56W8J aS5DtqHaryRklbqIKuTKWcDt1WPYoMwzWOcX+x/4XsU9Bbk2gpMhbFTuoYaM67Vuusup 1MDw== X-Forwarded-Encrypted: i=1; AFNElJ/krrqyqb4MNceAgGHKfnqeIXe0PI1RiuLDoifm+vZ/yFLPCV5XybARuSI0jy4SyD0BXLxgewRgr8jxN8g=@vger.kernel.org X-Gm-Message-State: AOJu0YzzWt9fI1gcF3RmThnlVgwzBk80E8NQhj9JskmiY4uazBJ8UYg+ sdi6+YdV6mxsMft8z6CR+oD2ZU8FPP6fa90ZWjfQxVYYZOVU61oXiTA9fzGAu+co X-Gm-Gg: AeBDiesbiVCDrnvQbnu91oI0zrQ8sRvbHl8C+vLuxJNSqIynbOj/h4aSGYns5Tam9OO LSdpR2j9EVtioucoS+vEIHRsomTP7oNeNo6H/8CCEDDHvYf+dhcmpOeWcHVNo2nbY066bCVl7La GrfimmZ5kptWWjj3j79oJ6gfKO9/Fo9v8gAJ4bs1/03igj68shMn0supF84VhPsLfnoI+adafZs 3mjDmEvqiaWrMzI1ySoF6Viw0/AzfzovIR2ww4Ukwaod7oV2iV5qUdoOnPmzSUlWAUftmOG/pg5 9Vsg5S2N9+ByepnJYzATNQODJXrrLI6vFXHFTPtOTL0pL6qouZgKzzVn4mMIlzqLkDGunqJEaGw 5Qy9A+TfNs2nHphfywq6gZssynMC4VFSmrChStoiLVCjZd+hKeSFQr4DXEDsEKTeVzDA3V+rz88 UCajtoG5IA/JRvbP+iwLR+dQiGw+lGRPAjzFiD7ez0nER5WFUy81doarmQeu6iDj7hrC4RKguhI uBILKYQJKA5sRaXbszxvU8= X-Received: by 2002:a05:7022:ef09:b0:12a:6b99:1ad4 with SMTP id a92af1059eb24-12c73f6c3c6mr11619846c88.11.1776820075248; Tue, 21 Apr 2026 18:07:55 -0700 (PDT) Received: from [192.168.1.18] (177-4-161-87.user3p.v-tal.net.br. [177.4.161.87]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c919266f6sm12358283c88.1.2026.04.21.18.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 18:07:54 -0700 (PDT) From: =?utf-8?q?C=C3=A1ssio_Gabriel?= Date: Tue, 21 Apr 2026 22:07:41 -0300 Subject: [PATCH] ALSA: usb-audio: Fix Audio Advantage Micro II SPDIF switch Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260421-microii-spdif-switch-fix-v1-1-5c50dc28b88f@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMUQqDMBCE4avIPnfBpGq1VxEfarLWKVQlq60g3 r2pPn4D82+kEiBK92SjIB8oxiHCXBJy/WN4CsNHk01tkWbmxm+4MAKsk0fH+sXseu6wcuXLtrC muuZlTvE+BYnzka6b07q0L3Hzv0f7/gPWlx8VfAAAAA== X-Change-ID: 20260417-microii-spdif-switch-fix-9d8b62193585 To: Takashi Iwai , Jaroslav Kysela Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?C=C3=A1ssio_Gabriel?= X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1283; i=cassiogabrielcontato@gmail.com; h=from:subject:message-id; bh=DmvQdbnSVkU390Uki7nhoRgUGLW/SfBTGzh+vLC9FdE=; b=owGbwMvMwCV2IdZeKur/u2bG02pJDJkv5NPPu15ZNsl05XWBA/VxjtMLQvf9OmkVoSFyesu2p aVduz7YdZSyMIhxMciKKbKsTlpkuafrwdX6uBUeMHNYmUCGMHBxCsBE/hcxMnQcSvWctF4ibx5/ omDc6vsTitc+ufDR75jYF46cLI4Nh64w/JVqvLuHUXFtUsH7JYKLrzufmCcdpBGyoynj456fE7Z XbeEFAA== X-Developer-Key: i=cassiogabrielcontato@gmail.com; a=openpgp; fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83 snd_microii_spdif_switch_put() returns 0 when the requested vendor register value differs from the cached one. This comparison was inverted by the resume-support conversion, so real SPDIF switch toggles are ignored while no-op writes still issue SET_CUR and report success. Return early only when the requested value matches the cached one. Fixes: 288673beae6c ("ALSA: usb-audio: Add resume support for MicroII SPDIF= ctls") Cc: stable@vger.kernel.org Signed-off-by: C=C3=A1ssio Gabriel --- sound/usb/mixer_quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index a01510a855c2..6cd50cfc563b 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -2025,7 +2025,7 @@ static int snd_microii_spdif_switch_put(struct snd_kc= ontrol *kcontrol, int err; =20 reg =3D ucontrol->value.integer.value[0] ? 0x28 : 0x2a; - if (reg !=3D list->kctl->private_value) + if (reg =3D=3D list->kctl->private_value) return 0; =20 kcontrol->private_value =3D reg; --- base-commit: 46b0e9075ce97e82726d45ce9b048840d0b4eec7 change-id: 20260417-microii-spdif-switch-fix-9d8b62193585 Best regards, -- =20 C=C3=A1ssio Gabriel