From nobody Wed Jun 17 01:34:24 2026 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 915003BC695 for ; Tue, 21 Apr 2026 13:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776604; cv=none; b=kV+sDLpcE3pnSTLn42ITKbdkm0ya4gu3bo7E7r1De75uXRSmgxzE/V7wxvpbPadzVXlzMaPpkMTA7v6pDRLdY7xzH5eJB9Wi4pphYEeV1+3EatXagfxeQXId/ItkRZYgRiDaViA2vXxfMD3HIsBEycaFD2BwBih1W/Kw0FDXswQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776604; c=relaxed/simple; bh=iJiUvbReoT4x4uCETYAX16I6NQD1wIABfCHxzjQCt34=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=uWAYZrSd7MdH07vvKKhtWiqlC9F1ZjNxoORTZ9uvLDUlhY8z/tZMaeG4L0gNXCQUsjKGG8esdtbyAnXt/BHWkpV8ja/4cZrbAFS9Bm/tQAQXwdqmKmzom/Yf+/hDIkW5OthoxHCkmKorB1p7NHqmGRMkdy2jRTXlKI2Gv53q1TY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D4So+Sjq; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D4So+Sjq" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-2de831d2b20so8088445eec.1 for ; Tue, 21 Apr 2026 06:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776776601; x=1777381401; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=RrlnIkmfaLavUxMwyP8T54KIMpBamxkwMLXcyq5lim0=; b=D4So+SjqZnw7/g2fr5xcJd3ABQpQHi1kHM+R2b6VqW0xSYYhf00Pl0/s8ojaVNMkoo +x1t1RiJt0BL/OnJbfx+06tbqQrSWx5mSZQfN9XMBO/8hrTA3tgMFwPmX8HpiDOCCV7E rJfybKhvVAdRXLHaEuPK7FB7NZ7wxc5jeeAQk+HtHekcltCGuQQ/1sTo4H5esvapWmAR 09S3W4RpdE675hk0AZfxwCuZ03ljgJiX56ut5jBE31NO1hl8JtpvxUppqMvFdHWZ/dvj 5/v7M/RE0x/pKmm4fEMCW2O0b4PgJfm6P6/1D8aIOvnOOMxmEx6IERsDZ8pXJMhZ3hkm j+MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776776601; x=1777381401; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RrlnIkmfaLavUxMwyP8T54KIMpBamxkwMLXcyq5lim0=; b=mPP3R1QcZnCRe8mgkZvIOPa5Zw6oBJnkMPs/N0uGPlMUQMCTILyMTwtfqhsgrbqeW5 pnw6X/tn8BIuVLZsEJ6fzJMcaVUvYlX1K0eu/54UHKXDFFeEdTBb/9FBj22pPvlZGwrM Hxg7Icdj1U+KX08p5Hs+ovOeNq2lzkUEEGq7Mz4jFSpwrO6ZB46W6BbeDt7d9ivce8KH nE+5UvsTdnwTwxk4OoJ75faq4/xDvye4TS+YR9TpSb3QGNMiUWs0khblmHCJYjIBN5QH xVzReA9p+fGBJnm2EJlW4RAfOvvBeRVra3Bpm4hr44VDtUE9HuxgueuKS0zaQpK/t6YJ 4bdA== X-Forwarded-Encrypted: i=1; AFNElJ/Vvs7nU6EmgWtGdqyKSE8ycnOI0AYyouv4ozudH9Z4/1RFTE9JRQlMTdYd0jrNFJV3rndyxwIsQABUxBY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh1z8QUpRyR25ZNsIqC96CUZpUkIe8dHGVcfpJuzZs+ohRi9n8 KhJOrb8zpkcvZ8BwrHOZCImHcubogwEY1Rq6XaP2O/uYV5AZyCKqlzIC X-Gm-Gg: AeBDies5xDbfRu7IuHtQUj7oVWjoRu/zgOpD9VLMrqJsuB54FzVBWeKIJbumUqEqKeY PfVMnOXyEVkp3Qt9mTdxarFlJBdZ1q262d9rDsdC8kOThNshgbYDYZFiNjPFGetN+lPWOAwvDSY xBIlmOlExvzQMmUKxlFcEZ0qdkV39t3VL7XF8m4T2sHU2Ch9SBSfFIjedUOLWkq72p94f3gdgL4 fTEBXPf7JjaVY6xzyvYHe6HXavwH9WPdwRCX7KzdF6ydTWv5kPi1pZCAhNTfo5UOCe6BuW6xyJB UVfzvtfjj9cb1xCbj1GFTR/kPft4qekHZtfP5Bi8khPDiQdIJ3U+Rmwv/naxiL52Dkx3nS6P//h y4bX0SxdeTWBQHM2bng+FLVOAa82l+qw2hpx2D2WNpdgrz2JcMijtt7aTlOUIrUPLrqaerHWnlm sj1QQlvuVicKMB3gRgndWBtbhTzpc6N5hBBkuaV+EPhkB6ofbHrtrSTHg52zfyQsgMaOkTCeWWw FcrYHN1BZ4U X-Received: by 2002:a05:7300:2d15:b0:2e7:5737:8364 with SMTP id 5a478bee46e88-2e75746d9c9mr7148510eec.15.1776776599207; Tue, 21 Apr 2026 06:03:19 -0700 (PDT) Received: from [192.168.1.18] (177-4-161-87.user3p.v-tal.net.br. [177.4.161.87]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53d2cfc1dsm18294986eec.22.2026.04.21.06.03.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 06:03:18 -0700 (PDT) From: =?utf-8?q?C=C3=A1ssio_Gabriel?= Date: Tue, 21 Apr 2026 10:03:06 -0300 Subject: [PATCH] ALSA: pcmtest: Fix resource leaks in module init error paths Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260421-alsa-pcmtest-init-unwind-v1-1-03fe0c423dbb@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMwQrCMAyA4VcZORtoq0z0VcRD18QtonE03RTG3 t3qjt/h/xcwzsIG52aBzLOYvLTC7xpIQ9SeUagaggutO/gTxodFHNOzsBUUlYKTvkUJj8l15B1 R2BPUfMx8k89/fblutqm7cyq/H6zrF3njQXB8AAAA X-Change-ID: 20260419-alsa-pcmtest-init-unwind-7c0bd10dd23d To: Ivan Orlov , Takashi Iwai , Jaroslav Kysela Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?C=C3=A1ssio_Gabriel?= X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1841; i=cassiogabrielcontato@gmail.com; h=from:subject:message-id; bh=iJiUvbReoT4x4uCETYAX16I6NQD1wIABfCHxzjQCt34=; b=owGbwMvMwCV2IdZeKur/u2bG02pJDJnPSydf0ytp2nGW4dzbD1Mu39Xof/5ujeldHWsp1/OHt ldsuaP7sKOUhUGMi0FWTJFlddIiyz1dD67Wx63wgJnDygQyhIGLUwAmoujFyLAmo0Fg3mNPqReV f5j/X9WJPxE5l8X6hKpeSXCnsemSlwcZ/sfrpew5oPbg5TGX44LaMxKjzjIvc7M4f71vZ+BBO+V mbQYA X-Developer-Key: i=cassiogabrielcontato@gmail.com; a=openpgp; fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83 pcmtest allocates its pattern buffers and creates its debugfs tree before registering the platform device and driver, but mod_init() does not release those resources when a later init step fails. As a result, a debugfs directory creation failure leaks the pattern buffers, while platform_device_register() and platform_driver_register() failures leave both the pattern buffers and the debugfs tree behind. The recent fix for failed device registration only dropped the embedded device reference. Add the missing cleanup for the debugfs tree and pattern buffers in the remaining module init error paths. Fixes: 315a3d57c64c ("ALSA: Implement the new Virtual PCM Test Driver") Cc: stable@vger.kernel.org Signed-off-by: C=C3=A1ssio Gabriel --- sound/drivers/pcmtest.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/sound/drivers/pcmtest.c b/sound/drivers/pcmtest.c index 20ceb9082fa9..fe31ff1e5b3c 100644 --- a/sound/drivers/pcmtest.c +++ b/sound/drivers/pcmtest.c @@ -754,15 +754,24 @@ static int __init mod_init(void) =20 err =3D init_debug_files(buf_allocated); if (err) - return err; + goto err_free_patterns; err =3D platform_device_register(&pcmtst_pdev); if (err) { platform_device_put(&pcmtst_pdev); - return err; + goto err_clear_debug; } err =3D platform_driver_register(&pcmtst_pdrv); - if (err) + if (err) { platform_device_unregister(&pcmtst_pdev); + goto err_clear_debug; + } + + return 0; + +err_clear_debug: + clear_debug_files(); +err_free_patterns: + free_pattern_buffers(); return err; } =20 --- base-commit: 0396822571d079e2f275cca8446f653e6ac0e9f2 change-id: 20260419-alsa-pcmtest-init-unwind-7c0bd10dd23d Best regards, -- =20 C=C3=A1ssio Gabriel