From nobody Wed Jun 17 02:51:34 2026 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B150C2A1AA for ; Wed, 22 Apr 2026 00:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776819251; cv=none; b=Pai+hhPj3bwpuqECbHQzTJdzS/opp19lJZBjTzZujJmR8mwpcRv1rQeWDV+yWIcErG+gEus89a0LssR77LBnYoK4bjqpoD1W8ov3J0dK2LrZvo/dKiAWhT5/9nZtH1QVdzZK515dRn1DCpHZN78mnyfXGrW2ZFiZzxEhyf/X2XE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776819251; c=relaxed/simple; bh=oULGjG5GZU5uTRY06JYOKrCRx+zd81vIOoy5cKg3Lag=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=CrrgvtM+U7ZkFGmaKGkL0hSFA4QtiNWuR1m4SRILUJ8Nv1pXhBmZVDj3sDWsIJY/sFftp57KfmerGa1ozQzzg+d13H3E5prJyldbcU5y/MpiMqZsIO0MUfkso3+9kJb2cTSlbpopnAcMokoMp3FZDKZJWUiAu0ao+gyODbfCoQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eFuE5Hpy; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eFuE5Hpy" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2bdd40d3c61so4599313eec.1 for ; Tue, 21 Apr 2026 17:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776819248; x=1777424048; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=LEPznx1qAI8FTDXOwTfZzkvUsU4Rd9xTBemC7UbrqCQ=; b=eFuE5HpyF8N2RQI/pOFNebdlVTOmUOMcgPvHoaMY/xA7i+h28oO6N4asnReDN9mBpi bwT+wY2PmhhYZ2LfxoAuDGc7XsoLldrBLcxelkgLPj1RRX1vyx/PG0Kh5SFFlIBNEl4G e0an/6r5FB3dhhUb5MhacjMu2MsI9RVJ7kUsSDVUDskICYW+XzvsKPOVXRmOspCpoqM/ Erzg5J0UaS6fS79Zpzr2SXP1vogn5Z/fcBDBpYwa5n9WvP+DSmTZuvKDynSsE8Ifkejk L1gETlSAkLYtp+nCyjrxOkI1ta72cHcBSO4JmoG0katjZX9nHGFGqh885kxUuPZPhSqq F87Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776819248; x=1777424048; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LEPznx1qAI8FTDXOwTfZzkvUsU4Rd9xTBemC7UbrqCQ=; b=Zice5MtxgQllGEpmPM5KWv3pgVubl6FzSctjo4AK1oF6vLXYoGJQWfYylY8jjm1n8S 8gKuGSW/V9Rutw9QG4XofnMWYHq2bxhEtEusUHdohk0z5fl47hLDHX7qdDz4m/8mUfca S05CmOo/0D8/sRy3UrclVwQpC6OnTUgNA6DQMQnU2vuZ2rIwGBWIPlYOBmBmG31Gkxn5 ffAyCb+3ZTuajiTPWqBnK/BtmiwI+uo+sj5DiVcI+frvLfOXnWSBG/beR7z2V4UJoPFc iAITledppYmJLqHs8SUTv56jq6McOlUSqdCCLynSd1mICNU2c7Bk+RAISrPNd5m8JDCG 4ohQ== X-Forwarded-Encrypted: i=1; AFNElJ+PiDAgQFIwiwPVIf0V+NypzktGovs+7mIMKGnb5srxgsAZRc80wEUXStmbGgoJddI9s/tVE9wwA9SvnFQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyu85HBUtC0M67XhgpgWgwaJPceFmLwfa7y8K0emFqmGruuTZRQ HBmMntoUBpg84tFhg+rIiDxtQdpOXhFHn6KnxZUXvbB7zdL4MHxc1chG X-Gm-Gg: AeBDieszdzxnH9c+HtlJhWoOQWTJUlDY0mfQ86jQwYNa94uyGMGXvtM5sf1HqH/VJlh VPT//NRVvU8P/lU/neznIs8vJCU7UTj2jvHyOUTQxIggAbFDS562k2rrqv5eODUiKPyzFJBSILL wJrz/xLjOQOTvZ6gUwi2kjDu/HmMbD0Oc2FpFMZPJ/dPRp2jDZ1se5MVranPOi/qp9L3keRv/ib h7TbSmiKCAjqvsch7Cevuh5jYBat8Z/lgIr+mZtnRsthLOMbzYx7R32LotnQFpqURHXdQwHpINt JCyaSibEJlLwJr8J8ZRkHy7ID9pGJg0sItcnJofDh4O3unxZ6cFTERIRqinvFljJWtdmurs0EqU FwyZGHv+vY+C98qSIMt8kr0SoTpIxIKVgrGDnP+7WvoEFR9raj+icZvLzICeBHA642juhfscLNs AZCDxjSMKLm/+Q7QrJZ3EYiu3wMEPVeMnUocJZ4ba0dUs1KCv9LljyrT1ksipKfexatw62DFpQg Z2yFoSucqim X-Received: by 2002:a05:7300:4349:b0:2be:7fc2:fc38 with SMTP id 5a478bee46e88-2e466044e0fmr10934403eec.5.1776819247623; Tue, 21 Apr 2026 17:54:07 -0700 (PDT) Received: from [192.168.1.18] (177-4-161-87.user3p.v-tal.net.br. [177.4.161.87]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e539fa6134sm21804460eec.3.2026.04.21.17.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 17:54:07 -0700 (PDT) From: =?utf-8?q?C=C3=A1ssio_Gabriel?= Date: Tue, 21 Apr 2026 21:53:52 -0300 Subject: [PATCH] ALSA: usb-audio: Avoid false E-MU sample-rate notifications Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260421-alsa-emuusb-samplerate-notify-v1-1-8b63bbc1d7f1@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMSQ7CMAwAwK9UPmOpCy3LVxAHJ3HAqE2rOEGgq n8nwHEus4JyFFY4VytEforKHAqaXQX2TuHGKK4Y2rod6n1zQBqVkKec1aDStIwcKTGGOYl/48m 7Y+d62w2mh3Iskb28fv/l+rdm82Cbvils2wcG4KA8gQAAAA== X-Change-ID: 20260417-alsa-emuusb-samplerate-notify-9fd83d5c36b5 To: Takashi Iwai Cc: Jaroslav Kysela , Sergiy Kovalchuk , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?C=C3=A1ssio_Gabriel?= X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1764; i=cassiogabrielcontato@gmail.com; h=from:subject:message-id; bh=oULGjG5GZU5uTRY06JYOKrCRx+zd81vIOoy5cKg3Lag=; b=owGbwMvMwCV2IdZeKur/u2bG02pJDJkvZLTPpJsJNteUrMy4sbpI9eXnatXPpQGnSnWKddLma F0yvJnYUcrCIMbFICumyLI6aZHlnq4HV+vjVnjAzGFlAhnCwMUpABMxXsTIMPvRVbbgol1dVSfP JRx2v7TCLXjxtm2eB1LNuf22+5+55MfwP+KwVUBq7vtmRq7Fzzv+n4uZf/v31X7nY2s8Ih9ycfa FMQIA X-Developer-Key: i=cassiogabrielcontato@gmail.com; a=openpgp; fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83 snd_emuusb_set_samplerate() unconditionally notifies the E-MU SampleRate Extension Unit control after issuing SET_CUR. If snd_usb_mixer_set_ctl_value() fails, the control value has not changed, yet snd_usb_mixer_notify_id() still invalidates the cache and emits a value-change event to userspace. Notify the control only after a successful write. Fixes: 7d2b451e65d2 ("ALSA: usb-audio - Added functionality for E-mu 0404US= B/0202USB/TrackerPre") Cc: stable@vger.kernel.org Signed-off-by: C=C3=A1ssio Gabriel --- sound/usb/mixer_quirks.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index a01510a855c2..5194a2ac1ea8 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -1538,15 +1538,17 @@ void snd_emuusb_set_samplerate(struct snd_usb_audio= *chip, { struct usb_mixer_interface *mixer; struct usb_mixer_elem_info *cval; + int err; int unitid =3D 12; /* SampleRate ExtensionUnit ID */ =20 list_for_each_entry(mixer, &chip->mixer_list, list) { if (mixer->id_elems[unitid]) { cval =3D mixer_elem_list_to_info(mixer->id_elems[unitid]); - snd_usb_mixer_set_ctl_value(cval, UAC_SET_CUR, - cval->control << 8, - samplerate_id); - snd_usb_mixer_notify_id(mixer, unitid); + err =3D snd_usb_mixer_set_ctl_value(cval, UAC_SET_CUR, + cval->control << 8, + samplerate_id); + if (!err) + snd_usb_mixer_notify_id(mixer, unitid); break; } } --- base-commit: d60c26089541d574b854d7762e9f3c182a76ad9d change-id: 20260417-alsa-emuusb-samplerate-notify-9fd83d5c36b5 Best regards, -- =20 C=C3=A1ssio Gabriel