From nobody Thu Jun 18 08:16:37 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CF3513A86C for ; Mon, 20 Apr 2026 11:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776684932; cv=none; b=FmaUoNLSQgTEmsKrIbRLiynZHbrkDMXaMgKlUZ8CNB7GMw6yB7zy2HFM0FKQZ5cHcb4yG6Era0tmWvviUOfQG64qexxt1/RlRCpvZgNvWSS7tI4+Ne10RLMneZjp/dRqQP01nk41oHgzyk9T/ZdYEN91/q5xwAYwWSSRWUgsFsY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776684932; c=relaxed/simple; bh=vmov1pEJBH+Rs3GpKL7hdtxpWbbPQv3pfJjcajOE0ec=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eBzaqanW8mqDCayRXRGZR5otkj4gOMXmxLFsu0WqCNoWUKh9+KDcT2i/eUXZb0lB48bw4FOkmLIttkJRiNe5ZM+ulGc10DJqljDu8u4LYjgf2YvcxGbPnJV9MVSv53DutDTBmfVPAhq04QgAd6XJjt9kI8fpYVJAgLpiwhGHihk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rrNBZEYZ; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rrNBZEYZ" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43cf5f6d2eeso177376f8f.0 for ; Mon, 20 Apr 2026 04:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776684929; x=1777289729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hz+pmA33HsYlT05KYLULHj0zn0MHmQJIrBIibT5vZ8w=; b=rrNBZEYZVhZr3x2pc3RDcmLA7LdPfpCURhdIKbZHM+LlomkgiSsQMClZ0sr7Ce3KGr 8ufrLp09LejkCVJ8PEqoWt5Ops6+72ieRBZn4l4YTiEw1o97PEYBIzAIZyBU4qK7OPnb 86jAtfdTWSOpo8TkyKpD63ptdwR/hLxNNmc2wLtfux84dnoNsvJ9Daf3UBsJDG+Mdxe+ HqYZS16moBAzdee53JqptCOkruVZoDkEB+IODJqzyyEHZpu2oNfQyE64JaGFGMD1paQi uAvgPNvyKr+/3VOCHXzwUQUbMTDPEFywVP7EzCIrYi/b3koXshQWMKodVjudJIWqwAEB OrHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776684929; x=1777289729; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hz+pmA33HsYlT05KYLULHj0zn0MHmQJIrBIibT5vZ8w=; b=c4v1mjXnWIHwXGjAmClZIJYwoU3bSqmC9oNmDOlMzPmLqGJ6bpP6TNecmJNAeI4vrl bhvM/d9wC3rDBUkMULXlSrgXMYsDInXd1h79wpFDpudusPQ0JrzKBNvoV0pwEWf5T6KO MDq5b2KFhzeo6dmw+ArB4QZ7oMKX7+Dj4aWnXo3FmJDkM5UZ8aaLC4/GiKNH61fH2lqj lDUPZMz4lsU8HdO+wRUxW/QEwiWjOQSt+bRujLEdT9I2oNbnPR/IaOfS96XVuDsCPYZs PWZTeKTR/VaQNPdWQKWXKOiWIrDYmBISM5UvQhlscCYFNSAuhrzm6xSOrOze5wY1zYfm GY/w== X-Forwarded-Encrypted: i=1; AFNElJ8cfYL3MrNnJ8gzaES18qME8XaJNOcaCac211jPFZS8FRDh7YhIJlR180tJszU1yMDSbqtnSNlEskxjA64=@vger.kernel.org X-Gm-Message-State: AOJu0YzgxwWG44G2bUi4cgBET3Aqf8DiXtDHnjwI4gSFEE384ECdDAtN 6ZN9wzpjzzsHkcBgfYMqcxDjwHFPpwxA4hiywClExNc8WqJFTpjCmneU X-Gm-Gg: AeBDieuM1gp150589kdNYNTnwQ836XpYBJsXLmWHkRGtgnX6eaWN0I63LARmxgCroev t68Eg2nTQkRnBB2e/aZ/l4r4+KhmHAPi8l25TERwVz5rp4Kgo4sK1UGWjTVN9eJXOMpNhu6Hop5 9oL3FKTVdWMULLigaR6GNm9e4+Cl/S038GwoUE9P2IqmbJkMvhVxT+ayD11DRLdPoRGtHZ4JeJK lvL0NYs8ZUdzTMXRpfVk5wgeA3W/Fs7wc+rPZ7NAy2KExS2cVDOGtt324RL1Y9z5qo90rpqdYvj 6gCPQt4cyZ3zxIaX5/H9M+QOeUjZAetKryAauMNKbzyzICkpwQ5bshqp9QVC1JsxZyJRvcUEZLh 9xxjyJxWMesX2GP13yMg6pcqsbxX3mzBjzkrZO/JJE4Uo2QEdeWGZM8Ijhbhs6y+OapjZ/iXVWU 9TdvhEOA5x5PumOccQ4+QsQSrLKCAUZM9P+EtxN+EphTmuinglR+YFHlDNwjswkAokICmMvo9UD aOGS8JRq3rQcVFE7ZZ7ORP3D4J7TIp8tIaT7wyjIpYt/8HuHeDlqymEiKDLHF4= X-Received: by 2002:a05:600c:4247:b0:489:1dc6:d6e with SMTP id 5b1f17b1804b1-4891dc60e71mr11320735e9.1.1776684929103; Mon, 20 Apr 2026 04:35:29 -0700 (PDT) Received: from fedora ([149.3.87.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891c320084sm119227705e9.2.2026.04.20.04.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 04:35:28 -0700 (PDT) From: Giorgi Tchankvetadze To: antoniu.miclaus@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Giorgi Tchankvetadze Subject: [PATCH v2] iio: adc: ti-ads7924: Use guard(mutex) in ADC read helper Date: Mon, 20 Apr 2026 15:34:45 +0400 Message-ID: <20260420113445.126516-2-giorgitchankvetadze1997@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace mutex_lock()/mutex_unlock() pair with guard(mutex)() and move the lock into ads7924_get_adc_result(). Keeping the guard in the helper makes the locking scope match the operation being protected. Suggested-by: Jonathan Cameron Signed-off-by: Giorgi Tchankvetadze --- Changes in v2: - Move guard(mutex)() into ads7924_get_adc_result(). - Drop the extra scope from ads7924_read_raw(). =20 drivers/iio/adc/ti-ads7924.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ti-ads7924.c b/drivers/iio/adc/ti-ads7924.c index bbcc4fc22b6e..5f294595a415 100644 --- a/drivers/iio/adc/ti-ads7924.c +++ b/drivers/iio/adc/ti-ads7924.c @@ -12,6 +12,7 @@ */ =20 #include +#include #include #include #include @@ -198,6 +199,8 @@ static int ads7924_get_adc_result(struct ads7924_data *= data, if (chan->channel < 0 || chan->channel >=3D ADS7924_CHANNELS) return -EINVAL; =20 + guard(mutex)(&data->lock); + if (data->conv_invalid) { int conv_time; =20 @@ -227,9 +230,7 @@ static int ads7924_read_raw(struct iio_dev *indio_dev, =20 switch (mask) { case IIO_CHAN_INFO_RAW: - mutex_lock(&data->lock); ret =3D ads7924_get_adc_result(data, chan, val); - mutex_unlock(&data->lock); if (ret < 0) return ret; =20 --=20 2.52.0