From nobody Sat Jun 20 04:59:55 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CFB617A305 for ; Mon, 20 Apr 2026 09:39:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776677949; cv=none; b=Kinxw/l7crdIgHtQyOPWQQHQRHhzm+oYOBrSqdxapE2Fl/Nnq9aZBwz1FnB8ySXhhQK2D9KItjzpAdbwDzJWsMDSg49P2+s4I6/UDPc/6DFhy661+5rRuL35CGGOpzjP3W4x4I2Y3Kmjt9vc7ZveSu0NLQwKbPkZDW9B3RHZlyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776677949; c=relaxed/simple; bh=aYiHX5rAJalMyGgqasItiAaZl0PwJqW8xhexmlXewP0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YPLSrWw9AwGX6q0+14jaSM8JPS4hs7VI5qIxcGU4NRIVdVmX/272Jb0ueiAQxR2zEf1RXTROeIa4lJe2r1lv9t//gzAOcuJB2nxxZKlUaytWotQxhSyNMc1Omsx+usLQ+WACbxyt91H3zd77TgM/kM6fqCiRb+RhprYNuvwtcbo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KEbM1UgX; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KEbM1UgX" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8296d553142so1683006b3a.3 for ; Mon, 20 Apr 2026 02:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776677948; x=1777282748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KCVZolkJ/jGGZ3sp1HB4+a9dT+5CyB5mH+bc98lNAj8=; b=KEbM1UgXhBnW1CZSaphRRlxJNa5AxuHXrRcR4TfaEHKw3bvKG8jX1q8OB9WRXTQ9Vb khHlEI+doLtgKlzkeVR3QDTGyvn8jzZ2LB7rVBOIcQO2gMx7WaAAKnKqG9f/1sFK70fJ LXeSMLlPpsDaJJWXdagUbLM8S+7b6ZH95y8R4NcvHbhs7WIVI6eAQSs7pvvl6RtqKHOi oDDDS1oW3MAkulQndWn0fNOvq0NIbKLG7vgGlX8/3CEZ3zocY9ZzYTHcdwtpMCGIh+XT 5hMANqFMu/6ezoPl49ILkFIs39sb1CUThReBbxhWy0VO4SRl/Q4MZVLx+GY+R+oWHvLr J4nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776677948; x=1777282748; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KCVZolkJ/jGGZ3sp1HB4+a9dT+5CyB5mH+bc98lNAj8=; b=pW0JHZo6wX1SbZqkOEyazW5r/VAADTZCB4udPBp01qYppUX0bkzjrm5FbcVn2upO6K QXmXTckIR0z4p0bJbJ6vjgEMpHFt2/fLN5EingAlFP5a/z2TwqknXy71MDWUyNvEucpI d7LZANGstjlWRRbm/0mxWzTNjV/SWCe0UmSuqMzryYexSOKA+GI71vSQKLopapwSMd83 z4meQPyrM2+863Tqjco9ZzlaTLc+elQWrwijRQrOLZQkyt+7wkpW/99TOhye5wLsZEIx a3AYEOucNArHqk7xdqXyRLr7KcvkMYQjpRb32+UvArr+YxAThbMvqBU2HMNSKwNhB3BI rt6A== X-Forwarded-Encrypted: i=1; AFNElJ+N2w28Y3mcmlBFOtSLtNZBn+qTOoa1ItTLiYlVMXJuvL2l7glOrbd7ESak6cCt+noaz79+qHRMt0mDbGU=@vger.kernel.org X-Gm-Message-State: AOJu0YyyZLJqRwZDVTOmZbsPihoMLRttMUzxQpqVKvJdSSkWZgowFx1r UITN1adcBFYBQUX0yTcAKKGxhqsjRRN8m2eoAXApk7GHgO7ANNNrRpXm X-Gm-Gg: AeBDietnoV69EcFb2mRTxkUmYaK5R+x5JoadjLA5fgu+1L9k66toI2WYBGJl+RdupIQ XujT0rtAq2wf4eNsF+j9kmLSmdsTfmwyXt4FXoMnXzQfnAC4RPDY1o9aDlJC2fAeYnZiWXx7rK4 8kbhiB8u8nG6q6GgmVl/9zv0TogkeOYafEzE4/WjThrNwdsGUCPreLLDvjzOzh4gOOeq93IYSRd dpQ4D9BODZkB9y1CGj36eUJU4WYZIFoUagvQbZ3IaelMv8Uw3QnBIhSUxD5g91HQQdTRYC50fx0 refrLVKkPFgwN6hpWIaPawop6k3BxPdfc/OipBZ41BLG5SOyB6dn+8uc+3bxxIdB/SiQ2rHQOQG wZn61g8ZFCChK+Y5qNPyYdk30GySWMDZ5c9uyjCQ3gaYDc8TZ7L3hnJXan122z9qnKvrUHpa9j0 5cg3skI/+G6nyaybFIG/pW+Ng/RkdC4ZZN X-Received: by 2002:a05:6a00:340e:b0:82a:fc5:fb81 with SMTP id d2e1a72fcca58-82f8c7d109emr13729867b3a.5.1776677947512; Mon, 20 Apr 2026 02:39:07 -0700 (PDT) Received: from lgs.. ([2408:8417:d50:4775:2038:6723:d0d:eba3]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebb33fcsm9681407b3a.33.2026.04.20.02.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 02:39:07 -0700 (PDT) From: Guangshuo Li To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Mahesh Salgaonkar , Tyrel Datwyler , Haren Myneni , Guangshuo Li , Christian Brauner , Kees Cook , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] powerpc/pseries/papr-hvpipe: fix NULL dereference in handle creation Date: Mon, 20 Apr 2026 17:38:56 +0800 Message-ID: <20260420093856.123681-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" papr_hvpipe_dev_create_handle() transfers ownership of src_info with retain_and_null_ptr(src_info) after anon_inode_getfile() succeeds. However, retain_and_null_ptr() clears src_info immediately, and the function then still dereferences src_info in the subsequent list_add(). Store the transferred pointer in a separate variable and use that for the list insertion. Manually identified during code review. Fixes: 6d3789d347a7af5c4b0b2da3af47b8d9da607ab2 ("papr-hvpipe: convert papr= _hvpipe_dev_create_handle() to FD_PREPARE()") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- arch/powerpc/platforms/pseries/papr-hvpipe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/pseries/papr-hvpipe.c b/arch/powerpc/pl= atforms/pseries/papr-hvpipe.c index 14ae480d060a..497eb967611b 100644 --- a/arch/powerpc/platforms/pseries/papr-hvpipe.c +++ b/arch/powerpc/platforms/pseries/papr-hvpipe.c @@ -480,6 +480,7 @@ static const struct file_operations papr_hvpipe_handle_= ops =3D { static int papr_hvpipe_dev_create_handle(u32 srcID) { struct hvpipe_source_info *src_info __free(kfree) =3D NULL; + struct hvpipe_source_info *owned_src_info; =20 spin_lock(&hvpipe_src_list_lock); /* @@ -509,7 +510,7 @@ static int papr_hvpipe_dev_create_handle(u32 srcID) if (fdf.err) return fdf.err; =20 - retain_and_null_ptr(src_info); + owned_src_info =3D retain_and_null_ptr(src_info); spin_lock(&hvpipe_src_list_lock); /* * If two processes are executing ioctl() for the same @@ -520,7 +521,7 @@ static int papr_hvpipe_dev_create_handle(u32 srcID) spin_unlock(&hvpipe_src_list_lock); return -EALREADY; } - list_add(&src_info->list, &hvpipe_src_list); + list_add(&owned_src_info->list, &hvpipe_src_list); spin_unlock(&hvpipe_src_list_lock); return fd_publish(fdf); } --=20 2.43.0