From nobody Tue Jun 16 12:42:43 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F1BF2ECE93 for ; Mon, 20 Apr 2026 04:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776659702; cv=none; b=N9pKMtnLnhBzwyI///ZFLMPgCodC+X0B0CPLNGnoJAAPbiWOtJ38wZJxYRVAsrbL7C30400m6cFYwO4dAwQ+Nbf41Lus1Pf7Pj6ojEZIEGA1Qb6I5L4KzI+hN+Kl53N51Aq+4GOv0aamqpIvZpGNuGjjnIBiMbjAgM7n+7RwJyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776659702; c=relaxed/simple; bh=2HPqnQMRtv0/eCGmh4tSrfTxg0tc2Yxqnj6WCItB6pA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k5qtcVyeIrJzgDC3EQbZBsuxtJpoe9sCkpdzk4M/NtVBbBwmg7JnWjiLj21hT1fsrCsnuTjikPimCLnpJCTMq/+goVGkUFxt50rf3/0GKXo2FRoXQcdJtVYc7nY0K3qJfYD+nCVRFuo7jXJzWlGpFlnkAXQ2CZRvHQuSVd9/3oE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pGGLNkvr; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pGGLNkvr" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-82f83bd32efso1985677b3a.2 for ; Sun, 19 Apr 2026 21:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776659701; x=1777264501; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eOcTTerYRxScw0XuJN9vjsh2E4H0d23/wA4kuMvKkYc=; b=pGGLNkvrmX+CEUwTehh2oW9xpoDPOyyrj6m2ShVYOan1FQn1/Jl5XmLPvBnO+Upaqj aN1qVo3Aoyc481/DPzyQAsEddIr0IMa8lPUbtB7yBvAxT4Myg4Vtl6gVAawq7CYOkwo1 ivkkR2OzfN0HGtWA5eQs3z6IBxYVTtnl2f9fpb7alrr5dN4xQ6KTktu60zNtQtmImmqb VeY/Ww0wlE0opgpOmXt5WpM/FeYM/ZtBEjXI7AXLfYHvENMIXHrzdvduFKJv4GrtNV3P F7Y4LPDwmmxbiI59I6yEbgjKka2/MbeglaHnX8AE1AURlQun+6OCjwyf3gOHkVlq2O7M GQ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776659701; x=1777264501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eOcTTerYRxScw0XuJN9vjsh2E4H0d23/wA4kuMvKkYc=; b=rAg4mcYTS5AwP1tjkDp6SmL7qaANhapkPHj/HW7kIg3v7gI1hXE2r3j6KYS0G0IW2I uAYK5u+QBmy8qO3kg1DlMyZLIS7I1OqkuOvSXjvM0FyU/qZE+hR30E5SRByTuZulMDLw fA+quzSjB8g5Bnvgz8/h+JsxfTErt+vE3eCm4eN7RLkLp+l8fqQk5Ew2hdpZTkbp0ZBO YFGjaRCC3lhgRzR/DkA9M5MeYhDuE8rwOy1Rss4SeALe/uq1d27EANFKBO6g4WqnvKw0 3FU5eqfIu2CRLx7zaRuHhJabYL3NJX2bBaQfiHFWqotoB9qAqiA2Bf/V6pu641GkQbr0 iMZw== X-Forwarded-Encrypted: i=1; AFNElJ+iWhLqOC6A9iQeJKkbJ42msXgTGo/jvaeDBXwZEQP8c8jT+vMeBJIxLEXTr0gyUOj2W5zVJ3fO0E17GVI=@vger.kernel.org X-Gm-Message-State: AOJu0YznIlfwvH20wQNhJGtsZ3qqM7GRCsugEu03YZeTIPQFHHMVnUGv i8ephBl+4vkjF3LN6vOB8QQyBhAnSNMew9PN2OYbAe+sI38SaMkxTrQsArljrg== X-Gm-Gg: AeBDieuL9ICV8vtDKeMrrtua428LsnTJwo3+TOCPYSgf52EejHjrBmBitHINaDjuYGx RdsriBqXlEs095Q5NOSOM2Fo0A4B+l6ImnjMKxghaSf2LhugkXGYJR66h60EA1kcAagmdUPRuds Jk9884p4z6+bjsF8jB1mtef52oGk8CafxmGk40SaCtxSFECSu7qLTZTs/NnNLjsmOkfFF3y6JpW 0dEs5ZoHhleQbDqnbiR6FzVprkeBah+wbZq3AEPszd+ChA80taP+JcCG/ko9smUTtoNTjyhR/RG SCjO8+jpzhDV4ZmdnL98WlgddV/kdnd5VErrdKbJ/Ua0LT6XBXW16ZQrqgElqgFgKrfcgpuTufr P1To0xixv/Iat8rN0m+Jmwqp5pYJ+c/SFB5R5ZrLPt+gp56vUS3K6WFbzeOsEjYb8nsKpbZ96PS PBeHAUPFSS+yAsZ4vKS6TUlV2KhD/5FuUZPc+GRHwi/3scfxLkqY/3 X-Received: by 2002:a05:6a00:1953:b0:82c:d861:3caf with SMTP id d2e1a72fcca58-82f8c907fbfmr12578564b3a.36.1776659700685; Sun, 19 Apr 2026 21:35:00 -0700 (PDT) Received: from arch.localdomain ([103.182.132.254]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e984f20sm9868599b3a.8.2026.04.19.21.34.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 21:35:00 -0700 (PDT) From: Debjeet Banerjee To: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org Cc: andy@kernel.org, sakari.ailus@linux.intel.com, debjeetbanerjee48@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v2] staging: media: atomisp: csi2: Fix DPCM decompression for source pad format Date: Mon, 20 Apr 2026 10:04:42 +0530 Message-ID: <20260420043442.60982-1-debjeetbanerjee48@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260420032701.33250-1-debjeetbanerjee48@gmail.com> References: <20260420032701.33250-1-debjeetbanerjee48@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The CSI2 source pad format was set by blindly copying the sink pad format, regardless of whether the sink pad is receiving a DPCM-compressed mbus code. This was marked with a FIXME comment. When a sensor transmits DPCM-compressed data over MIPI CSI-2 (e.g. MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8), the Atom ISP hardware decompresses it before passing it to the ISP pipeline. Therefore the source pad must expose the uncompressed format (e.g. MEDIA_BUS_FMT_SGRBG10_1X10), not the compressed one. atomisp_subdev_uncompressed_code() already implements this mapping via the compressed_codes[] table in atomisp_subdev.c, which pairs each DPCM mbus code with its uncompressed counterpart. For codes that are not DPCM-compressed, the function returns the code unchanged, so this change is a no-op for all non-DPCM formats. Signed-off-by: Debjeet Banerjee --- v2: - Rebased onto latest media tree (fix CI apply failure) - Fix missing linux-staging recipient (typo in v1) - Fix indentation --- drivers/staging/media/atomisp/pci/atomisp_csi2.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2.c b/drivers/sta= ging/media/atomisp/pci/atomisp_csi2.c index 95b9113d75e9..e723304bec80 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_csi2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_csi2.c @@ -107,10 +107,17 @@ int atomisp_csi2_set_ffmt(struct v4l2_subdev *sd, &tmp_ffmt); } =20 - /* FIXME: DPCM decompression */ - *actual_ffmt =3D *ffmt =3D *__csi2_get_format(csi2, sd_state, which, - CSI2_PAD_SINK); - + /* + * The source pad must expose the uncompressed format even when the sink + * pad receives DPCM-compressed data. The hardware decompresses DPCM + * (e.g. SGRBG10_DPCM8_1X8 -> SGRBG10_1X10) between sink and source, + * so propagate the sink format but map the mbus code to its uncompressed + * equivalent. atomisp_subdev_uncompressed_code() returns the code + * unchanged for formats that are not DPCM-compressed. + */ + *actual_ffmt =3D *__csi2_get_format(csi2, sd_state, which, CSI2_PAD_SINK); + actual_ffmt->code =3D atomisp_subdev_uncompressed_code(actual_ffmt->code); + *ffmt =3D *actual_ffmt; return 0; } =20 --=20 2.53.0