From nobody Tue Jun 16 12:43:21 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DEA320468E for ; Mon, 20 Apr 2026 04:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776658201; cv=none; b=Xe0aBhr9dnZgL5p1Jq1Izm6whMlh/5KT81vFgA8f7maeiUVo4K0SmUgnkzHZ/sA0v017XX6Of1ZuNzL1L/kRX1AuQkSJR3f/uxBsg8sUpe+/ck3lEyPSzyNFCkYM6yhWg08mxjRaGa0ypV52SQWZKE26Unjke0EChmHbzP48r1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776658201; c=relaxed/simple; bh=bZ2ry1xfP2UeocaW7TLRpAHTsNMxxx+8b53nzvK38NU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kiD/FN8IbttwfVuaNaaDSBsyBn8PG2ahmfKNMasu8JktSMYcYJG7Ga2+XC6kU0GLFfdxKDb42s27TW+cCEo8ifLIvmF1nZGIE55zc9yKkU1j371kzdbhdmUg1qNm2rUu4K558pF9HOgYU9pApom+Ikw3xgCp6d8PE0C8amqekAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IdJuD4gt; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IdJuD4gt" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-823c56765fdso1028075b3a.1 for ; Sun, 19 Apr 2026 21:09:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776658199; x=1777262999; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GG9gvbqL+uVEpWZ2SVlw3MTaiPM/Nzs0ORA3YODGzCo=; b=IdJuD4gt4grt9XCk2Xya3wDnbP8uJZyLFB5gTUwvfwi1ye0dIdRTSoEAjeJhTT0OBL R3EBDZKWqcTzcM6ozQmRF61CFPKJo7/7JLgv8oeVgpT5u6f1CDLlxcp9Qd/YN5/W3CgB jtPmgc4pisjaaQN3j4Tqhs/1h5UKk+Z0o0bZ40XTKsnn5msOBCi85/60ChkwIf1Z03vI 3npaaDiLtADh1EoeDLhC2IFUnQuKEMnEy1Mi1QNCstbfGOEzmTfxhSjgRICgJwEtQ/aR jO7I0+c7JZc06xIcffrWRvxNB+P7phtkCnqRzWToYX69vd5vDzpWpw/HPewGgmXy8BF2 zD/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776658199; x=1777262999; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GG9gvbqL+uVEpWZ2SVlw3MTaiPM/Nzs0ORA3YODGzCo=; b=roVZUUN3zviE5L9wGRmvPCMJwkLdmW9Fsd0YFBXLQonZFW0Ouq6hO+oIgai4L/XxnU 1UWkQcQeabGantEDVpF4ZupgQjQqgxfi8ljVx3Utci5NJuNTQhc0SlxiuOIE5G/VX/ka qGWO/Przk6pk7U6cKbzXrjrykPVtlZikxF8bY8eaUZ4+7x2vNNiZxKlx/Gy/Zt2fvBm5 4GcE4514uB+agnqmmFty88Xr7uPLvTnfnseOl29nGVtfxp1w4KEGmRxupGVd7A5it9cW AEHQZNes7vp7k7ClBpYmAVV5nk1udZ50G6sofdHl78wRqcWApAy2NxbVV5/NcojJuero 7GGg== X-Forwarded-Encrypted: i=1; AFNElJ/a6vni54nF/tDUyKxD35wcV/6kFIu6NuxfNOz76OlI7tJY2R+9pXoPuEFxToHafPq3UrQOLF2s9Gwyxw0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm8aFFkzA9GG1E0l/4t3IkWGrx1pIKjPoJfjv0NrK8ypoF3oSk gsLqdVOd8ePINo5LUnqO1HS5dHj2xdC7sXavRacnkLREjVO49L/ICnuu X-Gm-Gg: AeBDiesnL0kvsqx33kJXdgZUGgzs7kxtZWp7lXfXhdSqTvUqIjOcSsnLAGIfYgGZjOB ggg3dvsrB5DTQvQ2EdWVob8H6dU71ht6YCjyQGdR1rrXyWAvlxBPGlmEbOk0cS6Imocv/Lt4zja g4yuZSiiAnOts/gUiaCS37h5MupSUYrw7cOPdFS1SIaVqY5e/zBxbLnS85UHFDsryK+2yc2TwBP YpbFMjmNqelppPfQ+LrvVWL6iLawEul0x1ggefHdfelETXFOjM8I8/zBmBOZSz41QUW4FQQQnF8 eU7g0Hpqk2s/42cwWIO8q9SHpdA8/y63RhR+eHj3woXKEFk/tEJdU3EQUECVGMSoCLotTAQzM2+ bkTOfq4KJ0RvowpS8MPBsp6e5J62w028qKhBgK2q8nNapwGLGwgBxKttMY1Kw5uEziY4EEBmDp8 uCMtSwkzNMVSA1rFAoCXEjOYDOmPHmDGNM1UbSRN877sVcCrT4Ew82G65p1y5Ri/EgywY= X-Received: by 2002:a05:6a20:7faa:b0:3a1:90ef:7e31 with SMTP id adf61e73a8af0-3a190ef81d8mr3758746637.54.1776658199433; Sun, 19 Apr 2026 21:09:59 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.24]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797702fbfcsm6800160a12.22.2026.04.19.21.09.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 19 Apr 2026 21:09:58 -0700 (PDT) From: neilfsun X-Google-Original-From: neilfsun To: bhelgaas@google.com, shawn.lin@rock-chips.com, hans.zhang@cixtech.com, tglx@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: neilfsun , Sun Feng Subject: [PATCH] PCI/MSI: Fix memory leak in pci_alloc_irq_vectors_affinity INTx path Date: Mon, 20 Apr 2026 12:09:40 +0800 Message-ID: <20260420040940.14824-1-neilfsun@tencent.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the INTx fallback path of pci_alloc_irq_vectors_affinity(), affinity masks are created and never freed. Signed-off-by: neilfsun Signed-off-by: Sun Feng --- drivers/pci/msi/api.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pci/msi/api.c b/drivers/pci/msi/api.c index c18559b6272c..c1377f74b8f3 100644 --- a/drivers/pci/msi/api.c +++ b/drivers/pci/msi/api.c @@ -280,14 +280,17 @@ int pci_alloc_irq_vectors_affinity(struct pci_dev *de= v, unsigned int min_vecs, /* use INTx IRQ if allowed */ if (flags & PCI_IRQ_INTX) { if (min_vecs =3D=3D 1 && dev->irq) { + struct irq_affinity_desc *masks =3D NULL; + /* * Invoke the affinity spreading logic to ensure that * the device driver can adjust queue configuration * for the single interrupt case. */ if (affd) - irq_create_affinity_masks(1, affd); + masks =3D irq_create_affinity_masks(1, affd); pci_intx(dev, 1); + kfree(masks); return 1; } } --=20 2.52.0