From nobody Tue Jun 16 12:42:50 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C928737AA7D for ; Mon, 20 Apr 2026 03:28:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776655731; cv=none; b=Rzy3oLlaNEGuPYkei6MCfwz9VrMwNoNlrLvhe1dwVV58UInfZVk8uThz/1aCp9EhYMxtu6x3ZA/a0aJ3VQJFIYj0+8gd9s2dKwEvCudHiD8Z8rrPZkHuwsEEmayhxej+uPKEWBnge+yvuPiIyBeSuQ4KgVdAc/0QvMv2k2KcKfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776655731; c=relaxed/simple; bh=8RyeZRkPocpu3XADaSYHtDJkP24aI8UpoYQwth7E5PU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mAQ+Svkvf5gpBlfWqSUxKoAgD3mXhcKOlobnNQyamMj0e9xyjysAbeDb52Hy9fFALLD/YvQQ6blDBml4C7s1GPvj0VKkIOudiPeFwFVgucVTfoKgtZSsnrjSh37E61Fzj4OMDfVDDuROjYy24X9oIJcMAJZkzG8QFOMYYvgYG4I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CdXscuaw; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CdXscuaw" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-82f8b60e54dso1634300b3a.2 for ; Sun, 19 Apr 2026 20:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776655730; x=1777260530; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RziaJ6zqK2RvwU0310ZyP1dPnpTZQW8g+PDO4r27y7g=; b=CdXscuawV4nNU8H6qrmPOahGiEkrdiBL4AKT17WeB+HWrJUUA4KVOKpkr3aoiTJXXl Exo/D6OydT1r9wbW7CQ5jSTHzHFrjPZmqY4Hyjfh6ic0ECffcLT83SbQXbxcA9DwseUa Ru6H8QppjpDOVGGZ7Vm6LzbAVQwhP/QTXz8o/pt66/TJmnHk2ekLKqild8H34Dx2iJNj 2ZIz22Rbsh0+x77tHCDtg2JjuTrYK/bgaF9Xn8Z8N9NAs/bcV5hQ3JoCJeRJE1l09MJx p/wvj9ROyQFvoCKm5maB8MzFq2vVwA6BkjI9i9jFLqeScX5lR2VDKtnQm3AVmAcTnXGE T8zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776655730; x=1777260530; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RziaJ6zqK2RvwU0310ZyP1dPnpTZQW8g+PDO4r27y7g=; b=q8c6iuflXDvbs4UEndmXb1dvkjtiSaD7oGoEi3BaEaZkfohJ4s0yW664BjRYODu9Ji JiSm+DV/TQKwFXubHShRdcqRcpdGmRtM8T85x24KMZhxvWyvH+v58F5H35bE4iO3ZqKH C1bApCnwoMngmepNIyHmWjcG+ut5SQib3pqwGC9ZRFjwj2S8AZXd2xEoNV23boXGIfR0 UIVzlihXohvkDO0v9YwBqkNoVEP9J63LkH+8VSxFCi/nqQLGJ8rsEqgQCyeqghHWvJrR EIgQjS4DVF9jII1nw2aoEpx6DlMrKQrE1sFR8UpplgxY8rJGr1llr+7i5dztuS1p5nam 3QNA== X-Forwarded-Encrypted: i=1; AFNElJ+eNYHKzmcKiUl2HUqVH6xYEJSejii5gZVb5J868gH1ad9bmsazKSCQGAP1Hj9inLc8Gwa0RC13Mquhdkc=@vger.kernel.org X-Gm-Message-State: AOJu0YwRWL4UlK9bGuxiGtNgUWEDzoRlmzIrj7fwLkflu3yL3J007CKQ kQqpUOyBzFkJMvXuJgnATnEde2/PgOKiFqlt6drVLdqeq3C0j/n56HEV X-Gm-Gg: AeBDiets+ImujbjB+raUNAP9RR7BCmdX7SvngYO6WT8xuOD+CIOjiWAnc+rbwRpw2Cm jBGFaVTLch9px4qFc0XKvgU+3sZT6tlscxLNYVUmGOOzu5Z4nsz64qhdSmtXJaTfm9qRhfD2lHm MBIlOUuX6M9+kjtvkKjEmetSW8mMQyw21krVHnJYp7zcxuiWoxn8iQRG8KUDJQ7L3dktuaeI4QD 6o5etjKDg/8iwycA+plF4KWn8rZUSNgPGeJ98YzYpXSu1sXCy316BZ2CvwUwCMb8MI/JEezBcu4 ruUlXLE6/qpASRVT6SU42HaQFHidwN9Lu8GFX/5VzEisL53dyCzA99Mpwq46UBWi4ZcVePlNOph EdWup8TAOGcPRzYNncAoapi0x1AJz64MOwps7lKQMDDMg2adVJ+uvLVsml9yFpQ5G0YHKRUjq5C 6Mk3ekuMrK/ReZzXwfTATiI7qwUd/e+vG3POjpqzEkcpHwjr+UsdvD X-Received: by 2002:a05:6a00:3695:b0:82c:9e00:f958 with SMTP id d2e1a72fcca58-82f8c3dac2dmr11526854b3a.0.1776655730045; Sun, 19 Apr 2026 20:28:50 -0700 (PDT) Received: from arch.localdomain ([103.182.132.254]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e981829sm10537865b3a.12.2026.04.19.20.28.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 20:28:49 -0700 (PDT) From: Debjeet Banerjee To: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org Cc: andy@kernel.org, sakari.ailus@linux.intel.com, debjeetbanerjee48@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, inux-staging@lists.linux.dev Subject: [PATCH] staging: media: atomisp: csi2: Fix DPCM decompression for source pad format Date: Mon, 20 Apr 2026 08:57:01 +0530 Message-ID: <20260420032701.33250-1-debjeetbanerjee48@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The CSI2 source pad format was set by blindly copying the sink pad format, regardless of whether the sink pad is receiving a DPCM-compressed mbus code. This was marked with a FIXME comment. When a sensor transmits DPCM-compressed data over MIPI CSI-2 (e.g. MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8), the Atom ISP hardware decompresses it before passing it to the ISP pipeline. Therefore the source pad must expose the uncompressed format (e.g. MEDIA_BUS_FMT_SGRBG10_1X10), not the compressed one. atomisp_subdev_uncompressed_code() already implements this mapping via the compressed_codes[] table in atomisp_subdev.c, which pairs each DPCM mbus code with its uncompressed counterpart. For codes that are not DPCM-compressed, the function returns the code unchanged, so this change is a no-op for all non-DPCM formats. Signed-off-by: Debjeet Banerjee --- drivers/staging/media/atomisp/pci/atomisp_csi2.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2.c b/drivers/sta= ging/media/atomisp/pci/atomisp_csi2.c index 95b9113d75e9..484765b0d9e6 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_csi2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_csi2.c @@ -107,10 +107,17 @@ int atomisp_csi2_set_ffmt(struct v4l2_subdev *sd, &tmp_ffmt); } =20 - /* FIXME: DPCM decompression */ - *actual_ffmt =3D *ffmt =3D *__csi2_get_format(csi2, sd_state, which, - CSI2_PAD_SINK); - =20 + /* + * The source pad must expose the uncompressed format even when the si= nk + * pad receives DPCM-compressed data. The hardware decompresses DPCM + * (e.g. SGRBG10_DPCM8_1X8 -> SGRBG10_1X10) between sink and source, + * so propagate the sink format but map the mbus code to its uncompres= sed + * equivalent. atomisp_subdev_uncompressed_code() returns the code + * unchanged for formats that are not DPCM-compressed. + */ + *actual_ffmt =3D *__csi2_get_format(csi2, sd_state, which, CSI2_PAD_SI= NK); + actual_ffmt->code =3D atomisp_subdev_uncompressed_code(actual_ffmt->co= de); + *ffmt =3D *actual_ffmt; return 0; } =20 --=20 2.53.0