From nobody Tue Jun 16 12:43:34 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42E5137FF7B; Mon, 20 Apr 2026 03:09:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776654587; cv=none; b=Zh4RRBlNyz/WQNME4zK3Rs0Xw4JLEZ2q273vhTj5nCPw70c207hllrYBaAhRpAHgs1O3riDk6FGIwjajpQBqpF9+rVjG1uouq1g4+XlWb+d6QEvg1EHiqzhczT+9KCkqxAw6MH3eCof7HK0SPSq+jp+TcLhwISYeeyW1f8N0n8U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776654587; c=relaxed/simple; bh=dy4N6TGQJWD6tnl0B/E2R/g5apTeDjbZP8aIdYHCVsg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=OZq7CRkUdFtsD3qKVjj4/y/fXz7QBO6+H2/2XVTQoi1B/MiL+3DkNQQgr0XL2VM8n7nQY4ycbTAD9KjDeSntuK3BfQuQeTg2rGtWh9ghww0oxdjqas0MWJK+qeLU8bHElpD4+xEDbfbIR/tlc4rYB5E+3DoS6vyZ4PCvayIXMs0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 5d8f1cc03c6611f1aa26b74ffac11d73-20260420 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS CIE_BAD, CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_GOOD, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:a8d281f0-31a0-43f8-b0e6-db6f1420addd,IP:15, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:35 X-CID-INFO: VERSION:1.3.12,REQID:a8d281f0-31a0-43f8-b0e6-db6f1420addd,IP:15,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:35 X-CID-META: VersionHash:e7bac3a,CLOUDID:a2256f6e5add7f916926163279390ec3,BulkI D:260420110939KEUEHNOD,BulkQuantity:0,Recheck:0,SF:17|19|66|78|102|127|898 ,TC:nil,Content:0|15|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil, BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 5d8f1cc03c6611f1aa26b74ffac11d73-20260420 X-User: liwang@kylinos.cn Received: from computer.. [(116.128.244.171)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1913366724; Mon, 20 Apr 2026 11:09:37 +0800 From: Li Wang To: Miklos Szeredi Cc: Joanne Koong , Bernd Schubert , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Li Wang Subject: [PATCH] fuse: drop redundant check in fuse_sync_bucket_alloc() Date: Mon, 20 Apr 2026 11:09:00 +0800 Message-Id: <20260420030900.4944-1-liwang@kylinos.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kzalloc_obj with __GFP_NOFAIL is documented to never return failure, and checking for NULL is redundant (__GFP_NOFAIL in gfp_types.h). Besides, its caller fuse_sync_fs_writes() uses it without a NULL check (atomic_inc on new_bucket, rcu_assign_pointer). fuse_fill_super_common() passes fuse_sync_bucket_alloc() directly to rcu_assign_pointer() without NULL check either. Signed-off-by: Li Wang Reviewed-by: Joanne Koong --- fs/fuse/inode.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 33009227e91d..e5069d2f8e90 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c @@ -676,11 +676,9 @@ static struct fuse_sync_bucket *fuse_sync_bucket_alloc= (void) struct fuse_sync_bucket *bucket; =20 bucket =3D kzalloc_obj(*bucket, GFP_KERNEL | __GFP_NOFAIL); - if (bucket) { - init_waitqueue_head(&bucket->waitq); - /* Initial active count */ - atomic_set(&bucket->count, 1); - } + init_waitqueue_head(&bucket->waitq); + /* Initial active count */ + atomic_set(&bucket->count, 1); return bucket; } =20 --=20 2.34.1