From nobody Tue Jun 16 12:42:42 2026 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 689A3376BF1 for ; Mon, 20 Apr 2026 01:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776650270; cv=none; b=urKSjJdSV/oV99aTF7TEQ7JfNAc07K/a6RnfyO8TlWvE7aWevlhj/opZgHwV738imllke9jYncw8saJqgXoiXVeAVSwCzw0/xJpVbY1KwLK4xxg7RQmaLwyhEnmFbOwdDSt790Uube/vA5hbLFV3z0eqGXzAPs9xL31ihVo+zpE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776650270; c=relaxed/simple; bh=nDOO/QVVxqLEgHoPDQz6EwQRY3Od75nFCAbkfCou6bY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=e0tdRuj05k9WKCbapxPSa3ogR7y+ZEJz6w9c+u6373R/HeAiBMUJQNJpibvemRNfrEniR9KV7hCskKrqy/mzQ76qW1PSlJjRtRsrY8kx6ZEgSvqw1l7jEHbD5n1hgiWZY8mz5c+usRiU8XwZe7QWnGJcMmK5HWy/yQ2z3hXIyNg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ltfWM9Nx; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ltfWM9Nx" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-8aca6bd57cfso26579846d6.0 for ; Sun, 19 Apr 2026 18:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776650268; x=1777255068; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tGxkhVLfHZjK8520beBJO1JbPMJ7IBle55iVGcEnGWs=; b=ltfWM9NxzQI6xg8W+qC8xfe2z+j0zYF2phPpwxjcKPYO4hYX3Ji01bNVpHe+Y6aheO avnOD+UbwJFJZ5BQzYyMTroAHn1slKiz/Ds1dmJDW9xxiOU37Clk71JUo7vm301pqYH9 qEKJcpZrWsNjmtXIm3tNcUm4MYSYcdQQ905qz/VPvtlnwKXNAjt+Us5nUoh96M3meUg7 6dUE0xsaayUzuwG1zF0hxM9E4OP4n2fIU8mmUASjvbPxKEjTUilLRFPlTdDmxUqCFFlI Bbx40GtAtMN6ynFjB4afDaP5awRY+CLyv9QVJkJOwBZzFBjP7TNGIRgS6E2uo4sshJ1B Y6Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776650268; x=1777255068; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tGxkhVLfHZjK8520beBJO1JbPMJ7IBle55iVGcEnGWs=; b=H4N3pbFADxUJePdnXXTcwlrYSxWTLyp5IiVTG6tl6qkhgTzlMKiBVtCTLRYPu0NL+o McbS20PL4EYwyRMJ7/UkXmgVsWhzc3EmjHBjcrxWZGMd5CEP2Nm34QFIr/9VVgMhxPp0 iELOQPQW3IS8n6a4NWBPE4ldxEtLO5dCbwuknxBDda+1Q1Z3YRQgrjETJ+0fA57GOH6M OF1rQ0n4kAIMSpHi2JB48q2SSgJX89mYDGFB9+sumfVx3a4VuMa/2StRk2xt60y7lXhq M64KQvo9UcqizTus2Z7SP/0icos5+sL2CoBYhIhB7dfrnERm9zP27n61Lo0AmnNtLuB+ +Ejg== X-Forwarded-Encrypted: i=1; AFNElJ80/JwIyc9V+8THBcq+QAetKC+ZLydQvz6rNuMPCQNelutgvZGE3d6IFgKi2G2/J8q6ANC8sIpstm+lZRc=@vger.kernel.org X-Gm-Message-State: AOJu0YyQ4e1OH4o57SzjVXHhQqBNiN5sdMJ5+l1kG52zEC2YRm9Ro5o7 aRv6iaPQwIJRSuHU4FNZUjKvLj0F7QmDP1ej7vVF4UMypYx+F1Zz2hJU X-Gm-Gg: AeBDieuPHxvx9z6NfiihAUWU8GM/fFPaDYmNQhJpC8+elWtcBZ2HwHdM8IfXz33dKNf 2bkrUPVMC6sIETpQXOVljz/H36kpcbhgwNP5bNc+BQz9WroENGfnByCFlcHSdw4nHKeaysbx9D6 3avEQo2AF46BSbSHxvXNtBN2VwGhsyyNRB5KtHivV4TtNAb5z1BhSrd3hiTWU46lvfONMKV8wzO a5enVccOqjVNtDW8EMGXRz/xQ7LkYjAeXPr+9igw2/55kqRTTJXZCHSUnT52tzbrIMNCa/w2MSk 4VVCEAe64u4h3uGO1NY4L6CtUGMPCZe5qQhwaQcwolw0ZfGEKe9VSiBwI6p0ok1Vn3FpGaSioz1 KhTY9HGijquRi2A+72f7usIme1kcc3KMkxYkb/gyuSJjWiPC+NcyF8vCXdLCEFCe0qNSYNck0xx SDlsdmGnzb0qU7gAgKXn8u5anXA7uBWtfrtqCRGOqNx61t1hdxKoDQDq9IY6xITZIDUzNgwZZpk dpgkyfMPsyNEtnluExkMO9fIfxgu2C83pGNONA= X-Received: by 2002:ad4:5ecb:0:b0:8ae:64c0:c922 with SMTP id 6a1803df08f44-8b02817684fmr194814596d6.46.1776650268394; Sun, 19 Apr 2026 18:57:48 -0700 (PDT) Received: from TDC4045031631.e0cglfehwr0e5gttmepj3hi3hf.ux.internal.cloudapp.net ([20.63.37.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ae79733sm65963546d6.33.2026.04.19.18.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 18:57:48 -0700 (PDT) From: Ashutosh Desai To: netdev@vger.kernel.org Cc: linux-hams@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org, Ashutosh Desai Subject: [PATCH] net: rose: use pskb_may_pull() in CLEAR_REQUEST length check Date: Mon, 20 Apr 2026 01:57:23 +0000 Message-Id: <20260420015723.462479-1-ashutoshdesai993@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 2835750dd647 ("net: rose: reject truncated CLEAR_REQUEST frames in state machines") guards against short CLEAR_REQUEST frames using a plain skb->len comparison. Use pskb_may_pull() instead, which both enforces the length requirement and ensures the bytes are in the linear part of the skb, making the subsequent accesses to skb->data[3] and skb->data[4] safe for non-linear buffers. Suggested-by: Simon Horman Signed-off-by: Ashutosh Desai --- net/rose/rose_in.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rose/rose_in.c b/net/rose/rose_in.c index ca4f217ef3d3..48183363d3f9 100644 --- a/net/rose/rose_in.c +++ b/net/rose/rose_in.c @@ -274,7 +274,7 @@ int rose_process_rx_frame(struct sock *sk, struct sk_bu= ff *skb) * ROSE_CLEAR_REQUEST carries cause and diagnostic in bytes 3..4. * Reject a malformed frame that is too short to contain them. */ - if (frametype =3D=3D ROSE_CLEAR_REQUEST && skb->len < 5) + if (frametype =3D=3D ROSE_CLEAR_REQUEST && !pskb_may_pull(skb, 5)) return 0; =20 switch (rose->state) { --=20 2.34.1