From nobody Sun Jun 14 01:05:51 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FC673C2768 for ; Mon, 20 Apr 2026 19:26:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776713218; cv=none; b=Mnc/IktaNkfo/0zsNqWU+L11IPSTkddXi49lf1DWbyXDTArxCSBwcnXu3y7rrFWLonFhsTy6piXZsqB3OtrcD5Qs67ipTlwJPOXvo97cA6YUbxvdqQJRgwZQPvU+QeLpRlvh0lTlDvAGwrzD4Dg67cyu5scnQsI/o6tIlwKkMr0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776713218; c=relaxed/simple; bh=q/KD6vbsCHIP2YFsYt8cPRg7KoZe+g3bSUiSIqD/e14=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PbMqhFKYlth9jBtN1F8h08gW8OU51tXsz8J3cq99xkqKaofL39bPZoMkpmc7k26FuM7w8lKy8rUxrL9HnXlPrgFFCnHnfAM9OWZPHgd1D/RzNggBx0B5b+efZ2sN05t+IKDhPBTNeVCrSzlHTp4BR1Q19da0gEWqoYfnJjTIsPQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lKoOhjRE; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lKoOhjRE" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-483487335c2so35229395e9.2 for ; Mon, 20 Apr 2026 12:26:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776713216; x=1777318016; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=r4tLDDmxREE4wgs5r5ScyPH/634xf/UlA99QJ6WpHiM=; b=lKoOhjRExnbuuNKUKyS+OpCeS29yHwTrzARgVjAt9q1M1OskQWwWzZlnWAsWIzbAqd b+aqap7Nk+n4TcxkJ7qeomo9CudmzdXavbRdd6+SuwgB+I7wS1R1n+cCfDG+rUhUllMs KPf/4I1VWGH805WsbQ6irrABrNLeq9lYgBAGmtuaquymOnCKNQGGiIUbqVWEsuKvZpXB UZceg1a0EayTDAa6lbq6lmld3yptR/4OZpqVFc96NPhXezNK7bQE+/rvV+J7KeXpiydz Cp/fH+55D4rJjqzW7ahsPjLUc598eHNvGEBM2c9NmNEOAnN0mr4zmmvAhl0ow3JnR+zD tlTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776713216; x=1777318016; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=r4tLDDmxREE4wgs5r5ScyPH/634xf/UlA99QJ6WpHiM=; b=VR6sY4Wq2Y2SWh7AoF8DyBop+8Lg5FTr5s3i1I9V91Jy1bFjEMIbxTiwcC7IJ+WS45 Bacy4DamR4Q0U3rfj3mwomPMz+5AnNPcz+MSWzdNSyhYpe3f1ASRsWlFXmtDS2CDbBKL Ei4thG2g81CRuXbHKLoIAUg4gEof1uPDGVomD9Dc7kAUIvhRJyFSojMSDyrk5FGcq/0S BgXPjiHFr8Ua/9ZSw4rwUtOwyDjo32sXAHs7UDI6/di1u295mVhDpEG7XSuDTNUGuHkg Lt8V3wLpZZ23ynFzLZdV2v2Sull/1mrkeNEfmi6dbCP7pJGtkLCNqYXB8jocn1+qkPFc 5MXQ== X-Forwarded-Encrypted: i=1; AFNElJ8rPljCIAbEfgIuoiKp2LcxQKouYr3dhsoJMtkcHU0KJlWdBFHe5MIoV4AGEwj+qsedOqZ9+uKOaQtPk+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxtwOI8MDi65Re8YC8G3lzQCIbevqUOpm30JlTKoXrWW417LJ15 1wnFrN4ye2BXRhDn5kU1I8cbxc/dTLtcdNoKRq8naqIW8TCqNZjUYCYRb9E+jo7cFQQ= X-Gm-Gg: AeBDieu8WZ+yQu4BFZaYxuNK5GiRQdoHQp3sSp8gkB4eUQVGZcIjPlkYF91yoDfbkdq 3BYaUn6TE4axbnFWzSgs+nWDZMZFbRPE87ypuVg+5OeaOKzdVI18hqZ4rchfQjwuu8X1h4Y/6Dd 7JfVwKvcH2dyYVmBT5txdlY+8N03XsEs0RhUo9u7VxIPZGyw3HzZUabgpaV1TTGQhDwa8wfC6Qn rig3BLkk+PZ8ikErtkgo34077oML9+AsGTJYSzYKEwIFEKCQueT4SX3GwI1bciwSeqlI1pKKbl+ Am6vwSn8+Sr/03WgPfgxPSng4IUcT68gyqxzqP2F/rhQ/Se1oX/ZsFON8ZF2CQrm6WpX9sFxx4X +LScTNVCgsmYutO+d8hWI0cnOE8Vpil+2h7t2rXm9uOyBKRpiDVIPlo7NU4YVni8PiY5RcASkGM eKv8dVz1oj8JBRvIL3e8ZnsTVHROzLTDzePY8sieKIsiAuZLxvtvpwAtw= X-Received: by 2002:a05:600c:8b8c:b0:489:1d74:56d with SMTP id 5b1f17b1804b1-4891d7406famr73622275e9.29.1776713215554; Mon, 20 Apr 2026 12:26:55 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:106d:1080:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb78d1bcsm133524515e9.5.2026.04.20.12.26.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 12:26:55 -0700 (PDT) From: Neil Armstrong Date: Mon, 20 Apr 2026 21:26:51 +0200 Subject: [PATCH v2 1/3] arm64: dts: qcom: sm8650: update the cpus capacity-dmips-mhz Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260420-topic-sm8650-upstream-cpu-props-v2-1-689e07d8ab8c@linaro.org> References: <20260420-topic-sm8650-upstream-cpu-props-v2-0-689e07d8ab8c@linaro.org> In-Reply-To: <20260420-topic-sm8650-upstream-cpu-props-v2-0-689e07d8ab8c@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2456; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=q/KD6vbsCHIP2YFsYt8cPRg7KoZe+g3bSUiSIqD/e14=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBp5n38c3+m2fgLqbAWn46zTOOkWJO7AdvauiaRBhkm cmjXu4iJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCaeZ9/AAKCRB33NvayMhJ0T75EA CGEcy7ZMkI8DnMdJaKTxwbnJgnAgroene+BtHHaSmodVFVb3vQQNWdmMg/foyu/sV3sOKjJjtfjkGh q5bDKxvkanMcYgu4f1zdILEOiE1vFfC8M5Tx3uSkPqOBmhPeBry2rYC1/T/jz3HOIu64UZujrwWAnw i5nsbbnW7/1WfG/+ApW2RsXK+ANyVKWnWutvUJ1T0uHtd9mI4YHq7Y+UAtJ1oVaICjH5SPt6WujA7T p5bdfAP3Va3MhodPRbYeXU/rElbNo+gtyG4ybC31+LNgEYGzdsobSuIQSOomS29FA4Rj3A19nqEV/G T+2kab4zXuPettJ2lO2QSvY1XwgxtY01/s/7wAAvSiz7K7bV772X30ZXbpWkW0YsJI+aWnS/6c3r0B o+3bb9zHHCX1gND88j9QK68Nb0fGBHe91P8A2QVHUjQAgXt9uczTKCgAUKlrDYfP9tJxjgQW23ZHLW bJ6ARcYWr7Rk0lsD1TLqLwrFivjK+1Vjc7WvitxZiT/lMSBn1Hjxwj347Gi+X8qXa+crwB/MvtcIyJ lph75hu4TlPV25B/ZLfsjPUqzbUOpFvmqQqSbz72O76euyDe5XB66uG7m2KKSq4xOK5vRILxDdigG5 ggwmJFE8gcTlKcrkB31A52qGz9C/ZTZD26FDsDH9Yd6s23aLMqummE0ht/dA== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE After some more advanced benchmarks with Integer, Floaring Point, Encryption, Compression, NEON, ... on the A520, A720 and X4 cpus, the median gain with the same frequency range is: - 281% of A720 over A520 - 126% of X4 over A720 When adjusted with the frequency delta, we get better values describing the difference in capacity, showing the weakness of the A520 designed for very small tasks while the A720 and X4 are much more powerful. Reviewed-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qco= m/sm8650.dtsi index 1604bc8cff37..42977b04346a 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -153,7 +153,7 @@ cpu2: cpu@200 { =20 enable-method =3D "psci"; next-level-cache =3D <&l2_200>; - capacity-dmips-mhz =3D <1792>; + capacity-dmips-mhz =3D <2909>; dynamic-power-coefficient =3D <238>; =20 qcom,freq-domain =3D <&cpufreq_hw 3>; @@ -189,7 +189,7 @@ cpu3: cpu@300 { =20 enable-method =3D "psci"; next-level-cache =3D <&l2_300>; - capacity-dmips-mhz =3D <1792>; + capacity-dmips-mhz =3D <2909>; dynamic-power-coefficient =3D <238>; =20 qcom,freq-domain =3D <&cpufreq_hw 3>; @@ -225,7 +225,7 @@ cpu4: cpu@400 { =20 enable-method =3D "psci"; next-level-cache =3D <&l2_400>; - capacity-dmips-mhz =3D <1792>; + capacity-dmips-mhz =3D <2909>; dynamic-power-coefficient =3D <238>; =20 qcom,freq-domain =3D <&cpufreq_hw 3>; @@ -261,7 +261,7 @@ cpu5: cpu@500 { =20 enable-method =3D "psci"; next-level-cache =3D <&l2_500>; - capacity-dmips-mhz =3D <1792>; + capacity-dmips-mhz =3D <2909>; dynamic-power-coefficient =3D <238>; =20 qcom,freq-domain =3D <&cpufreq_hw 1>; @@ -297,7 +297,7 @@ cpu6: cpu@600 { =20 enable-method =3D "psci"; next-level-cache =3D <&l2_600>; - capacity-dmips-mhz =3D <1792>; + capacity-dmips-mhz =3D <2909>; dynamic-power-coefficient =3D <238>; =20 qcom,freq-domain =3D <&cpufreq_hw 1>; @@ -333,7 +333,7 @@ cpu7: cpu@700 { =20 enable-method =3D "psci"; next-level-cache =3D <&l2_700>; - capacity-dmips-mhz =3D <1894>; + capacity-dmips-mhz =3D <3591>; dynamic-power-coefficient =3D <588>; =20 qcom,freq-domain =3D <&cpufreq_hw 2>; --=20 2.34.1 From nobody Sun Jun 14 01:05:51 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D4163C277F for ; Mon, 20 Apr 2026 19:26:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776713220; cv=none; b=tmcO9co7ttTpcGnouboF2b8GX7VL9/JANA3Qt1UTLtKLSeLjf6V/WJBU4E45I17R/MD8DIEiUMkTK36zIQTXDHTQLxWmQvr1/Sb+ZSdxoJmoWyeyRESuBvGsTBmhe7UpiaL9WTSm/O565BfBJbOb+XSxLp84zLNPDedBIyPvBLo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776713220; c=relaxed/simple; bh=WcpHy4m8Hqbku7ILhoBi7bTOojWUPPfpvczwGndi/3Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KYIr5ag5v5qUj/u/0y2HcbGeaoidpAboAhS0P/MWoy0zKOsehhT3dXOwoBdfKRBMJey15rgxSo2SwYlL5QrfxVd3pJLU6ZjUCv1ZYYOzgELzHf+tF+x1SEvVY9ddpRifLFcp/+Ll7ara0IE5a3+M8xdDs/HyM662ycqS/mQkaMc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=t/n7rBMn; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t/n7rBMn" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so44215435e9.0 for ; Mon, 20 Apr 2026 12:26:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776713216; x=1777318016; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yzQLTSNnO0CldrTKhWAPY1a05DYxM3tccsWIwC6cb5M=; b=t/n7rBMnAvxaOUgcz/Hcv6vTKCScO4hgbKEk7TGcjJpE4hzTK/FRCIFrHr7ATn+6KY ZAGeA0JBxbJmnzcNOoGnR5+w3HRIF5b38PEUBH5vWkz+MddIaS+ViHN/XfEDm3d3Miml UwyC+05KEiYtAECP3kEvGm0lot37z9SUFnF116MhbwUTnKGDBnPeAa894EwKa956DN25 cBGXDBCyNXXV8Xb4Pig/kKgiliy1aQGBlia1tgSDCrndAQsEJKl4inW8JGtCZtq6Cwk8 12kfnnjbeun/+u2zQEV7hPXjX3h9430RFwLxOQoYK9DfPNqDMkJj0j+T2Z4zB3oyAaa3 SLtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776713216; x=1777318016; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yzQLTSNnO0CldrTKhWAPY1a05DYxM3tccsWIwC6cb5M=; b=M0VlaXPCfI6c3C8bOqy6ChnQMaPCeH/N94+M9ruqFSnzVhiT7hMv0ZHfKuHovUU0MB f6C+ATXU2ivNkqcdWmv9qyBz/IVtjeObmR+lErQKjma3A4HPBUsEGcNQGy2utGwMFGLG /M0ILSimALWtmfwblfeFP/5ih82cK3ECAF/czU//+2TqUsGZ8ToaZAXaEnbi2v0dYQKP zmj/6IqtPdZ7AWCIcS5MrxpzJNySsszmKMuMOPDWyLzs9GbF6dcC4QUf5mJghCm1qVza Yt5YFf0rQjL4h5OQ8mFPrXYmx1AxqAqvRLzAW62MesuSTuKNTC9xNr1alhk/3P3+HqED /jQw== X-Forwarded-Encrypted: i=1; AFNElJ+ZWzmlInwb3S6Jl5lp5H1eA8frRSo/vl2NZcJXX2WaWPe8QrwiqaJJ5o994oFf2Ompfrw2IYbr6CKi88I=@vger.kernel.org X-Gm-Message-State: AOJu0YxcZsfSwLJTM8wMWa2SS8z2RM8vFGFZZYiLRKfmSMj98k+oyT8i C2hRtVpsOjC7PKCjADlLhfT6+66IYxJ3VHnrUZK76BzSWbSBCdQznWhv1cT1Cfwoa8Q= X-Gm-Gg: AeBDietliV3I7V8rnPxBX/iCg8Q455c2FD1vYSjFo1IMi8Tr4zEtB5CMxoJ52K83IMp 2phn+GmGMc85VsOJJUTIZVdT8BGJuSHyeuao+USMoKRkyBiTeCi/cFBETU4NhsTB8F+3mbr5rry xKAiI7M/BwcSzbYLmHqHBlqH++IwiozXjOPrf8gMSgmVsPNKcT1u3Ea3gODvMPeVA7cxG9q9oAl 4Wwz2GepbzCoPDVIWM7N8HfCktocQ2z+10dHSAntQi/sHIc+G883z6SFgEhszdYBltIAuGKJKxK 4JX/9fhOlwc8zWAFwiSxL83965PIGPJsfof5RHDq2DVz7YlSpOQ8/gaFoFbFvimsRpLzeRxr5r/ FZmQzTEPMot3gwXEmducnT2+wTFO/gNJNUNnzEd8caFpWI6Xj4M3W+UiaY0DQPfaddyOur+MxG0 +U9DPSk+cYdD+dpO4e7Vn71ezNIoF3xsmB1LXeUJljT+L5oFkYI3GNtqgIe9FPQoDdkg== X-Received: by 2002:a05:600c:c0c8:b0:487:21c7:2885 with SMTP id 5b1f17b1804b1-488fb73d9ffmr169046275e9.5.1776713216306; Mon, 20 Apr 2026 12:26:56 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:106d:1080:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb78d1bcsm133524515e9.5.2026.04.20.12.26.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 12:26:56 -0700 (PDT) From: Neil Armstrong Date: Mon, 20 Apr 2026 21:26:52 +0200 Subject: [PATCH v2 2/3] arm64: dts: qcom: sm8650: add CPU cache size properties Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260420-topic-sm8650-upstream-cpu-props-v2-2-689e07d8ab8c@linaro.org> References: <20260420-topic-sm8650-upstream-cpu-props-v2-0-689e07d8ab8c@linaro.org> In-Reply-To: <20260420-topic-sm8650-upstream-cpu-props-v2-0-689e07d8ab8c@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=4680; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=WcpHy4m8Hqbku7ILhoBi7bTOojWUPPfpvczwGndi/3Y=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBp5n39cnDqJZgGVU3RWAoSVE2wI9D59KSWEFqaXktr Ba5KQLSJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCaeZ9/QAKCRB33NvayMhJ0WMvD/ 4oP0b9bDT6JOVy0IO9FNMjFwwIdQTFNh6bADJAcZTIxoLMc9i1qjwayXRMMjrO8Fr/2wT1hg4VYvCu ISN2utP8oJVCGWz/NhsW2papy3agGbxaM3PNDdzGqlj/KoLaoHpSmAt4fdU+vFguIsMqFANgg/F/hq IhSrNpXa5pIIg6+1oMjsoVMzlyIY19qI11H8PzdcwaUtiG+9QwVMnWaUzB2iMmcUK875D0E9BL230z EtxeQJSg0ntMzZ9QqFscdqkbvHTzkTrS0O0xIlwKVT79irHtG+TZfgnWxnYV5e2m+BobYELwlngoRb /2dDQ9/lWLte/EDoRZ7L055syWBYoeUpEnrMxEXMVDI/+1VRdDmqkLDCvnqoIqlLY9t0PY0UhoZ+sF 32gu72G247f5aFZvZnLmozOCeVnPBiixlrONs7qTV7tr+Ntq9RmuQ59x5ZCCM1YE1zuHM5HMZNuDnh go50ek8hKatDWtO+9ZI/1h1iTCWc7DFFmQGx4EdEg+V8B1kjjW6m8XZJZ5fiq3rxsbFGXGK4t5AHkT A8VZblpiXzY6Bk/XjfV9BnxrAb+wyPhBUdEURZEDZX+c2WCz6ifpu2RQLpyutZofBpgxVxSPsDKbsD nsg8hp2mdn8cWYhTEEwj+xGoBL8VpT6Y16lj22S+7oWmA/CwfRRQ/E1TvPfg== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE Add the L1 cache size and its line size (cache-size and cache-line-size) with the corresponding L1-I cache and L1-D cache. L1 cache is unified, but clidr_el1 register (get_cache_type) tells that L1 cache is separated (CACHE_TYPE_SEPARATE), add i-cache-line-size and d-cache-line-size and cache-line-size of L3 cache is specified. All cache line sizes were confirmed by checking ccsidr_el1. Signed-off-by: Neil Armstrong Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 56 ++++++++++++++++++++++++++++++++= ++++ 1 file changed, 56 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qco= m/sm8650.dtsi index 42977b04346a..c5358894fbb3 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -75,6 +75,11 @@ cpu0: cpu@0 { compatible =3D "arm,cortex-a520"; reg =3D <0 0>; =20 + i-cache-size =3D <65536>; + i-cache-line-size =3D <64>; + d-cache-size =3D <65536>; + d-cache-line-size =3D <64>; + clocks =3D <&cpufreq_hw 0>; =20 power-domains =3D <&cpu_pd0>; @@ -103,11 +108,15 @@ l2_0: l2-cache { cache-level =3D <2>; cache-unified; next-level-cache =3D <&l3_0>; + cache-size =3D <524288>; + cache-line-size =3D <64>; =20 l3_0: l3-cache { compatible =3D "cache"; cache-level =3D <3>; cache-unified; + cache-size =3D <12582912>; + cache-line-size =3D <64>; }; }; }; @@ -117,6 +126,11 @@ cpu1: cpu@100 { compatible =3D "arm,cortex-a520"; reg =3D <0 0x100>; =20 + i-cache-size =3D <65536>; + i-cache-line-size =3D <64>; + d-cache-size =3D <65536>; + d-cache-line-size =3D <64>; + clocks =3D <&cpufreq_hw 0>; =20 power-domains =3D <&cpu_pd1>; @@ -146,6 +160,11 @@ cpu2: cpu@200 { compatible =3D "arm,cortex-a720"; reg =3D <0 0x200>; =20 + i-cache-size =3D <65536>; + i-cache-line-size =3D <64>; + d-cache-size =3D <65536>; + d-cache-line-size =3D <64>; + clocks =3D <&cpufreq_hw 3>; =20 power-domains =3D <&cpu_pd2>; @@ -174,6 +193,8 @@ l2_200: l2-cache { cache-level =3D <2>; cache-unified; next-level-cache =3D <&l3_0>; + cache-size =3D <524288>; + cache-line-size =3D <64>; }; }; =20 @@ -182,6 +203,11 @@ cpu3: cpu@300 { compatible =3D "arm,cortex-a720"; reg =3D <0 0x300>; =20 + i-cache-size =3D <65536>; + i-cache-line-size =3D <64>; + d-cache-size =3D <65536>; + d-cache-line-size =3D <64>; + clocks =3D <&cpufreq_hw 3>; =20 power-domains =3D <&cpu_pd3>; @@ -210,6 +236,8 @@ l2_300: l2-cache { cache-level =3D <2>; cache-unified; next-level-cache =3D <&l3_0>; + cache-size =3D <524288>; + cache-line-size =3D <64>; }; }; =20 @@ -218,6 +246,11 @@ cpu4: cpu@400 { compatible =3D "arm,cortex-a720"; reg =3D <0 0x400>; =20 + i-cache-size =3D <65536>; + i-cache-line-size =3D <64>; + d-cache-size =3D <65536>; + d-cache-line-size =3D <64>; + clocks =3D <&cpufreq_hw 3>; =20 power-domains =3D <&cpu_pd4>; @@ -246,6 +279,8 @@ l2_400: l2-cache { cache-level =3D <2>; cache-unified; next-level-cache =3D <&l3_0>; + cache-size =3D <524288>; + cache-line-size =3D <64>; }; }; =20 @@ -254,6 +289,11 @@ cpu5: cpu@500 { compatible =3D "arm,cortex-a720"; reg =3D <0 0x500>; =20 + i-cache-size =3D <65536>; + i-cache-line-size =3D <64>; + d-cache-size =3D <65536>; + d-cache-line-size =3D <64>; + clocks =3D <&cpufreq_hw 1>; =20 power-domains =3D <&cpu_pd5>; @@ -282,6 +322,8 @@ l2_500: l2-cache { cache-level =3D <2>; cache-unified; next-level-cache =3D <&l3_0>; + cache-size =3D <524288>; + cache-line-size =3D <64>; }; }; =20 @@ -290,6 +332,11 @@ cpu6: cpu@600 { compatible =3D "arm,cortex-a720"; reg =3D <0 0x600>; =20 + i-cache-size =3D <65536>; + i-cache-line-size =3D <64>; + d-cache-size =3D <65536>; + d-cache-line-size =3D <64>; + clocks =3D <&cpufreq_hw 1>; =20 power-domains =3D <&cpu_pd6>; @@ -318,6 +365,8 @@ l2_600: l2-cache { cache-level =3D <2>; cache-unified; next-level-cache =3D <&l3_0>; + cache-size =3D <524288>; + cache-line-size =3D <64>; }; }; =20 @@ -326,6 +375,11 @@ cpu7: cpu@700 { compatible =3D "arm,cortex-x4"; reg =3D <0 0x700>; =20 + i-cache-size =3D <65536>; + i-cache-line-size =3D <64>; + d-cache-size =3D <65536>; + d-cache-line-size =3D <64>; + clocks =3D <&cpufreq_hw 2>; =20 power-domains =3D <&cpu_pd7>; @@ -354,6 +408,8 @@ l2_700: l2-cache { cache-level =3D <2>; cache-unified; next-level-cache =3D <&l3_0>; + cache-size =3D <2097152>; + cache-line-size =3D <64>; }; }; =20 --=20 2.34.1 From nobody Sun Jun 14 01:05:51 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4C893C3BEF for ; Mon, 20 Apr 2026 19:26:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776713220; cv=none; b=oli3y6XcwAIQErNkFo6idGiTbiLWacfYSb5J9RG7sNNAElaeDTonzmr5slnMfgUUPXWkghPCho1waKkAI4u9LiRqvHqwtZlY0hZQyhvL3PD2X1XdcxqMG5sAoINKXt/weprU+VsAFssBhQ4fH8qRKtt6T5Nx7b2f3xYcBnrFiBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776713220; c=relaxed/simple; bh=+qtKvBDAkMqbgXqc7T7YdD3JOpfzOdaRXujJjb3n4zc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NDp1xJRgkmqWGFjVnFn1n9fvCBO4cr4vNI2xEBS1ePEsW8plG0V+sqyPrWFGzH6RtEP93gOJMlmOCoACBvQ3ByVirLpCnS8CvsWFX4iylmK7ZPPfWP8MgKxh95ekS+gOqocS4hM+HFHxqI6+nrd+ptGBLI1h8/wjq59BSZK6ewo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tTtahd84; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tTtahd84" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-488b8bc6bc9so23946265e9.3 for ; Mon, 20 Apr 2026 12:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776713217; x=1777318017; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eFrB5VArQYae2VnkFo7wFR9PaBq4FSF4lzLh6V32m3A=; b=tTtahd84D6noqUbDQObRLm7RRPjTU9F8bRfm1pdjnptHg0XywziHLra1wohXm4bxBw d1N9nakG2gklO+0xBqLLr/WGGMv4ZmAcFNh0pxH9PmFhpuyi2pEQTdywZmwvxDvvFkrP fnrwjP55rHHvb/fEUoeIm6HqmzNwl3SyhctuZf5RLIDBM/8quU889YyuTgBS4hYONH3W qMEsUH6zfqYc8cYz5lJJO9kyzPJhhEFAWeYE/1B8uPMAFZ12AdJW/kK00hpbbc71RNH0 M1P1jgU9RViqdBE5KQbAEbsQblzagNXY7JjVsqykKyZdmjwMVFLX30MidZzn2qiUMbuo FGrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776713217; x=1777318017; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eFrB5VArQYae2VnkFo7wFR9PaBq4FSF4lzLh6V32m3A=; b=U59196wYpI11mkfi0c6kYdY+gzNkpQwdzJu8gjJOaRXH+WQVBCfDUrXE3/ZmYQyAeW BWsRIo6EbT3aAOeLd2hy1lr8hT6i8jLPvJ4aVb4QwI2jvTepyQSaT4uP+gOCOXkDVn6+ xRGmDQ9zZc5jggMiDI/oOkBun01TQLMlcVHER3avCvke15j+JfoTxSXguFBnSgEXXmD/ 7HPUljFq7BykeWFXHxd/DtXbrBfVO/VY+y8NoloPJGrUKuUBaSvy9vL5YzLSHg2AYORF nxSe+mQWd5gFcWcz2u/OFYP5KVqSrpw9kNj2J03YyGqIRDOlQMo5/CFGCA3VlG0TFkBb iFyQ== X-Forwarded-Encrypted: i=1; AFNElJ+qAGQgxnGJnkom+2LD6InmC//7n8b5BqHo3ogsq45VJzJQRYtqwN+WSlm1gGzonB5Ypd7R3799C9vJlng=@vger.kernel.org X-Gm-Message-State: AOJu0YySBMR44Wr6D5CLAxG1GWaIX+dCYMkt4VuGDMaXcnGBfBEw2OYW W+1mwsSzcnOoHuwanHitgOqte1Z81R3Aq/Cwf9FzD8LyR8kvVCufzFsDS+EviBNCTX0= X-Gm-Gg: AeBDieu0RqnGB1x9sz+dPaBZltVn+rW8OsgslJE8yCN5i/fzqy7grJSbcLM3jP41tZu iVgPIvmeySK4xrX0jaExI/8B9NsHtYO3yZKiBh0PT4/VvUC1QIWWxk3/TKsIJKjd2KBiLoSUCSa CGA+tJfqS3GeXFIhQdgsRsxsnMkUDjIGNutvz5ODJ2ySdfxRtY5LhbzztpLtKVEOh6zT5iMaRAW J6Lm780Bf0YlocJ0rRt4/XX54WqUNyct8m7CSl7KePunZV0sg9ui7LSDQ0csTPQlvFSo/e4tKKb tIPXak+zEv6jvF60w5XO94FO2i3+eRuJPCM3ZCqA5XpkvvqTsf8WkvGWmDgPpFyzS5oE/QVMypm z+kzkZHwLr2Sq3rkEZw/kMSTLwJ7GiLb88zrl0Uu2zBkQu+Ok55iUCt6Gh3pREfwJ5uQTWBkrqx VHEBlqL4OsEZ8UBasR2n5uqMRgOTMckUBYDieT73x/Ydtkg350tKQ/TbQ= X-Received: by 2002:a05:600c:6286:b0:485:3f1c:d8a1 with SMTP id 5b1f17b1804b1-488fb74a677mr217645405e9.9.1776713216980; Mon, 20 Apr 2026 12:26:56 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:106d:1080:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb78d1bcsm133524515e9.5.2026.04.20.12.26.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 12:26:56 -0700 (PDT) From: Neil Armstrong Date: Mon, 20 Apr 2026 21:26:53 +0200 Subject: [PATCH v2 3/3] arm64: dts: qcom: sm8650: fix soundwire ports properties Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260420-topic-sm8650-upstream-cpu-props-v2-3-689e07d8ab8c@linaro.org> References: <20260420-topic-sm8650-upstream-cpu-props-v2-0-689e07d8ab8c@linaro.org> In-Reply-To: <20260420-topic-sm8650-upstream-cpu-props-v2-0-689e07d8ab8c@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=4260; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=+qtKvBDAkMqbgXqc7T7YdD3JOpfzOdaRXujJjb3n4zc=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBp5n39IEyi7kb6DOf2khjlgzAwqI8iJ6RsnDZUQcNW 4xPbDE+JAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCaeZ9/QAKCRB33NvayMhJ0YgoD/ 4vkWgc4YeQBaz7JVYgaTzn1rKixBaW9Yvzp4rhcFJu/3Tpv90uJgobaCi8QNiWAQhQ4gb4Q/Z3xkQf v9iY3JMcMecrQJRWiDUThZpK9Nloma58+ieVUIqNtvTqyU0OuKmpEkaqXfHewEkIUVnVxsXWdkbo84 ZX1t2fQFRf4CxaTZRrj7mjN/MT04E7vjGvG4PfnKLrMqh6N+0FicPonhoXfBdwvWH97ZTE50zgKGzI 20f4ci1PfYY8rTuGlx9puneGl+mlAwZA9e7FF5juv1caCh/ydEOUujRR51R9xoEuAD06WExFcE9dKV OBn4E8yj0Rwg1q83G0lUKvInOLSW9E0zcD8oZ0pZICsBTMT5b/Xo8ckERoGG752LgDnYJQXC34u49K Btr0N0FNN/mBRV0XqXoEz6GeExLwSq+psFvd8uord2bn95qdsZMyw1czit/h+cDE2VtYecI2LfzveK +fP7bC34BwyFJ4WhCl/UbE1AEZSyjQN9vGs+mEUlWi5ZOI+UoyRuqM9FxBDoBDudMRo///qlgqsV+U /ZxD3hMZof502h5u0UZKT5k00eAwxS3KbqRG4hnkJXnPUyYAvCB717WLh5M/dbDIHf9Qov+JrJy9PX RLIeTAqdnZhPy/SpqMhn7RayYWm4I6zUNhhTIzb76guC/4/PERWnAwFbuVCw== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE Since commit 9e53a66a2f2f ("soundwire: qcom: deprecate qcom,din/out-ports"), the ports are checked against the actul hardware configuration, leading to: qcom-soundwire 6ad0000.soundwire: din-ports (0) mismatch with controller (1) qcom-soundwire 6d30000.soundwire: dout-ports (0) mismatch with controller (= 1) Fix the ports count and properties of the corresponding soundwire controllers. Signed-off-by: Neil Armstrong Reviewed-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 42 ++++++++++++++++++--------------= ---- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qco= m/sm8650.dtsi index c5358894fbb3..2cccfbc6d008 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -4730,18 +4730,18 @@ swr1: soundwire@6ad0000 { pinctrl-0 =3D <&rx_swr_active>; pinctrl-names =3D "default"; =20 - qcom,din-ports =3D <0>; + qcom,din-ports =3D <1>; qcom,dout-ports =3D <11>; =20 - qcom,ports-sinterval =3D /bits/ 16 <0x03 0x1f 0x1f 0x07 0x03 0xff 0xff= 0x31 0xff 0xff 0xff>; - qcom,ports-offset1 =3D /bits/ 8 <0x00 0x00 0x0b 0x09 0x01 0xff 0xff 0x= 00 0xff 0xff 0xff>; - qcom,ports-offset2 =3D /bits/ 8 <0x00 0x00 0x0b 0x00 0x00 0xff 0xff 0x= 00 0xff 0xff 0xff>; - qcom,ports-hstart =3D /bits/ 8 <0xff 0x03 0xff 0xff 0xff 0xff 0xff 0x0= 0 0xff 0xff 0xff>; - qcom,ports-hstop =3D /bits/ 8 <0xff 0x06 0xff 0xff 0xff 0xff 0xff 0x0f= 0xff 0xff 0xff>; - qcom,ports-word-length =3D /bits/ 8 <0x01 0x07 0x04 0xff 0xff 0xff 0xff= 0x18 0xff 0xff 0xff>; - qcom,ports-block-pack-mode =3D /bits/ 8 <0xff 0x00 0x01 0xff 0xff 0xff = 0xff 0x01 0xff 0xff 0xff>; - qcom,ports-block-group-count =3D /bits/ 8 <0xff 0xff 0xff 0x01 0x03 0xf= f 0xff 0x00 0xff 0xff 0xff>; - qcom,ports-lane-control =3D /bits/ 8 <0x01 0x00 0x00 0x00 0x00 0xff 0xf= f 0x01 0xff 0xff 0xff>; + qcom,ports-sinterval =3D /bits/ 16 <0x03 0x1f 0x1f 0x07 0x03 0xff 0xff= 0x31 0xff 0xff 0xff 0xff>; + qcom,ports-offset1 =3D /bits/ 8 <0x00 0x00 0x0b 0x09 0x01 0xff 0xff 0x= 00 0xff 0xff 0xff 0xff>; + qcom,ports-offset2 =3D /bits/ 8 <0x00 0x00 0x0b 0x00 0x00 0xff 0xff 0x= 00 0xff 0xff 0xff 0xff>; + qcom,ports-hstart =3D /bits/ 8 <0xff 0x03 0xff 0xff 0xff 0xff 0xff 0x0= 0 0xff 0xff 0xff 0xff>; + qcom,ports-hstop =3D /bits/ 8 <0xff 0x06 0xff 0xff 0xff 0xff 0xff 0x0f= 0xff 0xff 0xff 0xff>; + qcom,ports-word-length =3D /bits/ 8 <0x01 0x07 0x04 0xff 0xff 0xff 0xff= 0x18 0xff 0xff 0xff 0xff>; + qcom,ports-block-pack-mode =3D /bits/ 8 <0xff 0x00 0x01 0xff 0xff 0xff = 0xff 0x01 0xff 0xff 0xff 0xff>; + qcom,ports-block-group-count =3D /bits/ 8 <0xff 0xff 0xff 0x01 0x03 0xf= f 0xff 0x00 0xff 0xff 0xff 0xff>; + qcom,ports-lane-control =3D /bits/ 8 <0x01 0x00 0x00 0x00 0x00 0xff 0xf= f 0x01 0xff 0xff 0xff 0xff>; =20 #address-cells =3D <2>; #size-cells =3D <0>; @@ -4827,17 +4827,17 @@ swr2: soundwire@6d30000 { pinctrl-names =3D "default"; =20 qcom,din-ports =3D <4>; - qcom,dout-ports =3D <0>; - - qcom,ports-sinterval-low =3D /bits/ 8 <0x01 0x01 0x03 0x03>; - qcom,ports-offset1 =3D /bits/ 8 <0x00 0x00 0x01 0x01>; - qcom,ports-offset2 =3D /bits/ 8 <0x00 0x00 0x00 0x00>; - qcom,ports-hstart =3D /bits/ 8 <0xff 0xff 0xff 0xff>; - qcom,ports-hstop =3D /bits/ 8 <0xff 0xff 0xff 0xff>; - qcom,ports-word-length =3D /bits/ 8 <0xff 0xff 0xff 0xff>; - qcom,ports-block-pack-mode =3D /bits/ 8 <0xff 0xff 0xff 0xff>; - qcom,ports-block-group-count =3D /bits/ 8 <0xff 0xff 0xff 0xff>; - qcom,ports-lane-control =3D /bits/ 8 <0x01 0x02 0x00 0x00>; + qcom,dout-ports =3D <1>; + + qcom,ports-sinterval-low =3D /bits/ 8 <0x00 0x01 0x01 0x03 0x03>; + qcom,ports-offset1 =3D /bits/ 8 <0x00 0x00 0x00 0x01 0x01>; + qcom,ports-offset2 =3D /bits/ 8 <0x00 0x00 0x00 0x00 0x00>; + qcom,ports-hstart =3D /bits/ 8 <0xff 0xff 0xff 0xff 0xff>; + qcom,ports-hstop =3D /bits/ 8 <0xff 0xff 0xff 0xff 0xff>; + qcom,ports-word-length =3D /bits/ 8 <0xff 0xff 0xff 0xff 0xff>; + qcom,ports-block-pack-mode =3D /bits/ 8 <0xff 0xff 0xff 0xff 0xff>; + qcom,ports-block-group-count =3D /bits/ 8 <0xff 0xff 0xff 0xff 0xff>; + qcom,ports-lane-control =3D /bits/ 8 <0xff 0x01 0x02 0x00 0x00>; =20 #address-cells =3D <2>; #size-cells =3D <0>; --=20 2.34.1