From nobody Tue Jun 16 11:20:35 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9790F27A904 for ; Sun, 19 Apr 2026 16:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776615428; cv=none; b=kOWVDGz69BrGp3RKP0TcRKM2M343Vyt6aMAcxe4DTmF7w3i2RXeb12qCXryuizPB3GHBiYno5LfBx1xJVX1/ZEF0OsKPsOF70fxvHb8A8NT30FUj7suBBvclGQwaaMbK5hueT0Eo9W7MDhiH657Sbb0yDY4GhnF8JA2YDBOMRMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776615428; c=relaxed/simple; bh=jZNKZAn2YKXtjGCWMeOBt/AhxqBUbKDDEP7I8udltl4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=l288iRfWvwbGeC97m8UpWnajfeGbBOPdkkjHXRIf9lvpTyae3JZgypBGFKs/1Q4ekHnpPfR3ZHnoWBnOzUOmsqos6BNrWXah2yS1b4xNh3wV4fk4f2qfJK2c9PvTIs5hOK7QTixmIUWCUAJa6muKh4F3QI72CDkQdBhfElZznWI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NOHJJidJ; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NOHJJidJ" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c79506f3c40so724898a12.1 for ; Sun, 19 Apr 2026 09:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776615424; x=1777220224; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=utT2YYlbnBp4hh3H8H6bzqYhXolLpldEOILxjzBy/Zs=; b=NOHJJidJxaUCGJ05PShXeXxHt0nOiGz+prMHLLyc6DEmrP+2rsEYaxkdnLWrWXKB3l z4TWsKV56vEAxWKKl8BXDrAuM/CFMBOFXH2NUz9QwDvnoH0N5mUARr6HmS/XxuAAmEek F53XBXLteGPv9I3784po2G22kDVYgJrt38eVKsYATG2gt2pNO/nB6R35jbTtiTXeVxBB /0I9biOt/wNFTK1LJ8/ypl6LQRg5sgA5Z69J17ehZo3kBT2f4enVx9ksBIQ0bSykhmYt vxRGPGaiArCab7SO84E3jWAx+4kedssuAHwfULK2VuzoEUO/ivapBhhNrwVR3orH1pqb 4xCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776615424; x=1777220224; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=utT2YYlbnBp4hh3H8H6bzqYhXolLpldEOILxjzBy/Zs=; b=iuFj7SaFgyb37urBkgyj/ZZNV8ur8XVEmqXAr4yEyoJOtW3EGhFkX/ST56uZFgH3Cy EUOGpjdKFP1aAuq3zrc4dbcaHDuPR44Fw9mbIQE7PqtMHfsImGXyBiBhUcFf1P7DUhL+ k554963k+DiicH02U9EekACI1myBQdIhu7LoVWuQLcrAJI7nXDL8JMgTbNfVOzG3RCJ6 LtG/hkcL5TEp0+8g8lpnkcGZ1VuJvRV7HvaR7r8UfiXblKgdgaCzn+7vxEc1DhiL8UPJ ZnRzb2RIx35+7BW1qU8SO+/ZNcdyAh+ETwLDrcm2c2p2D2x6U5pQE8s2AzOCfHtpTg5u XRjQ== X-Forwarded-Encrypted: i=1; AFNElJ9q8eQG4EqbH3vNiZePWKG6zzYdJ6JnEm+dITG7r90RvG+H9njNKYrL3Hy8xaaJmXTHsnRHpmHyd0mciHs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5vdlZu0X8fVJFjoNZzwdrwAvEA/Iw+FMH+8eOxAZmkFU0guFb cf0zQ2Bzc4/mklpr3iQm29aDFnfpQAxAkaAxJeT9Xt8ktpGOptjKzLVA X-Gm-Gg: AeBDiev5FR3TYIWnrIarjNu55uxgUgXKmED7/o0miN1yMsv7L24y9RCn5phhuFk7lF/ Es02VKqxzedpaQeSsMA+Wn86MWRYF18MI9XKOtuIRt2JgLRWSSiKg/t4asZQwEqQMc9C5s3wTLU MH1f1AlkPbzJVjTrpU7r4OUjwMMprR94bTlfveric/565eZPIaWDe9/ALofS9afkCd/S3KdSoM0 MzZdkA3P3K6IGmjfHsVFcHtu5cX3Sm4Cz7f+4lMnXC0UiNrA1fBu/lDoBYRH6w0iGquva66RfsZ sbFHGHRRCB5FhVOg2QDK5itwI0S5l2wpMzOS1zJ9RzkUTiI7OJqtebOwfxWvC6a0j1NVGujzsoA od6ySG/w4l0DYrtWAkXNVrO2WM6QsWOd0g/79RAZ1WUo4IzjpUSmoRQmaTS5nfUzscE7rYmpyVc TbM17A7CXWUzi196EeokpiB0H9945i3GAW7r02Aub7sfFrt1YOgqMghE1cFPnG X-Received: by 2002:a17:90b:3c0f:b0:359:855f:ff96 with SMTP id 98e67ed59e1d1-3614048b2f5mr10150896a91.17.1776615423426; Sun, 19 Apr 2026 09:17:03 -0700 (PDT) Received: from yuma.tail3bb52.ts.net ([155.69.181.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36141869e88sm7506523a91.1.2026.04.19.09.17.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 09:17:02 -0700 (PDT) From: Yuma Ochi To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , Yuma Ochi Subject: [PATCH v3] staging: rtl8723bs: Remove boolean comparisons Date: Mon, 20 Apr 2026 00:16:36 +0800 Message-ID: <20260419161636.692366-1-ochiyuma.ochi@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unnecessary comparison to true/false in if statements to follow standard Linux kernel coding style. Signed-off-by: Yuma Ochi --- v3: add missing changelog below --- (Greg KH bot) v2: remove unnecessary parentheses (Dan Carpenter) --- drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 2 +- .../staging/rtl8723bs/core/rtw_ieee80211.c | 2 +- .../staging/rtl8723bs/core/rtw_ioctl_set.c | 50 ++++++------- drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 ++-- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 16 ++--- drivers/staging/rtl8723bs/core/rtw_recv.c | 70 +++++++++---------- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- .../staging/rtl8723bs/core/rtw_wlan_util.c | 18 ++--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 34 ++++----- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 +-- drivers/staging/rtl8723bs/hal/hal_com.c | 4 +- .../staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +- drivers/staging/rtl8723bs/hal/hal_intf.c | 4 +- drivers/staging/rtl8723bs/hal/odm.c | 4 +- .../staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +- drivers/staging/rtl8723bs/hal/odm_DIG.c | 24 +++---- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 10 +-- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 ++-- .../staging/rtl8723bs/hal/rtl8723bs_recv.c | 2 +- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 8 +-- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 48 ++++++------- .../staging/rtl8723bs/os_dep/sdio_ops_linux.c | 4 +- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +- 26 files changed, 176 insertions(+), 176 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8= 723bs/core/rtw_ap.c index 4b4012411011..eb4e0bbb2f97 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -301,7 +301,7 @@ void expire_timeout_chk(struct adapter *padapter) =20 psta->keep_alive_trycnt =3D 0; spin_lock_bh(&pstapriv->asoc_list_lock); - if (list_empty(&psta->asoc_list) =3D=3D false) { + if (!list_empty(&psta->asoc_list)) { list_del_init(&psta->asoc_list); pstapriv->asoc_list_cnt--; updated =3D ap_free_sta(padapter, psta, false, diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/= rtl8723bs/core/rtw_btcoex.c index 0191a943f0a4..831e5802f419 100644 --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c @@ -11,7 +11,7 @@ void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_statu= s) { if ((media_status =3D=3D RT_MEDIA_CONNECT) - && (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) =3D=3D true)) { + && check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE)) { rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL); } =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ieee80211.c index 72b7f731dd47..669151c08a3f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -347,7 +347,7 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv) =20 /* HT Cap. */ if ((pregistrypriv->wireless_mode & WIRELESS_11_24N) && - (pregistrypriv->ht_enable =3D=3D true)) { + pregistrypriv->ht_enable) { /* todo: */ } =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ioctl_set.c index c70541f95a73..8e7e8ee41af8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -80,7 +80,7 @@ u8 rtw_do_join(struct adapter *padapter) pmlmepriv->to_join =3D false; _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else { - if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { /* submit createbss_cmd to change to a ADHOC_MASTER */ =20 /* pmlmepriv->lock has been acquired by caller... */ @@ -139,32 +139,32 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, stru= ct ndis_802_11_ssid *ssid) netdev_dbg(padapter->pnetdev, "set ssid [%s] fw_state =3D 0x%08x\n", ssid->ssid, get_fwstate(pmlmepriv)); =20 - if (padapter->hw_init_completed =3D=3D false) { + if (!padapter->hw_init_completed) { status =3D _FAIL; goto exit; } =20 spin_lock_bh(&pmlmepriv->lock); =20 - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) goto handle_tkip_countermeasure; - else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) =3D=3D true) + else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) goto release_mlme_lock; =20 - if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) =3D=3D t= rue) { + if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE)) { if ((pmlmepriv->assoc_ssid.ssid_length =3D=3D ssid->ssid_length) && (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length)= )) { - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D false) { - if (rtw_is_same_ibss(padapter, pnetwork) =3D=3D false) { + if (!check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { + if (!rtw_is_same_ibss(padapter, pnetwork)) { /* if in WIFI_ADHOC_MASTER_STATE | WIFI_ADHOC_STATE, create bss or re= join again */ rtw_disassoc_cmd(padapter, 0, true); =20 - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_LINKED)) rtw_indicate_disconnect(padapter); =20 rtw_free_assoc_resources(padapter, 1); =20 - if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { _clr_fwstate_(pmlmepriv, WIFI_ADHOC_MASTER_STATE); set_fwstate(pmlmepriv, WIFI_ADHOC_STATE); } @@ -177,12 +177,12 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, stru= ct ndis_802_11_ssid *ssid) } else { rtw_disassoc_cmd(padapter, 0, true); =20 - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_LINKED)) rtw_indicate_disconnect(padapter); =20 rtw_free_assoc_resources(padapter, 1); =20 - if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { _clr_fwstate_(pmlmepriv, WIFI_ADHOC_MASTER_STATE); set_fwstate(pmlmepriv, WIFI_ADHOC_STATE); } @@ -195,7 +195,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct= ndis_802_11_ssid *ssid) goto release_mlme_lock; } =20 - if (rtw_validate_ssid(ssid) =3D=3D false) { + if (!rtw_validate_ssid(ssid)) { status =3D _FAIL; goto release_mlme_lock; } @@ -203,7 +203,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct= ndis_802_11_ssid *ssid) memcpy(&pmlmepriv->assoc_ssid, ssid, sizeof(struct ndis_802_11_ssid)); pmlmepriv->assoc_by_bssid =3D false; =20 - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) pmlmepriv->to_join =3D true; else status =3D rtw_do_join(padapter); @@ -223,10 +223,10 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u= 8 *bssid, struct ndis_802_1 bool ssid_valid =3D true; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 - if (!ssid || rtw_validate_ssid(ssid) =3D=3D false) + if (!ssid || !rtw_validate_ssid(ssid)) ssid_valid =3D false; =20 - if (!bssid || rtw_validate_bssid(bssid) =3D=3D false) + if (!bssid || !rtw_validate_bssid(bssid)) bssid_valid =3D false; =20 if (!ssid_valid && !bssid_valid) { @@ -234,7 +234,7 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u8 = *bssid, struct ndis_802_1 goto exit; } =20 - if (padapter->hw_init_completed =3D=3D false) { + if (!padapter->hw_init_completed) { status =3D _FAIL; goto exit; } @@ -244,9 +244,9 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u8 = *bssid, struct ndis_802_1 netdev_dbg(padapter->pnetdev, FUNC_ADPT_FMT " fw_state =3D 0x%08x\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv)); =20 - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) goto handle_tkip_countermeasure; - else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) =3D=3D true) + else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) goto release_mlme_lock; =20 handle_tkip_countermeasure: @@ -267,7 +267,7 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u8 = *bssid, struct ndis_802_1 pmlmepriv->assoc_by_bssid =3D false; } =20 - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) pmlmepriv->to_join =3D true; else status =3D rtw_do_join(padapter); @@ -296,15 +296,15 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter = *padapter, =20 spin_lock_bh(&pmlmepriv->lock); =20 - if ((check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) || (*pold_state = =3D=3D Ndis802_11IBSS)) + if (check_fwstate(pmlmepriv, _FW_LINKED) || (*pold_state =3D=3D Ndis802_= 11IBSS)) rtw_disassoc_cmd(padapter, 0, true); =20 - if ((check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) + if (check_fwstate(pmlmepriv, _FW_LINKED) || + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) rtw_free_assoc_resources(padapter, 1); =20 if ((*pold_state =3D=3D Ndis802_11Infrastructure) || (*pold_state =3D=3D= Ndis802_11IBSS)) { - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_LINKED)) rtw_indicate_disconnect(padapter); /* will clr Linked_state; before th= is function, we must have checked whether issue dis-assoc_cmd or not */ } =20 @@ -347,7 +347,7 @@ u8 rtw_set_802_11_disassociate(struct adapter *padapter) =20 spin_lock_bh(&pmlmepriv->lock); =20 - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) { + if (check_fwstate(pmlmepriv, _FW_LINKED)) { rtw_disassoc_cmd(padapter, 0, true); rtw_indicate_disconnect(padapter); /* modify for CONFIG_IEEE80211W, none 11w can use it */ @@ -369,7 +369,7 @@ u8 rtw_set_802_11_bssid_list_scan(struct adapter *padap= ter, struct ndis_802_11_s res =3D false; goto exit; } - if (padapter->hw_init_completed =3D=3D false) { + if (!padapter->hw_init_completed) { res =3D false; goto exit; } diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index ddfc56f0253d..c3457dc57851 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -351,7 +351,7 @@ int is_same_network(struct wlan_bssid_ex *src, struct w= lan_bssid_ex *dst, u8 fea u16 s_cap, d_cap; __le16 tmps, tmpd; =20 - if (rtw_bug_check(dst, src, &s_cap, &d_cap) =3D=3D false) + if (!rtw_bug_check(dst, src, &s_cap, &d_cap)) return false; =20 memcpy((u8 *)&tmps, rtw_get_capability_from_ie(src->ies), 2); @@ -1282,7 +1282,7 @@ void rtw_stassoc_event_callback(struct adapter *adapt= er, u8 *pbuf) struct wlan_network *cur_network =3D &pmlmepriv->cur_network; struct wlan_network *ptarget_wlan =3D NULL; =20 - if (rtw_access_ctrl(adapter, pstassoc->macaddr) =3D=3D false) + if (!rtw_access_ctrl(adapter, pstassoc->macaddr)) return; =20 if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { @@ -1566,7 +1566,7 @@ void rtw_mlme_reset_auto_scan_int(struct adapter *ada= pter) =20 if (pmlmeinfo->VHT_enable) /* disable auto scan when connect to 11AC AP */ mlme->auto_scan_int_ms =3D 0; - else if (adapter->registrypriv.wifi_spec && is_client_associated_to_ap(ad= apter) =3D=3D true) + else if (adapter->registrypriv.wifi_spec && is_client_associated_to_ap(ad= apter)) mlme->auto_scan_int_ms =3D 60 * 1000; else if (rtw_chk_roam_flags(adapter, RTW_ROAM_ACTIVE)) { if (check_fwstate(mlme, WIFI_STATION_STATE) && check_fwstate(mlme, _FW_L= INKED)) @@ -1668,10 +1668,10 @@ static int rtw_check_roaming_candidate(struct mlme_= priv *mlme int updated =3D false; struct adapter *adapter =3D container_of(mlme, struct adapter, mlmepriv); =20 - if (is_same_ess(&competitor->network, &mlme->cur_network.network) =3D=3D = false) + if (!is_same_ess(&competitor->network, &mlme->cur_network.network)) goto exit; =20 - if (rtw_is_desired_network(adapter, competitor) =3D=3D false) + if (!rtw_is_desired_network(adapter, competitor)) goto exit; =20 /* got specific addr to roam */ @@ -1763,12 +1763,12 @@ static int rtw_check_join_candidate(struct mlme_pri= v *mlme goto exit; } =20 - if (rtw_is_desired_network(adapter, competitor) =3D=3D false) + if (!rtw_is_desired_network(adapter, competitor)) goto exit; =20 if (rtw_to_roam(adapter) > 0) { if (jiffies_to_msecs(jiffies - competitor->last_scanned) >=3D mlme->roam= _scanr_exp_ms - || is_same_ess(&competitor->network, &mlme->cur_network.network) =3D=3D= false + || !is_same_ess(&competitor->network, &mlme->cur_network.network) ) goto exit; } diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 5f00fe282d1b..4821abfae98e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -512,8 +512,8 @@ unsigned int OnProbeReq(struct adapter *padapter, union= recv_frame *precv_frame) if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) return _SUCCESS; =20 - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D false && - check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE|WIFI_AP_STATE) =3D=3D f= alse) { + if (!check_fwstate(pmlmepriv, _FW_LINKED) && + !check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE|WIFI_AP_STATE)) { return _SUCCESS; } =20 @@ -725,7 +725,7 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) goto auth_fail; } =20 - if (rtw_access_ctrl(padapter, sa) =3D=3D false) { + if (!rtw_access_ctrl(padapter, sa)) { status =3D WLAN_STATUS_AP_UNABLE_TO_HANDLE_NEW_STA; goto auth_fail; } @@ -748,7 +748,7 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) } else { =20 spin_lock_bh(&pstapriv->asoc_list_lock); - if (list_empty(&pstat->asoc_list) =3D=3D false) { + if (!list_empty(&pstat->asoc_list)) { list_del_init(&pstat->asoc_list); pstapriv->asoc_list_cnt--; if (pstat->expire_to > 0) { @@ -1239,7 +1239,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) pstat->flags &=3D ~WLAN_STA_HT; =20 =20 - if ((pmlmepriv->htpriv.ht_option =3D=3D false) && (pstat->flags&WLAN_STA_= HT)) { + if (!pmlmepriv->htpriv.ht_option && (pstat->flags&WLAN_STA_HT)) { status =3D WLAN_STATUS_CHALLENGE_FAIL; goto OnAssocReqFail; } @@ -1474,7 +1474,7 @@ unsigned int OnDeAuth(struct adapter *padapter, union= recv_frame *precv_frame) u8 updated =3D false; =20 spin_lock_bh(&pstapriv->asoc_list_lock); - if (list_empty(&psta->asoc_list) =3D=3D false) { + if (!list_empty(&psta->asoc_list)) { list_del_init(&psta->asoc_list); pstapriv->asoc_list_cnt--; updated =3D ap_free_sta(padapter, psta, false, reason); @@ -1546,7 +1546,7 @@ unsigned int OnDisassoc(struct adapter *padapter, uni= on recv_frame *precv_frame) u8 updated =3D false; =20 spin_lock_bh(&pstapriv->asoc_list_lock); - if (list_empty(&psta->asoc_list) =3D=3D false) { + if (!list_empty(&psta->asoc_list)) { list_del_init(&psta->asoc_list); pstapriv->asoc_list_cnt--; updated =3D ap_free_sta(padapter, psta, false, reason); @@ -4973,7 +4973,7 @@ void linked_status_chk(struct adapter *padapter) /* todo: To check why we under miracast session, rx_chk would be false = */ psta =3D rtw_get_stainfo(pstapriv, pmlmeinfo->network.mac_address); if (psta) { - if (chk_ap_is_alive(padapter, psta) =3D=3D false) + if (!chk_ap_is_alive(padapter, psta)) rx_chk =3D _FAIL; =20 if (pxmitpriv->last_tx_pkts =3D=3D pxmitpriv->tx_pkts) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index f78194d508df..52216b0326e4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -382,7 +382,7 @@ static signed int recvframe_chkmic(struct adapter *adap= ter, union recv_frame *p =20 /* psecuritypriv->dot118021XGrpKeyid, pmlmeinfo->key_index, rxdata_key= _idx); */ =20 - if (psecuritypriv->binstallGrpkey =3D=3D false) { + if (!psecuritypriv->binstallGrpkey) { res =3D _FAIL; goto exit; } @@ -406,10 +406,10 @@ static signed int recvframe_chkmic(struct adapter *ad= apter, union recv_frame *p } =20 =20 - if (bmic_err =3D=3D true) { + if (bmic_err) { /* double check key_index for some timing issue , */ /* cannot compare with psecuritypriv->dot118021XGrpKeyid also cause t= iming issue */ - if ((is_multicast_ether_addr(prxattrib->ra) =3D=3D true) && (prxattri= b->key_index !=3D pmlmeinfo->key_index)) + if (is_multicast_ether_addr(prxattrib->ra) && (prxattrib->key_index != =3D pmlmeinfo->key_index)) brpt_micerror =3D false; =20 if (prxattrib->bdecrypted && brpt_micerror) @@ -463,7 +463,7 @@ static union recv_frame *decryptor(struct adapter *pada= pter, union recv_frame *p } } =20 - if ((prxattrib->encrypt > 0) && ((prxattrib->bdecrypted =3D=3D 0) || (pse= curitypriv->sw_decrypt =3D=3D true))) { + if ((prxattrib->encrypt > 0) && ((prxattrib->bdecrypted =3D=3D 0) || (pse= curitypriv->sw_decrypt))) { psecuritypriv->hw_decrypted =3D false; =20 switch (prxattrib->encrypt) { @@ -713,8 +713,8 @@ static signed int sta2sta_data_frame(struct adapter *ad= apter, union recv_frame * u8 *sta_addr =3D NULL; signed int bmcast =3D is_multicast_ether_addr(pattrib->dst); =20 - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) || + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { =20 /* filter packets that SA is myself or multicast or broadcast */ if (!memcmp(myhwaddr, pattrib->src, ETH_ALEN)) { @@ -736,7 +736,7 @@ static signed int sta2sta_data_frame(struct adapter *ad= apter, union recv_frame * =20 sta_addr =3D pattrib->src; =20 - } else if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { /* For Station mode, sa and bssid should always be BSSID, and DA is my = mac-address */ if (memcmp(pattrib->bssid, pattrib->src, ETH_ALEN)) { ret =3D _FAIL; @@ -744,7 +744,7 @@ static signed int sta2sta_data_frame(struct adapter *ad= apter, union recv_frame * } =20 sta_addr =3D pattrib->bssid; - } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { if (bmcast) { /* For AP mode, if DA =3D=3D MCAST, then BSSID should be also MCAST */ if (!is_multicast_ether_addr(pattrib->bssid)) { @@ -761,7 +761,7 @@ static signed int sta2sta_data_frame(struct adapter *ad= apter, union recv_frame * sta_addr =3D pattrib->src; } =20 - } else if (check_fwstate(pmlmepriv, WIFI_MP_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_MP_STATE)) { memcpy(pattrib->dst, GetAddr1Ptr(ptr), ETH_ALEN); memcpy(pattrib->src, GetAddr2Ptr(ptr), ETH_ALEN); memcpy(pattrib->bssid, GetAddr3Ptr(ptr), ETH_ALEN); @@ -800,9 +800,9 @@ static signed int ap2sta_data_frame(struct adapter *ada= pter, union recv_frame *p u8 *myhwaddr =3D myid(&adapter->eeprompriv); signed int bmcast =3D is_multicast_ether_addr(pattrib->dst); =20 - if ((check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) && - (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true || - check_fwstate(pmlmepriv, _FW_UNDER_LINKING) =3D=3D true) + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) && + (check_fwstate(pmlmepriv, _FW_LINKED) || + check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) ) { =20 /* filter packets that SA is myself or multicast or broadcast */ @@ -847,8 +847,8 @@ static signed int ap2sta_data_frame(struct adapter *ada= pter, union recv_frame *p goto exit; } =20 - } else if ((check_fwstate(pmlmepriv, WIFI_MP_STATE) =3D=3D true) && - (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true)) { + } else if (check_fwstate(pmlmepriv, WIFI_MP_STATE) && + check_fwstate(pmlmepriv, _FW_LINKED)) { memcpy(pattrib->dst, GetAddr1Ptr(ptr), ETH_ALEN); memcpy(pattrib->src, GetAddr2Ptr(ptr), ETH_ALEN); memcpy(pattrib->bssid, GetAddr3Ptr(ptr), ETH_ALEN); @@ -866,7 +866,7 @@ static signed int ap2sta_data_frame(struct adapter *ada= pter, union recv_frame *p } =20 =20 - } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* Special case */ ret =3D RTW_RX_HANDLED; goto exit; @@ -903,7 +903,7 @@ static signed int sta2ap_data_frame(struct adapter *ada= pter, union recv_frame *p unsigned char *mybssid =3D get_bssid(pmlmepriv); signed int ret =3D _SUCCESS; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* For AP mode, RA =3DBSSID, TX =3DSTA(SRC_ADDR), A3 =3DDST_ADDR */ if (memcmp(pattrib->bssid, mybssid, ETH_ALEN)) { ret =3D _FAIL; @@ -1413,7 +1413,7 @@ static signed int validate_80211w_mgmt(struct adapter= *adapter, union recv_frame =20 /* only support station mode */ if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) && check_fwstate(pmlmepr= iv, _FW_LINKED) && - adapter->securitypriv.binstallBIPkey =3D=3D true) { + adapter->securitypriv.binstallBIPkey) { /* unicast management frame decrypt */ if (pattrib->privacy && !(is_multicast_ether_addr(GetAddr1Ptr(ptr))) && (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || subtype = =3D=3D WIFI_ACTION)) { @@ -1597,7 +1597,7 @@ static signed int wlanhdr_to_ethhdr(union recv_frame = *precvframe) eth_type =3D ntohs(be_tmp); /* pattrib->ether_type */ pattrib->eth_type =3D eth_type; =20 - if ((check_fwstate(pmlmepriv, WIFI_MP_STATE) =3D=3D true)) { + if (check_fwstate(pmlmepriv, WIFI_MP_STATE)) { ptr +=3D rmv_len; *ptr =3D 0x87; *(ptr + 1) =3D 0x12; @@ -1672,7 +1672,7 @@ static void rtw_recv_indicate_pkt(struct adapter *pad= apter, struct sk_buff *pkt, =20 /* Indicate the packets to upper layer */ if (pkt) { - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { struct sk_buff *pskb2 =3D NULL; struct sta_info *psta =3D NULL; struct sta_priv *pstapriv =3D &padapter->stapriv; @@ -1915,7 +1915,7 @@ static int recv_indicatepkts_in_order(struct adapter = *padapter, struct recv_reor plist =3D get_next(phead); =20 /* Handling some condition for forced indicate case. */ - if (bforced =3D=3D true) { + if (bforced) { if (list_empty(phead)) { /* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */ /* spin_unlock(&ppending_recvframe_queue->lock); */ @@ -1950,8 +1950,8 @@ static int recv_indicatepkts_in_order(struct adapter = *padapter, struct recv_reor =20 /* indicate this recv_frame */ if (!pattrib->amsdu) { - if ((padapter->bDriverStopped =3D=3D false) && - (padapter->bSurpriseRemoved =3D=3D false)) + if (!padapter->bDriverStopped && + !padapter->bSurpriseRemoved) rtw_recv_indicatepkt(padapter, prframe);/* indicate this recv_frame */ =20 } else if (pattrib->amsdu =3D=3D 1) { @@ -1991,8 +1991,8 @@ static int recv_indicatepkt_reorder(struct adapter *p= adapter, union recv_frame * wlanhdr_to_ethhdr(prframe); =20 if (pattrib->qos !=3D 1) { - if ((padapter->bDriverStopped =3D=3D false) && - (padapter->bSurpriseRemoved =3D=3D false)) { + if (!padapter->bDriverStopped && + !padapter->bSurpriseRemoved) { rtw_recv_indicatepkt(padapter, prframe); return _SUCCESS; =20 @@ -2002,7 +2002,7 @@ static int recv_indicatepkt_reorder(struct adapter *p= adapter, union recv_frame * =20 } =20 - if (preorder_ctrl->enable =3D=3D false) { + if (!preorder_ctrl->enable) { /* indicate this recv_frame */ preorder_ctrl->indicate_seq =3D pattrib->seq_num; =20 @@ -2013,7 +2013,7 @@ static int recv_indicatepkt_reorder(struct adapter *p= adapter, union recv_frame * return _SUCCESS; } } else if (pattrib->amsdu =3D=3D 1) { /* temp filter -> means didn't supp= ort A-MSDUs in a A-MPDU */ - if (preorder_ctrl->enable =3D=3D false) { + if (!preorder_ctrl->enable) { preorder_ctrl->indicate_seq =3D pattrib->seq_num; =20 retval =3D amsdu_to_msdu(padapter, prframe); @@ -2049,7 +2049,7 @@ static int recv_indicatepkt_reorder(struct adapter *p= adapter, union recv_frame * /* */ =20 /* recv_indicatepkts_in_order(padapter, preorder_ctrl, true); */ - if (recv_indicatepkts_in_order(padapter, preorder_ctrl, false) =3D=3D tru= e) { + if (recv_indicatepkts_in_order(padapter, preorder_ctrl, false)) { _set_timer(&preorder_ctrl->reordering_ctrl_timer, REORDER_WAIT_TIME); spin_unlock_bh(&ppending_recvframe_queue->lock); } else { @@ -2079,7 +2079,7 @@ void rtw_reordering_ctrl_timeout_handler(struct timer= _list *t) =20 spin_lock_bh(&ppending_recvframe_queue->lock); =20 - if (recv_indicatepkts_in_order(padapter, preorder_ctrl, true) =3D=3D true) + if (recv_indicatepkts_in_order(padapter, preorder_ctrl, true)) _set_timer(&preorder_ctrl->reordering_ctrl_timer, REORDER_WAIT_TIME); =20 spin_unlock_bh(&ppending_recvframe_queue->lock); @@ -2094,13 +2094,13 @@ static int process_recv_indicatepkts(struct adapter= *padapter, union recv_frame struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; =20 - if (phtpriv->ht_option =3D=3D true) { /* B/G/N Mode */ + if (phtpriv->ht_option) { /* B/G/N Mode */ /* prframe->u.hdr.preorder_ctrl =3D &precvpriv->recvreorder_ctrl[pattrib= ->priority]; */ =20 if (recv_indicatepkt_reorder(padapter, prframe) !=3D _SUCCESS) { /* inc= luding perform A-MPDU Rx Ordering Buffer Control */ =20 - if ((padapter->bDriverStopped =3D=3D false) && - (padapter->bSurpriseRemoved =3D=3D false)) { + if (!padapter->bDriverStopped && + !padapter->bSurpriseRemoved) { retval =3D _FAIL; return retval; } @@ -2110,7 +2110,7 @@ static int process_recv_indicatepkts(struct adapter *= padapter, union recv_frame if (retval !=3D _SUCCESS) return retval; =20 - if ((padapter->bDriverStopped =3D=3D false) && (padapter->bSurpriseRemov= ed =3D=3D false)) { + if (!padapter->bDriverStopped && !padapter->bSurpriseRemoved) { /* indicate this recv_frame */ rtw_recv_indicatepkt(padapter, prframe); } else { @@ -2199,7 +2199,7 @@ static int recv_func(struct adapter *padapter, union = recv_frame *rframe) /* check if need to enqueue into uc_swdec_pending_queue*/ if (check_fwstate(mlmepriv, WIFI_STATION_STATE) && !is_multicast_ether_addr(prxattrib->ra) && prxattrib->encrypt > 0 && - (prxattrib->bdecrypted =3D=3D 0 || psecuritypriv->sw_decrypt =3D=3D tru= e) && + (prxattrib->bdecrypted =3D=3D 0 || psecuritypriv->sw_decrypt) && psecuritypriv->ndisauthtype =3D=3D Ndis802_11AuthModeWPAPSK && !psecuritypriv->busetkipkey) { rtw_enqueue_recvframe(rframe, &padapter->recvpriv.uc_swdec_pending_queu= e); @@ -2286,8 +2286,8 @@ static void rtw_signal_stat_timer_hdl(struct timer_li= st *t) } } =20 - if (check_fwstate(&adapter->mlmepriv, _FW_UNDER_SURVEY) =3D=3D true || - check_fwstate(&adapter->mlmepriv, _FW_LINKED) =3D=3D false + if (check_fwstate(&adapter->mlmepriv, _FW_UNDER_SURVEY) || + !check_fwstate(&adapter->mlmepriv, _FW_LINKED) ) { goto set_timer; } diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging= /rtl8723bs/core/rtw_sta_mgt.c index 07a6db1d2317..349b27f91033 100644 --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c @@ -531,7 +531,7 @@ u8 rtw_access_ctrl(struct adapter *padapter, u8 *mac_ad= dr) paclnode =3D list_entry(plist, struct rtw_wlan_acl_node, list); =20 if (!memcmp(paclnode->addr, mac_addr, ETH_ALEN)) - if (paclnode->valid =3D=3D true) { + if (paclnode->valid) { match =3D true; break; } diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 6a7c09db4cd9..221d03b6a832 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -147,7 +147,7 @@ unsigned int ratetbl2rateset(struct adapter *padapter, = unsigned char *rateset) default: rate =3D ratetbl_val_2wifirate(rate); =20 - if (is_basicrate(padapter, rate) =3D=3D true) + if (is_basicrate(padapter, rate)) rate |=3D IEEE80211_BASIC_RATE_MASK; =20 rateset[len] =3D rate; @@ -236,7 +236,7 @@ void Restore_DM_Func_Flag(struct adapter *padapter) =20 void Switch_DM_Func(struct adapter *padapter, u32 mode, u8 enable) { - if (enable =3D=3D true) + if (enable) rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_SET, (u8 *)(&mode)); else rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_CLR, (u8 *)(&mode)); @@ -847,7 +847,7 @@ static void bwmode_update_check(struct adapter *padapte= r, struct ndis_80211_var_ if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (!phtpriv->ht_option) return; =20 if (pIE->length > sizeof(struct HT_info_element)) @@ -931,7 +931,7 @@ void HT_caps_handler(struct adapter *padapter, struct n= dis_80211_var_ie *pIE) if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (!phtpriv->ht_option) return; =20 pmlmeinfo->HT_caps_enable =3D 1; @@ -994,7 +994,7 @@ void HT_info_handler(struct adapter *padapter, struct n= dis_80211_var_ie *pIE) if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (!phtpriv->ht_option) return; =20 if (pIE->length > sizeof(struct HT_info_element)) @@ -1122,7 +1122,7 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *p= frame, u32 packet_len) struct mlme_priv *pmlmepriv =3D &Adapter->mlmepriv; int ssid_len; =20 - if (is_client_associated_to_ap(Adapter) =3D=3D false) + if (!is_client_associated_to_ap(Adapter)) return true; =20 len =3D packet_len - sizeof(struct ieee80211_hdr_3addr); @@ -1689,7 +1689,7 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmeex= t, u8 *pframe, uint len) pmlmeext->bcn_delay_cnt[delay_ms]++; /* pmlmeext->bcn_delay_ratio[delay_ms] =3D (pmlmeext->bcn_delay_cnt[dela= y_ms] * 100) /pmlmeext->bcn_cnt; */ /* dump for adaptive_early_32k */ - if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done =3D=3D true))= { + if (pmlmeext->bcn_cnt > 100 && pmlmeext->adaptive_tsf_done) { u8 ratio_20_delay, ratio_80_delay; u8 DrvBcnEarly, DrvBcnTimeOut; =20 @@ -1737,7 +1737,7 @@ void rtw_alloc_macid(struct adapter *padapter, struct= sta_info *psta) =20 spin_lock_bh(&pdvobj->lock); for (i =3D 0; i < NUM_STA; i++) { - if (pdvobj->macid[i] =3D=3D false) { + if (!pdvobj->macid[i]) { pdvobj->macid[i] =3D true; break; } @@ -1762,7 +1762,7 @@ void rtw_release_macid(struct adapter *padapter, stru= ct sta_info *psta) =20 spin_lock_bh(&pdvobj->lock); if (psta->mac_id < NUM_STA && psta->mac_id !=3D 1) { - if (pdvobj->macid[psta->mac_id] =3D=3D true) { + if (pdvobj->macid[psta->mac_id]) { pdvobj->macid[psta->mac_id] =3D false; psta->mac_id =3D NUM_STA; } diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 7bce0343d59f..97d79dc125a0 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -386,7 +386,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * } else { while (true) { /* IOT action */ - if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && (pattrib= ->ampdu_en =3D=3D true) && + if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && pattrib-= >ampdu_en && (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_)) { pattrib->vcs_mode =3D CTS_TO_SELF; break; @@ -422,7 +422,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * /* to do list: check MIMO power save condition. */ =20 /* check AMPDU aggregation for TXOP */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -484,10 +484,10 @@ static s32 update_attrib_sec_info(struct adapter *pad= apter, struct pkt_attrib *p memset(pattrib->dot11tkiptxmickey.skey, 0, 16); pattrib->mac_id =3D psta->mac_id; =20 - if (psta->ieee8021x_blocked =3D=3D true) { + if (psta->ieee8021x_blocked) { pattrib->encrypt =3D 0; =20 - if ((pattrib->ether_type !=3D 0x888e) && (check_fwstate(pmlmepriv, WIFI_= MP_STATE) =3D=3D false)) { + if ((pattrib->ether_type !=3D 0x888e) && (!check_fwstate(pmlmepriv, WIFI= _MP_STATE))) { res =3D _FAIL; goto exit; } @@ -652,8 +652,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p memcpy(pattrib->dst, ðerhdr.h_dest, ETH_ALEN); memcpy(pattrib->src, ðerhdr.h_source, ETH_ALEN); =20 - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { memcpy(pattrib->ra, pattrib->dst, ETH_ALEN); memcpy(pattrib->ta, pattrib->src, ETH_ALEN); } else if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { @@ -719,7 +719,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (!psta) { /* if we cannot get psta =3D> drop the pkt */ res =3D _FAIL; goto exit; - } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) && (!(p= sta->state & _FW_LINKED))) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) && !(psta->state & _F= W_LINKED)) { res =3D _FAIL; goto exit; } @@ -901,7 +901,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr SetFrameSubType(fctrl, pattrib->subtype); =20 if (pattrib->subtype & WIFI_DATA_TYPE) { - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { /* to_ds =3D 1, fr_ds =3D 0; */ =20 { @@ -915,7 +915,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pqospriv->qos_option) qos_option =3D true; - } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* to_ds =3D 0, fr_ds =3D 1; */ SetFrDs(fctrl); memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); @@ -924,8 +924,8 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pattrib->qos_en) qos_option =3D true; - } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + } else if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); memcpy(pwlanhdr->addr2, pattrib->src, ETH_ALEN); memcpy(pwlanhdr->addr3, get_bssid(pmlmepriv), ETH_ALEN); @@ -983,7 +983,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr pattrib->ampdu_en =3D true; =20 /* re-check if enable ampdu by BA_starting_seqctrl */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { u16 tx_seq; =20 tx_seq =3D psta->BA_starting_seqctrl[pattrib->priority & 0x0f]; @@ -1140,7 +1140,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 frg_inx++; =20 - if (bmcst || (rtw_endofpktfile(&pktfile) =3D=3D true)) { + if (bmcst || rtw_endofpktfile(&pktfile)) { pattrib->nr_frags =3D frg_inx; =20 pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + @@ -1166,7 +1166,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 xmitframe_swencrypt(padapter, pxmitframe); =20 - if (bmcst =3D=3D false) + if (!bmcst) update_attrib_vcs_info(padapter, pxmitframe); else pattrib->vcs_mode =3D NONE_VCS; @@ -2003,14 +2003,14 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_bu= ff **ppkt) do_queue_select(padapter, &pxmitframe->attrib); =20 spin_lock_bh(&pxmitpriv->lock); - if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe) =3D=3D true)= { + if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe)) { spin_unlock_bh(&pxmitpriv->lock); return 1; } spin_unlock_bh(&pxmitpriv->lock); =20 /* pre_xmitframe */ - if (rtw_hal_xmit(padapter, pxmitframe) =3D=3D false) + if (!rtw_hal_xmit(padapter, pxmitframe)) return 1; =20 return 0; @@ -2054,7 +2054,7 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x signed int bmcst =3D is_multicast_ether_addr(pattrib->ra); bool update_tim =3D false; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D false) + if (!check_fwstate(pmlmepriv, WIFI_AP_STATE)) return ret; psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/r= tl8723bs/hal/hal_btcoex.c index 2a2dd60be8bb..3974fa0e38b0 100644 --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c @@ -164,8 +164,8 @@ static u8 halbtcoutsrc_IsWifiBusy(struct adapter *padap= ter) =20 pmlmepriv =3D &padapter->mlmepriv; =20 - if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE) =3D=3D true) { - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) + if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE)) { + if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) return true; if (pmlmepriv->link_detect_info.busy_traffic) return true; @@ -185,8 +185,8 @@ static u32 _halbtcoutsrc_GetWifiLinkStatus(struct adapt= er *padapter) bp2p =3D false; portConnectedStatus =3D 0; =20 - if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE) =3D=3D true) { - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE)) { + if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { if (bp2p) portConnectedStatus |=3D WIFI_P2P_GO_CONNECTED; else @@ -528,7 +528,7 @@ static u8 halbtcoutsrc_Set(void *pBtcContext, u8 setTyp= e, void *pInBuf) case BTC_SET_ACT_UPDATE_RAMASK: pBtCoexist->btInfo.raMask =3D *pU4Tmp; =20 - if (check_fwstate(&padapter->mlmepriv, WIFI_ASOC_STATE) =3D=3D true) { + if (check_fwstate(&padapter->mlmepriv, WIFI_ASOC_STATE)) { struct sta_info *psta; struct wlan_bssid_ex *cur_network; =20 diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 728a2171fbcb..48b35e0945e9 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -136,7 +136,7 @@ bool HAL_IsLegalChannel(struct adapter *adapter, u32 Ch= annel) bool bLegalChannel =3D true; =20 if ((Channel <=3D 14) && (Channel >=3D 1)) { - if (is_supported_24g(adapter->registrypriv.wireless_mode) =3D=3D false) + if (!is_supported_24g(adapter->registrypriv.wireless_mode)) bLegalChannel =3D false; } else { bLegalChannel =3D false; @@ -605,7 +605,7 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 = *val) odm->SupportAbility =3D *((u32 *)val); break; case HW_VAR_DM_FUNC_OP: - if (*((u8 *)val) =3D=3D true) { + if (*((u8 *)val)) { /* save dm flag */ odm->BK_SupportAbility =3D odm->SupportAbility; } else { diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index bdd595a99b98..d6e9c6f9e300 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -461,7 +461,7 @@ u8 PHY_GetTxPowerIndexBase( u8 txPower =3D 0; u8 chnlIdx =3D (Channel-1); =20 - if (HAL_IsLegalChannel(padapter, Channel) =3D=3D false) + if (!HAL_IsLegalChannel(padapter, Channel)) chnlIdx =3D 0; =20 if (IS_CCK_RATE(Rate)) @@ -490,7 +490,7 @@ s8 PHY_GetTxPowerTrackingOffset(struct adapter *padapte= r, u8 RFPath, u8 Rate) struct dm_odm_t *pDM_Odm =3D &pHalData->odmpriv; s8 offset =3D 0; =20 - if (pDM_Odm->RFCalibrateInfo.TxPowerTrackControl =3D=3D false) + if (!pDM_Odm->RFCalibrateInfo.TxPowerTrackControl) return offset; =20 if ((Rate =3D=3D MGN_1M) || (Rate =3D=3D MGN_2M) || (Rate =3D=3D MGN_5_5M= ) || (Rate =3D=3D MGN_11M)) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 27c0c0198714..9cae6462c705 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -160,7 +160,7 @@ s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct = xmit_frame *pmgntframe) /* pwlanhdr =3D (struct rtw_ieee80211_hdr *)pframe; */ /* memcpy(pmgntframe->attrib.ra, pwlanhdr->addr1, ETH_ALEN); */ =20 - if (padapter->securitypriv.binstallBIPkey =3D=3D true) { + if (padapter->securitypriv.binstallBIPkey) { if (is_multicast_ether_addr(pmgntframe->attrib.ra)) { pmgntframe->attrib.encrypt =3D _BIP_; /* pmgntframe->attrib.bswenc =3D true; */ @@ -206,7 +206,7 @@ void rtw_hal_update_ra_mask(struct sta_info *psta, u8 r= ssi_level) =20 pmlmepriv =3D &(padapter->mlmepriv); =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) + if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) add_ratid(padapter, psta, rssi_level); else { UpdateHalRAMask8723B(padapter, psta->mac_id, rssi_level); diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723b= s/hal/odm.c index 3dffa7620768..85f851829d2c 100644 --- a/drivers/staging/rtl8723bs/hal/odm.c +++ b/drivers/staging/rtl8723bs/hal/odm.c @@ -431,7 +431,7 @@ static void odm_RSSIMonitorCheckCE(struct dm_odm_t *pDM= _Odm) =20 for (i =3D 0; i < sta_cnt; i++) { if (PWDB_rssi[i] !=3D (0)) { - if (pHalData->fw_ractrl =3D=3D true)/* Report every sta's RSSI to FW = */ + if (pHalData->fw_ractrl)/* Report every sta's RSSI to FW */ rtl8723b_set_rssi_cmd(Adapter, (u8 *)(&PWDB_rssi[i])); } } @@ -623,7 +623,7 @@ void ODM_DMWatchdog(struct dm_odm_t *pDM_Odm) } odm_CCKPacketDetectionThresh(pDM_Odm); =20 - if (*(pDM_Odm->pbPowerSaving) =3D=3D true) + if (*(pDM_Odm->pbPowerSaving)) return; =20 =20 diff --git a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c b/drivers/stag= ing/rtl8723bs/hal/odm_CfoTracking.c index 0eaedd8f6469..7e6b49399abb 100644 --- a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c +++ b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c @@ -138,7 +138,7 @@ void ODM_CfoTracking(void *pDM_VOID) pCfoTrack->CFO_ave_pre =3D CFO_ave; =20 /* 4 1.4 Dynamic Xtal threshold */ - if (pCfoTrack->bAdjust =3D=3D false) { + if (!pCfoTrack->bAdjust) { if (CFO_ave > CFO_TH_XTAL_HIGH || CFO_ave < (-CFO_TH_XTAL_HIGH)) pCfoTrack->bAdjust =3D true; } else { diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8= 723bs/hal/odm_DIG.c index a31c8368f9d9..390b509ef148 100644 --- a/drivers/staging/rtl8723bs/hal/odm_DIG.c +++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c @@ -82,7 +82,7 @@ void odm_NHMBB(void *pDM_VOID) =20 =20 if ((pDM_Odm->NHMCurTxOkcnt) + 1 > (u64)(pDM_Odm->NHMCurRxOkcnt<<2) + 1) = { /* Tx > 4*Rx possible for adaptivity test */ - if (pDM_Odm->NHM_cnt_0 >=3D 190 || pDM_Odm->adaptivity_flag =3D=3D true)= { + if (pDM_Odm->NHM_cnt_0 >=3D 190 || pDM_Odm->adaptivity_flag) { /* Enable EDCCA since it is possible running Adaptivity testing */ /* test_status =3D 1; */ pDM_Odm->adaptivity_flag =3D true; @@ -99,7 +99,7 @@ void odm_NHMBB(void *pDM_VOID) } } } else { /* TXadaptivity_flag =3D=3D true && pDM_Odm->NHM_cnt_0 <=3D 200)= { + if (pDM_Odm->adaptivity_flag && pDM_Odm->NHM_cnt_0 <=3D 200) { /* test_status =3D 2; */ pDM_Odm->tolerance_cnt =3D 0; } else { @@ -189,7 +189,7 @@ void odm_AdaptivityInit(void *pDM_VOID) { struct dm_odm_t *pDM_Odm =3D (struct dm_odm_t *)pDM_VOID; =20 - if (pDM_Odm->Carrier_Sense_enable =3D=3D false) + if (!pDM_Odm->Carrier_Sense_enable) pDM_Odm->TH_L2H_ini =3D 0xf7; /* -7 */ else pDM_Odm->TH_L2H_ini =3D 0xa; @@ -232,7 +232,7 @@ void odm_Adaptivity(void *pDM_VOID, u8 IGI) pDM_Odm->IGI_target =3D (u8) IGI_target; =20 /* Search pwdB lower bound */ - if (pDM_Odm->TxHangFlg =3D=3D true) { + if (pDM_Odm->TxHangFlg) { PHY_SetBBReg(pDM_Odm->Adapter, ODM_REG_DBG_RPT_11N, bMaskDWord, 0x208); odm_SearchPwdBLowerBound(pDM_Odm, pDM_Odm->IGI_target); } @@ -253,9 +253,9 @@ void odm_Adaptivity(void *pDM_VOID, u8 IGI) =20 if ( pDM_Odm->bLinked && - pDM_Odm->Carrier_Sense_enable =3D=3D false && - pDM_Odm->NHM_disable =3D=3D false && - pDM_Odm->TxHangFlg =3D=3D false + !pDM_Odm->Carrier_Sense_enable && + !pDM_Odm->NHM_disable && + !pDM_Odm->TxHangFlg ) odm_NHMBB(pDM_Odm); =20 @@ -323,7 +323,7 @@ bool odm_DigAbort(void *pDM_VOID) return true; =20 /* add by Neil Chen to avoid PSD is processing */ - if (pDM_Odm->bDMInitialGainEnable =3D=3D false) + if (!pDM_Odm->bDMInitialGainEnable) return true; =20 return false; @@ -387,14 +387,14 @@ void odm_DIG(void *pDM_VOID) if (odm_DigAbort(pDM_Odm)) return; =20 - if (pDM_Odm->adaptivity_flag =3D=3D true) + if (pDM_Odm->adaptivity_flag) Adap_IGI_Upper =3D pDM_Odm->Adaptivity_IGI_upper; =20 =20 /* 1 Update status */ DIG_Dynamic_MIN =3D pDM_DigTable->DIG_Dynamic_MIN_0; - FirstConnect =3D (pDM_Odm->bLinked) && (pDM_DigTable->bMediaConnect_0 =3D= =3D false); - FirstDisConnect =3D (!pDM_Odm->bLinked) && (pDM_DigTable->bMediaConnect_0= =3D=3D true); + FirstConnect =3D (pDM_Odm->bLinked) && (!pDM_DigTable->bMediaConnect_0); + FirstDisConnect =3D (!pDM_Odm->bLinked) && (pDM_DigTable->bMediaConnect_0= ); =20 /* 1 Boundary Decision */ /* 2 For WIN\CE */ @@ -529,7 +529,7 @@ void odm_DIG(void *pDM_VOID) /* 1 Force upper bound and lower bound for adaptivity */ if ( pDM_Odm->SupportAbility & ODM_BB_ADAPTIVITY && - pDM_Odm->adaptivity_flag =3D=3D true + pDM_Odm->adaptivity_flag ) { if (CurrentIGI > Adap_IGI_Upper) CurrentIGI =3D Adap_IGI_Upper; diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging= /rtl8723bs/hal/rtl8723b_cmd.c index 12416e499ac3..265418ebf94d 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -363,7 +363,7 @@ void rtl8723b_set_FwPwrMode_cmd(struct adapter *padapte= r, u8 psmode) } =20 if (psmode > 0) { - if (hal_btcoex_IsBtControlLps(padapter) =3D=3D true) { + if (hal_btcoex_IsBtControlLps(padapter)) { PowerState =3D hal_btcoex_RpwmVal(padapter); byte5 =3D hal_btcoex_LpsVal(padapter); =20 diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/= rtl8723bs/hal/rtl8723b_dm.c index 928226679ab4..195814de0df2 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c @@ -131,21 +131,21 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter) =20 hw_init_completed =3D Adapter->hw_init_completed; =20 - if (hw_init_completed =3D=3D false) + if (!hw_init_completed) goto skip_dm; =20 fw_current_in_ps_mode =3D adapter_to_pwrctl(Adapter)->fw_current_in_ps_mo= de; rtw_hal_get_hwreg(Adapter, HW_VAR_FWLPS_RF_ON, (u8 *)(&bFwPSAwake)); =20 if ( - (hw_init_completed =3D=3D true) && + (hw_init_completed) && ((!fw_current_in_ps_mode) && bFwPSAwake) ) { rtw_hal_check_rxfifo_full(Adapter); } =20 /* ODM */ - if (hw_init_completed =3D=3D true) { + if (hw_init_completed) { u8 bLinked =3D false; u8 bsta_state =3D false; bool bBtDisabled =3D true; @@ -207,7 +207,7 @@ void rtl8723b_HalDmWatchDog_in_LPS(struct adapter *Adap= ter) struct sta_priv *pstapriv =3D &Adapter->stapriv; struct sta_info *psta =3D NULL; =20 - if (Adapter->hw_init_completed =3D=3D false) + if (!Adapter->hw_init_completed) goto skip_lps_dm; =20 =20 @@ -216,7 +216,7 @@ void rtl8723b_HalDmWatchDog_in_LPS(struct adapter *Adap= ter) =20 ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_LINK, bLinked); =20 - if (bLinked =3D=3D false) + if (!bLinked) goto skip_lps_dm; =20 if (!(pDM_Odm->SupportAbility & ODM_BB_RSSI_MONITOR)) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index e794fe3caf9d..7755fed4be58 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -738,7 +738,7 @@ static void hal_ReadEFuse_BT( Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_BAN= K, &total); =20 for (bank =3D 1; bank < 3; bank++) { /* 8723b Max bake 0~2 */ - if (hal_EfuseSwitchToBank(padapter, bank) =3D=3D false) + if (!hal_EfuseSwitchToBank(padapter, bank)) goto exit; =20 eFuse_Addr =3D 0; @@ -882,7 +882,7 @@ void rtl8723b_InitBeaconParameters(struct adapter *pada= pter) rtw_write16(padapter, REG_TBTT_PROHIBIT, 0x6404);/* ms */ /* Firmware will control REG_DRVERLYINT when power saving is enable, */ /* so don't set this register on STA mode. */ - if (check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE) =3D=3D false) + if (!check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE)) rtw_write8(padapter, REG_DRVERLYINT, DRIVER_EARLY_INT_TIME_8723B); /* 5= ms */ rtw_write8(padapter, REG_BCNDMATIM, BCN_DMA_ATIME_INT_TIME_8723B); /* 2m= s */ =20 @@ -998,7 +998,7 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapter = *padapter) rtw_write32(padapter, REG_TCR, value32); =20 /* NOTE: Fix test chip's bug (about contention windows's randomness) */ - if (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE|WIFI_ADHOC_MASTER= _STATE|WIFI_AP_STATE) =3D=3D true) { + if (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE|WIFI_ADHOC_MASTER= _STATE|WIFI_AP_STATE)) { rtw_write8(padapter, REG_RXTSF_OFFSET_CCK, 0x50); rtw_write8(padapter, REG_RXTSF_OFFSET_OFDM, 0x50); } @@ -2118,7 +2118,7 @@ static void hw_var_set_mlme_sitesurvey(struct adapter= *padapter, u8 variable, u8 /* config RCR to receive different BSSID & not to receive data frame */ value_rxfltmap2 =3D 0; =20 - if ((check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true)) + if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) rcr_clear_bit =3D RCR_CBSSID_BCN; =20 value_rcr =3D rtw_read32(padapter, REG_RCR); @@ -2185,7 +2185,7 @@ static void hw_var_set_mlme_join(struct adapter *pada= pter, u8 variable, u8 *val) val32 |=3D RCR_CBSSID_DATA|RCR_CBSSID_BCN; rtw_write32(padapter, REG_RCR, val32); =20 - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) RetryLimit =3D (pEEPROM->CustomerID =3D=3D RT_CID_CCX) ? 7 : 48; else /* Ad-hoc Mode */ RetryLimit =3D 0x7; @@ -2723,7 +2723,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) break; =20 case HW_VAR_DL_RSVD_PAGE: - if (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) =3D=3D true) + if (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE)) rtl8723b_download_BTCoex_AP_mode_rsvd_page(padapter); else rtl8723b_download_rsvd_page(padapter, RT_MEDIA_CONNECT); diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_recv.c index cab4707091e2..888029e21dcb 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c @@ -135,7 +135,7 @@ static void update_recvframe_phyinfo(union recv_frame *= precvframe, precvframe->u.hdr.psta =3D NULL; if ( pkt_info.bssid_match && - (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) =3D=3D true) + (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE)) ) { if (psta) { precvframe->u.hdr.psta =3D psta; diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index f50726d2ed0c..3f0acb18c363 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -93,7 +93,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter *pada= pter) ) goto free_xmitbuf; =20 - if (rtw_sdio_wait_enough_TxOQT_space(padapter, pxmitbuf->agg_num) =3D=3D = false) + if (!rtw_sdio_wait_enough_TxOQT_space(padapter, pxmitbuf->agg_num)) goto free_xmitbuf; =20 traffic_check_for_leave_lps(padapter, true, pxmitbuf->agg_num); @@ -225,7 +225,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, st= ruct xmit_priv *pxmitpriv =20 frame_phead =3D get_list_head(pframe_queue); =20 - while (list_empty(frame_phead) =3D=3D false) { + while (!list_empty(frame_phead)) { frame_plist =3D get_next(frame_phead); pxmitframe =3D container_of(frame_plist, struct xmit_frame, list); =20 @@ -269,7 +269,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, st= ruct xmit_priv *pxmitpriv } =20 /* ok to send, remove frame from queue */ - if (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) =3D=3D true) + if (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE)) if ( (pxmitframe->attrib.psta->state & WIFI_SLEEP_STATE) && (pxmitframe->attrib.triggered =3D=3D 0) @@ -566,7 +566,7 @@ void rtl8723bs_free_xmit_priv(struct adapter *padapter) spin_unlock_bh(&pqueue->lock); =20 phead =3D &tmplist; - while (list_empty(phead) =3D=3D false) { + while (!list_empty(phead)) { plist =3D get_next(phead); list_del_init(plist); =20 diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index f2f73c65a636..f4073f6a342f 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -597,7 +597,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pwrctrlpriv =3D adapter_to_pwrctl(padapter); =20 if ( - adapter_to_pwrctl(padapter)->bips_processing =3D=3D true && + adapter_to_pwrctl(padapter)->bips_processing && adapter_to_pwrctl(padapter)->pre_ips_type =3D=3D 0 ) { unsigned long start_time; diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 098456e97c96..38b84c8b1143 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -275,7 +275,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl notify_timestamp =3D ktime_to_us(ktime_get_boottime()); =20 /* We've set wiphy's signal_type as CFG80211_SIGNAL_TYPE_MBM: signal stre= ngth in mBm (100*dBm) */ - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true && + if (check_fwstate(pmlmepriv, _FW_LINKED) && is_same_network(&pmlmepriv->cur_network.network, &pnetwork->network, = 0)) { notify_signal =3D 100 * translate_percentage_to_dbm(padapter->recvpriv.s= ignal_strength);/* dbm */ } else { @@ -372,7 +372,7 @@ void rtw_cfg80211_ibss_indicate_connect(struct adapter = *padapter) struct wlan_bssid_ex *pnetwork =3D &(padapter->mlmeextpriv.mlmext_info.= network); struct wlan_network *scanned =3D pmlmepriv->cur_network_scanned; =20 - if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { memcpy(&cur_network->network, pnetwork, sizeof(struct wlan_bssid_ex)); rtw_cfg80211_inform_bss(padapter, cur_network); } else { @@ -410,7 +410,7 @@ void rtw_cfg80211_indicate_connect(struct adapter *pada= pter) return; } =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) + if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) return; =20 { @@ -479,7 +479,7 @@ void rtw_cfg80211_indicate_disconnect(struct adapter *p= adapter) return; } =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) + if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) return; =20 if (!padapter->mlmepriv.not_indic_disco) { @@ -768,7 +768,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param struct sta_info *psta, *pbcmc_sta; struct sta_priv *pstapriv =3D &padapter->stapriv; =20 - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE | WIFI_MP_STATE) =3D=3D = true) { /* sta mode */ + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE | WIFI_MP_STATE)) { /* s= ta mode */ psta =3D rtw_get_stainfo(pstapriv, get_bssid(pmlmepriv)); if (psta) { /* Jeff: don't disable ieee8021x_blocked while clearing key */ @@ -891,15 +891,15 @@ static int cfg80211_rtw_add_key(struct wiphy *wiphy, = struct net_device *ndev, memcpy(param->u.crypt.key, (u8 *)params->key, params->key_len); } =20 - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { ret =3D rtw_cfg80211_set_encryption(ndev, param, param_len); - } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { if (mac_addr) memcpy(param->sta_addr, mac_addr, ETH_ALEN); =20 ret =3D rtw_cfg80211_ap_set_encryption(ndev, param, param_len); - } else if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true - || check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) + || check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { ret =3D rtw_cfg80211_set_encryption(ndev, param, param_len); } =20 @@ -1031,7 +1031,7 @@ static int cfg80211_rtw_change_iface(struct wiphy *wi= phy, struct mlme_ext_priv *pmlmeext =3D &(padapter->mlmeextpriv); int ret =3D 0; =20 - if (adapter_to_dvobj(padapter)->processing_dev_remove =3D=3D true) { + if (adapter_to_dvobj(padapter)->processing_dev_remove) { ret =3D -EPERM; goto exit; } @@ -1072,7 +1072,7 @@ static int cfg80211_rtw_change_iface(struct wiphy *wi= phy, =20 rtw_wdev->iftype =3D type; =20 - if (rtw_set_802_11_infrastructure_mode(padapter, networkType) =3D=3D fals= e) { + if (!rtw_set_802_11_infrastructure_mode(padapter, networkType)) { rtw_wdev->iftype =3D old_type; ret =3D -EPERM; goto exit; @@ -1207,8 +1207,8 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy pwdev_priv->scan_request =3D request; spin_unlock_bh(&pwdev_priv->scan_req_lock); =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { - if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS | _FW_UNDER_SURVEY | _FW_UND= ER_LINKING) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { + if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS | _FW_UNDER_SURVEY | _FW_UND= ER_LINKING)) { need_indicate_scan_done =3D true; goto check_need_indicate_scan_done; } @@ -1223,10 +1223,10 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy if (request->ie && request->ie_len > 0) rtw_cfg80211_set_probe_req_wpsp2pie(padapter, (u8 *)request->ie, request= ->ie_len); =20 - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) =3D=3D true) { + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) { need_indicate_scan_done =3D true; goto check_need_indicate_scan_done; - } else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) { ret =3D -EBUSY; goto check_need_indicate_scan_done; } @@ -1282,7 +1282,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy } spin_unlock_bh(&pmlmepriv->lock); =20 - if (_status =3D=3D false) + if (!_status) ret =3D -1; =20 check_need_indicate_scan_done: @@ -1582,7 +1582,7 @@ static int cfg80211_rtw_join_ibss(struct wiphy *wiphy= , struct net_device *ndev, ret =3D rtw_cfg80211_set_auth_type(psecuritypriv, NL80211_AUTHTYPE_OPEN_S= YSTEM); rtw_set_802_11_authentication_mode(padapter, psecuritypriv->ndisauthtype); =20 - if (rtw_set_802_11_ssid(padapter, &ndis_ssid) =3D=3D false) { + if (!rtw_set_802_11_ssid(padapter, &ndis_ssid)) { ret =3D -1; goto exit; } @@ -1608,7 +1608,7 @@ static int cfg80211_rtw_leave_ibss(struct wiphy *wiph= y, struct net_device *ndev) =20 rtw_wdev->iftype =3D NL80211_IFTYPE_STATION; =20 - if (rtw_set_802_11_infrastructure_mode(padapter, Ndis802_11Infrastructur= e) =3D=3D false) { + if (!rtw_set_802_11_infrastructure_mode(padapter, Ndis802_11Infrastructu= re)) { rtw_wdev->iftype =3D old_type; ret =3D -EPERM; goto leave_ibss; @@ -1632,7 +1632,7 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, =20 padapter->mlmepriv.not_indic_disco =3D true; =20 - if (adapter_wdev_data(padapter)->block =3D=3D true) { + if (adapter_wdev_data(padapter)->block) { ret =3D -EBUSY; goto exit; } @@ -1662,11 +1662,11 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy= , struct net_device *ndev, ndis_ssid.ssid_length =3D sme->ssid_len; memcpy(ndis_ssid.ssid, (u8 *)sme->ssid, sme->ssid_len); =20 - if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) =3D=3D true) { + if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) { ret =3D -EBUSY; goto exit; } - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) rtw_scan_abort(padapter); =20 psecuritypriv->ndisencryptstatus =3D Ndis802_11EncryptionDisabled; @@ -1759,7 +1759,7 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, =20 /* rtw_set_802_11_encryption_mode(padapter, padapter->securitypriv.ndisen= cryptstatus); */ =20 - if (rtw_set_802_11_connect(padapter, (u8 *)sme->bssid, &ndis_ssid) =3D=3D= false) { + if (!rtw_set_802_11_connect(padapter, (u8 *)sme->bssid, &ndis_ssid)) { ret =3D -1; goto exit; } @@ -2065,7 +2065,7 @@ static netdev_tx_t rtw_cfg80211_monitor_if_xmit_entry= (struct sk_buff *skb, struc u32 len =3D skb->len; u8 category, action; =20 - if (rtw_action_frame_parse(buf, len, &category, &action) =3D=3D false) + if (!rtw_action_frame_parse(buf, len, &category, &action)) goto fail; =20 /* starting alloc mgmt frame to dump it */ @@ -2546,7 +2546,7 @@ static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, = struct wireless_dev *wdev, /* indicate ack before issue frame to avoid racing with rsp frame */ rtw_cfg80211_mgmt_tx_status(padapter, *cookie, buf, len, ack, GFP_KERNEL); =20 - if (rtw_action_frame_parse(buf, len, &category, &action) =3D=3D false) + if (!rtw_action_frame_parse(buf, len, &category, &action)) goto exit; =20 rtw_ps_deny(padapter, PS_DENY_MGNT_TX); diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c b/drivers/st= aging/rtl8723bs/os_dep/sdio_ops_linux.c index 3ea9fdfa14f8..e9a2f3f7ec74 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c @@ -224,7 +224,7 @@ u32 sd_read32(struct intf_hdl *pintfhdl, u32 addr, s32 = *err) if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) padapter->bSurpriseRemoved =3D true; =20 - if (rtw_inc_and_chk_continual_io_error(psdiodev) =3D=3D true) { + if (rtw_inc_and_chk_continual_io_error(psdiodev)) { padapter->bSurpriseRemoved =3D true; break; } @@ -300,7 +300,7 @@ void sd_write32(struct intf_hdl *pintfhdl, u32 addr, u3= 2 v, s32 *err) if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) padapter->bSurpriseRemoved =3D true; =20 - if (rtw_inc_and_chk_continual_io_error(psdiodev) =3D=3D true) { + if (rtw_inc_and_chk_continual_io_error(psdiodev)) { padapter->bSurpriseRemoved =3D true; break; } diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/stagin= g/rtl8723bs/os_dep/xmit_linux.c index dc0b77f38b1a..3a9857378581 100644 --- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c @@ -188,7 +188,7 @@ void _rtw_xmit_entry(struct sk_buff *pkt, struct net_de= vice *pnetdev) struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; s32 res =3D 0; =20 - if (rtw_if_up(padapter) =3D=3D false) + if (!rtw_if_up(padapter)) goto drop_packet; =20 rtw_check_xmit_resource(padapter, pkt); --=20 2.53.0