From nobody Tue Jun 16 11:21:38 2026 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CAC432A3C9 for ; Sun, 19 Apr 2026 03:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776568575; cv=none; b=alTVsbHP0U8CUMGEeT+ta2x0D5PF+TZp+v4Fb1556NDK3wbhSCiS7DdJxv+b6ot6Oogwi8OVSfdoP4bxwO7/QI8tDKBw5j0C1VtwmLKXoO8g/SDwm2BRQr4YTStZdHhXNk5Q+vdlu+tJLogGEj0ya3thxGChDArKSNs/wj/pHNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776568575; c=relaxed/simple; bh=o1An2SvrCqr40SIRC+E6nswZR7lN//rkfQ0/TYvQBRg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pxGwpKJZs9nQzU95KyBPOLIGfSZiKBmw+V+BCWWB3isoS0xbrTu3jNR62PDjmEk1cYR9vmJJPMi7lJt8SxxejiVfrfnLrVKtlbMyNkFdd6b6S535zviEPLo5/F0wjtivbvS/9rGg2OFY6QBAtwvc3btDcymGnnHLMAj1w+Hbw3Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=qeKwwkGJ; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="qeKwwkGJ" Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 417B63F20E for ; Sun, 19 Apr 2026 03:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1776568560; bh=Z87teUv8a9vw/PuofVqXhMl3313Ral2SkrCndNJuZ8w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qeKwwkGJZVL2CaqLGBCL5AzELx6QHVBIhoIbwDN61LNvCZRiAFOTP8oYoNL1ku7hP zri9XbJbrE+nlBHa4IhcW7t/Dyb1TVFUc/MI6mzGd+b1i9fYaNeFBXfk4IBfwWWOfr /iZH8gvRnO2R0u8SH22vRGU80T9NMf1gnAkjdkVNNv6wDLodFHLyO0pZNYyys37ZCU U/82TU6nBDlGAmZQEqSwjq293dUCcUicJim9iwtR0GaFjtmLKDmU9tLTLwEdEs0+pd ZSI3h0lzaYvi7UZla/ZttuIg3VstqsxH9qF1s6aA5xfw2bbSjSyV4jxtYNqrtqqLST oBs7JVwY3rMr5HJyfSpFquz+ARNrQchPnvOvWekFCOHaiMhKbTX+U83NOksPiAXgtd 128+fWQEat7zq7Sf/NEZxMzb6RK2ziYprf+OXFetqquFukKr0XlZlaerXhD6tNUXXb nA3bSRgtl8kl0lSriDdJpoNPZPjmT8LcnVN+PZJCGiBjoba2qw/ALsewUDkZNHugaz cisYU9RGDxLifB8uTHl10w3DWJKe9qVwMKsWQA1fp+PNUCEFA1DuncLg+sN+MN1Cni UGYJpiwDCndEAGVL0AwA+Uj7EmkLWL4LauTUOuvBWeBD8xyEACHlkzjGP20e6pFcmP j1e+zgcYwCzSp0qaot7ROXqg= Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b24af7ca99so23147345ad.1 for ; Sat, 18 Apr 2026 20:16:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776568558; x=1777173358; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z87teUv8a9vw/PuofVqXhMl3313Ral2SkrCndNJuZ8w=; b=fDwe/wCoaUfPc59Q1QBSqKdO5zTk9zcLp0VDBUqS2a1bRMqRj6G4vuEkAGFTHXtc2a Rl8FyGrIJ54s0rcbaDrFq1+dzAnyxvPKXVYagM4ejdxqoKnlF+/eSpe8gqge7+UJxw6/ azNNOi2NB9/hjoUOZLClRWSZ7oQ/7e08oGt2XuHjRA3O4I50eomC4cPOXgvgWLPOFdTP +aNeff2Q8cNiEYDb6QaSXPymwnOhkNjDabrIk1xvLc/eaPGy/fklBZaKtzB56EFPhRkv tXzPoKf8yvbgIOHbWvlzxGLQen/C7d5dItn9yA0gcLCmersJ1LU6Js0pT5mERSpk2R91 gvVg== X-Forwarded-Encrypted: i=1; AFNElJ9/oOL/TynsMx28p2FhwoZplb2JPc0oaLMzhJiFF4iJPArOgpPjKXjwGy7gFISuOYOYJNkkGU5ZYo6e8wI=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd7TXOKmi+iinQpJEl3gsKyYGnqO/H1i3r2OI3DZe9fw4rg7JT Iw7xLY6giGEkKhl5O/yltuvDF0tKlsIUzjWZlRiE7ktmg8dhPuRYHTKRM7PIwEhT4kVjgshWH7z udEbG4Yuvaz/CcEzeL88jNUEIzrX3HA7E9I6zh9yEKgwT5XuxLBhEdYvqkVekfPVORCbB+wBiM1 6l+dLzTw== X-Gm-Gg: AeBDiesEqH4+p158Oxz/cNEHSBdnv1PE2aH29QEawus1X5rCRdbE5vyqSklafu7ubHI 6pGyU2fse5nGlNenYyDkwWnu6HO9+2C+XZ1cjEDKKSLlm3iNgituNsFJiKiPOmmviSmHv+2viZr jtNVHAqvRcx3xGkFURxRqVnytHseKRFLcm85GSBG6lu2f0qRpGFW//UNQ9uzKC+/+rElB/jYAjS fp+RqhY4XcWw5IqqkOlxL1bmXiMGZ2PfZMCaCwbTS1rlhX5H11p1hRgNhzxCXZr43B6xKRe0PWm Xq6KKftEAqqlXRquhFZS1uOsqpmgEFaxvA6bx75pkVEUdeIxPKVSwiwTSHP5d6oQ4MoCIUfzLVG yZz6weE8L0tMLSzx6gPx9TfBKqSoaHcZds25DzOLI9C8oP/+5Ip06dg== X-Received: by 2002:a17:902:ce0a:b0:2b0:af2f:b27a with SMTP id d9443c01a7336-2b5f9ec3590mr84772525ad.11.1776568558435; Sat, 18 Apr 2026 20:15:58 -0700 (PDT) X-Received: by 2002:a17:902:ce0a:b0:2b0:af2f:b27a with SMTP id d9443c01a7336-2b5f9ec3590mr84772395ad.11.1776568558047; Sat, 18 Apr 2026 20:15:58 -0700 (PDT) Received: from localhost.localdomain ([120.159.24.52]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fa9fedf0sm74764235ad.6.2026.04.18.20.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 20:15:57 -0700 (PDT) From: Changwei Zou To: sakari.ailus@linux.intel.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, mchehab@kernel.org, changwei.zou@canonical.com Subject: [PATCH v2] media: i2c: ov5645: Correct Y_OFFSET value at 2592x1944 resolution Date: Sun, 19 Apr 2026 13:15:50 +1000 Message-ID: <20260419031550.15368-1-changwei.zou@canonical.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Y_OFFSET register at (0x3812, 0x3813) is set to 6, which is inconsistent with the OV5645 datasheet and the X_OFFSET setting. For consistency and clarity, change the value from 6 to 4. height =3D (Y_ADDR_END - Y_OFFSET * 2 - Y_ADDR_START) + 1 =3D (V(0x3806, 0x3807) - V(0x3812, 0x3813) * 2 - V(0x3802, 0x3803)) + 1 =3D (0x079F - 4 * 2 - 0) + 1 =3D (1951 - 8 - 0) + 1 =3D 1943 + 1 =3D 1944 Signed-off-by: Changwei Zou --- drivers/media/i2c/ov5645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c index b10d408034a1..0af1b12c0989 100644 --- a/drivers/media/i2c/ov5645.c +++ b/drivers/media/i2c/ov5645.c @@ -479,7 +479,7 @@ static const struct reg_value ov5645_setting_full[] =3D= { { 0x380d, 0x1c }, { 0x380e, 0x07 }, { 0x380f, 0xb0 }, - { 0x3813, 0x06 }, + { 0x3813, 0x04 }, { 0x3814, 0x11 }, { 0x3815, 0x11 }, { 0x3820, 0x47 }, --=20 2.43.0