From nobody Sat Jun 20 07:11:37 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DFD1395D8F for ; Sat, 18 Apr 2026 14:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776522990; cv=none; b=jjS7gcWLmRPTkuoIhWs+aUAG5C9O7ph+bGPc9fUXe/8DH/XxIKQYve7IRtLmWeEiRB49p2RWmC2ypmvFQtxETl/NMIW9b+NZiF+YkDAjbLVYhUBSBowiMBE4Z+EM7f7MHbMMi0Py7vIGh3gh6LP9Phq+oKwAD4QtvKV+fk+Da3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776522990; c=relaxed/simple; bh=s1QiCuvO/yxnom0YdaAgahlW+22nZ8MdjRUuFA4w6ME=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=l/X0Lc0Miei6mVz4SpSm2a1L7I5fRHtKQfgXJrViqjdOMNNyG/LYDnzVHvh/IJZX8D3u70q0XZBegWumQmq0ocjN8KDayXyWCk/uLI8lXJAk4RYSYfRh5ECCTZatDKAy3SejNaHdcQj7nXe4zU+AYeyFgZAq4jaVIW4DGTe+DMY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=crimson.net.eu.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=crimson.net.eu.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso22500565e9.3 for ; Sat, 18 Apr 2026 07:36:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776522987; x=1777127787; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J8Myl5eTPvtfBTYrdmzc0XSzpZs+RgyOgv0qYMVJpcU=; b=NGxFCmc/CoAq6QeRgnYpHRFuyAkrMlY4C6CfO14QK8mTeyjLJCX8HUMirFVWas0Smx EQUUAmMmepQwdcV1HdjarvXsLU2XsykO4Nyqxt6kx+jLL4H00J/+vJ6MfnCSGw2gVNGj VuJR6B1gwJ3pIdQmz6EE2+RL3dfBpwKcF+InYBb5lYQFDzrFEBVoxDhR/X0caT248UFc tUPjNd7lobWDx6pIxqOIKZGFRyHDHzH9iWqbwFFdMH8+cP2qjGIs987V6+TRHqewafjR ipGe4J/V6kowfbVdVjNw8/nylHrucnKFkWsLr/yt3+lft1qVoi2X4yUnanQX9WGL+zL2 xz2Q== X-Forwarded-Encrypted: i=1; AFNElJ+QJH4KF16/DblP55Y3Cm5u0xERYXbSHjC20j9a7GATzp24+d8uNf8QQsDABftR/zDV1If+l0OwfJBWzyI=@vger.kernel.org X-Gm-Message-State: AOJu0YxRAnHlCDvAqz3nIDnuCIdVrAMYK8wN6cOXt8mg1mbpmK3XHrXF mRpm6QEyu1mtspcI29pncd8xrtTOsgV2/YARM5y5gFek61Yl/fu7dPYt0tUuBA== X-Gm-Gg: AeBDietU6jhWWgf0+w4PSYYLbCsjL9nYMmEr8OZ9WhLp8ATsv5nviF1vWirA+ihUXar 9dBubJilp1ZRmh7FXKt6RiAlbtOLldWwG7jEZ3174BMy59Qg+iT8zFhmz2ux/SrHUdgNfhHMmx8 xLLG5g2DsbMGMof1Ftnyz0VKmytukaJuPyIzpuLYMVtIBKubLLCjgXA2sxO3Pto4lch2kDQbO8o tqOEQ8PAtpZXOLqX6xb32c5YJBS/jNk3uWC0GTcIAuQFjyaADFf/cgWKRPdTxriMQLI3/Gui7PV Ewy8S2JBCcBuz+H7HmArsLINd3vF3HCfLpka2fugM+lyOwdX5W7st1QijDQOM6bEDVUEv12OCqo FXjwQ+V69zce4xIXbGDZXUYUK7yq193JfNiLMdwI8wAK4j2XT6bJn7ZjVOO0BdeIQO7/oQQLAKP ZXU2vXP4cnLxc05KbkMS+by3U9v9v1/u9JGjDsQC7kaGgxJ5Yed+luPyT+aIohBzl8VZtHl2FRX 5rJ9TOijsl2sQH7l3DnTfETyDfk4X2W1g== X-Received: by 2002:a05:600c:674f:b0:488:be21:54ae with SMTP id 5b1f17b1804b1-488fb6e9cecmr107092205e9.0.1776522987033; Sat, 18 Apr 2026 07:36:27 -0700 (PDT) Received: from localhost.localdomain ([151.41.34.202]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc0f8188sm144271375e9.2.2026.04.18.07.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 07:36:26 -0700 (PDT) From: deep@crimson.net.eu.org To: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kenet Jovan Sokoli Subject: [PATCH] staging: sm750fb: remove unused functions Date: Sat, 18 Apr 2026 16:36:20 +0200 Message-ID: <20260418143620.845355-1-deep@crimson.net.eu.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kenet Jovan Sokoli The functions sm750_enable_i2c() and sm750_hw_cursor_set_data2() are defined and declared but never used. Following the driver's TODO list to remove unused code, this patch deletes these dead functions. Verified by compilation and cppcheck. Signed-off-by: Kenet Jovan Sokoli --- drivers/staging/sm750fb/ddk750_power.c | 17 ---------- drivers/staging/sm750fb/ddk750_power.h | 5 --- drivers/staging/sm750fb/sm750_cursor.c | 43 -------------------------- drivers/staging/sm750fb/sm750_cursor.h | 2 -- 4 files changed, 67 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_power.c b/drivers/staging/sm750= fb/ddk750_power.c index 12834f78eef7..eaba3bc2e01a 100644 --- a/drivers/staging/sm750fb/ddk750_power.c +++ b/drivers/staging/sm750fb/ddk750_power.c @@ -126,20 +126,3 @@ void sm750_enable_gpio(unsigned int enable) =20 sm750_set_current_gate(gate); } - -/* - * This function enable/disable the I2C Engine - */ -void sm750_enable_i2c(unsigned int enable) -{ - u32 gate; - - /* Enable I2C Gate */ - gate =3D peek32(CURRENT_GATE); - if (enable) - gate |=3D CURRENT_GATE_I2C; - else - gate &=3D ~CURRENT_GATE_I2C; - - sm750_set_current_gate(gate); -} diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750= fb/ddk750_power.h index 5cbb11986bb8..1c4f054d7276 100644 --- a/drivers/staging/sm750fb/ddk750_power.h +++ b/drivers/staging/sm750fb/ddk750_power.h @@ -33,9 +33,4 @@ void sm750_enable_dma(unsigned int enable); */ void sm750_enable_gpio(unsigned int enable); =20 -/* - * This function enable/disable the I2C Engine - */ -void sm750_enable_i2c(unsigned int enable); - #endif diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750= fb/sm750_cursor.c index 7ede144905c9..f0338e6e76b1 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -130,46 +130,3 @@ void sm750_hw_cursor_set_data(struct lynx_cursor *curs= or, u16 rop, } } } - -void sm750_hw_cursor_set_data2(struct lynx_cursor *cursor, u16 rop, - const u8 *pcol, const u8 *pmsk) -{ - int i, j, count, pitch, offset; - u8 color, mask; - u16 data; - void __iomem *pbuffer, *pstart; - - /* in byte*/ - pitch =3D cursor->w >> 3; - - /* in byte */ - count =3D pitch * cursor->h; - - /* in byte */ - offset =3D cursor->max_w * 2 / 8; - - data =3D 0; - pstart =3D cursor->vstart; - pbuffer =3D pstart; - - for (i =3D 0; i < count; i++) { - color =3D *pcol++; - mask =3D *pmsk++; - data =3D 0; - - for (j =3D 0; j < 8; j++) { - if (mask & (1 << j)) - data |=3D ((color & (1 << j)) ? 1 : 2) << (j * 2); - } - iowrite16(data, pbuffer); - - /* assume pitch is 1,2,4,8,...*/ - if (!(i & (pitch - 1))) { - /* need a return */ - pstart +=3D offset; - pbuffer =3D pstart; - } else { - pbuffer +=3D sizeof(u16); - } - } -} diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750= fb/sm750_cursor.h index 88fa02f6377a..51ba0da0270c 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -10,6 +10,4 @@ void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, = int x, int y); void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg); void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); -void sm750_hw_cursor_set_data2(struct lynx_cursor *cursor, u16 rop, - const u8 *data, const u8 *mask); #endif --=20 2.43.0