From nobody Tue Jun 16 10:11:05 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9080B35FF5B for ; Sat, 18 Apr 2026 13:11:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776517868; cv=none; b=QJuIOdmm7qPUslNG9nHZE4DnmreeCLd1KpWMVxengeG6RlCOnjzEN4xhPGw1ydseeqajz0V4WcznYlDZBJAMTlhcpmj46OIqpd80B3J2fyledO8kZ37K45m5BopF1weZqEw6ct2TOdxKLl5dkGs60v3wVwKy8bj8RW3PYUi64os= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776517868; c=relaxed/simple; bh=+xkPi3Ts+vZPFs6LV6P2y7SlqE1SPgnlAU7DIjbAE+k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HFgwG8IBm01Q3QE4VgNdGc82NRi3LLS7yw1P1jaA0HHbNIDkge3mgHzKDmPEjWlmubuTu5GJQZza8QBytHWb+kDrd2J2JsVv2ve97ByVRYNigFOWeNjYiKDGW+si7eW6VWRf2+WEESltg8ch/DD+6nRSA149K1zsEvfKlaFbLZo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sogpsIFv; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sogpsIFv" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-482f454be5bso25688905e9.0 for ; Sat, 18 Apr 2026 06:11:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776517865; x=1777122665; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qy9Y3Izl0t2648U+SRfDngw68zD0TyRucNL5CZqQfL4=; b=sogpsIFvd1+0vCs23+9Sk4mSVeP1fjvAiAI76f3J3+anHj33SQO7Mc039O8/XYd4iK 6O+u2mfImYQeKbHMJmXXQULoTTQrsGIc3za1kzq3sMoDyph1jA01vEsynctARjOWlJL0 wXH3Qw/WnV/kQAD3AxSQAARvYLNu4oAmzniqunqrQ2Ll70Xwhx3FwK/lYirT0X8FFdtd yTUxntMwBAQi3/m7fPpDK1/W6xpN5YpCmLPbg/tNTchjSDwnt8Zyf7qMAvSEarfm0NPt 4j/nAYY+MWnIjcjgk5XNHoDsdpeRmFoaKQPlc+TDZqzD3VYJLxToBoMpkb8ADp95rYA8 hWSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776517865; x=1777122665; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qy9Y3Izl0t2648U+SRfDngw68zD0TyRucNL5CZqQfL4=; b=crdGbViwsmlXy4ofa6qHRqRmd+WQJjnWSL1qW53NfUTBHdHe7xK/6Cwub00eFtGboW H2i85OlwR1CIn1RG/EPMrYmqNj34sPa0zG3q4gC2L5LU1aT57HUCoBo0AbqvhjUHVHwE Ei3X6AT41ITnoqM/Zcko82C4YRh3MNxGRWHZB/CMohCCCqdq6lMIYSr/56M/IzIUh6A+ FoEe27vMuxoHSX0Dpk0hdbMYVfsnIgKmHy78fzUme6an88pfmX0CeYtCpveCg8pM9+mz L/ts8q8YXudbga8rwApD3ABNVoFDjNFBHbShj4X20kFmTDwKR5VjHoB0JsNvvMiqvB8d O47A== X-Forwarded-Encrypted: i=1; AFNElJ91Z7G7vYwMm3i0KUy10Qn5VMsFStgQAvLe73F9JxQ6GceRBkB5+FVvJI2uOTt6ZjODIHwaanc1yCGKDXo=@vger.kernel.org X-Gm-Message-State: AOJu0YxDALDLbhoP8Og5unoVhhYO0ZoV05VW9zqfPauokIiwrX9XdRWU p33zrXCZYmpa82usnBQ6iRoVfFPVCJCP2DtHi66vmzfov9pM2at/FKo= X-Gm-Gg: AeBDiesZXG5HJOO5J74PHr0Koywp4lGucfZeC+FsT3lT7u1oH1d5fmi1fTtdIiIohrd qxyDaO43o/HP7yNdYABKO3eSL/F/j7QHHkf/20mcT9HAcViwn4YenePUhMXWg/sA/0DRStRnqG7 LDFRZxVNSQGsVhEpipTpiySas2zXJwBWavEbNel5VBHTPDe82iQseaV8bfVNbu7FYzopTvtSYoi BGR16Lfzy5YxhPiyWDGp9MsAK1lCliqTeHIyz3dISWauG7oeDjfdweXQbkdPzlBuvCd00/5CPCU kzjSUfwRFNdzpFFAvKvAD4F8hkk8Uz6RyOdFp+IW0EDaNgIWaWSm1dUgckBlD9dJYNxes1blR9/ 8bhmoPQCA+IRKUVi2yWuAoMG0T7uL5xipIqKY2AcC3mCKt+GtbUWqjW/w50F8i/+jXSVQU65fB7 LwgeE= X-Received: by 2002:a05:600c:6089:b0:487:22ad:403e with SMTP id 5b1f17b1804b1-488fb8ba594mr86850415e9.14.1776517864809; Sat, 18 Apr 2026 06:11:04 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4c221cdsm13191103f8f.0.2026.04.18.06.11.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 06:11:04 -0700 (PDT) From: Tristan Madani To: agruenba@redhat.com Cc: gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, syzbot+3e2c95229d1ab81a0bfd@syzkaller.appspotmail.com Subject: [PATCH] gfs2: replace WARN_ON_ONCE with fs_warn in rgblk_free Date: Sat, 18 Apr 2026 13:11:03 +0000 Message-ID: <20260418131103.1058618-1-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristan Madani rgblk_free() triggers WARN_ON_ONCE when gfs2_rbm_from_block() fails due to a block number outside the resource group bounds. This can be triggered by a corrupted filesystem image, causing unnecessary kernel warnings. Replace WARN_ON_ONCE with fs_warn() to provide a more informative diagnostic message while avoiding the kernel warning. Reported-by: syzbot+3e2c95229d1ab81a0bfd@syzkaller.appspotmail.com Fixes: 5b924ae2b7b4 ("GFS2: fix rgrp end rounding problem for bsize < page = size") Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani --- fs/gfs2/rgrp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 26d6c1eea5591..7707c1b1082f8 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -2266,8 +2266,11 @@ static void rgblk_free(struct gfs2_sbd *sdp, struct = gfs2_rgrpd *rgd, struct gfs2_bitmap *bi, *bi_prev =3D NULL; =20 rbm.rgd =3D rgd; - if (WARN_ON_ONCE(gfs2_rbm_from_block(&rbm, bstart))) + if (gfs2_rbm_from_block(&rbm, bstart)) { + fs_warn(sdp, "rgblk_free: block %llu outside rgrp\n", + (unsigned long long)bstart); return; + } while (blen--) { bi =3D rbm_bi(&rbm); if (bi !=3D bi_prev) { --=20 2.47.3