From nobody Tue Jun 16 10:10:31 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1912AF513 for ; Sat, 18 Apr 2026 13:10:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776517840; cv=none; b=F1fFJe+D+hbQdVVTD0Y38t98LkAIjXI5vkP88ca3vP8SIALqjo0RLxAxuhyqIL35/c2rXY4/qA4E+gQDVJ93qNnwMuiXlIcstU28dri9RFk+EoyVmV/YhxgxVl/0iQLAvWWgLOC1s4dbjZyJzememizyp5+DraQJ4vfZjMqlQ5E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776517840; c=relaxed/simple; bh=9kRymbzP5EnIRvF+LtoDejrj42KY4JbIoBOEpAUVsmA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tU403AWoJvFWHZlRqMCqa82o9cYU0KsW5CsTMyrYKLFkbEzViqahoPphU6K0g7yZy4j1CLBc97j+2XLUzo1jQ+IXDE/HQtA2nOldYHiZ6shiPQvuOlBTDIqmkebZyhjmEmA93Z7qENLIldMp66GoghEI9pTMzjvJvrrCL9jLyu4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GklENj1R; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GklENj1R" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43cfd832155so1071164f8f.1 for ; Sat, 18 Apr 2026 06:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776517837; x=1777122637; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L7f0YRiST0xoyWZIkt/ryzQU03D0pkCx/ltqK8VLk8U=; b=GklENj1RMZHdwU1nvT1oMnN+8ErKmFC2IeKH27bPVML9AGlHieXQrKkPYmCUbYz1ji fdizt9hdSachlJVszVS/nIlX+cdQVGgobFctjgFYeszskLlM1RAi1JvIp/lnunt7u1Ez Z/G9w19I4vaUHhql9fJoOjw8Zgchgrz6lB+XpLy6pqaVOPc1W8T1KjVyZ/HvkTOkGYfx zYwztg565Rb5DsajvwZCrKnCN46H5SSE/c0BJkadEscBnCrIvNHiVmSVXe4+xDFkH+Hm ByE+6BanIM61yParsGRRvcQhHplUm/Lv4zC57nivwTxbiUMy+IlM44jnJGaEOMF2Teyd jZ2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776517837; x=1777122637; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L7f0YRiST0xoyWZIkt/ryzQU03D0pkCx/ltqK8VLk8U=; b=H3VE5/3fWMsH05sbveLMQeue7zLnsMzAYTDaSp8tQOpkKjy76Z2RLfwo9vYAL7tUOi r8xym+0ucN7YBuIKtOvp81rD5Odhc89dFlqaZS/CvXmCUaMSJZgYFfd3c99uwt3h01RZ dpmPuGmBKMboR7u5EpaPpNL7F0lxH1nkbNHXwueDUUuTyC/rET0+OVewwte7Hz2I1PjD 4FtT5TJHs6ZdMSf6WA5g+VoGKlh9IUSDb2xDxilYDe2zhNwPTNutXuEyIdIWysyY0d5f KDGX5xGdPLsw4K8psgAjNYSq9Ntgizxj2/w0MO9B52GOw5o4kTBqTOqPaLCAmT5SfM8e jsxw== X-Gm-Message-State: AOJu0YwBvKBe7ElW3EBzeDs7HzeTsSep3o1Xj+V3pHnR1N/kC6a/BVRF ydD6miTUispKg2gaiIqcyEyOeyq+8AjuYTLQI7kySoMGTNF7/S8l7Wo= X-Gm-Gg: AeBDieuAEqm+bbZZ8ldMw2yDoROgU/CSXxibi5k6aeveQpZgdq5BDzT+CJgty3bz4xe Y30rZbiYcCgk3/LlByUE47ZcLZLa+L4Q7UwNBkELe6uNRQVwyDTSjxkQTVF9MWbVab347ydhW8/ zQHnVwfnSBiuygfFMH1h/kgxE7fAPfA8zx4n8ym7tNkPe2Myg+Ek6AHIkefZV4ryoMkJ6R1+8RL SXH+AJDLgvSIOoeWAjaoKaL2Alr8xDoklt8nJ8ZSvDRbA3SNeJ/gsLu50dQpu64cBKN0Ky+zZ8K A7IW1S60xXvPKj1layDu43avUsYHoP8nafbSkNDVWEKkSuJxcdhuxyehgRl7YjyCpL0iBUBGuuo +yLrFkewq2esNOyzdqn4cFsAXTeYMZJDVSvmrTBSiY9DuS8Td3sda0blcP/ir2dFwCE0zEqsls3 6Gflc= X-Received: by 2002:a05:6000:18a8:b0:43f:dd91:b022 with SMTP id ffacd0b85a97d-43fe3e0a2a9mr9891626f8f.35.1776517837235; Sat, 18 Apr 2026 06:10:37 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4633bsm12681459f8f.26.2026.04.18.06.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 06:10:36 -0700 (PDT) From: Tristan Madani To: jack@suse.com Cc: linux-kernel@vger.kernel.org, syzbot+969e250fc7983fc7417c@syzkaller.appspotmail.com Subject: [PATCH] udf: propagate error from udf_fiiter_add_entry Date: Sat, 18 Apr 2026 13:10:35 +0000 Message-ID: <20260418131035.1048143-1-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristan Madani udf_fiiter_add_entry() triggers a WARN when it encounters an error condition but does not propagate the error to callers. This can be triggered by a corrupted filesystem image. Replace the WARN with proper error propagation to allow callers to handle the failure gracefully. Reported-by: syzbot+969e250fc7983fc7417c@syzkaller.appspotmail.com Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani --- fs/udf/namei.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/udf/namei.c b/fs/udf/namei.c index 9a3b7cef36064..2249b79c0e0b2 100644 --- a/fs/udf/namei.c +++ b/fs/udf/namei.c @@ -207,14 +207,9 @@ static int udf_expand_dir_adinicb(struct inode *inode,= udf_pblk_t *block) udf_fiiter_write_fi(&iter, impuse); } brelse(dbh); - /* - * We don't expect the iteration to fail as the directory has been - * already verified to be correct - */ - WARN_ON_ONCE(ret); udf_fiiter_release(&iter); =20 - return 0; + return ret; } =20 static int udf_fiiter_add_entry(struct inode *dir, struct dentry *dentry, --=20 2.47.3