From nobody Tue Jun 16 10:02:20 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FC4024503B for ; Sat, 18 Apr 2026 07:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776495752; cv=none; b=fszaSZQZVYi6Rs7fXMxhRYBp8H2zQy3RHa1VLvntrW6CZetxtHjOZQfufca+MDcJrBya4eGu/1eHpTyponw531x7sp+oOeJs2CZKapAP+/nHa+6ZkDMz/CdedcFfUHauRrtYHO2fhNvxhLKrcPYwi1nGO1oWFoVi7mDszZ5qrOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776495752; c=relaxed/simple; bh=CcDvIU6z25vhcQ4xVZy8lcj8AJMflIP8uYRdn7I9y5c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rPz+NBYIDzSiT6bZQHGlm1+KQyebSGrc5IDeo0X20iqcBbAbMl7JPOZuNvw2DycyNNZiMuDG3IUX5zGOtCUeLBoGwuJQAYOFaHZ5MlvoTwalEqzUP+WRdf27efpW1ZJKScNw2MoHz923e6kFH6oJ8INLn6UD86fzp416156Is/c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pHhRD1Hj; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pHhRD1Hj" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2b2d3a9e149so12097765ad.1 for ; Sat, 18 Apr 2026 00:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776495751; x=1777100551; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UiTYFjNnjpdpCtpnDwsxuALR8uSM4iRhQ8ijRVO9szM=; b=pHhRD1HjdGOBeK+d1xb/DQvb9tKjebI4uoUTcXWnbWtVuv6ZStghKAKqyejvVEa3lR i4iaRS7NTPtwBPIqRGFpJebo4dqhavgqmpWCsJm/tWWGNWlnFe3H7T1sP/TsuomwpuXC +A8Rd3sRgsVoznhFB8CUn6jQSsatsWmYKWdd566CZd1DyFr48hmAufMkTCaNFv/xPWTK 62sJCPF0sOgtxNxI5OZJz1hle/m2Ik6fiUzDrFnaRnwfSkT+IcQCDnwSWh/IwdaTenF2 VDZWrwiBPEZjZDsq8T12ZTz8bTS1xKnA2oMSCkOGvFaKWx/+EUsSO5zU4x/pR+7l5j6z i21A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776495751; x=1777100551; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UiTYFjNnjpdpCtpnDwsxuALR8uSM4iRhQ8ijRVO9szM=; b=EF/1Tw13ggfUSVsia7qRGykN+C9nDGU4pbUEAPzCmVA0cKdpilcdxI+DH1Wi4jMvW4 uN/77E7liAv8gVxQF3Pmhc1BPKIZb5E98HhAusKMslbXZfbpXamKoBe33dwibivu/rMy cQuOfsC6JQSThUzMCME7BXuKbgW5vzmBhKrAJCYwwfNnOh7J8kGf8tP7+ABXtxQNOpOZ +TPwxO71WjmbjjA2VsWWNJdTHcseeo76bSv3WGTkFICWSWkzm1VyHZl4wMN6Gzj63uyW 6QEBUczvnoygjYVsz7s21vxHWKRAfoLGStNTVyWGlaaUM/2zMt3VNZIfiQx9yL0VHHjK /Vmg== X-Forwarded-Encrypted: i=1; AFNElJ92wc3GrcDIsD7Jigu9MLLQRrZrnUW+jn9mtVO9HcgP7G1dyveJXegWpgZ9pJC3TlaQ11ldr+fUkej6Xr0=@vger.kernel.org X-Gm-Message-State: AOJu0YyN2tFAIaSWu4gn8cY8VfhdpwS+gWzfMfOGoIPxdFsMFvp56+Pi KC9s8r4bMJlcNuQ6MYnVsPEm1hgVkuRu5nJsLw0RPZS1UfoXf4LuGXhe X-Gm-Gg: AeBDietg09Z1xgVDjNPYHK5dszwFvQs3TYh4cqi4wlnGSqdfBmjNUJk3tTx1OpqQIvM vaeK2hymqwHsfnC5u6Ywww8VNT38NgOfe/AfEtHAplGR3iQRtl/baKzYsF9+fM3JtED3AmZ9jsb zg9OE51NC3vQjYQbufAMD+FIz10tO316IKzdjgzvQWswNTlucVkrAw+1Pb/fYOB1irFi82a5plD VfQOp2gfrgYtZOIUyrqtRLzd8gD6EYgjPbsKrJ/X6B0KzIv3u7K8c47CGcC+l8jdUGyGBOeBIPf CrLpQryUkWZcaw+77DK0v4FHO/v2MwMhOhx+N2csPshKyyc1q4EWMcOeq7eNKx/mO+I/0tQ1P1P IIVzWGlKIqSarT2zaVaiPKU9JriQ7SsN/dCwKBwtAYK09ltO9jMcaR5eZJltSBLLq8jsiUzR7eW UC/rtzTnPYMABFXQ/mPjgOXt6s1RvNweDNQNzfUtxMzxbn X-Received: by 2002:a17:903:bd0:b0:2b0:4f16:22f7 with SMTP id d9443c01a7336-2b5f9e8d873mr38136045ad.16.1776495750567; Sat, 18 Apr 2026 00:02:30 -0700 (PDT) Received: from lgs.. ([2408:8417:d50:4775:ba08:bee7:5a64:abce]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fa9fedf0sm49448665ad.6.2026.04.18.00.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 00:02:30 -0700 (PDT) From: Guangshuo Li To: Luis Chamberlain , Russ Weight , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Tianfei zhang , driver-core@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] firmware_loader: fix device reference leak in firmware_upload_register() Date: Sat, 18 Apr 2026 15:02:20 +0800 Message-ID: <20260418070220.64542-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" firmware_upload_register() -> fw_create_instance() -> device_initialize() After fw_create_instance() succeeds, the lifetime of the embedded struct device is expected to be managed through the device core reference counting, since fw_create_instance() has already called device_initialize(). In firmware_upload_register(), if alloc_lookup_fw_priv() fails after fw_create_instance() succeeds, the code reaches free_fw_sysfs and frees fw_sysfs directly instead of releasing the device reference with put_device(). This may leave the reference count of the embedded struct device unbalanced, resulting in a refcount leak. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fix this by using put_device(fw_dev) in the failure path and letting fw_dev_release() handle the final cleanup, instead of freeing the instance directly from the error path. Fixes: 97730bbb242c ("firmware_loader: Add firmware-upload support") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Russ Weight --- drivers/base/firmware_loader/sysfs_upload.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/fir= mware_loader/sysfs_upload.c index f59a7856934c..a6dab34b22d8 100644 --- a/drivers/base/firmware_loader/sysfs_upload.c +++ b/drivers/base/firmware_loader/sysfs_upload.c @@ -351,7 +351,8 @@ firmware_upload_register(struct module *module, struct = device *parent, if (ret !=3D 0) { if (ret > 0) ret =3D -EINVAL; - goto free_fw_sysfs; + put_device(fw_dev); + goto exit_module_put; } fw_priv->is_paged_buf =3D true; fw_sysfs->fw_priv =3D fw_priv; @@ -365,9 +366,6 @@ firmware_upload_register(struct module *module, struct = device *parent, =20 return fw_upload; =20 -free_fw_sysfs: - kfree(fw_sysfs); - free_fw_upload_priv: kfree(fw_upload_priv); =20 --=20 2.43.0