From nobody Sat Jun 13 13:01:16 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 756192BD11 for ; Sat, 18 Apr 2026 03:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776484107; cv=none; b=vC3yvfAVC59TZ2BkQDRT9lU/G6I5FZ1s3sA0hoAD61OzU0I/R35xoj+geY1upAVCOSnWdpNlcgTBRr61XNU6gMeZ8KL/+zH0n2NgOzFQzXKrAjKklayLh9hLOXG4nrbS6LAVzBL0JIjohsJHw2eWn5N5QtQuy/tsBqloJclPStA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776484107; c=relaxed/simple; bh=l62WI7Ygy+J0W2/WvRq2MtdPbp3iVD3gSZDmZzAIvbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HdRPnNLNhfx9mA4bqf2Dphv1qwz7UqJF+7npde1FH+cxF0MJJXvIQr2BxflzND6Nxlt1nWl78k3z3eEPVEikLzmoi5u8lFlFetsCXtu4xgWCdX3FXMdzXtm1MwS4hZCuk48yyj8KPJZqcBIU8R5U61N5FKExk2mFnVI0Wy1gIqs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fPKYfilZ; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fPKYfilZ" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c795f096fa5so540741a12.3 for ; Fri, 17 Apr 2026 20:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776484106; x=1777088906; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=joLiL8rHMacEzcwk5prGowFLUmrQwzWzBoDZlkxhLUA=; b=fPKYfilZ4PP/4YeVz93Xm8GYM95I4FJ+Sg/S8srQ0Qm9VTT2Lb5jKQQPYSuJV0KZuy WixARircgVOZO73O5rQodEClZ+bb/SHd33pgE+D1TFYbnpMKnwdigoxG8ebHJzrfDRXn eaETm/i1lwfoe/zK/41fFpvAYaLwkXdanq/7RBNvoLHWXrRk+dTII0hwfPw8Vce4nH8H Nb4MDrduehPROKE0MkIzHL6JY11abvfmS7q7RP9xloAb/lCu0rxHlSCgfa0a+d5UlvkR zR6iCX0maY24MgkqQW9N7FnYXe6k1GJmfbMbgx8ifmLPJjQP6ZNR0r8sSzJBP0HEpNHL sbIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776484106; x=1777088906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=joLiL8rHMacEzcwk5prGowFLUmrQwzWzBoDZlkxhLUA=; b=iVjjTo6Qiz4VP/4atIohbvRCKJFp/kJuN6zfshJwcb/is/sG1al9L8k/OEtLG8aoo/ nu6ZXt5LDqch16xynwme16r2CBKABjlWMbe1NZ9aYYr5iBRfYCXkDcUAGR3RzKzgWXZ4 hWiY37QJ6RMJTZMH46XMkMBJCbwoR+RPNNs45lgCo6iyOdPx3fyvUk+VRbSVsTMQ28hV JfDibaIT8hb8Oad6A23ODreIdQoliFGPhYUykNeV1c6171Lsz+/1UKgxmXNp6UbRSQ8l 4gtcDEoy9Sk9hnHq+R21PCkITQp0qFdJBogh5veyijgqV7mAVISYZfjcg3cEakpa1FHy dJVQ== X-Forwarded-Encrypted: i=1; AFNElJ/358OPG5ThHl3K2bvR2rRj70yjyvukGh+w+UJtkQmaGLGp9vLbshawQWkNHidpKQXr77V/LblEs2dYWkk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+dsZyK1eOHqqe3vy3bF69bGBpDak5wrpgE1PA/IMBpwnYmlHF 30MtMierzSm8TK9vxWW0n3Jkx1+xMz7O1XCv3YmMm6nKZnfRjoxfferl X-Gm-Gg: AeBDietDcBxHuboTNt/z7uFHOV/hUBkzuUeHkfUoh+qBn3mD0BwO8iVchya6xrY0o0X bTb1B1i35clkC2Hc54EmlUTa0vEScdFCPmJgJUWORbNUoieejF+0+5qP2cwakCDg3/WMw882QjJ H4xhgUc3vtS5++aCfIvbEoZqUjvhxiwrhWTUXSoXgQ2wSk9nbUZh7kyPpShGIpucIWPkK0xg80h +asnHOUDVYDThllqGqbCl9CKZgsvtM0rwUQzgdYMFUlZAJWUifs44v0qK5ASdKlvRnc8TlDuSZo hbYvIFmigjv/O3FE1v+o2DGPAVDg/x3c1daHrIJQn458NhfJFnOQ1YqThVr8TGTO7hGCSchBi9U IXe7MrkGARTKnUe9jkhIxqor6YNuc95D7NfYcp4HR0f9ururfAuI7VGPPs8wSednss8YFEw6fQH 688E8ok0qqV7xrADdwOd0OxsXijJDyPn1HcSDX3rBwgyLfXGfUmE18UU6zq8hJNwKFIdT19b+zb A== X-Received: by 2002:a05:6300:2109:b0:398:b346:b13 with SMTP id adf61e73a8af0-3a08d6f1991mr5383337637.16.1776484105826; Fri, 17 Apr 2026 20:48:25 -0700 (PDT) Received: from tabrez-VivoBook-ASUSLaptop-X513UA-KM513UA.. ([27.4.62.72]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ec05391sm3549074b3a.56.2026.04.17.20.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 20:48:25 -0700 (PDT) From: Tabrez Ahmed To: linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, me@brighamcampbell.com, Tabrez Ahmed , Sashiko Subject: [PATCH v3 1/3] hwmon: (ads7871) Fix endianness bug in 16-bit register reads Date: Sat, 18 Apr 2026 09:15:59 +0530 Message-ID: <20260418034601.90226-2-tabreztalks@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260418034601.90226-1-tabreztalks@gmail.com> References: <20260418034601.90226-1-tabreztalks@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ads7871_read_reg16() function relies on spi_w8r16() to read the 16-bit sensor output. The ADS7871 device transmits the Least Significant Byte (LSB) first. On Little-Endian architectures, spi_w8r16() correctly reconstructs the 16-bit value. However, on Big-Endian architectures, the byte swapping causes the first received byte (LSB) to be placed in the most significant byte of the u16, resulting in corrupted voltage readings. Replace spi_w8r16() with a manual spi_write_then_read() into a byte array, and safely reconstruct the integer using get_unaligned_le16() to ensure correct behavior across all architectures. Reported-by: Sashiko Closes: https://sashiko.dev/#/patchset/20260329073352.270451-1-tabreztalks%= 40gmail.com Signed-off-by: Tabrez Ahmed --- drivers/hwmon/ads7871.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c index 9bfdf9e6bcd77..9b52aa496d522 100644 --- a/drivers/hwmon/ads7871.c +++ b/drivers/hwmon/ads7871.c @@ -59,6 +59,7 @@ #include #include #include +#include =20 #define DEVICE_NAME "ads7871" =20 @@ -77,9 +78,14 @@ static int ads7871_read_reg8(struct spi_device *spi, int= reg) static int ads7871_read_reg16(struct spi_device *spi, int reg) { int ret; + u8 buf[2]; + reg =3D reg | INST_READ_BM | INST_16BIT_BM; - ret =3D spi_w8r16(spi, reg); - return ret; + ret =3D spi_write_then_read(spi, ®, 1, buf, 2); + if (ret < 0) + return ret; + + return get_unaligned_le16(buf); } =20 static int ads7871_write_reg8(struct spi_device *spi, int reg, u8 val) --=20 2.43.0 From nobody Sat Jun 13 13:01:16 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D4B92BD11 for ; Sat, 18 Apr 2026 03:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776484112; cv=none; b=nyBYYIviNKk/nt48xirDdOrNeZx30qQPdB/bHZzQpVPCj2FDWIQ3EXGWxialn0egP6bL92UwVzUxQyf2uJWMilpcG2l9uojAvQp8eE7O+5v+lymor5dhxVInYL7X9V2Pt15Bg2vTLxJWZxrc2RnKzN+KYs2gg7wqfFW2FrCnZ8w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776484112; c=relaxed/simple; bh=jACSQHstZVFKbNTavRunskpjWXylElHwETO6kJX5INo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c6TiBGWi0k0r7OsxhRXKaSI+23oASGUM2D0Nad4vEwfd8j0xJIq+kNqySFUXh/KhtvpHU2540LfxlKufVk2FlM32NBo4Ob46PpiXjQNaMRPjnztfSmqGakAX+K0RGnqRk4FoY055BvEYDjq8m1JBvUSPzev3rXS6SGFUqaJiLS0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XZx/umZ6; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XZx/umZ6" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-82f33d28c1dso766093b3a.3 for ; Fri, 17 Apr 2026 20:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776484110; x=1777088910; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GMyfv1bKqxfNWpqWMHaFl3fAcAdpQRPSSvO41ZTDbwY=; b=XZx/umZ6PatfCXfDlT5h5VzB2DBXxtYhe0hHKUFVYPDCowADlsgRaZWN6PPMiMsrzj BhNoxyGlDby2VpNby/4KRqPTa1QOMcWkIljX5knasTn53wZ3SwTlupCrKFfYiVRG/wJX do6pXO8U0RfvHP5DcfNRhjaWzQpu6yAXB2GnkvMNFiFfk1QSt9Ky56jPRePH9AgQb+8v xDlN4yAmvTwy86nYhnK6gxByKEObpOO5wQBjVfHFeTKzw84jBSRAueNFbVkPMRhU2RfN JWU6NweCLBtZtzeD09JllVL/zOsH57/GNQ4LnVJtffxCsWTixD559i644zrUnzxalhbS zBtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776484110; x=1777088910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GMyfv1bKqxfNWpqWMHaFl3fAcAdpQRPSSvO41ZTDbwY=; b=Bt0012O+FYS7OKg5h8RbXkJPZwSdXbgS50JXd0udBsmQ5oHkj5QmXWxLMM/JQRn0gF E2IvZOKmLrGtWLurqOevoVVdIft6a/1SmZt+usO2lybYbAYJIXN1t+OJSOT0SOPSQCzp NmhuQKcsdrQ4bnliZORSeVyKrHpXNP3K8Ud7Ggnc8INbwRoRKRTLlBIiimVkHOU8/rM9 YqcP3sm+ciXOBaxWiAe6alciNn9oRAJsD9NlOSgdFI+VyIukxXwbmJ6b1TaNewcJpXWh L4OZPmpN2tJylFKf8FlM9AZdBBpO474/TypK3zTppMxWqWXnodSrEHz2FkbFzk9NJ+LJ 0aFg== X-Forwarded-Encrypted: i=1; AFNElJ81ZFnkpwoSHWflfdyN3+vZzbB2JJKDfk+WBSolXi9II4ghltYYdGR3WfQpScm5cIpBzYH0yiQ1X3XZgCk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2yeIuXw6zYRNE85s6I8+hr3K0uEGd301NMVvyDhS0pEvUgaeG dfWZ5btBeJBuSu+NpMtH1mlo9dSCrmTm3kk7Jmr7+WuFY2AnRTj52Bhd X-Gm-Gg: AeBDiety+U1+mUl9Vls2rLyCnHV+pqUVYEgd+yktx9bMydn3FQDMTpXc7ERoX43A4Cv mtnCyFqYc1DkQZvYQz5bfW5ee0KESYqh/OwaIzQ/IG42VN8Y1mTp4UFDMDNVNDG433Qhtc8ytJq 2WH8Ug/BbMBkBGVE77r3Xdi5M24ine6Q0AFhj6Xkjl8aGqUsWKvTiQFBBPUj2lFFsh2BwGT9MFX Noht8r2rGL+9ENKpkatHeV+Xju7MoKz/rNLsaIXAyw6pMCn+PN/dAB02legjIwlkNG7y6cBooKd cYYvJDrUEK1+8K8WRBEtcipUaMlx7rJ6t2QnZSWy18KuQsYEcvsZjIuApYd0cwSlEGkAvf3bT1L JECWUzEYVd3MsaGpgdH5kc1xRD/g3Ujxi1zFD69rAzIsDUAPH7E3d3gP3aQIh1iiycS5f/vbhje JdZf1M9l+r6I6QilClpXWuDH7J7KFTa9KMSlYEhJ79BOMQ/KOGdbsxvLGKNOtCihQxspzdV5BgT A== X-Received: by 2002:a05:6a00:17a1:b0:82c:e0d7:2681 with SMTP id d2e1a72fcca58-82f8c8888b4mr5551098b3a.16.1776484110480; Fri, 17 Apr 2026 20:48:30 -0700 (PDT) Received: from tabrez-VivoBook-ASUSLaptop-X513UA-KM513UA.. ([27.4.62.72]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ec05391sm3549074b3a.56.2026.04.17.20.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 20:48:30 -0700 (PDT) From: Tabrez Ahmed To: linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, me@brighamcampbell.com, Tabrez Ahmed Subject: [PATCH v3 2/3] hwmon: (ads7871) Convert to hwmon_device_register_with_info Date: Sat, 18 Apr 2026 09:16:00 +0530 Message-ID: <20260418034601.90226-3-tabreztalks@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260418034601.90226-1-tabreztalks@gmail.com> References: <20260418034601.90226-1-tabreztalks@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the ads7871 driver from the legacy hwmon_device_register() to the modern hwmon_device_register_with_info() API. This migration simplifies the driver by using the structured hwmon_channel_info approach and prepares the codebase for the transition to a shared DMA-safe buffer. While at it, fix checkpatch violations. Signed-off-by: Tabrez Ahmed --- drivers/hwmon/ads7871.c | 75 ++++++++++++++++++++++------------------- 1 file changed, 40 insertions(+), 35 deletions(-) diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c index 9b52aa496d522..851b70e9f6ba2 100644 --- a/drivers/hwmon/ads7871.c +++ b/drivers/hwmon/ads7871.c @@ -56,7 +56,6 @@ #include #include #include -#include #include #include #include @@ -67,6 +66,16 @@ struct ads7871_data { struct spi_device *spi; }; =20 +static umode_t ads7871_is_visible(const void *data, + enum hwmon_sensor_types type, + u32 attr, int channel) +{ + if (type =3D=3D hwmon_in && attr =3D=3D hwmon_in_input) + return 0444; + + return 0; +} + static int ads7871_read_reg8(struct spi_device *spi, int reg) { int ret; @@ -91,19 +100,20 @@ static int ads7871_read_reg16(struct spi_device *spi, = int reg) static int ads7871_write_reg8(struct spi_device *spi, int reg, u8 val) { u8 tmp[2] =3D {reg, val}; + return spi_write(spi, tmp, sizeof(tmp)); } =20 -static ssize_t voltage_show(struct device *dev, struct device_attribute *d= a, - char *buf) +static int ads7871_read(struct device *dev, enum hwmon_sensor_types type, + u32 attr, int channel, long *val) { struct ads7871_data *pdata =3D dev_get_drvdata(dev); struct spi_device *spi =3D pdata->spi; - struct sensor_device_attribute *attr =3D to_sensor_dev_attr(da); - int ret, val, i =3D 0; - uint8_t channel, mux_cnv; + int ret, raw_val, i =3D 0; + u8 mux_cnv; =20 - channel =3D attr->index; + if (type !=3D hwmon_in || attr !=3D hwmon_in_input) + return -EOPNOTSUPP; /* * TODO: add support for conversions * other than single ended with a gain of 1 @@ -133,39 +143,34 @@ static ssize_t voltage_show(struct device *dev, struc= t device_attribute *da, } =20 if (mux_cnv =3D=3D 0) { - val =3D ads7871_read_reg16(spi, REG_LS_BYTE); - if (val < 0) - return val; + raw_val =3D ads7871_read_reg16(spi, REG_LS_BYTE); + if (raw_val < 0) + return raw_val; + /*result in volts*10000 =3D (val/8192)*2.5*10000*/ - val =3D ((val >> 2) * 25000) / 8192; - return sysfs_emit(buf, "%d\n", val); + *val =3D ((raw_val >> 2) * 25000) / 8192; + return 0; } =20 return -ETIMEDOUT; } =20 -static SENSOR_DEVICE_ATTR_RO(in0_input, voltage, 0); -static SENSOR_DEVICE_ATTR_RO(in1_input, voltage, 1); -static SENSOR_DEVICE_ATTR_RO(in2_input, voltage, 2); -static SENSOR_DEVICE_ATTR_RO(in3_input, voltage, 3); -static SENSOR_DEVICE_ATTR_RO(in4_input, voltage, 4); -static SENSOR_DEVICE_ATTR_RO(in5_input, voltage, 5); -static SENSOR_DEVICE_ATTR_RO(in6_input, voltage, 6); -static SENSOR_DEVICE_ATTR_RO(in7_input, voltage, 7); - -static struct attribute *ads7871_attrs[] =3D { - &sensor_dev_attr_in0_input.dev_attr.attr, - &sensor_dev_attr_in1_input.dev_attr.attr, - &sensor_dev_attr_in2_input.dev_attr.attr, - &sensor_dev_attr_in3_input.dev_attr.attr, - &sensor_dev_attr_in4_input.dev_attr.attr, - &sensor_dev_attr_in5_input.dev_attr.attr, - &sensor_dev_attr_in6_input.dev_attr.attr, - &sensor_dev_attr_in7_input.dev_attr.attr, +static const struct hwmon_channel_info * const ads7871_info[] =3D { + HWMON_CHANNEL_INFO(in, + HWMON_I_INPUT, HWMON_I_INPUT, HWMON_I_INPUT, HWMON_I_INPUT, + HWMON_I_INPUT, HWMON_I_INPUT, HWMON_I_INPUT, HWMON_I_INPUT), NULL }; =20 -ATTRIBUTE_GROUPS(ads7871); +static const struct hwmon_ops ads7871_hwmon_ops =3D { + .is_visible =3D ads7871_is_visible, + .read =3D ads7871_read, +}; + +static const struct hwmon_chip_info ads7871_chip_info =3D { + .ops =3D &ads7871_hwmon_ops, + .info =3D ads7871_info, +}; =20 static int ads7871_probe(struct spi_device *spi) { @@ -200,10 +205,10 @@ static int ads7871_probe(struct spi_device *spi) return -ENOMEM; =20 pdata->spi =3D spi; - - hwmon_dev =3D devm_hwmon_device_register_with_groups(dev, spi->modalias, - pdata, - ads7871_groups); + hwmon_dev =3D devm_hwmon_device_register_with_info(dev, spi->modalias, + pdata, + &ads7871_chip_info, + NULL); return PTR_ERR_OR_ZERO(hwmon_dev); } =20 --=20 2.43.0 From nobody Sat Jun 13 13:01:16 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2855257849 for ; Sat, 18 Apr 2026 03:48:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776484116; cv=none; b=mOqmWI0NOGTWtoEBttc3YuHTshEzAroqfKoZVbKjb8jddhB6zE16BnVLJDf/l4OPNBC+H5jWmhXaAQC3+8OyhJlc5kE0SUz1XtJBqPqRod7nZ3Wy6iqBMMgxHy8HqQnZvZWe5Y+UmXQeFBWtx2y1dRC3IONd+WtTAqYqGUx6Ukg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776484116; c=relaxed/simple; bh=KlCZSGoNQ2owu6z4cnzLx9ww+W5qqB0R4s7DRzeFrS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kcYdRNhp7hYlI8uxelQe1FHdmq7FrKU2Wd+laW83OBoar5NE62ATjmH6aDgFyvnT9f2bfFDyLaPnHRISIPx5KpfXpoUghyaC2xF1+p3sUy5ouBOb/E8Js/NnKy73QQbB0ck4ehif5k4+sRt9pI4/fWdBsEaz6nSPmkQJp6yrNOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ojNJKEw+; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ojNJKEw+" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-824c9da9928so681258b3a.3 for ; Fri, 17 Apr 2026 20:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776484115; x=1777088915; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tv/rI+ADctzcEfXSseQ7mhn237mO7KKBrL7JH0PS3mo=; b=ojNJKEw+hCCB+Eb+64Uxfwy8c6mkVACrdaF4Hfsy6pvKear/YBhlLXKXLVdsIjJyIS AWTvUxuRKRIF+PPy1Wj0n39OZEZY4jlK8aR3QaapefyPgmUdM2YoTZ1vmH7jPSFH6xg7 Q60Y+TmIAhwo1mke5NMpz0gdx0FjPmwIc6rbTYGa8BVKgA2iO3VCQTaW3Vn5CunBsH1k ZfMXIYpFGp9hNu9EoM6DMQAY0jyd9qrJnui2hi6xxDC3LDtFaLQA+2XtR6jkZN9vgQNA tkUbU+w5uPXPzpQ+jbyrpH0+z09QYuyQwgHcFRYupSOw8YVFYsNpElHR4Z3gLUHVeLtn EDpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776484115; x=1777088915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Tv/rI+ADctzcEfXSseQ7mhn237mO7KKBrL7JH0PS3mo=; b=a+G0G9Z9RCHjunhFojTd/5UBBNIiC51EEDpveOMJqqKRD9xRKGyKeKcnrNeekJeD8m aDrJ40DJNPt/FRltbo7qxXvXKAUiwNfdP4XTFHylAAc7dsN+ztlWfcPnLmLYJ4zSc/pJ v5cjFyQiCbU+ON2nGjke5VnYhglT2gryP8j8fl2Pv2TjYuaRJsHXW5O0AGShL+NHs1tI wF7KgItJcPk5SyHQpBco9OyTqPvr2tG0cZGhuYPquiEd7vZnzvHSV5DJPm2nWRH4Vwp+ DEX3jcc/c/t66yHypU40M92metrUO0i20UtqrrKct0jMaFk+lD8PIL8kGaOUr8U53lPl pQgw== X-Forwarded-Encrypted: i=1; AFNElJ9GpOChoAtNZNpvjqyMdRSv/LCYnk8HFfYhwtfDuAFgoTXglRCfKtHqzcqc/3HX5dMu+REwurlJfAjSuaA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn6X7QeBQwfOkmHDRWASQdBksZPQ8AQuwgL5HNNq6fQOjQK29M IUqxZ2QDMtfRmdMiWC1QIHicU3ZLCpfGmzp8YBqVL4yA3nFSgZM/iByx X-Gm-Gg: AeBDiesmrczwglm4Q2wwipKTUkm1TP/RSSa8fJ9Mjd65wI+732evCAdFK0e5xnzetwO jMffhkinUlqAhT1p825Jm81nHzK9YncxD+Exsu4yKhznwAaW/7d14Eba59j1ViAwU86ANgODif9 hr+1/Dqi89TLWFJTAJiKDQKJwWqstCRB6iDLxkdtPhzayIvFeGuuJTDX1uxMkpf7OFR7Jtf1lhG gzCFXcgmwIlcHQOWUYlo4s33taMZKr2gEDWrGyYVgrUNBPCQrnUWZy/g+1V5ReXVs5XxCwHQ4Wd vxn0sNiIMHvM0GWWzCovgUfOp+0h/Z3/YC0Q9Q0hcOhA3yp6Vn4YcU15uelkLw9yrdW+qUnLbvl aQiaN9QfKYgi8P4CtlRMnBvQVaGmBKopXIBkmOGLPeTzbTgTS+DeF1OfHYnJMxoWRDSe7I4zoIY kQN21S8q1KrLoRHRSHPXSdelf/G0audO7jLiX+MliYVUHLcmMSw5VK1U0Fdtk+yaqwrhyYN9Mzx A== X-Received: by 2002:a05:6a00:4c0b:b0:82c:e4b4:b04f with SMTP id d2e1a72fcca58-82f8c9d598amr5356680b3a.47.1776484115185; Fri, 17 Apr 2026 20:48:35 -0700 (PDT) Received: from tabrez-VivoBook-ASUSLaptop-X513UA-KM513UA.. ([27.4.62.72]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ec05391sm3549074b3a.56.2026.04.17.20.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 20:48:34 -0700 (PDT) From: Tabrez Ahmed To: linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, me@brighamcampbell.com, Tabrez Ahmed Subject: [PATCH v3 3/3] hwmon: (ads7871) Use DMA-safe buffer for SPI writes Date: Sat, 18 Apr 2026 09:16:01 +0530 Message-ID: <20260418034601.90226-4-tabreztalks@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260418034601.90226-1-tabreztalks@gmail.com> References: <20260418034601.90226-1-tabreztalks@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver currently passes a stack-allocated buffer to spi_write(), which is incompatible with DMA on systems with CONFIG_VMAP_STACK enabled. Move the transfer buffer into the driver's private data structure to ensure it is DMA-safe. Since this shared buffer now requires serialization, this change depends on the previous commit which migrated the driver to the hwmon 'with_info' API. While moving the logic, also: - Corrected the sign extension for 14-bit data by casting to s16. - Scaled the output to millivolts (2500mV full scale ) to comply with the hwmon ABI. Signed-off-by: Tabrez Ahmed --- drivers/hwmon/ads7871.c | 35 +++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c index 851b70e9f6ba2..d0f1eec8effbf 100644 --- a/drivers/hwmon/ads7871.c +++ b/drivers/hwmon/ads7871.c @@ -64,6 +64,7 @@ =20 struct ads7871_data { struct spi_device *spi; + u8 tx_buf[2] ____cacheline_aligned; }; =20 static umode_t ads7871_is_visible(const void *data, @@ -97,11 +98,12 @@ static int ads7871_read_reg16(struct spi_device *spi, i= nt reg) return get_unaligned_le16(buf); } =20 -static int ads7871_write_reg8(struct spi_device *spi, int reg, u8 val) +static int ads7871_write_reg8(struct ads7871_data *pdata, int reg, u8 val) { - u8 tmp[2] =3D {reg, val}; + pdata->tx_buf[0] =3D reg; + pdata->tx_buf[1] =3D val; =20 - return spi_write(spi, tmp, sizeof(tmp)); + return spi_write(pdata->spi, pdata->tx_buf, 2); } =20 static int ads7871_read(struct device *dev, enum hwmon_sensor_types type, @@ -120,7 +122,7 @@ static int ads7871_read(struct device *dev, enum hwmon_= sensor_types type, */ /*MUX_M3_BM forces single ended*/ /*This is also where the gain of the PGA would be set*/ - ret =3D ads7871_write_reg8(spi, REG_GAIN_MUX, + ret =3D ads7871_write_reg8(pdata, REG_GAIN_MUX, (MUX_CNV_BM | MUX_M3_BM | channel)); if (ret < 0) return ret; @@ -128,6 +130,7 @@ static int ads7871_read(struct device *dev, enum hwmon_= sensor_types type, ret =3D ads7871_read_reg8(spi, REG_GAIN_MUX); if (ret < 0) return ret; + mux_cnv =3D ((ret & MUX_CNV_BM) >> MUX_CNV_BV); /* * on 400MHz arm9 platform the conversion @@ -147,8 +150,11 @@ static int ads7871_read(struct device *dev, enum hwmon= _sensor_types type, if (raw_val < 0) return raw_val; =20 - /*result in volts*10000 =3D (val/8192)*2.5*10000*/ - *val =3D ((raw_val >> 2) * 25000) / 8192; + /* + * Use (s16) to ensure the sign bit is preserved during the shift. + * Report millivolts (2.5V =3D 2500mV). + */ + *val =3D ((s16)raw_val >> 2) * 2500 / 8192; return 0; } =20 @@ -185,11 +191,17 @@ static int ads7871_probe(struct spi_device *spi) spi->bits_per_word =3D 8; spi_setup(spi); =20 - ads7871_write_reg8(spi, REG_SER_CONTROL, 0); - ads7871_write_reg8(spi, REG_AD_CONTROL, 0); + pdata =3D devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (!pdata) + return -ENOMEM; + + pdata->spi =3D spi; + + ads7871_write_reg8(pdata, REG_SER_CONTROL, 0); + ads7871_write_reg8(pdata, REG_AD_CONTROL, 0); =20 val =3D (OSC_OSCR_BM | OSC_OSCE_BM | OSC_REFE_BM | OSC_BUFE_BM); - ads7871_write_reg8(spi, REG_OSC_CONTROL, val); + ads7871_write_reg8(pdata, REG_OSC_CONTROL, val); ret =3D ads7871_read_reg8(spi, REG_OSC_CONTROL); =20 dev_dbg(dev, "REG_OSC_CONTROL write:%x, read:%x\n", val, ret); @@ -200,11 +212,6 @@ static int ads7871_probe(struct spi_device *spi) if (val !=3D ret) return -ENODEV; =20 - pdata =3D devm_kzalloc(dev, sizeof(struct ads7871_data), GFP_KERNEL); - if (!pdata) - return -ENOMEM; - - pdata->spi =3D spi; hwmon_dev =3D devm_hwmon_device_register_with_info(dev, spi->modalias, pdata, &ads7871_chip_info, --=20 2.43.0