From nobody Tue Jun 16 10:11:27 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB112175A91 for ; Sat, 18 Apr 2026 00:43:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776472988; cv=none; b=VXQfht+1zW1I+FeqZCyi1qo3Z3xNHy4GrMz9SY506KAvJtpqqEgs3d8olejRR7D/bxxwEPgFES5cE/fS9CaGiXGHLZwrVCqQ9zLgx5KhskV4MVZ7l9hO4o07Bj1tGpyH5FNKxABXzadt8GEGqB39EhG519Q9D6pCE/hD8/7wQJk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776472988; c=relaxed/simple; bh=AJMBkoH3WQnihpq57wIE9dMpIQhQKm8cZs6NWWcEJDw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=deaiSbQ/5EWOuafi7qf7mkDHpWd4Pb3/e2sIdcduF4ww/LdRacnz45KtKq9Ygu+KIrhxOw5M8Sw/azah85NnQtjjlNdKRDt4ng51pWBRd/k9P6odponKTgGzYL9kiLw0m6i/0Sd8CqokaFVjYzIuZnFMB58oYY1eQQoDjK/B/MM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZlNgHop2; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZlNgHop2" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488b0046078so11613865e9.1 for ; Fri, 17 Apr 2026 17:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776472984; x=1777077784; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Be+f4m8FGLJ7B2IMiGCObbiaQ4SmkheCMfMOaehd4dM=; b=ZlNgHop2rBE1UqQaBnRGrHa2NLsozS9sSvgYXoQYnUautHy3lvinJawjNs9aoGJ93Y J1N5qZTt1PpSquY5mhOgrSaERvelB3TZb1dx6BcZN8cJ+nR60QMUfvUw2tS94YkGZrdN DGvU5g9F1OI3JLs+87f+pOMexPgoOaS1WWsCSSGiMxrP9Wxsn4aIhNSx9QusinKN9ReT L7jc20YLwbPL7mSTbNTZvYceT01hr41yr6DQ05iLD7KvECStK6eGB6ocyYHwENW++yAC ZXJux51qvK+cA0MRWGwwTjxxbgVAW8sRD0KTyRJnYiBM0Z+HZvlaAThzVnL3HxczgyV3 odJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776472984; x=1777077784; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Be+f4m8FGLJ7B2IMiGCObbiaQ4SmkheCMfMOaehd4dM=; b=c+Pn9k2Mkbh/7lYgBaEbbs2Ysf9KlQqZ/CvgTDcYJboBMEWOe8rCr2nJ6jYF6mv4p0 surMwEeF4CVRxevpvmq+AMkPPRoOM6PJ6HYPBFROKpXSLC1BetwqRM6ljvFoYtaPC69V YLKNELWgVS/IAcj8rbGiLbE7U0vb3Y/bQ5nRdpeTK4JV3fy8q4/nEJKGokl2fYNgLcQt pn/wZBXmxuXMQW53PcmsU8cAitLe2gEJnQSQQ2InidxDDdBisYg72GibuaR+pzXRcCUB TiXjQXqbjPuwRd6Qpr9HwcCRFFAm7/DBDbG61nOOP4MmNCQN/pestiKTPRyLoXP1S/gy RDhg== X-Forwarded-Encrypted: i=1; AFNElJ/4AEfEayoEbmC3za9sKotQPMGCjaiXno13qccF3PSH+KAGkYMFpJOuwXm5iuz+sXhZDBv12l2OZx7VMLY=@vger.kernel.org X-Gm-Message-State: AOJu0YxIe+wLJVfn0LqRgHJ/oKHQ1I1qeYumAlE66BDsQ9VWcsbtjNIs bMiVqfT57JVAafJY+t5GS+ww+2MxU+R/AtIUOQaSS0C0xuP+0tCwfJ/k X-Gm-Gg: AeBDietop46XCiqW1xEtwg+ywYavAuNyZNGwA3N78XOLr4b8YptuhjWXI+TBgZDE2jp cbNDp0O1Q6Wfn/GVaXj08cSEM4ovCWMIXMRE8C2jmAeq+6FA3Tb1FxE2Xtaqpq0w/f4Jv1sB+RF eEfTcScB3r+CseCciv96GpUXyMOdBPdl34PFY0WczPC1CGxwLfqCSOilnSsB5SsJ1GKVj0gAVFJ LH1IaFvxXAadz/J+EgsQ5ZSeQKvvQvHuiXWGszMwyfH/IGK6cufaXo1qU0kKkan2zZk6sK+b3eb Hneb+Kbx0gYRadJ4tPcGU2/wYHvE1I55W6SK2QCMcJalPxUv7wfHM0qduFuuEsOaIaRZGxPqXYL 8aeV0IJKcFXqvPaTiq8fMJraWpTrawn8PLvwfa7yimRpYp962jXtt2UHWEqUZEFvagG01/Hc01S +2oR3a63ZiApHDwRsaZntGXWNK/a6EKcza2iBk6spNPejnDUR0sThFyzZlD7Ajn0sFp2FTqbbF2 zkGhXbJJSyoa/0Tp7r82OyCDg== X-Received: by 2002:a05:600c:b90:b0:488:b99b:4177 with SMTP id 5b1f17b1804b1-488fb78ee4emr67336305e9.25.1776472984028; Fri, 17 Apr 2026 17:43:04 -0700 (PDT) Received: from reolab.localdomain (static.32.225.235.167.clients.your-server.de. [167.235.225.32]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb78cddcsm39002005e9.4.2026.04.17.17.42.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 17:43:03 -0700 (PDT) From: Amir Mohammad Jahangirzad To: johannes.berg@intel.com, halves@igalia.com, johan@kernel.org, kees@kernel.org, mingo@kernel.org, swilczek.lx@gmail.com Cc: linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Amir Mohammad Jahangirzad Subject: [PATCH] wifi: libertas: fix integer underflow in process_cmdrequest() Date: Sat, 18 Apr 2026 04:12:47 +0330 Message-ID: <20260418004247.368944-1-a.jahangirzad@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The existing validation only checks if recvlength exceeds LBS_CMD_BUFFER_SIZE, but doesn't check the lower bound. When a USB device sends a response shorter than MESSAGE_HEADER_LEN, the subtraction (recvlength - MESSAGE_HEADER_LEN) wraps to a huge value, causing memcpy to corrupt the heap. Add the same lower bound check that libertas_tf already has. Signed-off-by: Amir Mohammad Jahangirzad --- drivers/net/wireless/marvell/libertas/if_usb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/w= ireless/marvell/libertas/if_usb.c index 8a6bf1365..42d3fd32e 100644 --- a/drivers/net/wireless/marvell/libertas/if_usb.c +++ b/drivers/net/wireless/marvell/libertas/if_usb.c @@ -625,9 +625,10 @@ static inline void process_cmdrequest(int recvlength, = uint8_t *recvbuff, unsigned long flags; u8 i; =20 - if (recvlength > LBS_CMD_BUFFER_SIZE) { + if (recvlength < MESSAGE_HEADER_LEN || + recvlength > LBS_CMD_BUFFER_SIZE) { lbs_deb_usbd(&cardp->udev->dev, - "The receive buffer is too large\n"); + "The receive buffer is invalid: %d\n", recvlength); kfree_skb(skb); return; } --=20 2.53.0