From nobody Tue Jun 16 10:11:27 2026 Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ADBF27CB35 for ; Fri, 17 Apr 2026 21:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776459756; cv=none; b=npvE47Rj8HQdwS9XmDdqvy9e/Y1G/UsdEmIAYJBMHRKE0olhQHLmhjzS1tMdK3piThipwkv5DkY7D4TQDi1P5Iu9byciJQrD+bYh4SSylVKeFxE43J65nXpQ4MneNtpChN/3Em3MXZH3TKNzIG9DOSp5bKuO7CIhJOzCpH5yFY0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776459756; c=relaxed/simple; bh=n/dAZp2QEWFwelLKkJvUuH9OdyDrpa0B0cYnhOlrASM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=JROIrEiUM2gcU71kmCW3fd23w2xEa6BT38A181qhA06egRzo4SY7VH/8HAYLmE5KZb+9i8ea/a2jHjtnUEtKIjIehIE1nkz65GCbw0DH94yXJoLkOEBX2bbOann+nqFTkInruXf3EMjG2YCHssEyfuTWf3iUBxcurBzEMKqJeAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=TFMTaKyK; arc=none smtp.client-ip=209.85.214.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="TFMTaKyK" Received: by mail-pl1-f228.google.com with SMTP id d9443c01a7336-2aae4816912so7405965ad.2 for ; Fri, 17 Apr 2026 14:02:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776459754; x=1777064554; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4IlWUqFFMsgdGDEhE7tusFb33eRjEXTf5yDuw4u6ujk=; b=IlyX6TyLwivSeSY4VjhzVCVycrISBsPMuHaG989/iPmLyN+UZqjMA1gUhwmeLbjOWB xuDR83Imix7eqzZ4zBwLoFUJq6gQpGvFKHXHSMJxh2O5HmCVyrdiwzOw9zOKv3mX4BX+ x2fqEIyN6SCAbnD5bpkuy6wV9uWr/jctPg2aaCrOXiBdjh96i1YjtkpryrG82Sci6LME jBZwZnBQfSfcCJKCsQ9aU9m8rkmtW+w7RvLmNxhsyqQGYd+tsJEYmM9H5HeNCI4WFV9P 4XvNybbDDgnW5FgceAbiSQzRSy99mASwnq9xhp4Q4JQyBwMvO6S897626BQq1PuXFPN5 Ww4Q== X-Forwarded-Encrypted: i=1; AFNElJ/jNWoVMf25H3WZolM/BnzFTxUZS81U3JshJH7R5mLOH81hd3oegnNXFHx8+pnIpLMpgUOnljWhVyzXf90=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+Rbv4R7KuOOKCvVGndqno9BZDOWN/lOfiVPzbJxM+RH8tmj1D QSVypEFXvmRIXQ5lxmWOnSVOl+TKPalA4/byqxlq9t6ZH6HZLIkOJBRvzgGjbZXblh+/vOxv2MG /N7HBoQiv9USAzjxAadJptH/eBd6L/k++bke5oZsffpDbThJzfS8baYJo3IYKmuetdantz697rT OIEDAOLwSMZd40CTZKBYInxXaPAkTmKk1OFJJ85FLL1kZWbO15hZaKfjvh5Iq4Hclqz/si3xQw4 JRL2v6ebG99oWAe X-Gm-Gg: AeBDiev7JuJaLIqom/da6XnuocjHEPb6blx8g5nZLwUeXeolj9GcfXsos/30pWdUDNX CFB26VxQ8rzqnDbc8yIpmSlFfF+WooNAXRLBkQ2sHHkm7QTKIl9w9uypcaU1ptK3qA5qGCOrhNY FAjmFfVZmJg6ve+/QPBMy7xg36F/Dn6KIAG8Po6ZrHZSsiFA2k7ijvTzFnv2ENKNnqUnqyg3yS1 rk5XSNedKEW6hKQh/Koul/8Y7Lsmp7EoljRD0oqd6BhllwvdfuKo2gQTZpCbsC4fe9Y8AP47K0V wApwh4NTmL3C90vWhJOZXBXC7A+jYkRgKUr5VLUf6hNA1bkyGGWFxDXl5NKtGmoj1Aq1do4QyKG H1ZOwF3HJXJzCR25JSKJC/1alejTLLHA7up9G0AFIZl8n46xMZP8vcQ1NMv3rrFsV6j4ofQn8Eo TmihCYJCI1rUoQ6EQI7Q2gQQISwrtFaaZBvZFLF5sF3g4GDJaX6+iPt+enHKx4HkNj X-Received: by 2002:a17:902:f9cf:b0:2b2:50e1:f104 with SMTP id d9443c01a7336-2b5f9e64c18mr30600325ad.3.1776459754451; Fri, 17 Apr 2026 14:02:34 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-24.dlp.protect.broadcom.com. [144.49.247.24]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2b5fab113f4sm1880455ad.45.2026.04.17.14.02.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Apr 2026 14:02:34 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-12c66fdd4aeso2137038c88.0 for ; Fri, 17 Apr 2026 14:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1776459753; x=1777064553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4IlWUqFFMsgdGDEhE7tusFb33eRjEXTf5yDuw4u6ujk=; b=TFMTaKyK2Ep8C0fkaDswcIYB3Y1b0yzA5hz6yF+4CqdUtWNoA2KKLpq6ggIiVHJChS RuSMlMa5dmaAP0wfdx8/tP/CL7K752tq2ZA4VOM53cCKMCEDZqQGH4MTQERCYWVowxbf j2MxmC+hgrysK+8wSUIpwq5z4AS7s7EGhWTI0= X-Forwarded-Encrypted: i=1; AFNElJ8RwxTmpApJx07touF2TWNvoqy5zO9Hb9WPNgjuvl/lB/YbgBT4lx8AB58sJdCTk+ouBSs1n4xsE2WMiHY=@vger.kernel.org X-Received: by 2002:a05:7022:90a:b0:127:33e0:ea40 with SMTP id a92af1059eb24-12c73f7fbaamr1852103c88.15.1776459752558; Fri, 17 Apr 2026 14:02:32 -0700 (PDT) X-Received: by 2002:a05:7022:90a:b0:127:33e0:ea40 with SMTP id a92af1059eb24-12c73f7fbaamr1852085c88.15.1776459751948; Fri, 17 Apr 2026 14:02:31 -0700 (PDT) Received: from mail.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e539fa5c86sm4617161eec.1.2026.04.17.14.02.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 14:02:30 -0700 (PDT) From: Kamal Dasu To: Ulf Hansson Cc: Wolfram Sang , Avri Altman , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Kamal Dasu Subject: [PATCH] mmc: core: fix host controller programming for fixed driver type Date: Fri, 17 Apr 2026 17:02:25 -0400 Message-Id: <20260417210225.3101961-1-kamal.dasu@broadcom.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" When using the fixed-emmc-driver-type device tree property, the MMC core correctly selects the driver strength for the card but fails to program the host controller accordingly. This causes a mismatch where the card uses the specified driver type while the host controller defaults to Type B (since ios->drv_type remains zero). Split the driver type programming logic to handle both fixed and dynamic driver type selection paths. For fixed driver types, program the host controller with the selected drive_strength value. For dynamic selection, use the existing drv_type as before. This ensures both the eMMC device and host controller use matching driver strengths, preventing potential signal integrity issues. Fixes: 6186d06c519e ("mmc: parse new binding for eMMC fixed driver type") Signed-off-by: Kamal Dasu Reviewed-by: Shawn Lin --- drivers/mmc/core/mmc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index 8846550a8892..3507a8d8610a 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -1371,8 +1371,12 @@ static void mmc_select_driver_type(struct mmc_card *= card) =20 card->drive_strength =3D drive_strength; =20 - if (drv_type) + if (fixed_drv_type >=3D 0) { + if (drive_strength) + mmc_set_driver_type(card->host, drive_strength); + } else if (drv_type) { mmc_set_driver_type(card->host, drv_type); + } } =20 static int mmc_select_hs400es(struct mmc_card *card) --=20 2.34.1