From nobody Tue Jun 16 08:55:54 2026 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C4D2358394 for ; Fri, 17 Apr 2026 16:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776443585; cv=none; b=ZpZ7xf+Aq8IkQ95Q5tHnnN0vXWrt9eXdbBcmVauU3lkShZ/EDsQ261y0oAEr/gtbLsbVc8T5DgSke9nRAL+PyelcU4HxqmhDtunHnjvEbvyX4//0VTRJmF37KQwjlSz0vtAfOjZgB0mxFPEFQpz2AZczwNHD0l+t7sYXiDv3tIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776443585; c=relaxed/simple; bh=+075GOoyLbd5S34H1HUCr/nG7KpOcOATM4+CPgFOnJs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MkEYpUsdjM98GvTeUu5L7j3HqWhABojbREb3/8CaC6KpOpMaLgEOtzoyrrEQ/cm20xTEWTgIZCOII+hzzhUgYhPfhgXvuckVR+lQYEZcsEr4FUHDAR+z0dbwjenV9Uf8qx14nQ7snMK2/9APHF8+CJ9AaD1IzfoS/cEE7PlyL+E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ClKPsrUS; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ClKPsrUS" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-12c726c30efso853965c88.1 for ; Fri, 17 Apr 2026 09:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776443582; x=1777048382; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yX+MCrL59z+GAPTCkuU/G/y2YHYVEKPhhbS8nU432oc=; b=ClKPsrUSsq+hitrgPAFzWIzs1HBzbZe8jyNtnZ6Sl2sbKeni2jWVys08nOfi+zw3AK iS2reSjObf6d8V8R5Hdq06k1lMvwG+F3GzJGnLIOeT95+ye/vSwmNjynZ3pqddp0g8Y9 faiK7zlG+7WU9ovWzb+FclAkGMUswMEZwpAH1ROZq1QjGaL5nbCkfbl9rwlr5WqOe7Ir n753fcdjMsIvye7avBN28Uzw1EKckLXCgNkWfmAzBjAvD21vRY+gyVVXsaZVztlgLrvA ljqk18uxcb2BVF+U5+Mztr8wvxSaJ7X3MuNahjHAYQcVzaYZkG26IrMQzE2ybv5QrfTL pvqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776443582; x=1777048382; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yX+MCrL59z+GAPTCkuU/G/y2YHYVEKPhhbS8nU432oc=; b=ltbnmcK7hYpwKVOIFafluXLPppNfMOBMeqnne3i+dA0PMlPmVbfA4Ivi9T03ORI6tP eJjzMfdQGuWJSAcs9KaV2iTFr+CGLpOJWIrnWtv63Ds3FK40YU72KISSqqKF7+ROfFbv MKDLHum1/vXwgXe6lHOJy7kduus7apF3ZMRQrefPU8FvXVjEfaEg1uIuc0Zt8iIE5vdT xe7xbv7bP4+NrKWQTvS+oDUsGtkq9+TgbXjaSQD8Sp2WWOLzZmHAGZRWjq2GWOrkpLKW sQ/lNHrVT1ShaA9pzSnBDUvZvlW2dLmcm3+HExqXzkGCJqEf5kP1IJUlVBeh9QiVSlZY AvKQ== X-Gm-Message-State: AOJu0Yw5x6+plPchxTS7hS50DCKSJok//u2vWhRujQh3snOg9qaShL/a tzlj9Avvv8qHsySn1bongMCKYFRsqgTn57unvFUAsDfhmPaCLLgQ4KRzHHw32bpm X-Gm-Gg: AeBDieuTMDSku/3URismGZ0KNTOXpmgamtZIy0AhJ3kQKabMm3X4y99IC15RbdVUL7Q 0rWGf6QfhZD23f0Dhbq5kuBN1KYpW7ZENle6XZ9l0UOh6nDD7Ba0wyS2oBq9TBaAbpByqD0i0nJ arH5qFqo12+/4h/3rUcrOpHpeW075/H2XeQIUSQ+XJSDuOoutPsXRgiwhajX3ZQ+Ipns1OSnNCs IfyJjpwhFQlBN3oL1ABVaYCRlOvjP4lUiirNBRGi+XUaNu9VxXyHB8uxFyNfxNeD2AWG+XAWiEW FRaRi+9Uiej0AYwQCam+IMpwm3QDC4MyIeA8zZdbPIdPPTttJUq+fJfVPDDjwxEj7StM3ZplsLI Ned8EuWMZR3avpyvOj5Qizokx4Il4f+3QuJbvsGzALF0m8yy9KvzcG+IBgK6BTO2xrlgLaQB4Ym rHRGeKtRX00nmtheEv3JLsaAmuO9Juu2SUIAFshIAKW6ytlcAyemiYAhWZklCT+BDL9P13oA== X-Received: by 2002:a05:7022:1282:b0:122:33e:6d41 with SMTP id a92af1059eb24-12c73f975e0mr1490067c88.23.1776443582098; Fri, 17 Apr 2026 09:33:02 -0700 (PDT) Received: from TC-LAPTOP (23-93-157-142.fiber.dynamic.sonic.net. [23.93.157.142]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c749dc86bsm3603777c88.8.2026.04.17.09.33.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 09:33:01 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v3 1/5] platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285 Date: Fri, 17 Apr 2026 09:32:48 -0700 Message-ID: <20260417163252.15603-2-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260417163252.15603-1-tchatard@gmail.com> References: <4ef5f305-0234-4193-a190-edbfe770ea04@kernel.org> <20260417163252.15603-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Dell Latitude 5285 2-in-1 has a BIOS bug where the ACPI GEXP device and the I2C4 controller (INT3446) both claim the same MMIO region via the shared SB04 variable. This causes intel_lpss_acpi to fail binding to I2C4 with -EBUSY, preventing the front camera (OV5670) sensor from being registered. Add a DMI quirk that selects IGNORE_RESOURCE_CONFLICTS for INT3446 on this machine, matching the existing pattern used by other LPSS quirks. Signed-off-by: Thierry Chatard Reviewed-by: Hans de Goede --- drivers/mfd/intel-lpss-acpi.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c index 63406026d..7d0964848 100644 --- a/drivers/mfd/intel-lpss-acpi.c +++ b/drivers/mfd/intel-lpss-acpi.c @@ -13,6 +13,8 @@ #include #include #include +#include +#include #include #include #include @@ -52,6 +54,15 @@ static const struct intel_lpss_platform_info spt_i2c_inf= o =3D { .swnode =3D &spt_i2c_node, }; =20 +/* Same as spt_i2c_info but with QUIRK_IGNORE_RESOURCE_CONFLICTS for Dell = 5285 + * where ACPI GEXP device conflicts with I2C4 (INT3446) MMIO resources. + */ +static const struct intel_lpss_platform_info spt_i2c_info_ignore_conflicts= =3D { + .clk_rate =3D 120000000, + .swnode =3D &spt_i2c_node, + .quirks =3D QUIRK_IGNORE_RESOURCE_CONFLICTS, +}; + static const struct property_entry uart_properties[] =3D { PROPERTY_ENTRY_U32("reg-io-width", 4), PROPERTY_ENTRY_U32("reg-shift", 2), @@ -172,6 +183,16 @@ static const struct acpi_device_id intel_lpss_acpi_ids= [] =3D { }; MODULE_DEVICE_TABLE(acpi, intel_lpss_acpi_ids); =20 +static const struct dmi_system_id dell5285_lpss_dmi[] =3D { + { + .matches =3D { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5285"), + }, + }, + { } +}; + static int intel_lpss_acpi_probe(struct platform_device *pdev) { const struct intel_lpss_platform_info *data; @@ -182,6 +203,17 @@ static int intel_lpss_acpi_probe(struct platform_devic= e *pdev) if (!data) return -ENODEV; =20 + /* Apply IGNORE_RESOURCE_CONFLICTS for I2C4 on Dell Latitude 5285. + * The ACPI GEXP device conflicts with I2C4 (INT3446) MMIO resources + * due to a BIOS bug where both use the same SB04 variable. + */ + if (data =3D=3D &spt_i2c_info && + acpi_dev_hid_uid_match(ACPI_COMPANION(&pdev->dev), "INT3446", NULL) && + dmi_check_system(dell5285_lpss_dmi)) { + dev_info(&pdev->dev, "Dell 5285: applying IGNORE_RESOURCE_CONFLICTS for = I2C4\n"); + data =3D &spt_i2c_info_ignore_conflicts; + } + info =3D devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL); if (!info) return -ENOMEM; --=20 2.51.0 From nobody Tue Jun 16 08:55:54 2026 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B2FE35C1AE for ; Fri, 17 Apr 2026 16:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776443587; cv=none; b=GZJwARvVWDscfrFE0QYl1pd0quWWGokCSWUtNXLw7MG9XYCCd/wT9nUkip/iGIu0HKGa0XehH4+wYTcD0tnf6/RMZvPfskba3m64B4Py1yC7BeM9e+sgqeT6A3bdmZjRWgJTL1psTJqVLaOBdj+FJH6qe8OY6ogvCubxuLTlbeA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776443587; c=relaxed/simple; bh=Cu1Qzmws012BXnI1eTEAw1sw3l4dPj+7XQhUK50WAm0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hs9V8RpUHMMYV38aPrFt2C1vVPJxz5qrgQCBf93qvB63SUXSCys5sm/j8pWiQ++zNQZ57FHQo/ZYR8xuwcnl7rjPdP77rJjD38mDyTR47x6/Cd1UyQaUyf91T5etJeanvB6m+13l0qhtDD+7o5uI62pVaPqRGS8tVQoolKv+U8M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VXBeNk5i; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VXBeNk5i" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-12c565dd3a7so1314960c88.1 for ; Fri, 17 Apr 2026 09:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776443584; x=1777048384; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+lDBm8n8fJvrsOswm79MFjtCZT25fXo9SM2Tx+0mY14=; b=VXBeNk5ik3eQP1muaXlgiq/5III6uvCaZTOm0JPvIowMBGdSw6xpNxb1zymgVWPhc/ ooVy9tFpjVkOCwh6qYz3FzLxmeu67GCfYPoW5ym2MdseeBk1808IizuMd45ug0zFnvVm eGxEsaTmLrZaZGX2GGpZkKtemNRCeT4c+fJOqyWydSevvareH4Ufiei/JDJccknt6UmU NX/VQpNUtoTdtZ9E3b+5l4EKf56lBC5RFVEXO2+WewMdj7eNsRnvN7QsOtQdXb2/uxOy J/W69Nlg8bpoQ/vc1DKz2Bv30ZWBpXhDssDP+NoIjd32ayVA/QE3zCkc3G9u/BsCL6iH ptnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776443584; x=1777048384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+lDBm8n8fJvrsOswm79MFjtCZT25fXo9SM2Tx+0mY14=; b=lm13bU7P1qBWmPZPxZhqIyhtR/4B1QDN4v8gJJOLdmHy6iYJ6Y05FcTEbvaPgTcfO+ HrgLW69dewIJmP6vPlBtCsZpcR6vRaPvolrfNYydkKkXGBm7PXzsiXrus34Fgna40cfw 7bXU1rkeU97ZdlSJebL28J0LTN0doLkvOLua82diMkxpYY2gGuXbev8V8QjQZP8gtJmP Ao015GA72RzXmYQvIwhdatUp73KwJZ812YbIQ6lFqetfYnONcYx1Bsg2TvbVEh6sE5Zz UWEX1kngjHiFO0VlXzMrTzDly9CRv9WV8OX3AdqivykzYXV4zGYnU0DeAPlBR7baEeDM rhuA== X-Gm-Message-State: AOJu0Yy+K025eFBEcUeArsKPuOXnkLV5k0O0v0KoQA1A5T6Zf2uMFwZg g71GFN1ErVMMMbVq1D9SmKSkK5XyTbeZb41hzNTcE3bbeubcToXIjfnS/NRxbt56 X-Gm-Gg: AeBDievitHK1jOuV6DpNd9KhUidLfDMvn8EFeb934/heKsexTfAmQWLpI1P5dHb+llD VJ4f26IIvIVTHaOd+uMcWSRzo9rdtRYuM2VTKCOZxflI4GI15xFiPqxRj9A5vGqmk2CO2xxvVyX RzjcTARzicdkJFjGq+ubywRpNBF0kmedTOBjG3gA9wQ986NGB/qfxt5YN16XPhwZkFJ2iLjw433 gWNep9mGwQXIL32vXIOLV2hhKKCV6p8twzcqd3dQZuxn8f9qYqufLSNgCjqfvau4dV3ODOQiEIy pqZD/pn1vSKAROo3u+ZPEGtp0DOj5qMhv2okkupa5M5xwabyMpAqfX2f71ezF7AnHUvWCsulvpr 0q4KGYlSMsPdNJOSEaMQUCR/QkfRZO8YFvy2lyKhOh1xeFlz+xriS2ryzCksAJoW5HkCnaPu1qt 4/hwRATlVwQpIZfNoRu50b863U37AjBE84QOzrEhI8sMa9tnrBvleHN1LPqZxx4icyG2CRJA== X-Received: by 2002:a05:7022:383:b0:12b:ebb9:1c18 with SMTP id a92af1059eb24-12c73fa739fmr2082866c88.31.1776443584133; Fri, 17 Apr 2026 09:33:04 -0700 (PDT) Received: from TC-LAPTOP (23-93-157-142.fiber.dynamic.sonic.net. [23.93.157.142]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c749dc86bsm3603777c88.8.2026.04.17.09.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 09:33:03 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v3 2/5] platform/x86: int3472: tps68470: fix clock consumer registration for Dell Latitude 5285 Date: Fri, 17 Apr 2026 09:32:49 -0700 Message-ID: <20260417163252.15603-3-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260417163252.15603-1-tchatard@gmail.com> References: <4ef5f305-0234-4193-a190-edbfe770ea04@kernel.org> <20260417163252.15603-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The BIOS on the Dell Latitude 5285 leaves GNVS field C0TP at zero. With C0TP=3D0 the ACPI _DEP method on INT3479 (OV5670, front camera) resolves to PCI0 instead of the INT3472 (TPS68470 PMIC) device. Because for_each_acpi_consumer_dev() walks the _DEP reverse-mapping, INT3479 is invisible to it: the clock consumer lookup entry for the front camera is never registered with the tps68470-clk driver, and the OV5670 sensor driver cannot acquire its MCLK. Fix this without touching ACPI tables by adding optional static clock consumer fields to struct int3472_tps68470_board_data: unsigned int n_clk_consumers; const struct tps68470_clk_consumer *clk_consumers; When board data is present and n_clk_consumers is non-zero, probe uses the static list instead of for_each_acpi_consumer_dev() to populate tps68470-clk platform data. Platforms that do not set these fields continue to use the existing ACPI traversal path unchanged. The board_data lookup is moved before the clock-pdata allocation so that it is available for both the static and dynamic paths. Signed-off-by: Thierry Chatard Reviewed-by: Hans de Goede --- drivers/platform/x86/intel/int3472/tps68470.c | 29 ++++++++++++++++--- drivers/platform/x86/intel/int3472/tps68470.h | 10 +++++++ 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/tps68470.c b/drivers/platfo= rm/x86/intel/int3472/tps68470.c index a496075c0..3364ef428 100644 --- a/drivers/platform/x86/intel/int3472/tps68470.c +++ b/drivers/platform/x86/intel/int3472/tps68470.c @@ -155,9 +155,31 @@ static int skl_int3472_tps68470_probe(struct i2c_clien= t *client) if (!adev) return -ENODEV; =20 - n_consumers =3D skl_int3472_fill_clk_pdata(&client->dev, &clk_pdata); - if (n_consumers < 0) - return n_consumers; + /* + * Look up board data before building clock platform data. On platforms + * where a sensor's ACPI _DEP does not list the INT3472 device, + * for_each_acpi_consumer_dev() misses that sensor and its clock consumer + * entry is never registered. Board data can supply a static consumer + * list to use instead, bypassing the broken _DEP traversal. + */ + board_data =3D int3472_tps68470_get_board_data(dev_name(&client->dev)); + + if (board_data && board_data->n_clk_consumers) { + clk_pdata =3D devm_kzalloc(&client->dev, + struct_size(clk_pdata, consumers, + board_data->n_clk_consumers), + GFP_KERNEL); + if (!clk_pdata) + return -ENOMEM; + clk_pdata->n_consumers =3D board_data->n_clk_consumers; + for (i =3D 0; i < (int)board_data->n_clk_consumers; i++) + clk_pdata->consumers[i] =3D board_data->clk_consumers[i]; + n_consumers =3D board_data->n_clk_consumers; + } else { + n_consumers =3D skl_int3472_fill_clk_pdata(&client->dev, &clk_pdata); + if (n_consumers < 0) + return n_consumers; + } =20 regmap =3D devm_regmap_init_i2c(client, &tps68470_regmap_config); if (IS_ERR(regmap)) { @@ -176,7 +198,6 @@ static int skl_int3472_tps68470_probe(struct i2c_client= *client) device_type =3D skl_int3472_tps68470_calc_type(adev); switch (device_type) { case DESIGNED_FOR_WINDOWS: - board_data =3D int3472_tps68470_get_board_data(dev_name(&client->dev)); if (!board_data) return dev_err_probe(&client->dev, -ENODEV, "No board-data found for th= is model\n"); =20 diff --git a/drivers/platform/x86/intel/int3472/tps68470.h b/drivers/platfo= rm/x86/intel/int3472/tps68470.h index 35915e701..4aefb728e 100644 --- a/drivers/platform/x86/intel/int3472/tps68470.h +++ b/drivers/platform/x86/intel/int3472/tps68470.h @@ -12,11 +12,21 @@ #define _INTEL_SKL_INT3472_TPS68470_H =20 struct gpiod_lookup_table; +struct tps68470_clk_consumer; struct tps68470_regulator_platform_data; =20 struct int3472_tps68470_board_data { const char *dev_name; const struct tps68470_regulator_platform_data *tps68470_regulator_pdata; + /* + * Static clock consumers. When n_clk_consumers is non-zero these are + * used in place of for_each_acpi_consumer_dev() to build the tps68470-clk + * platform data. Needed on platforms where a sensor's ACPI _DEP does not + * list the INT3472 device, causing that sensor to be missed by the ACPI + * dependency traversal. + */ + unsigned int n_clk_consumers; + const struct tps68470_clk_consumer *clk_consumers; unsigned int n_gpiod_lookups; struct gpiod_lookup_table *tps68470_gpio_lookup_tables[]; }; --=20 2.51.0 From nobody Tue Jun 16 08:55:54 2026 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9118733A9FE for ; Fri, 17 Apr 2026 16:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776443590; cv=none; b=sfq5A0MbZRNRiWhtBVhmmwubIGAT8/SySsMBE6Rab9y4KJBZOeYwVVLBE7w/4+Rg0fe85H4dDZ5SMYBmRgqkaPjcXH2jvwivFt8uWuRJx9KK2WB/WUtZeVTF1qFeUUafZfRHJ0FFcYn1WuQcr0HearCFZeKJ9CRNtld1KSLHJJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776443590; c=relaxed/simple; bh=LRi+8j1uv4IQyt+SAcNH9ZeGWEkOX3C75mNUd0mLMwo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K9aTRKagzEOPaUIe0oD9BxEOZpGo2XER4sIXEi65jLpROMlfRljKfdnKLuB3BwA+bH6kifZo/tbysBQzzFmGdiaZaAqUaly6gwEttFIGiWzq0vvDk1FDWfS/0Mo7dcnRvOvCOJs78zMy/Tst11XBXowwq4ixHoQgmFIGWE+voeA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YZBhD0wj; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YZBhD0wj" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-12c726f46baso1212968c88.1 for ; Fri, 17 Apr 2026 09:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776443586; x=1777048386; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OZYzSmgJreVWUypCLvWA6sUD7qzkFl9KFowiKMZhy/4=; b=YZBhD0wjLsPA1xLU3hD877iYG9/rqT7vfEZcg02XQIDvmoyHBpbECILodegmD/hEH5 ooROrabaIMU+VZAZP6O9VwN2+u1DMxPFYkjefM8P4J/ZdwlDU1qRcdJ0WghDPfUe4SoA 8AIyyReXOpN+HUGXD1Qk6KkrTcc51xyzZvhwKQL6Aai5Yg+ahv1IwB/0AzxsI9La1Vjt NA2zDj3vb0kop/TlINgfBDfVZw7fvH+R8VFk4lHl2PM174vLWelWaCEf52Us4yNhKVse X/L3JpjfGARLxige6it5ykXuLaHSGjj4nKSgWywzwK9fw/0WcjXUdma9JO/foQPC2IX7 HfJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776443586; x=1777048386; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OZYzSmgJreVWUypCLvWA6sUD7qzkFl9KFowiKMZhy/4=; b=Nlw0wr1zYNYpmC5N/yIYyJTgU5ERmuN/IZx1FGWQccqCj1Pk5NC3ElibhESv8Qu+mQ 8wO5a2TnhzWxLSdB5IGV4cne/7mNullr/s5ETMSA0LXQ847QYKmBlNVKjRHEu0UzML0U MTwyF96zfZEfljScwo45IOBm7ouEpJK8kVugFYH6DImXuN6susgTF/E1MAiss8UnA22k FXHt2kKbHPU348Inds2dGLaU4pmEFqc6IKXL7jsFOhyytLNuxokkV6KoD20swUrEsonj JnCa/o52vKkl9yhjBVpdy6V9+bV0nU4zJ0YLi7JzO6lN/v4zNyFc34bHcJ+T2TbIri0R tdJQ== X-Gm-Message-State: AOJu0Yyk+V7alQ/3Vebl4TcEyu7h1iZVUzYYWi9PT5Kjmbkb97LDdKGB XqsNzYvSKxO8XXv4tvyP8Zy23tATiRaviKkOs+eWnZ5+J9nshdtDI3/4JNz8HSDC X-Gm-Gg: AeBDiesIdKZVUgy1m8sfZU3cvZNDLa+amWuWO8nwB+gpSJAqg5036GE2jm9CuU7daht uY97td+y5x2Y/slD8jp1yjtVWxwWaq/Y4+mBhS1Dm2V5kK8wJx2NwPgkKi2IEBilhNL8lb6T5cP NoHav6HvRpCbgZPrQAWT+T2WiBJWH6rF8En5g9eW6aLe60Cd1OE+r+Yo7XPRv6KVqs516vO2688 dSV3ddwrdAaQ+WSs02MgW2v22IMSdPWkXB9y/R9AylSSDMxYomvopwN+/oot4y8OYCOuP3il5Fj EPhHOdA6gOSOQG/FZfm8LQByIcN8a5bAbIX38tiEhB/wrYds8jgekvOVd1bL80ax+xGVJivO02b lVFhvgN8TrAIpV58nPmBwhawViMHny0D81rVPhptyOvDx9gx6N9y9i/aorSqZ7RmHuya4ZAZViP ZEJ+qNi1aGF8o5I1nuXOZ/FBhozg3ymx699r0psI9as3dXCs2hL4tJqa6sgQScPWqVapW7PA== X-Received: by 2002:a05:7022:11c:b0:128:d3de:c9e4 with SMTP id a92af1059eb24-12c73f9da5amr1468930c88.30.1776443586139; Fri, 17 Apr 2026 09:33:06 -0700 (PDT) Received: from TC-LAPTOP (23-93-157-142.fiber.dynamic.sonic.net. [23.93.157.142]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c749dc86bsm3603777c88.8.2026.04.17.09.33.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 09:33:05 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v3 3/5] platform/x86: int3472: tps68470: add board data for Dell Latitude 5285 Date: Fri, 17 Apr 2026 09:32:50 -0700 Message-ID: <20260417163252.15603-4-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260417163252.15603-1-tchatard@gmail.com> References: <4ef5f305-0234-4193-a190-edbfe770ea04@kernel.org> <20260417163252.15603-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Dell Latitude 5285 2-in-1 has two cameras connected through a TPS68470 PMIC/clock/GPIO hub: Front: OV5670 (ACPI INT3479) on I2C4 Back: OV8858 (ACPI INT3477) on I2C2, daisy-chained behind TPS68470 S_I2C port (controlled by reg 0x43 S_I2C_CTL) GPIO mapping (TPS68470): INT3479 (OV5670): GPIO3 =3D reset, GPIO4 =3D powerdown (both active-low) INT3477 (OV8858): GPIO9 =3D s_resetn, GPIO7 =3D s_enable (both active-low) GPIO9 and GPIO7 are the TPS68470 secondary-port GPIOs (SGPO reg 0x22 bits 2 and 0), not regular GPDO outputs. Regulator mapping: CORE -> dvdd / INT3477 ANA -> avdd / INT3477 VIO -> dovdd / INT3477 VSIO -> avdd / INT3479 and vsio / INT3477 (always_on: keeps S_I2C_CTL non-zero from boot so OV8858 is reachable on I2C2 at any time) AUX1 -> dvdd / INT3479 AUX2 -> dovdd / INT3479 Marking VSIO always_on ensures the TPS68470 S_I2C passthrough is active from the moment the PMIC driver probes, eliminating a timing dependency between TPS68470 and ov8858 probe ordering. A static clock consumer list is provided for both sensors (INT3477 and INT3479) to work around the broken ACPI _DEP on INT3479 described in the previous patch. Signed-off-by: Thierry Chatard --- .../x86/intel/int3472/tps68470_board_data.c | 176 ++++++++++++++++++ 1 file changed, 176 insertions(+) diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/dri= vers/platform/x86/intel/int3472/tps68470_board_data.c index 71357a036..c1bf13faf 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -287,6 +287,175 @@ static const struct int3472_tps68470_board_data dell_= 7212_tps68470_board_data =3D }, }; =20 +/* Settings for Dell Latitude 5285 2-in-1 */ + +/* + * The BIOS leaves GNVS field C0TP at zero, which causes INT3479's _DEP to + * resolve to PCI0 instead of the INT3472 device. Provide a static clock + * consumer list so probe registers MCLK lookups for both sensors regardle= ss + * of the broken _DEP traversal. + */ +static const struct tps68470_clk_consumer dell_5285_clk_consumers[] =3D { + { .consumer_dev_name =3D "i2c-INT3477:00" }, /* OV8858 rear camera */ + { .consumer_dev_name =3D "i2c-INT3479:00" }, /* OV5670 front camera */ +}; + +static struct regulator_consumer_supply dell_5285_int3477_ana_consumer_sup= plies[] =3D { + REGULATOR_SUPPLY("avdd", "i2c-INT3477:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3477_core_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dvdd", "i2c-INT3477:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3477_vio_consumer_sup= plies[] =3D { + REGULATOR_SUPPLY("dovdd", "i2c-INT3477:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3479_vsio_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("avdd", "i2c-INT3479:00"), + /* S_I2C_CTL: must be enabled for OV8858 I2C daisy-chain access */ + REGULATOR_SUPPLY("vsio", "i2c-INT3477:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3479_aux1_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dvdd", "i2c-INT3479:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3479_aux2_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), +}; + +static const struct regulator_init_data dell_5285_tps68470_core_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1200000, + .max_uV =3D 1200000, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_core_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3477_core_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_ana_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_ana_consumer_supp= lies), + .consumer_supplies =3D dell_5285_int3477_ana_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_vcm_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D 0, + .consumer_supplies =3D NULL, +}; + +static const struct regulator_init_data dell_5285_tps68470_vio_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_vio_consumer_supp= lies), + .consumer_supplies =3D dell_5285_int3477_vio_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_vsio_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + /* + * Keep S_I2C_CTL enabled from boot so OV8858 I2C daisy-chain + * is accessible before ov8858 driver probes. + */ + .always_on =3D 1, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3479_vsio_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3479_vsio_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_aux1_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1213200, + .max_uV =3D 1213200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3479_aux1_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3479_aux1_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_aux2_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3479_aux2_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3479_aux2_consumer_supplies, +}; + +static const struct tps68470_regulator_platform_data dell_5285_tps68470_pd= ata =3D { + .reg_init_data =3D { + [TPS68470_CORE] =3D &dell_5285_tps68470_core_reg_init_data, + [TPS68470_ANA] =3D &dell_5285_tps68470_ana_reg_init_data, + [TPS68470_VCM] =3D &dell_5285_tps68470_vcm_reg_init_data, + [TPS68470_VIO] =3D &dell_5285_tps68470_vio_reg_init_data, + [TPS68470_VSIO] =3D &dell_5285_tps68470_vsio_reg_init_data, + [TPS68470_AUX1] =3D &dell_5285_tps68470_aux1_reg_init_data, + [TPS68470_AUX2] =3D &dell_5285_tps68470_aux2_reg_init_data, + }, +}; + +static struct gpiod_lookup_table dell_5285_int3477_gpios =3D { + .dev_id =3D "i2c-INT3477:00", + .table =3D { + /* + * TPS68470 GPIO9 =3D s_resetn (secondary camera reset, active-low) + * TPS68470 GPIO7 =3D s_enable (secondary camera enable/powerdown) + * These logic outputs are specifically designed for secondary + * camera control on the TPS68470. Matches Surface Go pattern. + */ + GPIO_LOOKUP("tps68470-gpio", 9, "reset", GPIO_ACTIVE_LOW), + GPIO_LOOKUP("tps68470-gpio", 7, "powerdown", GPIO_ACTIVE_LOW), + { } + } +}; + +static struct gpiod_lookup_table dell_5285_int3479_gpios =3D { + .dev_id =3D "i2c-INT3479:00", + .table =3D { + GPIO_LOOKUP("tps68470-gpio", 3, "reset", GPIO_ACTIVE_LOW), + GPIO_LOOKUP("tps68470-gpio", 4, "powerdown", GPIO_ACTIVE_LOW), + { } + } +}; + +static const struct int3472_tps68470_board_data dell_5285_tps68470_board_d= ata =3D { + .dev_name =3D "i2c-INT3472:05", + .tps68470_regulator_pdata =3D &dell_5285_tps68470_pdata, + .n_clk_consumers =3D ARRAY_SIZE(dell_5285_clk_consumers), + .clk_consumers =3D dell_5285_clk_consumers, + .n_gpiod_lookups =3D 2, + .tps68470_gpio_lookup_tables =3D { + &dell_5285_int3477_gpios, + &dell_5285_int3479_gpios, + }, +}; + static const struct dmi_system_id int3472_tps68470_board_data_table[] =3D { { .matches =3D { @@ -316,6 +485,13 @@ static const struct dmi_system_id int3472_tps68470_boa= rd_data_table[] =3D { }, .driver_data =3D (void *)&dell_7212_tps68470_board_data, }, + { + .matches =3D { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5285"), + }, + .driver_data =3D (void *)&dell_5285_tps68470_board_data, + }, { } }; =20 --=20 2.51.0 From nobody Tue Jun 16 08:55:54 2026 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6B2369219 for ; Fri, 17 Apr 2026 16:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776443591; cv=none; b=If950etM6+CdfY4fu0ahVJU8UQref3GpGbhZ9eppSUwuKakk7cO1yg1ZzWIJYxDe28h/A3kAHWzEOThMcqjZnIYdQcrD3xbf2mPr4DLOF/QFYllxzICkTufBTFVEsyPienmn9iByZ59b7DmbItwpnBeKb1eRooC9JQcpcYaGeeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776443591; c=relaxed/simple; bh=wde4TF8CgNzn8si/JL9P12OCZloroRuFEPIxq/TcvgI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UE43K6z9ChnM26Q9MlizhzgbdRt+wmb2FYzw3JTsrlz7N+mH/hUGTcMJF/6jzr3IASTiVM5bn3BSpOl0r2Gb+s4C3hf8MqJTPItB2EM7saEkzCaCLQA9/cGROfw5BpfHBEk3q+NkXwfq67dsk402mTsN3KWbXOYrAENxKk3MdL8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mDh9BjCn; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mDh9BjCn" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-12c565dd3a7so1315280c88.1 for ; Fri, 17 Apr 2026 09:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776443588; x=1777048388; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TVHeDChmbK7H9JMCFb+9pqFytvxF0fdzrozCeGR4L7s=; b=mDh9BjCnf/w8BO1+JMrGkCDkZ783BuUbJzd8HDRs/jzlYQUsJZyesnoVJBgXU1hp+O j+LFV9+ajZspvucMIXFpz171eqU1Ugn1kDTE+7JyPceUttSAvwa3vh59eq5y54Vjx/2C 6O+bL1vPGg4bBWNK8Bwtmpzsi1EssJJMadn9O58UNuIegM3m7mJrf3qOR0vgMM7nI6Uy 7vxOjrYOMO+dOPyJv11FFdcmldNvIjEMoGlbrNgeVTX+vW3V552nLOyRddlLYmYKnjHo mzPYUu5LV4l8JAdLVgqvlQ6Wocc0uRyovHPo5VwcUGghBuvlF+QUeg3Ky8vkRka5oOlx CODg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776443588; x=1777048388; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TVHeDChmbK7H9JMCFb+9pqFytvxF0fdzrozCeGR4L7s=; b=VkTpQ1ChHhn5evlKuXHQo7LPISbYm2BYoghKPUqC0k3sTreD8m5cJJIQ0d2xAkegnx 6NciO5W/9pLwQWtx+Xy0zdU1az7nfuC82Luob7IWvBR7hf7RBTc+yhETYUqaajx0FJib zsfBdCZaZrU8Mk9RGcNP0GNohTzrwHvb6SiZr1dl8GDqJX3hbGPi+Gf3DxBbRBO8XfaQ 9U7fjESEK3fFSNVvpG8/7UPOX5ycG/BBRLNRlX+gZWUDWy7r2MW1gcwFoBN/uQEz2i/J w7v0jicsblyE9Mwc2WtTJ4slW9Dq/ohd4aFMhPN4fGQhGrzcDAe/KVIynB8tRbWEC163 0bcw== X-Gm-Message-State: AOJu0Yyrjdd2KPykkD5UVrkLIBjbnpgaakhKOnw+eE+U9IkFgtlyo81X 2+iCJmj9eyRE8FkBV4XUOQNhMZ8e0u+6QmgbUiA8vdd+KYjWFNVI9nHuKFSt3q8u X-Gm-Gg: AeBDies+sG6F5zH8TlSsheSpbBCF7G8oR9gFj8BfeJhEa0hlOWzuors77xigWMhCQ8u e6E6a+mLoUHyOeQzQ4V+0E2+uztHu786yxT2zGeppsOyBSK+PFVkXdNXFVZoLfOxH30JcTZO/R9 QT46HNIWa0DFRrahQwFbbL2nQeSlykZss9ryx+U+SQGGrq6QViLANtj8SUSUE6PmNdz1SXE7IeV i1CJJJ8orZDtxE9ExDjDtqeYcf2LBVtCb+wyvhtXdvTG53aSE9Wx4iAbsGutuczs4CDLaFMZa/m TB5lESYS0HSfYTKn2FSkVCL9J0nFNWEhJL7fo/k/AtQxCxowPgfD4J0h3i4ZsRR2gWYNir1Ieer H89ckKT824P7T0RKxPGOlCwuPKP21g2eJ4BVIAcJSGQ0hPDj47lvNNf7PhK5ZqrfMSIA2z5NOrI YIWxKEBEc33JVryRmdmCO9IavDR8BLQsqNT0Nax4rkSh0WX5S/k31UQCq80lHEoY/aNZQNJw== X-Received: by 2002:a05:7022:eac8:b0:12c:2f8b:4c4d with SMTP id a92af1059eb24-12c73f7cbabmr2017351c88.15.1776443588111; Fri, 17 Apr 2026 09:33:08 -0700 (PDT) Received: from TC-LAPTOP (23-93-157-142.fiber.dynamic.sonic.net. [23.93.157.142]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c749dc86bsm3603777c88.8.2026.04.17.09.33.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 09:33:07 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v3 4/5] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Date: Fri, 17 Apr 2026 09:32:51 -0700 Message-ID: <20260417163252.15603-5-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260417163252.15603-1-tchatard@gmail.com> References: <4ef5f305-0234-4193-a190-edbfe770ea04@kernel.org> <20260417163252.15603-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Omnivision OV8858 is used as the rear camera in several Intel IPU3-based devices (e.g. Dell Latitude 5285 2-in-1). Its ACPI HID is INT3477. Add a sensor configuration entry with a link frequency of 360 MHz to allow ipu_bridge to create the firmware node for this sensor. Signed-off-by: Thierry Chatard Acked-by: Sakari Ailus Reviewed-by: Hans de Goede --- drivers/media/pci/intel/ipu-bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel= /ipu-bridge.c index fc6608e33..f51749d0f 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c @@ -63,6 +63,8 @@ static const struct ipu_sensor_config ipu_supported_senso= rs[] =3D { IPU_SENSOR_CONFIG("INT33F0", 1, 384000000), /* Omnivision OV2740 */ IPU_SENSOR_CONFIG("INT3474", 1, 180000000), + /* Omnivision OV8858 */ + IPU_SENSOR_CONFIG("INT3477", 1, 360000000), /* Omnivision OV5670 */ IPU_SENSOR_CONFIG("INT3479", 1, 422400000), /* Omnivision OV8865 */ --=20 2.51.0 From nobody Tue Jun 16 08:55:54 2026 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A76D3043CE for ; Fri, 17 Apr 2026 16:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776443593; cv=none; b=AL2WWBdl8nOYw/Z4u8coabLm2XfAjNcR6ohP6I5TzvWkXUWhuTNyP2e8vnpYzbiF2+6YjKd/pIOFEtFAp25TI3Zo+W6UsxmDvY7Ckb47Z70WKMC30q/5Jg62Oq6tUlBwoxoGoOPhs0wJ/V7e43C1DuK8FCSyXuhNmTRl2cjRtBM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776443593; c=relaxed/simple; bh=kn4gRyG2CWdohr2zODJVwJLXxsAV9GOcDFXCGFJSgyU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lRmawqt3zvoLOf2jzD7PP/txEprcJRPtj72WnAB0Rl8ULE/i9hEJF3M1HmACbhofQbA7CBYznryi88iDKimSmWm9p73p0lS0YM1KCCIm+Kew/sK7tUS2Ux7UaE2vI3w0jmD0UKdlZrrMPQ0EJXKOoDxAboHJVbqyqGap0btpXBk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OI4ZnqQv; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OI4ZnqQv" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-12c726f46baso1213069c88.1 for ; Fri, 17 Apr 2026 09:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776443591; x=1777048391; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fItzBPGWBSGQf6v7HfvNDUYpHiJWqdhO3Tr8TUmXrPk=; b=OI4ZnqQvk4HqR2AESBItxpSrJ/YpEMInHIvh3+chhzF8KH5mrlg0y8Ry1XhxHOQh0v htFB7gIy7nZJ3B8v4hcLlqMv5wfw+GWtg/x2pL2Wx4YlSDpRCR0zRZ9xc5G0RdrF0aLu RYctWM0n4P2H42vevycnOVnCQqVujaVWstwBkoqpupE3QSZucOIxbqMhkwTA4pn/+wRK TC9RyaGPTsfzhHgc5pcwALibvgKDmPUMY/hjyNJ3XVdv6OmzD/BvtuO6f6wXqWbJx7Mn kSOQepstaEbE6t1biJXjFD1XKSZ33w76wc+bzQpmd+lgFIjrFLrZgWyUWyBKtVyauA17 s79w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776443591; x=1777048391; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fItzBPGWBSGQf6v7HfvNDUYpHiJWqdhO3Tr8TUmXrPk=; b=Ur9LprV6Nd1u17ibNTS6BEKJwlDv+uAyUZFjbhwLHFuU9OmlWIfNGs3cWB1QRzCTpk S0XE85rHPm85GvnctEIehXKQ5nSCRni0izzSvTWJWclwyghz6dAwy4EwWOnu7dAvPj/T Yfwb6H607vNOCh+/TcayDS4TE1V35Ogg3UZovskw350xHqRScrxnr87x2IrDPTHqyk0n qmtAhTz1uWagCX4HN5e2hFCl2remelKZj0U3hly6Rgs9D+DMmuykr1zEXlPk4/pOWTwN 1q1SYNSQBnMa4Uu2ZpvzojqC9rsqjgOgChY41xhwwnODd/O0A2TvENP8dOroaMLHtlxp oSaQ== X-Gm-Message-State: AOJu0YyYCw/rHCdUJqz/rTqoNHBUBd/vdvM9btKSzsS4kfM5uso/+v9C s+EpBpj7ST01o+fPGyZi7q82XmUdSdmg2Jo/c3enGD8ecVYpPCljimtPUh3jXKTM X-Gm-Gg: AeBDieumaZiPhOrGUmBuTBq/9iiSlTNgyLZdwE4S5zr9on8PRhc64J4V64gX71+VjEV 5ZCCWm1rb+u5/Y0FgG/4JdC+pn8qkjT9p/+DRg5743mSkPA5h5jJtYKNe0Q53JpE0qUlBh0YzwK mgjkrp9b0D57Qz5tzNYXmTs+42Z5bJe8KVMx1Xp56+VqNQ9EQeWQL9ZAcjl/jjLWLgofSFeLsT3 9XRLmB3MwbUkzsFOdVmi8vzNg2tz0kwVxbHmy9hRTIFY7EXGgmdNvPSf2rmsbSPIE7By3mlza8H 98h5o3oc8fbvJt1ra+xOnuVNTk30OyS/FxbZ+fEcYOPSVwkd7HL7GSEq4cTzQp434dSSGFcS9BS QiZvaTfQaCqo98seoEQFWG9m2oDl8okM/v4sC1WKBdCp/kcgenIqSWzKGacdREgkOv+77KKm5Lv DnNEgo5STz82fGNQDYtrCYA7Sw8o2z5BBBsAe75jXWICLEx0zomwN/mGMrzKpgsaPTLSc0Rw== X-Received: by 2002:a05:7022:3d87:b0:124:9fd8:4ba9 with SMTP id a92af1059eb24-12c73f6cd01mr1749321c88.12.1776443590684; Fri, 17 Apr 2026 09:33:10 -0700 (PDT) Received: from TC-LAPTOP (23-93-157-142.fiber.dynamic.sonic.net. [23.93.157.142]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c749dc86bsm3603777c88.8.2026.04.17.09.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 09:33:10 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v3 5/5] media: ov8858: add ACPI device ID INT3477 and vsio power supply Date: Fri, 17 Apr 2026 09:32:52 -0700 Message-ID: <20260417163252.15603-6-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260417163252.15603-1-tchatard@gmail.com> References: <4ef5f305-0234-4193-a190-edbfe770ea04@kernel.org> <20260417163252.15603-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Omnivision OV8858 appears in ACPI firmware under the HID INT3477 on Intel IPU3-based platforms such as the Dell Latitude 5285 2-in-1. Add INT3477 to the ACPI match table so the driver binds when instantiated by ipu_bridge. On the Dell Latitude 5285 the OV8858 is powered through a TPS68470 PMIC. The TPS68470 VSIO regulator controls the S_I2C_CTL register (0x43) which enables I2C passthrough to the sensor. The board data for this machine maps VSIO to the supply name "vsio" for INT3477. Add "vsio" to ov8858_supply_names[] so the driver requests this regulator at probe time. The existing supply array had a duplicate "dvdd" entry; replace it with the new "vsio" entry and reorder to: avdd, dvdd, dovdd, vsio. Signed-off-by: Thierry Chatard --- drivers/media/i2c/ov8858.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov8858.c b/drivers/media/i2c/ov8858.c index 3f45f7fab..5bfea237b 100644 --- a/drivers/media/i2c/ov8858.c +++ b/drivers/media/i2c/ov8858.c @@ -79,8 +79,9 @@ =20 static const char * const ov8858_supply_names[] =3D { "avdd", /* Analog power */ - "dovdd", /* Digital I/O power */ "dvdd", /* Digital core power */ + "dovdd", /* Digital I/O power */ + "vsio", /* Secondary I2C / S_I2C_CTL enable */ }; =20 struct regval { @@ -1981,11 +1982,18 @@ static const struct of_device_id ov8858_of_match[] = =3D { }; MODULE_DEVICE_TABLE(of, ov8858_of_match); =20 +static const struct acpi_device_id ov8858_acpi_ids[] =3D { + { "INT3477" }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(acpi, ov8858_acpi_ids); + static struct i2c_driver ov8858_i2c_driver =3D { .driver =3D { .name =3D "ov8858", .pm =3D &ov8858_pm_ops, .of_match_table =3D ov8858_of_match, + .acpi_match_table =3D ACPI_PTR(ov8858_acpi_ids), }, .probe =3D ov8858_probe, .remove =3D ov8858_remove, --=20 2.51.0