From nobody Tue Jun 16 08:53:02 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EB7B370D5F for ; Fri, 17 Apr 2026 12:49:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430178; cv=none; b=Ouki71pm//j0lmImNkZB1U81+c3tR01IOyxwIst/7VrFLGtX/i9+mMVB9zW4n0qLfEZCJHHGnYv2rZmn/6HKDD7ZNbzpnEMxbXkKg4cSWd/dCoxRnVLf65y7iHlHB/Tu0M8Yvzd9DoBDi0nTRnyLlfoyCJpHXEqqBmO4NXUKnjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430178; c=relaxed/simple; bh=/sbeCvYRJV2J6VSn1qTNL4TuFMe1xKvjzwFVqfDvwPU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=T5rvz+UgRCVIpAcUzauxoGuEWX+4YFBDJxuIkm9P0TZDKYEYl/kGPL4D0jewPPserASDmhrqf5CG1wU1YPx0ClD8KmFK6dKPWwh3afUf9ZncAy3AQEqyqbFZIXAVxvlu3VaWxnDi0OgNs2ijwUoRK2IIfOhb9PYX7r5r7P4KoQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EIFWWqXi; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EIFWWqXi" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ab232cc803so2837385ad.3 for ; Fri, 17 Apr 2026 05:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776430176; x=1777034976; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ilm5rEXfs+j3rDOpp9ULtRLO1fYzOj9RLqCJ/xDcEbU=; b=EIFWWqXiM56yMuGV/XJHTufT3602zkmf3plRdHdQJajvRwSPzK4XrwRuI0/Dt7cNGP h/syBcISVEyJhq1DiVI54NzuUurUH5bWHUl/qFDqNL9xRPBBg3GDriWyQH2+RvLAdv8y a+6FMF+PqE1OfsaFC1mvC8XA7rnwAzU0aVnBNcDOPZjy2WAo/62T0bsT+WgkK1eERrrq uBAF8EstKbxGijqz9crp4AwjsxTuDoDCJHZ+b14R9gytWjJpp5jfY3H4P6no6n+VoPP8 6pHzAx/BAzAPNOl8sCOcZVzYe10/soxIIeQZAYde3bCfSfCK/pZgIfX9pFKhDQY2OhGu /FZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776430176; x=1777034976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ilm5rEXfs+j3rDOpp9ULtRLO1fYzOj9RLqCJ/xDcEbU=; b=ksr8zCNsJ7ZtVxR8BVqJluFMNsQAywKdcPxlCrLgpeyya6REisGcaxbal+UhBBVMeN helHWFFHLw461HS8ihEnjPquWHZA/8UdZk+bDZ4RgCVkqvS2fL+uAWyqTzLRMLoWfDVb 0FbaaTz6JhSvRk3PKfGXarai0E6OGpYRYTpzBBzbYepXPOIxnpq2a8BhCQOQKR082ERz y6b2OWqoeRFTtZbqmMvpcNoRiMuifw3p5bVVXNMHf0yfKf7wNS/XZooNgJsqN9a8rs2e KtU79uIwbqA4zXj4hPJVqxsK3jqbUkWaDav1YqOsZLiCJbd/0ljS/TKj6HOFrb1NUtj9 Y4WA== X-Forwarded-Encrypted: i=1; AFNElJ9hl9DDZoW+6Ym2fkZYMnfjDp4ZAZ/4qIcti0XoUMh/vfdavF8Rm/SvrZqvzdOOsQRAtKoujQRQKj7itTQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzgyCtyVbxOpDUlUcmwN5OtdeO4PuAcTGn3AVb2GnxHT76nSEPJ CVS19HAmElbH2JAxHgqEjOxjsxs7IxNfKyEpIvec3U03hA25bhpWLZ1h X-Gm-Gg: AeBDieuaelJdnJk6bnbs+kTdd64epb121o50QQ4VbTC5ZDDo2KH/FqF3sLlwTXcedk8 BwoKKadeHbzKYLHFatR+V2cud1P7k1F6IUW3lhOWwbqrSwG+bhFkk9fzCrtXkBTWvqxy6GkINOu 1yRCucYgYKepvKfcRVG7cn9wjek78lzDwmoLa0oAco4XTcJFjKEusuom5hX/q3+F6HlQwSDZOjD 783iOYHOSEoYG5cpM0GvZes7MCTmLyhjdRLBeLrmyRmfAsgT94Q9kRsPb2EPXIISkHcEwl2iYA0 PSE94YpDoQQU3IxY5GyzlmjjWlKCaEyi+KRdtfhDBFZbHGKRmx8uvnut8qikYifbwVZ+tig/x9m RRJCyyB5CzCN1N/e8u1bim2U1bD3bRJeOqOyyFh3FttMJTnC8ZDVNr20eTvyTus6sEKIXLo2mFK ZSWn32ziuMMMLK6Xi9VsU0D6RtCf0Xt2XpsHYfiyBcAd+9EZx5P9ETI1EKz97LSZsJTBX3YA== X-Received: by 2002:a17:903:98b:b0:2b0:7026:24bf with SMTP id d9443c01a7336-2b5f9eff280mr28816875ad.14.1776430176409; Fri, 17 Apr 2026 05:49:36 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cb92sm19428855ad.50.2026.04.17.05.49.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:49:35 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, puranjay@kernel.org, cosmin.tanislav@analog.com, marcelo.schmitt@analog.com, antoniu.miclaus@analog.com, ramona.gradinariu@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/8] iio: accel: adxl313_core: Use devm-managed mutex initialization Date: Fri, 17 Apr 2026 18:19:17 +0530 Message-Id: <20260417124924.353189-2-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260417124924.353189-1-sanjayembedded@gmail.com> References: <20260417124924.353189-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Use devm_mutex_init() to tie the mutex lifetime to the device and improve debugging when CONFIG_DEBUG_MUTEXES is enabled. Signed-off-by: Sanjay Chitroda Reviewed-by: Andy Shevchenko --- drivers/iio/accel/adxl313_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/accel/adxl313_core.c b/drivers/iio/accel/adxl313_c= ore.c index bcc11dabdf22..1fc96b7b0f1f 100644 --- a/drivers/iio/accel/adxl313_core.c +++ b/drivers/iio/accel/adxl313_core.c @@ -1240,7 +1240,9 @@ int adxl313_core_probe(struct device *dev, data->regmap =3D regmap; data->chip_info =3D chip_info; =20 - mutex_init(&data->lock); + ret =3D devm_mutex_init(dev, &data->lock); + if (ret) + return ret; =20 indio_dev->name =3D chip_info->name; indio_dev->info =3D &adxl313_info; --=20 2.34.1 From nobody Tue Jun 16 08:53:02 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09EE538CFF1 for ; Fri, 17 Apr 2026 12:49:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430183; cv=none; b=nWV/1ua6cj7KijZbWqMCabxIM9g9b7YEbveXpA0VC6UiHBb8AyC7vVgLQ4cgGd1VS3kTIweGaDs6TCljVv+6xk/2KhwZr1KN+q0rHlarcd4RxCfg4z9wxM1vuYWSBk4mpORGMAD64y7+HjiSvrPbbocK7fXBCvMHUNWmQ2YsE2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430183; c=relaxed/simple; bh=t/PYPN/FNxWeoIy07qENKLtWK5VFABvTmes/ubhCSGY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=I/91dHSIzHofiwO4fYZ1NlBSWQla6qFcYMhzPv3tVvru2yi2PvoAP9VoDK24+cq5oDq88GwUiolYiAjZeVoVRbTPnunekVLrjpaG2nDLjx9Fz6xiBCv/HPAke0+F7c33taJ50v6nULmHxg1aENSp5RB6hKnHEZ4W2s+4UV4/2Ak= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n8Iv2O5p; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n8Iv2O5p" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ad617d5b80so3793555ad.1 for ; Fri, 17 Apr 2026 05:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776430181; x=1777034981; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vruBcRB4ust+Byaj+7nyfLxpyKyFagHRqNw2VFcgzW4=; b=n8Iv2O5p0wMIajY1naMuns0uwwWieA3QkSU+eRdZaRfA0FGft+26EW264mENtUjIoa dV3ukdLhMGLsyjKh7pPXFwJnmtK/CPj63DtHXBeLe9ln9dRiMhJLYcFEKOowu0aKq/0r XMak9K8ZvRAK7DJYJTYF/9pPoppOjm3gJDNXCTWFL/fYmEfhBgq4l3plwcnSkgRbC0Qo UkHqUIQIjMkKf7ljbSZqAbZTuIWGhs5BVygZejvpU9HJlOwCnVsn5fnOVhRqXUr0HK4O TieQ+dHKbkfjDurrweRqvw4s2d3YRiUB4DEBV6Lz1i1F4W9zgJltKU4vmOd76QGpckoX ZFQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776430181; x=1777034981; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vruBcRB4ust+Byaj+7nyfLxpyKyFagHRqNw2VFcgzW4=; b=qpmuZAKs7x615KY6GcrTrA6VqYFS6yNrmcULKIy47mlcdUbX4I62ptqMpTEq/a8Fql cWg0/Qo5KiB+BZvQTx2aF8tcSioNxT1InjzXVjvBKTlbcAhPm+pTzPmG9dXipp4k+eBI vIwYdoxkJgyt7oNK/JJgNr9lLcIx1WN3h21O9H0Jpg7FberpL0+bZR2avRF2Xvyd2ECF aO4xK0Jp/8RCiRBL+Z9n2G/oCQKwEDLZYvbIgYvJoEGorPwPOxGUZW+nmrHRlYMwzA+g uUVL+5Yjho7fWTHplFpyFIoQZFcXkXZHSLMf/b3z35C9B3r6WFHvwEJeh+8rC7BtFBi8 5DIg== X-Forwarded-Encrypted: i=1; AFNElJ8D/NYQEmZpU6EzhXDZpopGNEe/gSPHbZDTFyFG99jvm2Gyq/+0cEJtGmemIdL+XSMaPz6PVwSPpqv3gbc=@vger.kernel.org X-Gm-Message-State: AOJu0YzR0yu89Lxd50PD+AEzYdTS1YrMioMxcXvlNVLcec/29cvJ+aoK Ww6PY85B6HOxmtp2cNfLADdach9qqRiVdhcDrGeQxenapJOdFi72cVk2 X-Gm-Gg: AeBDiesJyQSmn+R175BrqCQcfPseGkiDKJDek4vD9eN2SVrQTHwPGVdWA+xHXfXXFha z+T1qf72Dgt0dzuDEZ1wWIp3HEWdPnOxJkupnxjaWvixp4DltZ/XqaJHK6RneUCSIgBs48oXqfL bBPVsirf8nC0UYNUT6xGz1qLeUbnNMTB53anmJH6ggGi48jA5i+BeZI5EcBr3VjyxtsHXRMXJDD rqeQ1+Z7Y4OFv8wXMnx2vQDq+mK6hDlDJEhUXSZwLFb4PHjFwcMFFo6cRy/RYbMSy0wj5oY73N1 OspbQcwa3tztnzP+ijvzN6KR7YneWNqBZFRqD+gup9CcKLXcA8byC4DSp1rfR7/EJ3wh2cpO1im xdztHDF0y+7s+xhPGvq6ohwFgnE4lIavsp32ESYEW/bdl6Bf5jGWiY4k/0583T07zuLNjYcnTE2 8Ms6JcBDPalESHkyFAnPqJrU+Uh80LdQCc4pYif+uEAGkLVB1/RTDOcLVDWsU= X-Received: by 2002:a17:902:8e82:b0:2b0:b41e:c5c3 with SMTP id d9443c01a7336-2b5f9f6710bmr21491155ad.29.1776430181197; Fri, 17 Apr 2026 05:49:41 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cb92sm19428855ad.50.2026.04.17.05.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:49:40 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, puranjay@kernel.org, cosmin.tanislav@analog.com, marcelo.schmitt@analog.com, antoniu.miclaus@analog.com, ramona.gradinariu@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/8] iio: accel: adxl313: Use dev_err_probe Date: Fri, 17 Apr 2026 18:19:18 +0530 Message-Id: <20260417124924.353189-3-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260417124924.353189-1-sanjayembedded@gmail.com> References: <20260417124924.353189-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda dev_err_probe() makes error code handling simpler and handles deferred probe nicely (avoid spamming logs). Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/adxl313_core.c | 6 ++---- drivers/iio/accel/adxl313_i2c.c | 10 ++++------ drivers/iio/accel/adxl313_spi.c | 10 ++++------ 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/iio/accel/adxl313_core.c b/drivers/iio/accel/adxl313_c= ore.c index 1fc96b7b0f1f..6dc918c4ae17 100644 --- a/drivers/iio/accel/adxl313_core.c +++ b/drivers/iio/accel/adxl313_core.c @@ -1252,10 +1252,8 @@ int adxl313_core_probe(struct device *dev, indio_dev->available_scan_masks =3D adxl313_scan_masks; =20 ret =3D adxl313_setup(dev, data, setup); - if (ret) { - dev_err(dev, "ADXL313 setup failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "ADXL313 setup failed\n"); =20 int_line =3D adxl313_get_int_type(dev, &irq); if (int_line =3D=3D ADXL313_INT_NONE) { diff --git a/drivers/iio/accel/adxl313_i2c.c b/drivers/iio/accel/adxl313_i2= c.c index b67ff0b4dc54..6736b83f23bd 100644 --- a/drivers/iio/accel/adxl313_i2c.c +++ b/drivers/iio/accel/adxl313_i2c.c @@ -65,6 +65,7 @@ MODULE_DEVICE_TABLE(of, adxl313_of_match); static int adxl313_i2c_probe(struct i2c_client *client) { const struct adxl313_chip_info *chip_data; + struct device *dev =3D &client->dev; struct regmap *regmap; =20 /* @@ -75,13 +76,10 @@ static int adxl313_i2c_probe(struct i2c_client *client) =20 regmap =3D devm_regmap_init_i2c(client, &adxl31x_i2c_regmap_config[chip_data->type]); - if (IS_ERR(regmap)) { - dev_err(&client->dev, "Error initializing i2c regmap: %ld\n", - PTR_ERR(regmap)); - return PTR_ERR(regmap); - } + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), "Error initializing i2c regma= p\n"); =20 - return adxl313_core_probe(&client->dev, regmap, chip_data, NULL); + return adxl313_core_probe(dev, regmap, chip_data, NULL); } =20 static struct i2c_driver adxl313_i2c_driver =3D { diff --git a/drivers/iio/accel/adxl313_spi.c b/drivers/iio/accel/adxl313_sp= i.c index dedb0885c277..555c11b68421 100644 --- a/drivers/iio/accel/adxl313_spi.c +++ b/drivers/iio/accel/adxl313_spi.c @@ -70,6 +70,7 @@ static int adxl313_spi_setup(struct device *dev, struct r= egmap *regmap) static int adxl313_spi_probe(struct spi_device *spi) { const struct adxl313_chip_info *chip_data; + struct device *dev =3D &spi->dev; struct regmap *regmap; int ret; =20 @@ -83,13 +84,10 @@ static int adxl313_spi_probe(struct spi_device *spi) regmap =3D devm_regmap_init_spi(spi, &adxl31x_spi_regmap_config[chip_data->type]); =20 - if (IS_ERR(regmap)) { - dev_err(&spi->dev, "Error initializing spi regmap: %ld\n", - PTR_ERR(regmap)); - return PTR_ERR(regmap); - } + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), "Error initializing spi regma= p\n"); =20 - return adxl313_core_probe(&spi->dev, regmap, + return adxl313_core_probe(dev, regmap, chip_data, &adxl313_spi_setup); } =20 --=20 2.34.1 From nobody Tue Jun 16 08:53:02 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C773B38CFF1 for ; Fri, 17 Apr 2026 12:49:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430187; cv=none; b=H6Y2fCfLI/I3kCrZNQAlVVJXgYZQ9k/a6ln2EaVQWsr8nA2RASD2+WV/pTHsbWET3Zl2XyPMVHvQRChKvnOmAd2AVJb1ocre6o44IY5Wa7CW4UgDpLfbffC2KMMg2E0zVn4pGelPHyhwJqQpQoqIbqYrk6j3eLg4fE/j+zCRoNo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430187; c=relaxed/simple; bh=qXCjDz32Ejwsyc/QGNOrStXFdACb9FOwNTJl7zDbkvQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WxOJLm52pVdIgBrI9+NRkbcisU13HYEkggRQ0/o8m9A8a8gmiTOrgwBkgR/2zXuaTWAmBPgI+9h5u/mwc/3YnzWk0mxxmCfgpbsKaqE2gXBr7CsKykmpUBQ0hzXZj5qtsAuBNzx0lj94L/lzzvO1JO/y3gWARQdEqBtGlKuhOXA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wn8Qrdg4; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wn8Qrdg4" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2ab232cc803so2838125ad.3 for ; Fri, 17 Apr 2026 05:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776430186; x=1777034986; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zTYsnC56M7LWSyOgDZjUbBdF1x0N0VfNXskukjfHF8Q=; b=Wn8Qrdg48QnteyAVVtQ/FPNM5D26qdTA0QjjZK+rm0i50wseqxdTizSJ3KF6ujQ0P/ /4WPFKEaM/RFLUG/EKR3B+X6KM48CkOB1ikRqcoQXlii00BUGrpHcjHkYglmbGLHggw9 docsmfatezXn/feYRAkxzdFu9j6Ukkvm9SmgJGwR7ViQCmof+x5chrpZ0niv/W3uss2v UMXMGMycyGvBmy1+6ZbZ2Pemlj9QAurgjF2ZnKjx97x/EqtE++LjS5fig4n8nI1wdAhT 7nC826m1MmiS/inaaSnGp2a0iSrBrzZZDaFcAgPTmqJxxBB2F66dP0GZuYLain4vWPP0 hVLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776430186; x=1777034986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zTYsnC56M7LWSyOgDZjUbBdF1x0N0VfNXskukjfHF8Q=; b=pTMYSGd0rGc+uas+PEpgwoPycSIdiELXfeELGl55AQzfy2jtx6itKkxTfKm8tMWr50 BEp6NoXaAwrJfmJse3crDdCAr2PFywjpB0cMz0jRqF+SEDwiDLjlL7BlEIDBLr8s02JA YpRAqinhZR+DGmpwjLcS+JvMS3PIgXDCi+c+ukvcpGq8VxGue6dUficEtm6Ml7V2Pk2K 1UZIFJumAPVo7dfhjBfz0DnOKdiVhVORl+bWH3Tm7UN33dgb4LTCH8h97soXTEU4xpxi cb46NO3Ta/HKBeHFWwpuvQxEcoFBIvyOo3efr4PBkqbcI7QY9LCRSd9ORvUfwhL4QPHq CI/Q== X-Forwarded-Encrypted: i=1; AFNElJ+LC3hfQmS9ie0cr4FuZOUrVhrK9mezMesVzxo7OBOs6fMyBkf0B2w1ue6DBARjXUIlZ8ZwjSq4wRIhcxU=@vger.kernel.org X-Gm-Message-State: AOJu0YxKJSucDiYDUbVhDToixKYaOqrGZEQmM6j3TvsMXco/rmV7VnSN 7lTBRD1a6zKMEYAm4J1RpuQN/FN6xaDQawC2w7nZYLDWaBlWp1HZL1Fa2QhCuQ== X-Gm-Gg: AeBDieuWDt1hEBr7uIKdztFOeqtKNxzYt5RQsbOQ6eaL03aq7KtSwL50k57gySGkj8u XIKYKa21ciAdVbR+XvK9gOOyOuxD8GBCSZvDMh6huPfHVBeF4NZ64taYrko+w8G2762NkMqYOEQ WQO0JrK8FLbH1Isvrh3uGAQkuJU9eIHHQQ9I03Mi41fVzcjPTxA4aAjfCxVXjM+OmmlKiGDgozP 60cLfHqDamMW2kK70HOfYAFmB+KnBDGRXppHVIfA1h1iYgPEo/4Y+SMDlsco0k3ONRkMg00EsDC fs3sqjHy3oHBmj9nGHRaGNL3fC3tSpoDa+Z/5oGyJLMnvV4ZrLrExs6HRuMlDEpPB4tbEScdIDZ 4vr05PMPr6EboIy7aOpfxDppUl6eSqyj6TCqKE+699YzONXYoQ4wq/88hND6JgsLKVz3itt+Hgu 6B9NUd+hY0giA33qWt6NC+Jnpo/2b0Jf76Sb9A6C4sohbbA8xU2Ts9+UGThaW1TnBaBVIspA== X-Received: by 2002:a17:902:74c2:b0:2b0:6d33:e7c0 with SMTP id d9443c01a7336-2b5f9ecaea6mr22170285ad.1.1776430186117; Fri, 17 Apr 2026 05:49:46 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cb92sm19428855ad.50.2026.04.17.05.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:49:45 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, puranjay@kernel.org, cosmin.tanislav@analog.com, marcelo.schmitt@analog.com, antoniu.miclaus@analog.com, ramona.gradinariu@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/8] iio: accel: adxl380: Use devm-managed mutex initialization Date: Fri, 17 Apr 2026 18:19:19 +0530 Message-Id: <20260417124924.353189-4-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260417124924.353189-1-sanjayembedded@gmail.com> References: <20260417124924.353189-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Use devm_mutex_init() to tie the mutex lifetime to the device and improve debugging when CONFIG_DEBUG_MUTEXES is enabled. Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/adxl380.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/accel/adxl380.c b/drivers/iio/accel/adxl380.c index e7bb32fbc475..7dca5523091f 100644 --- a/drivers/iio/accel/adxl380.c +++ b/drivers/iio/accel/adxl380.c @@ -1967,7 +1967,9 @@ int adxl380_probe(struct device *dev, struct regmap *= regmap, st->chip_info =3D chip_info; st->odr =3D ADXL380_ODR_DSM; =20 - mutex_init(&st->lock); + ret =3D devm_mutex_init(dev, &st->lock); + if (ret) + return ret; =20 indio_dev->channels =3D adxl380_channels; indio_dev->num_channels =3D ARRAY_SIZE(adxl380_channels); --=20 2.34.1 From nobody Tue Jun 16 08:53:02 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8634C36D9E7 for ; Fri, 17 Apr 2026 12:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430192; cv=none; b=C6vSlTxS5ml+0QYNfTGqOaYziejlt2/VPm1+fzPMLTzKgleR9s7hQsW7R0reNb74lRMeibiIUyy37mE8G6Gm1xuT2nuCGaZFgfRTrAqIgT3n0W8svxmn4hjekzIpfCeLUJu+CXWyKRdfzEHjkISzyafxeZsg3TZLOrgKiu31uXA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430192; c=relaxed/simple; bh=FyutRze4dwTunn8UefEMTf6/n/UG9pIcPguCaoYkTCo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UxNZlwUdk4Rbd8I01YcNQ5VeZz90MsJUQUzZrdt11x03Jvu/xXj3c5/zkwqvttb0lWPGxOP1TGIFGaMxAQ0oSFXjDy/0vlVXH+YayxUeiljZBOXpmsA6+vNNd6WAd/XVX0YR2bEmRnG35J8wB1fHJs5vjPl36Tt5RclE95Gz91Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kcN7rUME; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kcN7rUME" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2b2503753efso5859995ad.0 for ; Fri, 17 Apr 2026 05:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776430191; x=1777034991; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TRJ9joLNbqO0VrRbkOHdpVg+4neh1oV3/4mvLg8GreU=; b=kcN7rUMEKwkpWRaRRtnioGTWXZejUvID5f7uBSZpQn698j8mRSJ57pPNDgltAg74SA QsHDlJfMGVf8kCtfYpU0t+k4xH80/i8RLqPlEIQrK1gS9netD2wMNd3I5d6mEQnWJgQG tmQC2GfrAPJqhbe8XvdDIwsYpbUO2QJGvakhTYjVIySHRTJH4Frnncp0NVC3kP6qaSgS fexq9WemlMcSDtKbx2KkJ9DWZ7uQD8v5ej4+O0ZRouA9vz/emLyPLzhIS0rsTLgRpfU6 3Lv4W/D+0KI84BPgWClFOYIjn0CRQmw4HYM0ffses9XfLWp/NrZC5QKgQecz7yYPcuDm 9eMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776430191; x=1777034991; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TRJ9joLNbqO0VrRbkOHdpVg+4neh1oV3/4mvLg8GreU=; b=Tb3lY4vqxnmT5/+6HLNireKSqTDq0OjqDg11STu9GtEKD+5AewIEdVxGz6D9Gg1C3c Vh/9c0v/TnS/S4zi/YJ4nnuWh9OURQxF29Nk7+Ehdf1JHqIix7bsQXw7bIJ65F6fBgpK 8cvR5nlP0TEVdfCtxiPTXV0eLF7HCCqstCCYY2X7UOyYj3XqPZooeuzUBVju2bfrf0CP d4fqBM20dtZ4MYbFhFG2PlZQ/gCTH0QOfVHBZryTPshlIoSRs/3OlLehCeKUR5y7oT1D 42wOXz0ObMKgrOwgJ6I8TkqHCx4ufa8ovgznG8wyEgyCmpmda+UtCvBZqpIsBjjXagb0 krKg== X-Forwarded-Encrypted: i=1; AFNElJ/8upB4vspXN04WS/neV0AAtJHO8D1W0dNTHcMMLvNRWhMPYEvk4f+Vemo+1qgwfLkfqi4jojtgx3/zGs8=@vger.kernel.org X-Gm-Message-State: AOJu0YwQPDKlTLd82LBS5kMFTKDe3GMSHJlxCIZXEEZTT9taRYIjsw2E sIzcSqLZxaz6LMfqbfrrj++QPPxo53Dp5/71VFNoalHDlk/tvlkoXFdR X-Gm-Gg: AeBDieuuPBZZh1hWLnq4BOhM4AW1HmY5yEcl1yfucxWcsXIc2jt6M6Q+c5tUulgiM+S xvxfo007mvdnPRBPHY9CA0lioEvzsjN+IBnk0YjuFnEu7R3YPn0A8T5sOuDnfrz3jgm/Oc2UXh9 861vde0ub3iPetOCFbeoPamPQQKNGsrTzrBYsvy7C94gHSupm7ToTeV607nIVLYA6xs9pU6gimF 4picG/qeENQrfvp/XzrEtMAwbA1pWs2FUK5Kccdp62bpT8o6YyKvW6GYhULhp0sJpShKJ4qoJZO lKpeMlEDCVziH4/CB/+KCHBW/g6NOyTdWllNy+wVc6eQMGu7LBkB/iYTS2q0fOREyOzk78xWrIK sW1WtaKf0xJpxBRtyFHjLD3G4MnuoFba6t4zILf79ifhpwRXNiKPRIyxvBqKQVynzkB/LPG+GE0 xb/FIL1QzRYwTxTikCSkTrbTlivjUmaF4GSGST8JfdQnAXN7WRnL+/BdpRJLs= X-Received: by 2002:a17:902:8308:b0:2ae:c529:a13f with SMTP id d9443c01a7336-2b5f9eb2249mr19149155ad.14.1776430190900; Fri, 17 Apr 2026 05:49:50 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cb92sm19428855ad.50.2026.04.17.05.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:49:50 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, puranjay@kernel.org, cosmin.tanislav@analog.com, marcelo.schmitt@analog.com, antoniu.miclaus@analog.com, ramona.gradinariu@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/8] iio: accel: adxl355_core: Use devm-managed mutex initialization Date: Fri, 17 Apr 2026 18:19:20 +0530 Message-Id: <20260417124924.353189-5-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260417124924.353189-1-sanjayembedded@gmail.com> References: <20260417124924.353189-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Use devm_mutex_init() to tie the mutex lifetime to the device and improve debugging when CONFIG_DEBUG_MUTEXES is enabled. Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/adxl355_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_c= ore.c index 8f90c58f4100..a310f8e37e3d 100644 --- a/drivers/iio/accel/adxl355_core.c +++ b/drivers/iio/accel/adxl355_core.c @@ -802,7 +802,9 @@ int adxl355_core_probe(struct device *dev, struct regma= p *regmap, data->dev =3D dev; data->op_mode =3D ADXL355_STANDBY; data->chip_info =3D chip_info; - mutex_init(&data->lock); + ret =3D devm_mutex_init(dev, &data->lock); + if (ret) + return ret; =20 indio_dev->name =3D chip_info->name; indio_dev->info =3D &adxl355_info; --=20 2.34.1 From nobody Tue Jun 16 08:53:02 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE27394787 for ; Fri, 17 Apr 2026 12:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430197; cv=none; b=H6oNRhpJmJBXHV4ZcmJFuje4ir9K0kVXTeySebnmPGqFKxy7faXo6l26DBKfgBHK9RdmnWxpACrk3Lkks7Ewjz0yt4YF0+6YCRLxnQhoGDwV6rOt6Omk6fOviuKSMpMFsJ29GuwsI3ZREaocBQuckQiooAK5tWgDW9Gn+8UOIwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430197; c=relaxed/simple; bh=tnK53EaNGIBDfxbMBE4Ggz3ws+Vp5qfLWDMmlxLbTkM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BW4OiojwVGPj+POiytLiySwW9/D1110jvA+h2rgBoz+iZ9ytT+8xc0GeT7ZLgeCyzwG2zlaGnH8iVwC612PCx8J2H8i8lKgp61xpXxHMjKWdESxgnGOivj2pGXekv5PmMpXbShO18Rv3Yl77ezHk1tdaCiBNmVf2K1q//wVeonk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eMyEaOZj; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eMyEaOZj" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c70fb6aa323so216998a12.3 for ; Fri, 17 Apr 2026 05:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776430196; x=1777034996; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XnRZcX1V5Mt/WiCCq9xYJmYuZ/r7Obi0LyG4op6I5lM=; b=eMyEaOZjBv1zdiemUC++B5YWJChQRD13zT9nF6VnXkZ9Ygd9/k00Vp7s3192rIj01U Thh0LZ4V/E4PM1OSCPcAAtrg/YXDb1WkxtGmteBVk1zWwcBp2jtLXKy298fua1iqbQ9V UQi1e0c/QhLslUy8pAuZhkSeu460utVT3YtOU5Ozy5jVlsBSY84dwW48kLrx278nig7n 5BemLmYiMA/F3pkZ74Bjl8UnY6vR0kWtpeaad3V+gJjCFSq67GhgP8nszPWYxR5ECoHG 5XaF66H32O62k9bLMPB5gZRZFolD3zVwMwSPcEksAfn+ELDP2rGGfKlF/F8RrV6NxpSS B7cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776430196; x=1777034996; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XnRZcX1V5Mt/WiCCq9xYJmYuZ/r7Obi0LyG4op6I5lM=; b=I9lJxEpusO+ibaEyXgTS6vwTFmoNZSM50+NmIykAyb7PwVNRFg267d0fssI3Vc3Eep SHreBDknmfZCKke8oHGG/vx2fc0JyHaW/UmZPLOTgb0PEOlzTR7rUOL7BevF13BTu/ZX KfBg1uiaBEDzmPfZHwHJPVqY/QNXYyyzEwJ9p4AIU6vq96jTJ4clnmT+LsinTzjDaRil 5oMCtt/HOCRTShFKpEWwGVUJLiuK1cqz5zn9u9fPYTOOr7PW8wvLt2Edfgy9uCDjHgwB s+wf+Yn7rwPUtFa76c2YtH/2ZC6QOy6uy7NL8xxICDUXQdSOEhLcTN4f8WjYDKne8yYg 0IKA== X-Forwarded-Encrypted: i=1; AFNElJ+6xiOV97kJCd2ZfAYExVh6zwKZPj0q18Cpr8yXWQ5gO9695/ZQ2xvqK3s+4xVJR/WYhuGt9ax8/JLdPNc=@vger.kernel.org X-Gm-Message-State: AOJu0YwF8JWByB0Iv9xuqOAgLwOlv+e7HYoFdW6lOl8Mnyq3GnJigesI S8e0QNZ5ILcpBPo5j+D9+/vAEEahw0PgASCsg5DF+yjGcsbc66eNCipG X-Gm-Gg: AeBDieuge7Q4W5YUo63xCY2+LVWQOgP2y7tQOVwnSHCzmnnuoqDWR10HIYI2i109GJY ngFWf6Y99IM3kNdjXnPjggQTUI7EVX3xHGr1vo0uEkX2dn36ecLa4U2J9zgy1YveliaF8uAjRGF b7ZIUSJIshjIuJk0Bm8qhjcZO6ognYmkxjv9MJqFGIBi6xYnxc87VQUkIWJr/q2ZvGQIwQ1HZlC phq9W+WqNXU7jvA6L5+I2KkKVOC9CDAsIwHy+639l2h1PWZt33Cff4QKQUYptoEliIEC++JEQUZ o5DY16ysgXu83Ek6RDMKd7ci3BAp0G7AEDoSSHstrF5qKFh+ipIYvACPN1SBColPCa16McnaKAN ZJ6QxFvZwjZq//4X9rAKh75twgeXYfbUeZAolA3zKQ+AVLoVa7NExiIofS7+bhggl1orONw1vAo PDnH+AtXVVsOFmmZn0mVV8ZgeHzu/gaD80CA1Rp6kVQBW9chF77XhfKEKQtpU= X-Received: by 2002:a17:903:bd2:b0:2b2:ccfb:8387 with SMTP id d9443c01a7336-2b5f9f534d9mr23127615ad.28.1776430195669; Fri, 17 Apr 2026 05:49:55 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cb92sm19428855ad.50.2026.04.17.05.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:49:55 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, puranjay@kernel.org, cosmin.tanislav@analog.com, marcelo.schmitt@analog.com, antoniu.miclaus@analog.com, ramona.gradinariu@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/8] iio: accel: adxl355: Use dev_err_probe Date: Fri, 17 Apr 2026 18:19:21 +0530 Message-Id: <20260417124924.353189-6-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260417124924.353189-1-sanjayembedded@gmail.com> References: <20260417124924.353189-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda dev_err_probe() makes error code handling simpler and handles deferred probe nicely (avoid spamming logs). Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/adxl355_core.c | 24 ++++++++---------------- drivers/iio/accel/adxl355_i2c.c | 11 ++++------- drivers/iio/accel/adxl355_spi.c | 11 ++++------- 3 files changed, 16 insertions(+), 30 deletions(-) diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_c= ore.c index a310f8e37e3d..03e5744d9667 100644 --- a/drivers/iio/accel/adxl355_core.c +++ b/drivers/iio/accel/adxl355_core.c @@ -336,10 +336,8 @@ static int adxl355_setup(struct adxl355_data *data) return ret; =20 do { - if (--retries =3D=3D 0) { - dev_err(data->dev, "Shadow registers mismatch\n"); - return -EIO; - } + if (--retries =3D=3D 0) + return dev_err_probe(data->dev, -EIO, "Shadow registers mismatch\n"); =20 /* * Perform a software reset to make sure the device is in a consistent @@ -775,10 +773,8 @@ static int adxl355_probe_trigger(struct iio_dev *indio= _dev, int irq) irq); =20 ret =3D devm_iio_trigger_register(data->dev, data->dready_trig); - if (ret) { - dev_err(data->dev, "iio trigger register failed\n"); - return ret; - } + if (ret) + return dev_err_probe(data->dev, ret, "iio trigger register failed\n"); =20 indio_dev->trig =3D iio_trigger_get(data->dready_trig); =20 @@ -814,18 +810,14 @@ int adxl355_core_probe(struct device *dev, struct reg= map *regmap, indio_dev->available_scan_masks =3D adxl355_avail_scan_masks; =20 ret =3D adxl355_setup(data); - if (ret) { - dev_err(dev, "ADXL355 setup failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "ADXL355 setup failed\n"); =20 ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, &iio_pollfunc_store_time, &adxl355_trigger_handler, NULL); - if (ret) { - dev_err(dev, "iio triggered buffer setup failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "iio triggered buffer setup failed\n"); =20 irq =3D fwnode_irq_get_byname(dev_fwnode(dev), "DRDY"); if (irq > 0) { diff --git a/drivers/iio/accel/adxl355_i2c.c b/drivers/iio/accel/adxl355_i2= c.c index 1a512c7b792b..19490a6e1f35 100644 --- a/drivers/iio/accel/adxl355_i2c.c +++ b/drivers/iio/accel/adxl355_i2c.c @@ -23,6 +23,7 @@ static const struct regmap_config adxl355_i2c_regmap_conf= ig =3D { static int adxl355_i2c_probe(struct i2c_client *client) { struct regmap *regmap; + struct device *dev =3D &client->dev; const struct adxl355_chip_info *chip_data; =20 chip_data =3D i2c_get_match_data(client); @@ -30,14 +31,10 @@ static int adxl355_i2c_probe(struct i2c_client *client) return -ENODEV; =20 regmap =3D devm_regmap_init_i2c(client, &adxl355_i2c_regmap_config); - if (IS_ERR(regmap)) { - dev_err(&client->dev, "Error initializing i2c regmap: %ld\n", - PTR_ERR(regmap)); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), "Error initializing i2c regma= p\n"); =20 - return PTR_ERR(regmap); - } - - return adxl355_core_probe(&client->dev, regmap, chip_data); + return adxl355_core_probe(dev, regmap, chip_data); } =20 static const struct i2c_device_id adxl355_i2c_id[] =3D { diff --git a/drivers/iio/accel/adxl355_spi.c b/drivers/iio/accel/adxl355_sp= i.c index 869e3e57d6f7..347ed62b6582 100644 --- a/drivers/iio/accel/adxl355_spi.c +++ b/drivers/iio/accel/adxl355_spi.c @@ -26,6 +26,7 @@ static const struct regmap_config adxl355_spi_regmap_conf= ig =3D { static int adxl355_spi_probe(struct spi_device *spi) { const struct adxl355_chip_info *chip_data; + struct device *dev =3D &spi->dev; struct regmap *regmap; =20 chip_data =3D spi_get_device_match_data(spi); @@ -33,14 +34,10 @@ static int adxl355_spi_probe(struct spi_device *spi) return -EINVAL; =20 regmap =3D devm_regmap_init_spi(spi, &adxl355_spi_regmap_config); - if (IS_ERR(regmap)) { - dev_err(&spi->dev, "Error initializing spi regmap: %ld\n", - PTR_ERR(regmap)); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), "Error initializing spi regma= p\n"); =20 - return PTR_ERR(regmap); - } - - return adxl355_core_probe(&spi->dev, regmap, chip_data); + return adxl355_core_probe(dev, regmap, chip_data); } =20 static const struct spi_device_id adxl355_spi_id[] =3D { --=20 2.34.1 From nobody Tue Jun 16 08:53:02 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BDE239EF15 for ; Fri, 17 Apr 2026 12:50:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430202; cv=none; b=Ys+KyogETlLMMS5DhQT8kDM+Nlg5FmyjkQXBB+P0YbZwMDWFuhtTKQZLCw/nPO/zTHe5yiPkY4ic8iw49zRtMilj42DfN0xCFzs01TEfzG5Gl4KRVwxTuBcFX6ZlMo+bDfF++1InktKpxY+bgIhurEIgMyZwdcOgpzawUsqNhFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430202; c=relaxed/simple; bh=efwicCyrZDEtkztr6vEZiYX/J7Lp4tCEUvHc1dH2h3Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ym+YkNXuKkRVXWUaifamLBGxvVePVtnBwgi3aCLgBL/EWX5B6y5aIIMMjk5GMXWP1njAsvFvARGWweKE/fimcG21d5rLP7tOLg0awlTRSd+q4K4ul3QQ+n4XBGFrEfeyXbD8qtO82gSGnJGJz9gv5RzyzWuIK9BctB9s+BpZSRg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NwOU0yLc; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NwOU0yLc" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-35fb0bb27e7so437585a91.1 for ; Fri, 17 Apr 2026 05:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776430200; x=1777035000; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ihHREKrqctIVfsWwTzXBg6atiRkWkjOXg5T5trA8kd0=; b=NwOU0yLc/F99nQicRfom8whD/UflaURuvxOj7LsqEbR5R1wP2Me509/SnxPxevPcgl MA2BNF3+VWmTwD6WeAtEhXNVtkIO7PZbth2XttW1bZ/xLPraEICUtqDbAlYgWqYVUffe YxgbCPwNF1roRi4zGuFaajEGK1LKewz1y9v05OB9tLC03ojMbyufTFGXHtBa6uS7KEy3 4W7aCLAsoVerHjEpTPgZF7K7qMk2LdjN6hGLbmXC8BPfqVa1hFsi3jZ0hiANDmZ9FcmS 0iyQ6N/uNm+oU6AxTnReoAy4ZSrlqvCHBUDe5o8jajalw2PU/nXEAKp8kCz21asVO3nX fybw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776430200; x=1777035000; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ihHREKrqctIVfsWwTzXBg6atiRkWkjOXg5T5trA8kd0=; b=gDrcCDCzpnce7BG5bTcCN3GHZBy9t1ZYTaCnUDRkKfaYEptPZW1wv+iwfMjRiuZT65 ktokX1Q/ujRGbGwm1JK4dTAr6uRPGB00qEe3bZhKbx/nEcA5jt2eQaM9b/6HiNzOjv0h vpFmo/X2GnhhHWZsepnF+jcz0JcbhBpt1T5kJhX7PT6Chv533vxJnnGdpWOQsHdV2iAa x5CaBrPCbIRPn8+Yo3C+KUaNxZeQWfnJawuonhp0QVuZrBC0ubHze4KpzyQLlPVkhID2 9juU2Pv+umpv6Z0piwWp6OHpTk8ZOYqzYUblSypOKxjcZkAFoqT4MZt7rcyJ6gISCVmR OEkQ== X-Forwarded-Encrypted: i=1; AFNElJ8gSL7sUoKKO9NR1SN3DfOKiE0P5cf4kw8LA8ykHhLXFixLolMvqFqczfRk0z1FN8nmOuLxm2pj6QyG/H8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9HgUK0k9AxIm5rqAmlqZRxuFy29hOAvsaisnM+2RSJozShRpX 8J+rEE4w7Pa3/45eMfkWAr5aDOqYCtSe6IdH0QfMv1HUcUhK+WCv+UrO X-Gm-Gg: AeBDieu39SxeWZlJXpBYGk+vEsFc09H7r8t3hAQgeDuCKcl52nWR3ipEm7bbo0PsHZL cvf7IZEo4FiBhKYN8ezkIcVqQVZwgh29UKO5rL4pjEOzbCcPvzZ0r6dEmWCENTetSQN+DjBXHdW ZqnxZLt8OSRf9Pj38qbXnTEwSSXryJ4eZz9fM0ZMDMmZo38SDx6ooF8AWSUVpGv2e3JHKdEvaQQ 8lwC9+wCQ4Urc31G5gHQaGCbkGOmvM4Dqj6wchNLv7XCkxlxQOWfMiRU5XoUHaYrdRf40AQ7c8U 6uoc7iMoy2VTP8B4IfO6taRruIdxkhoNEhulG6vVXTrniVw/dDpX3S4qL3UeYG6rslnFKq7AX68 VJviTWUZPGmQV21N2cs3yTaKC/o3PHgLqWzy8bTxasbMY6I47lrtUQ2nzn9sJr3B6dTKu1M7JF4 qwh+BYz6fvLPkloz+U/20b+h7Fcv4ctbwlQ6Nh8ft+uHTEY8N7bq9EaMV6qzY= X-Received: by 2002:a17:902:d706:b0:2b0:b016:773f with SMTP id d9443c01a7336-2b5f9eb2233mr20425945ad.11.1776430200498; Fri, 17 Apr 2026 05:50:00 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cb92sm19428855ad.50.2026.04.17.05.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:50:00 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, puranjay@kernel.org, cosmin.tanislav@analog.com, marcelo.schmitt@analog.com, antoniu.miclaus@analog.com, ramona.gradinariu@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/8] iio: accel: adxl367: Use devm-managed mutex initialization Date: Fri, 17 Apr 2026 18:19:22 +0530 Message-Id: <20260417124924.353189-7-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260417124924.353189-1-sanjayembedded@gmail.com> References: <20260417124924.353189-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Use devm_mutex_init() to tie the mutex lifetime to the device and improve debugging when CONFIG_DEBUG_MUTEXES is enabled. Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/adxl367.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c index 0c04b2bb7efb..63a0b182824f 100644 --- a/drivers/iio/accel/adxl367.c +++ b/drivers/iio/accel/adxl367.c @@ -1445,7 +1445,9 @@ int adxl367_probe(struct device *dev, const struct ad= xl367_ops *ops, st->context =3D context; st->ops =3D ops; =20 - mutex_init(&st->lock); + ret =3D devm_mutex_init(dev, &st->lock); + if (ret) + return ret; =20 indio_dev->channels =3D adxl367_channels; indio_dev->num_channels =3D ARRAY_SIZE(adxl367_channels); --=20 2.34.1 From nobody Tue Jun 16 08:53:02 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D69E039C62F for ; Fri, 17 Apr 2026 12:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430206; cv=none; b=oKEFh/bVsgMmucn64QUIGncxw44UG6hMim6iqSHI2Ua3s4Cg0FOmIhLilup1DMl3A+HhrslpqBzEz6ziFVOKyR1H6M3BXkLs36sfNbpFM0fELNGE5N8gluG1jTaUL9DI7r66m86dcP5yt+VTAbhNpvMFtK47YSvv1F7XlY9FEs0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430206; c=relaxed/simple; bh=eZR5tp/JVNyN8jS3XqnnGvESQT8G/3eV0xYXffxiDdo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fbXcC6UL8FpGj0FLO0cN2PCYtE1A56ev/9YCtTG2f8mpLTqKcqg1VpL4VLK/ydR6rb3coh35qHU+ylId+q4BaNV5Px4qpNCgH9+EUpejWpmxzwrxyD6+JpxNYQBJo6aq+Dqyp68PIvWrqTJld77Odd287h0fVzkbj0/XBc/+gls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WwXno3R2; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WwXno3R2" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-35fb16e56efso442963a91.2 for ; Fri, 17 Apr 2026 05:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776430205; x=1777035005; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t/tHnp+bIyGjKlYK+3tXrqFm9DxnpPAtI6FJ4Q5u3nY=; b=WwXno3R2FkghZUg12QYmJ1H/niUVt6kxSAaJ9yisLglAH1kKMEJneZusAARe8VQk2X goGmBzw7yirU5lJJ0Aqs3t/knJV2YUxSUXlxCZUQKiohySBH7irevkIaPPtMPXrewL5K lOQInKHHHZVdI9HjCTkpIfJH9hW4D725bKkzvSpzIYQpI+7ySH8IHfCaKyFvT+1LE6e0 +KzMklFmMFJkm8hk9dc1cAwRwBV7CcOHeOyvcj1+HHsGtu7w5x+NtRX8P7dCmsOzG1EL tVcEbraF8k7JgsuVE3eeYZFkQ72Iy8GgnJLQzE1gIvD0X3kxKLewsCo0d/jCsj520lTm Dp5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776430205; x=1777035005; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=t/tHnp+bIyGjKlYK+3tXrqFm9DxnpPAtI6FJ4Q5u3nY=; b=CuvYBgfZvdG+xHpmEnWNU3Y2gj7QUOU+J0L1MCDUYqQC9HTpa4ZCfqtwarUYYc8Mxn 6Q1pVmZPZH+uEO/2G/99xLL1d4jaYqTueKOsCrOS0+7jqukiLoKYk1prjFaxi9GnmljU EpyE3YNmDNxR+bp2vLZ9sXeuXfkLhgiUrFv2CLjO1leg1R16O9NeV+idzLBUIbFst4dV 73AWvU/8cSLfVqFRKhHECMCucTm25d6n4s4EM73QRJ6qbU8JMy9szyIxJcLuZnGHFZeg ngvvf2V4HM1iDYVdBe4cR2ik6Dibo/PJ4J7y6ervkvtA5JgubP4mPIkWLMnZmhg+o7g8 sE4g== X-Forwarded-Encrypted: i=1; AFNElJ/gp1nEXh+TnNcs2IEWlnz5A6MLHV40NG//2IChCl/CzfcYP0bQSE+2EgjJhf4viwc3JO6hSheU94POf2o=@vger.kernel.org X-Gm-Message-State: AOJu0YwF8q6abZiDowmzIkDWzkFJkPPAVI4xT/sZc+MVPg3G7GyQHIPE QhDl4q42YsQ8yOqLgfsJZBI9oeUUOFlW0Quo+cPCZa9vjd9sbZphk4Ub X-Gm-Gg: AeBDietAmwhIgURBH1iczJsTO0Z6tIAQNrMuFHWsiMc8R8V4YV4198MQgOnoVQfP0dG dTNWiOElR+dMuiodg8O0l99lfvqPn7F+3JTe4DbZdHLgnb8hlsYhkznxWjb4E15+4xex2JRTDUh JZFCd4TZEy5xETmXMTLH5cpQ97CDTkYsSGcLc/oTFqT36lN6RlYeyg2Q3dd4MKHXYRUABVg+i9u 7mdMf+pjaBx+3v7NA33ydwzQU9UExue5ZbeED1yK1n9pb0pnLP94mD54tYmeIijYf2BJZzvZFxD rWSAF42pTheatf75P2d2DjkPpHA/63UKNRkXPv8AaJxmLQ09lb9s9PjAyLAGEwkHNVdXrJpmCf5 kmmsXO+5RRjWBPCorq+LVCmxZHUdAVVQDPS7P9jsKp0cZjEAt6mPsDuOZniLahFnRqCOSaoP6dM +XCYs6yXN/U3KHJ+kDmYE9LZ4iQG9tIakEAeBqcio1y8LemxXxdVBq+8bgPbI= X-Received: by 2002:a17:90a:d446:b0:35c:1f29:712f with SMTP id 98e67ed59e1d1-3614049a328mr2711834a91.24.1776430205310; Fri, 17 Apr 2026 05:50:05 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cb92sm19428855ad.50.2026.04.17.05.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:50:04 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, puranjay@kernel.org, cosmin.tanislav@analog.com, marcelo.schmitt@analog.com, antoniu.miclaus@analog.com, ramona.gradinariu@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 7/8] iio: accel: adxl372: Use devm-managed mutex initialization Date: Fri, 17 Apr 2026 18:19:23 +0530 Message-Id: <20260417124924.353189-8-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260417124924.353189-1-sanjayembedded@gmail.com> References: <20260417124924.353189-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Use devm_mutex_init() to tie the mutex lifetime to the device and improve debugging when CONFIG_DEBUG_MUTEXES is enabled. Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/adxl372.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c index 545a21e5a308..1a6ba94f54f4 100644 --- a/drivers/iio/accel/adxl372.c +++ b/drivers/iio/accel/adxl372.c @@ -1299,7 +1299,9 @@ int adxl372_probe(struct device *dev, struct regmap *= regmap, st->irq =3D irq; st->chip_info =3D chip_info; =20 - mutex_init(&st->threshold_m); + ret =3D devm_mutex_init(dev, &st->threshold_m); + if (ret < 0) + return ret; =20 indio_dev->channels =3D adxl372_channels; indio_dev->num_channels =3D ARRAY_SIZE(adxl372_channels); --=20 2.34.1 From nobody Tue Jun 16 08:53:02 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7A19399341 for ; Fri, 17 Apr 2026 12:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430211; cv=none; b=Jn2Ro+OMiXQMULSKK9lNTdLs5+dhy1Ags73nME5FaVfdakVKgaWEdl0PMyoweeD/n2qxC3EZNwJXWcOXjH7VEfxos1I8ky8wTrom6oxbD0TkcSHYyh9C2Pwfh9YyeNSKFk0AeAZkYRE/OxAI0R1OePfH7zrASqjiWlFEfmV74YU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430211; c=relaxed/simple; bh=TarAZlGuEdwHhc5/39Ow2rqN+MI5stQ5673+V9XGau0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BR3q1LdvLY7pKq94IpoRhPea874WbkQdsth1695QpVXpkoH4J2wRKjeZ7XWDcJSD7j+dgd7nbohArmZsmsuqWlujFIEf56emy9Kvfl0LqU1XzCYw2GPPIxi6E4ilDwmWJqeX++r94/wfnmc7oCI7x9E398G3YUFdKslpHDFX7uI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LRCnmZPm; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LRCnmZPm" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2aaf59c4f7cso2911185ad.1 for ; Fri, 17 Apr 2026 05:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776430210; x=1777035010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=imMh6hJBu2Zu1gcmhOVix7OG/ll3BvoGNjzRdYH94g0=; b=LRCnmZPm27LwUw/rR0UXr8Xt51QdURdC4iqAgGFbgu7GMy37FOxVIzstH2mRrn1AUI yGC0LrkEMz84g4ZrSaoLmz4bgodMe939aX3HKJU3z6uVQk9vMPzEHSDbThBRI8qOY/MT aObY0MirvpkZDVFHLJDvm/TRtOibSsm7/uciZXwdRwkZy0N9Ak2f1s5IzKKoIvPyBTK+ JjDn8TEu/mb2V+OS49KzChCDzbHZvHyjBS8d2xUYHGbOH/k876F2CJsvJbzt2Z+MJw5Y WkDzomTZ8SFRq4bNUW3/J9g0qp3eH/ZENoIlLadFqmqcEZv2Kt/zLHhSRRJv2HyNxfNL +YPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776430210; x=1777035010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=imMh6hJBu2Zu1gcmhOVix7OG/ll3BvoGNjzRdYH94g0=; b=m7MLLUlKa8Gk+Wk2uHjoATbt3Ppw0R19uJE7+b/u6Y8HiQWPlvj18t6UXSYGOoWwWn T6vvSRTVyptEn2b3XM6Xe3kNW6dc6qpGjingNHKYIc9FpkHvzkfR6z8S9uhFaqehb5bP qjla8rgjn+PlzZ1zxrOWT64I6o2AVQRQgQMyMarArYTLdI7uAPRR1cjPuzrgPRR3sKqn IvBV9ZlQFTQ0A/lULckC74aL5mbTDCjRapoNrR10RBC4c1qqtNZCKNfFZrgDS1tEhAb6 cgy5p5+B8Rj3yPoGJehYGRmJdWXRZzhdzixwgaEe8lIqD0xigPXK6O9htgBedU15kTxP 7rYQ== X-Forwarded-Encrypted: i=1; AFNElJ9CBejwH2Zmjese7p15aEu5/GoQQp7a2nbACDLSskZweBA0LDqwSFJgpzwfBICDD2Q0LvNXJmjuTVyeQz4=@vger.kernel.org X-Gm-Message-State: AOJu0YwRQGDeTOROQayoMifQtSukcfUSdgCzyc8ZBpRFPQDP+eDHg9oF DF8uyECh2dcdU/Bmv0D5+tscBxqcRAN0Z5a5RgKIBYT4uNtnFWIj5jbB X-Gm-Gg: AeBDieuglYI/VXn1ZmJUfVIt4fBZxSPWWGv068DDfgTu9zl6VkSJIDViQsO5RcQyB4P rc9cYnlQPI8gqJ+UHMvz42w/DehP/fGuvNSt97KiIyBzLqVUSEr6oBi2yqhsnJFw05SKuCfpgzO AaCAbyzdXwNSnfGuNurqDGiJCMuxX/TXMJGPoY50C8PZ7dbABZXp5bBv13Cs5yLzrJh+p6wQ5eq kca07rhQCtXkT78p7mzEiTCLBuVwuCqh5i9OCz8gvrMUvFxM+32/2Wibc5YKUDKoIp/xdghrE/o KdtRvbrCodNHSEmm+fniyO3yWPZTPkvpMcP2WZ8FAWARIXOxdqHZc3X3r118QDuSr6M0oWwMrwo 2lP/siOozaTRXeidS2jI+wuuyC6ZKox0kwpDmVwotF/wv5iEgKyt9jW61JDkWJekRDGbBd7m/Fg tadj6huYDYkZ99OR8kRw4IdUsgSDm1NBbqnuPDVx/Uh4xtbdoychygqRFWzBY= X-Received: by 2002:a17:902:db0d:b0:2b2:4fe3:7b89 with SMTP id d9443c01a7336-2b5f9f52879mr26795615ad.38.1776430210102; Fri, 17 Apr 2026 05:50:10 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cb92sm19428855ad.50.2026.04.17.05.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:50:09 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, puranjay@kernel.org, cosmin.tanislav@analog.com, marcelo.schmitt@analog.com, antoniu.miclaus@analog.com, ramona.gradinariu@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 8/8] iio: accel: adxl372: Use dev_err_probe Date: Fri, 17 Apr 2026 18:19:24 +0530 Message-Id: <20260417124924.353189-9-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260417124924.353189-1-sanjayembedded@gmail.com> References: <20260417124924.353189-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda dev_err_probe() makes error code handling simpler and handles deferred probe nicely (avoid spamming logs). Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/adxl372.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c index 1a6ba94f54f4..e375d068a3f5 100644 --- a/drivers/iio/accel/adxl372.c +++ b/drivers/iio/accel/adxl372.c @@ -1316,10 +1316,8 @@ int adxl372_probe(struct device *dev, struct regmap = *regmap, } =20 ret =3D adxl372_setup(st); - if (ret < 0) { - dev_err(dev, "ADXL372 setup failed\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "ADXL372 setup failed\n"); =20 if (chip_info->fifo_supported) { ret =3D adxl372_buffer_setup(indio_dev); --=20 2.34.1