From nobody Thu Jun 18 08:01:16 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75D322475D0 for ; Fri, 17 Apr 2026 06:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776408826; cv=none; b=WuyikwIr9Pv8aJ9R9r88SOcaGjmomJq24+MuNp54E/0/PqwTgu2bOv8mkEgTdJSZcdIg72G52wwFB8Yt+uvbCze/5jll5l+s7zxvfqEYUTYnfR2dy7ltCJ75nCtj/xWw12DCTiVi7pEPDDb6x4G07zDmAg2b9b0OcAD+hwdAeqs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776408826; c=relaxed/simple; bh=uZBkgnwy12Z6S+MN3Nh7ARIhFyFzyr3YpSPDxdevAWc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Cr8M6kNiRI5ekOKtMayAgVb1RWpA+MpOI5gGRzT7SMEpEkBCiEVEgC6paOOFzPdPTYAvlj/80zcFI+M4XN7GfX3VzQ7PVn8/HwpUNvrtBiJ60qHvhvSFqx4QdKDsUTzibIYefAcUOn5Lo9yn9M22i8OKEIiXLE5gwjp8Liwdgko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HuSOQ0Kl; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HuSOQ0Kl" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35fb166b0c6so769484a91.0 for ; Thu, 16 Apr 2026 23:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776408825; x=1777013625; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dz2TbEulj/LIiFp5mSvpOE3UlRqu5LHEOaLq1tYoI6c=; b=HuSOQ0KljIGWqvU2uwQS3GR8tKCbQtjGxLouP/eeHZ7XSXdmBuNaiWnkjqLKbxyt3r B593F0VZUHMhfld/UrSTBBMvgqHr1ZHbZtLlWyCWGPQitMtJEvDe2+zuw7w8w+dVddrx /cOJSvWzJTdR2SrgEE1GuJnM96l/8NmkwDYpqNutE4j9bBMIe6TD4Exh5a8eaEjs9yaA Nc8VBQpLHU5JGakiABXJvnHLsXMT/UlSa1V1kFHQai94E8iSW07CKY3r90liU2okjX3d wY/iriSU7+NAqnjJKAi3ku839HdBga1hKWOPlfWjj2PJQaKTTbhopPoRLHTtNGTzpcy0 zB3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776408825; x=1777013625; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dz2TbEulj/LIiFp5mSvpOE3UlRqu5LHEOaLq1tYoI6c=; b=gpCQtiEB3GhU2gqurg9nlux9UB02RQuw8GKfAsxsr8HoxYCCh+qheJv1eZk0PeX5YH Ysb/2bTH8OeQR31qkrcy1VCblsZ3mFqWGoirF82HN7/xz6fZjLhSbxhRmVGhwJ4zT1ZJ bXM9Ud0sknLlHZy0oKZr6fzwxqDXUfwu80JGiDNEs6LH/bvkR83//wUb+pTvLfKqYUCP +5YGcyerH+gvuijw9n4X20m/InpgJcYuxSCB1SRXJ09msryrvNqf6oA+JSrVAFlyIImb 0U4RpluIifGCCaiWwPltSN/qtzYqi0SvHafVO3/BWCq3e5yoE2o8MTh+nPtQq5LXaHuo UvrA== X-Forwarded-Encrypted: i=1; AFNElJ+4GU9ve6xygWsZuRuNrQtmkLwtV1QwmVvs2m3VsrsP6ytDNf8drPq0IkhK/6RAT5zYyf148sTmGk3LpMc=@vger.kernel.org X-Gm-Message-State: AOJu0YwtmmnC9Q0HE5BElm9d5OF42wxHGdcwBfDhZKrxXgdrxBzIlbG/ lpjshI0wgZU/3M8C0X0dI6ZQeIHvZrL2b3nSSPTxRNqGpqCNabQuMYiz X-Gm-Gg: AeBDietZ/3ykReczxxiNUjgNJCb2St+CmYlWzcIAUbjdeetKVzd3AwNWb5zBtx3zhYe NAndHSHTZKaBxlIC7lsbuhFjwl0CxkKT+3MeKoTsk2dLUorrKAxxTqaf9oKb6sxjYBl8csOYWEs FNRJnCOb7/eNMsTameJBR535Iq8HAnlcVjz0xsqokBu+8ag0OC3yds1b/+Bi0oqZSjNv1y9pu+b q1JdfFk7U42S35cQL0OEEHVsWeVrzErqzjnnMysL4sDc5koMT+Bn1lqI6tJFZ3ugYAqKL0jPCtj wMRpP/ZRf9sJ/vfT45BQWqJPU/W+rqi9RPgeSejACJode5URQmBEPkDQ7vBykJdWFkAY5fsI344 R+uIKiSgEvOc6XXk232koW3XOn/K65JNCjEZ4ZvYzh2M8WewONtu827uXQ/WG8xr2epC1ETToVk Y+gp7IODIzRASRC6imq3roWwFaQex9G4W8HtaGel36dQ== X-Received: by 2002:a17:90b:3d02:b0:35b:d795:cf5d with SMTP id 98e67ed59e1d1-361401ec4b4mr1280969a91.5.1776408824736; Thu, 16 Apr 2026 23:53:44 -0700 (PDT) Received: from lgs.. ([2409:893d:1140:1e34:335a:efd9:dc2:f12e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-361410bafa9sm978644a91.15.2026.04.16.23.53.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 23:53:44 -0700 (PDT) From: Guangshuo Li To: Mauro Carvalho Chehab , Guangshuo Li , Kees Cook , Hans Verkuil , Jonathan Corbet , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH v2] media: marvell-cam: fix missing pci_disable_device() on remove Date: Fri, 17 Apr 2026 14:53:30 +0800 Message-ID: <20260417065330.4032892-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During manual code audit, we found that cafe_pci_probe() enables the PCI device with pci_enable_device(), and its probe error path properly calls pci_disable_device() on failure. However, cafe_pci_remove() tears down the controller and frees the driver data without disabling the PCI device, leaving the remove path inconsistent with probe cleanup. Add the missing pci_disable_device() call to cafe_pci_remove(). Fixes: abfa3df36c01 ("[media] marvell-cam: Separate out the Marvell camera = core") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - Fix subject prefix to use "media:" as reported by CI drivers/media/platform/marvell/cafe-driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/marvell/cafe-driver.c b/drivers/media/p= latform/marvell/cafe-driver.c index 632c15572aa8..22034df6cba9 100644 --- a/drivers/media/platform/marvell/cafe-driver.c +++ b/drivers/media/platform/marvell/cafe-driver.c @@ -609,6 +609,7 @@ static void cafe_pci_remove(struct pci_dev *pdev) return; } cafe_shutdown(cam); + pci_disable_device(pdev); kfree(cam); } =20 --=20 2.43.0