From nobody Tue Jun 16 08:56:46 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B424C3264D0 for ; Fri, 17 Apr 2026 15:07:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776438425; cv=none; b=VWdFcafMmyl83TaMMNv9PibClCLLAqhUSC9wBUaYDOveGHA8i6IPtvCKiVWMdpHkXezfrGodu5UHvAXc6m0mA8oGF2x3mcFeAcvLPELPksdfzzCe5F2oCif9upv+2eegMtOHQfv7CS/6/NIC2Ub6Ctep0y9lG5r/exwo1HOTEwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776438425; c=relaxed/simple; bh=+MwV8AsdZ/5jaRACYsk23cIdHiV4nVvviraIMeQqn2s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=qR17zu88nQEnp0aIkvh5iL2xwV/oRSLLjuWdrsU3UCzypOO4LX7wy8QvsfSibys5do4c6HHkYq1ZfQvKepaqb99HlTy3XnbA/EmLs9l58gDbFueIQPp94Hl+RUQAuHyo7AiMOL3zKpcQiDuXqsikaSIEio+vHmB53s1gdPy1j34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LcTLMg9s; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LcTLMg9s" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3590042fa8eso638744a91.1 for ; Fri, 17 Apr 2026 08:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776438423; x=1777043223; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=o6tFApCIoJhXtGwkpF7Y8a0eo4V5rb44+8Jp9WUbXyI=; b=LcTLMg9smZaE58HBpc5ehd2a0Oqb9HGxtGtwB/2hHI/1ieWRQya/wDp4mJF3KxmItm oPSa5ieVdLvUulCXCgE45wLIJSrz7+xzKJkwsObwBWJ/7ub7WTugoAxUMqyC4QPfRegx E0E9u1TVbYDhSwvV7JRgHSLldhg2PQwudmfbAslk9OLewP2LQb4hZ6Tr/FXmTFSdB+ya F0SKb7eb2VorD0xPzPzPoaOhMjKF+57M6tgqpAabUTXZuCLFuk75LRkv156eg7UbBOr8 ucSXAQkypK6PKjjTwXlXXlYY3VHLBwFRCRDt11SBTB41SkrEja9P3P7FXTY4ZfEGEpQf RE7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776438423; x=1777043223; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o6tFApCIoJhXtGwkpF7Y8a0eo4V5rb44+8Jp9WUbXyI=; b=Ncl5CDkGwYK+2yzd7BtcgnMs8XMkbtioBEn0dMQWQYm7D4tuXKMVwFvtbSHE4xOeBi vZFtMuKOUXcwf1KVzFY1IOpbhcTymO4liIB3yia9WOLGdEIbqoJ6ExWw1/XeJQdImQMO oYK3951DKNryrLhsMu37F9t524FowiHGBKk0GyyZHoAX8fPa0Otm4s4VUETC7nUZ3ICd CikgR37tkPx1UZph6qDSj8xI6/UapUHvjXG47Qsveclwz30rXbZ6fFhuOP4Z59nc9ndx D1YTOs/fAtDTkEhVVxBDtW0PJcyCQ0U0/WLhdom78pq6ItXPURGO5Hmty7i+QCkDTKm5 PtSA== X-Forwarded-Encrypted: i=1; AFNElJ8AgUprYKZ41OPXTlyMndvfliHDgPgknqv4INTRgY2sdG904avZRxzi1YSbrA08vzmcb0UfOGqEE+/hNjY=@vger.kernel.org X-Gm-Message-State: AOJu0YxhHan5O+KyPjwEKTqnDX+B8mgEEV+nUna2T+HzOYF1cV/nl+97 KJRJo8vmO45ygiQeT5IBbJZiDpqibozu0fMXYt9Jjzo6Z2QJtP6kw0c3 X-Gm-Gg: AeBDietu2X8Psmb7EbhmcVbhoc0DHH77t+8NZfo0VYSvhHMETWUXmlods1ahDP6YsZ2 BBrrkYeLp8VGGvrKpivq5My9IRA/8KnsMEca91zVDPJe6kvN5NlAbYtufT9B69LxPfdSinXnfG+ c/7XzUFZvKman5yEyKAIIT4xlJN+iVXEluj8cOXfbdNI20f67rOBHjRuvNl3x6qujUkTfXxpG3c QzSlkDRsv3lFk/yH51DUm/CSAVR6MA65qPITPam9RGa8iEgGKoyvSKg1A71OJzM3DvdEK+OVQNi 7dedtZ+C2j1Ss36sRWxlT5aoRjFCTll1deBD5w55RxjLiqva8QendL1HdBXVxCnSoN9wO0EYzJj hXmeCZz23XD2egYLf/oeFuADAZNnu3CNL/qd9W9n9U0DxkXPoMbiIkfi2VT+jE1qjMRcYki2e0m mTLZ0PrJxQm1pIQpQ5sjEZCOyiN7sW9z4dSU9ngyV17l8DRjQCOBK6Wj6CQmwFJw91gsL4IXCyb qFyz6Ib2FKt4o8xrCtI3/OisvQlPtav4Q2/yKQNRw== X-Received: by 2002:a17:90b:3b4a:b0:35d:a4c0:a0ac with SMTP id 98e67ed59e1d1-361403d61camr3484516a91.3.1776438422821; Fri, 17 Apr 2026 08:07:02 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-361410bafa9sm2357455a91.15.2026.04.17.08.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 08:07:02 -0700 (PDT) From: Felix Gu Date: Fri, 17 Apr 2026 23:06:58 +0800 Subject: [PATCH] counter: ti-eqep: fix runtime PM leak in probe error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260417-ti-eqep-v1-1-a7db4642d9d0@gmail.com> X-B4-Tracking: v=1; b=H4sIAJFM4mkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDE0Nz3ZJM3dTC1AJdi9S0JMvkZHND49REJaDqgqLUtMwKsEnRsbW1ALX +8WdZAAAA X-Change-ID: 20260417-ti-eqep-8efb9cc713ea To: David Lechner , William Breathitt Gray , Judith Mendez Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776438421; l=1380; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=+MwV8AsdZ/5jaRACYsk23cIdHiV4nVvviraIMeQqn2s=; b=FH3I5fCP44NThJLQdd8aUkxpSVUc74TpVyl8aINWG0pd96WSIjuN3BbMNMKiAxwlAbtqQ5oIw cuiufgeii8DAfmF0yvaXTnDVo5woXl+Vz9UGTiDDRyIPcZ5U4ygZpUH X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In ti_eqep_probe(), if devm_clk_get_enabled() fails, the function returns without cleaning up the runtime PM state. Fixes: 0cf81c73e4c6 ("counter: ti-eqep: enable clock at probe") Signed-off-by: Felix Gu --- drivers/counter/ti-eqep.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c index d21c157e531a..dfa945b3eec6 100644 --- a/drivers/counter/ti-eqep.c +++ b/drivers/counter/ti-eqep.c @@ -548,17 +548,22 @@ static int ti_eqep_probe(struct platform_device *pdev) pm_runtime_get_sync(dev); =20 clk =3D devm_clk_get_enabled(dev, NULL); - if (IS_ERR(clk)) - return dev_err_probe(dev, PTR_ERR(clk), "failed to enable clock\n"); + if (IS_ERR(clk)) { + err =3D dev_err_probe(dev, PTR_ERR(clk), "failed to enable clock\n"); + goto disable_pm; + } =20 err =3D counter_add(counter); - if (err < 0) { - pm_runtime_put_sync(dev); - pm_runtime_disable(dev); - return err; - } + if (err < 0) + goto disable_pm; =20 return 0; + +disable_pm: + pm_runtime_put_sync(dev); + pm_runtime_disable(dev); + + return err; } =20 static void ti_eqep_remove(struct platform_device *pdev) --- base-commit: 452c3b1ea875276105ac90ba474f72b4cd9b77a2 change-id: 20260417-ti-eqep-8efb9cc713ea Best regards, --=20 Felix Gu