From nobody Tue Jun 16 09:05:07 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34AAE399003 for ; Fri, 17 Apr 2026 12:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776429896; cv=none; b=Xp9NJed6u5K6RihuO8DPRfLHzBcM6489H4zhJB3baAfEJBbC44JdEP5LVVumoGwc49T8jaZHeLl6EVudmsG5B0pWwbsEvep4YJRSOv528egdj6aVkf4rkWeQQu81xMUv1w3XwFnreCkQsoo9XULlSUEzbwAuPzH5aJEQXyzXguQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776429896; c=relaxed/simple; bh=8J3euFUAkX555f6UH9lDBy9GyKozalMKu453mhRKq+A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RzjbfUdkxcS1p+sEDUoVrq6XhI2uqUfICNLMckJwQs+K6UEbTGGLj7+08csD5Jg+bltNoOjmxc+8n5eYKmiiEeQHdoYk3SF5v2nNtEKTbd6xqYs6CrxrcyZi1X7ZmY8W7xyMnPSscqfltPAyLlTLSQHZyEF2DWjNezoGd2FFTGs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BbsaZDRT; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BbsaZDRT" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso7493615e9.2 for ; Fri, 17 Apr 2026 05:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776429892; x=1777034692; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1zS1PBWa+JXK0MkE3TTgbc7YFAJrep/RIJGz8IkXGLY=; b=BbsaZDRT7pc50n+3rQsOL3Tpjt22oUSU03SocCMEqcJp/TI8f0HFvGlPw6ASqTgq0t m2M56zFMnpN1BdU/nDbFI/afqls/r8qD215v6aSidCDT4U1t9oJf4bHrd05zEpVxeBB1 0dolk9oOhJJ3h3Eeb0IcrZeruNzcta0GtN6T5AgkBJJ9JrOHGTrkwsUsvWGprntzjJZb oP8P1V2uuYg5zGeelbMhZzPBbC6bC+Km2vYeVzAxcvKxr7luPwnrAc4sqCCh1xKEM5/h Tui6Jz0YEGTw1vl3e96p2GU/MKH1w/rzeKGzPcghiIvNtRpV4ORzMbpWobHMszcLG9a1 n0rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776429892; x=1777034692; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1zS1PBWa+JXK0MkE3TTgbc7YFAJrep/RIJGz8IkXGLY=; b=TQerl7OYBkmu0caRSUc33Vb6+8gCrJ0rWMFpmnP0IEIxcFQ7ZuVIGHNS5nOPw/Nqee g0XGhfHzRFYHOAwKggYQgcUy19ezMuMYIE9f8FgB9fLfWMpbzWkiyQBBWkNNW4BJjOse v4sLKNDWUdfEUWnQq3xieHRga3r/j9kYS/+J4YsMHDKRdxB26JvWtyhRZsdQOIhSOwIR sXkg34yDQ0kdhZNDNthRh7lSleY/84g2Q3KpYvSk30PSECrK4o4EBJZL02gal/LmVp6W 3YnjRLSdI8mBxTJI8N/TiCA8vJjzRUWG/frR2us7Oa1NLnSzuz4Q2zxsbfm86ixEtaBo ftbw== X-Forwarded-Encrypted: i=1; AFNElJ81uov5ZjMLmocQcDofrdSBAionCsJlszWoqDU+INw8VZO300vH2yl7D4WN44Ft6oh5OI0twQ4t7P28bz0=@vger.kernel.org X-Gm-Message-State: AOJu0YzoiiXkmbShOZBYevVdJWXnLcbBM2W/9UkoBTD8zLxmRFlKxJvG KfGqR8k2k7a0Z6CoqJtY1GytxP5QIjDO0PpnXv90bZlv+4JU85DcuPbj X-Gm-Gg: AeBDies4dVz12x+cC4kbT9hTQQbdhY/vs5qwJUBS8dnQQgiq8GN3bGuM54/m1iPpz2c ggjLuVmEQf5clZFw+Y4x8h/G2B2fF8SCqx60gBN48riOW3UkT181TeZfL5CIbhfBPsQWyOOrlmS xGslCqSxaqTW7IxhK8BK8MzRHJ97zV2g8mBqTYC+/YfRWqmeTGw+I6Rz53ndb0XwPSoTlYAYUpu wiRbXKyVEqOcUPdL58PjHI07XSSgDzBA4TSU8UFZWYd7Ro83tSf5aRHy1BpiaNhl/xWAwM44OuO XcqEnlEWMH/Oi16cECIk+BdmIjOeSsx3ZG3vrs+S3+x8k3zn5hVMo6BuwxKVjzfPXCNvL6R1OCh 9JcEvsw8vA8BGagNYv1fhcSucQyD10BvkmBeoKnx+OHLRcpr6H3X3hSzRIfbXJPstLSIWQsXUug +uH8EfMmTEgC82oy6D29/u7hIsPpNjpxF4YaV0o4DTXGSeErs40A67+FZ3Z9zI+iGS7HyiwfjgT YYAyXd7P9D1E88yaNvGMvVchfS5+2I= X-Received: by 2002:a05:600c:c090:b0:488:c744:49b with SMTP id 5b1f17b1804b1-488fb74a53dmr28081015e9.7.1776429892308; Fri, 17 Apr 2026 05:44:52 -0700 (PDT) Received: from [127.0.1.1] (cust-east-par-46-193-119-166.cust.wifirst.net. [46.193.119.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc100162sm47416315e9.5.2026.04.17.05.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:44:51 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Fri, 17 Apr 2026 14:44:27 +0200 Subject: [PATCH v4 1/3] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260417-ksz87xx_errata_low_loss_connections-v4-1-6c7044ec4363@exotec.com> References: <20260417-ksz87xx_errata_low_loss_connections-v4-0-6c7044ec4363@exotec.com> In-Reply-To: <20260417-ksz87xx_errata_low_loss_connections-v4-0-6c7044ec4363@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fidelio Lawson X-Mailer: b4 0.15.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776429890; l=7515; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=8J3euFUAkX555f6UH9lDBy9GyKozalMKu453mhRKq+A=; b=TNlxopG6Lb2gnbhvoBiBKAbztrtqfO5uHHa8jEth4SqdDdA/sbfw9WCJlCeqekHE8sI4v2Wxf HIezHZSvA5CD9rJNyJTlsjsczzruBZ3NrYkI1PdM1Sb5ilZ/TdVZChl X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Implement the "Module 3: Equalizer fix for short cables" erratum from Microchip document DS80000687C for KSZ87xx switches. The issue affects short or low-loss cable links (e.g. CAT5e/CAT6), where the PHY receiver equalizer may amplify high-amplitude signals excessively, resulting in internal distortion and link establishment failures. KSZ87xx devices require a workaround for the Module 3 low-loss cable condition, controlled through the switch TABLE_LINK_MD_V indirect registers. This change models the erratum handling as vendor-specific Clause 22 PHY registers, virtualized by the KSZ8 DSA driver and accessed via ksz8_r_phy() / ksz8_w_phy(). The following controls are provided: - A boolean =E2=80=9Cshort-cable=E2=80=9D preset, which applies a documente= d and conservative configuration (LPF 62 MHz bandwidth and DSP EQ initial value 0), and is the recommended interface for typical use cases. - Separate LPF bandwidth and DSP EQ initial value controls intended for advanced or experimental tuning. These are orthogonal and independent, and override the corresponding settings without requiring any specific ordering. The preset and tunables act as simple setters with no implicit state machine or invalid combinations, keeping the API predictable and aligned with the KISS principle. The erratum affects the shared PHY analog front-end and therefore applies globally to the switch. Signed-off-by: Fidelio Lawson --- drivers/net/dsa/microchip/ksz8.c | 67 ++++++++++++++++++++++++++++++= ++++ drivers/net/dsa/microchip/ksz8.h | 1 + drivers/net/dsa/microchip/ksz8_reg.h | 21 ++++++++++- drivers/net/dsa/microchip/ksz_common.h | 4 ++ 4 files changed, 92 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz8.c b/drivers/net/dsa/microchip/k= sz8.c index c354abdafc1b..0f2b8acee80f 100644 --- a/drivers/net/dsa/microchip/ksz8.c +++ b/drivers/net/dsa/microchip/ksz8.c @@ -1058,6 +1058,22 @@ int ksz8_r_phy(struct ksz_device *dev, u16 phy, u16 = reg, u16 *val) if (ret) return ret; =20 + break; + case PHY_REG_KSZ87XX_SHORT_CABLE: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D !!(dev->lpf_bw =3D=3D KSZ87XX_PHY_LPF_62MHZ && + dev->eq_init =3D=3D KSZ87XX_DSP_EQ_INIT_LOW_LOSS); + break; + case PHY_REG_KSZ87XX_LPF_BW: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D dev->lpf_bw; + break; + case PHY_REG_KSZ87XX_EQ_INIT: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D dev->eq_init; break; default: processed =3D false; @@ -1271,6 +1287,29 @@ int ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 = reg, u16 val) if (ret) return ret; break; + case PHY_REG_KSZ87XX_SHORT_CABLE: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + ret =3D ksz87xx_apply_low_loss_preset(dev, !!val); + if (ret) + return ret; + break; + case PHY_REG_KSZ87XX_LPF_BW: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_PHY_LPF, (u8)val= ); + if (ret) + return ret; + dev->lpf_bw =3D val; + break; + case PHY_REG_KSZ87XX_EQ_INIT: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_DSP_EQ, (u8)val); + if (ret) + return ret; + dev->eq_init =3D val; + break; default: break; } @@ -2096,11 +2135,39 @@ int ksz8463_w_phy(struct ksz_device *dev, u16 phy, = u16 reg, u16 val) return 0; } =20 +int ksz87xx_apply_low_loss_preset(struct ksz_device *dev, bool enable) +{ + /* Apply the Microchip erratum short-cable preset (LPF 62 MHz, EQ init 0)= */ + /* providing a conservative configuration for short or low-loss cables. */ + u8 lpf_bw, eq_init; + int ret; + + lpf_bw =3D KSZ87XX_PHY_LPF_62MHZ; + eq_init =3D KSZ87XX_DSP_EQ_INIT_LOW_LOSS; + + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + if (!enable) + return 0; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_PHY_LPF, lpf_bw); + if (ret) + return ret; + dev->lpf_bw =3D lpf_bw; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_DSP_EQ, eq_init); + if (ret) + return ret; + dev->eq_init =3D eq_init; + + return ret; +} + int ksz8_switch_init(struct ksz_device *dev) { dev->cpu_port =3D fls(dev->info->cpu_ports) - 1; dev->phy_port_cnt =3D dev->info->port_cnt - 1; dev->port_mask =3D (BIT(dev->phy_port_cnt) - 1) | dev->info->cpu_ports; + dev->lpf_bw =3D KSZ87XX_PHY_LPF_90MHZ; + dev->eq_init =3D KSZ87XX_DSP_EQ_INIT_FACTORY; =20 return 0; } diff --git a/drivers/net/dsa/microchip/ksz8.h b/drivers/net/dsa/microchip/k= sz8.h index 0f2cd1474b44..5cf7bd90af0f 100644 --- a/drivers/net/dsa/microchip/ksz8.h +++ b/drivers/net/dsa/microchip/ksz8.h @@ -66,5 +66,6 @@ int ksz8_all_queues_split(struct ksz_device *dev, int que= ues); u32 ksz8463_get_port_addr(int port, int offset); int ksz8463_r_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 *val); int ksz8463_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val); +int ksz87xx_apply_low_loss_preset(struct ksz_device *dev, bool enable); =20 #endif diff --git a/drivers/net/dsa/microchip/ksz8_reg.h b/drivers/net/dsa/microch= ip/ksz8_reg.h index 332408567b47..5df17c463f7c 100644 --- a/drivers/net/dsa/microchip/ksz8_reg.h +++ b/drivers/net/dsa/microchip/ksz8_reg.h @@ -202,6 +202,10 @@ #define REG_PORT_3_STATUS_0 0x38 #define REG_PORT_4_STATUS_0 0x48 =20 +/* KSZ87xx LinkMD registers (TABLE_LINK_MD_V) */ +#define KSZ87XX_REG_DSP_EQ 0x08 /* DSP EQ initial value */ +#define KSZ87XX_REG_PHY_LPF 0x4C /* RX LPF bandwidth */ + /* For KSZ8765. */ #define PORT_REMOTE_ASYM_PAUSE BIT(5) #define PORT_REMOTE_SYM_PAUSE BIT(4) @@ -342,7 +346,7 @@ #define TABLE_EEE (TABLE_EEE_V << TABLE_EXT_SELECT_S) #define TABLE_ACL (TABLE_ACL_V << TABLE_EXT_SELECT_S) #define TABLE_PME (TABLE_PME_V << TABLE_EXT_SELECT_S) -#define TABLE_LINK_MD (TABLE_LINK_MD << TABLE_EXT_SELECT_S) +#define TABLE_LINK_MD (TABLE_LINK_MD_V << TABLE_EXT_SELECT_S) #define TABLE_READ BIT(4) #define TABLE_SELECT_S 2 #define TABLE_STATIC_MAC_V 0 @@ -729,6 +733,21 @@ #define PHY_POWER_SAVING_ENABLE BIT(2) #define PHY_REMOTE_LOOPBACK BIT(1) =20 +/* Vendor-specific Clause 22 PHY registers (virtualized) */ +#define PHY_REG_KSZ87XX_SHORT_CABLE 0x1A +#define PHY_REG_KSZ87XX_LPF_BW 0x1B +#define PHY_REG_KSZ87XX_EQ_INIT 0x1C + +/* LPF bandwidth bits [7:6]: 00 =3D 90MHz (default), 01 =3D 62MHz, 10 =3D = 55MHz, 11 =3D 44MHz */ +#define KSZ87XX_PHY_LPF_90MHZ 0x00 +#define KSZ87XX_PHY_LPF_62MHZ 0x40 +#define KSZ87XX_PHY_LPF_55MHZ 0x80 +#define KSZ87XX_PHY_LPF_44MHZ 0xC0 + +/* Low-loss workaround DSP EQ INIT VALUE */ +#define KSZ87XX_DSP_EQ_INIT_LOW_LOSS 0x00 +#define KSZ87XX_DSP_EQ_INIT_FACTORY 0x0F + /* KSZ8463 specific registers. */ #define P1MBCR 0x4C #define P1MBSR 0x4E diff --git a/drivers/net/dsa/microchip/ksz_common.h b/drivers/net/dsa/micro= chip/ksz_common.h index 929aff4c55de..482e79cf6ae6 100644 --- a/drivers/net/dsa/microchip/ksz_common.h +++ b/drivers/net/dsa/microchip/ksz_common.h @@ -219,6 +219,10 @@ struct ksz_device { * the switch=E2=80=99s internal PHYs, bypassing the main SPI interface. */ struct mii_bus *parent_mdio_bus; + + /* KSZ87xx low-loss tuning state */ + u8 lpf_bw; /* KSZ87XX_PHY_LPF_* */ + u8 eq_init; /* DSP EQ initial value */ }; =20 /* List of supported models */ --=20 2.53.0 From nobody Tue Jun 16 09:05:07 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C7A039B49D for ; Fri, 17 Apr 2026 12:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776429896; cv=none; b=khvIeY8nV4dPsMMWzsRJ8u9zkpYFp/CpmER//yAvMbczrnYhrss98sSzGqDKv1mB2y7XAjIZp93zDUtgoUFjWgFdhcuygPbAHHnsKTKEWiLvtJ1rCcxhafNAtR9SUCekIJtezx7Q0+k7Miatj2JKhaD9RTF2kO2k8oDi7IZRkB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776429896; c=relaxed/simple; bh=Fs9VVuBPOJN07xoYLx1JLlEnA16IiWjsvm6UMCkZ0AM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qqUXWT8UKyFC5yrcdrgNVZJUjhmZBCaFpcMLMMYreth9H3dWjNt76S15tBewOL/oTr3ui5M3gROc7UViRxBmI8MrtbpfoIzZ7MINH0/zQBxVKkanCpoHH4BVZsMhjiKU+VIGhizWYO8r5G15vUlAWAkrsQx7FmpbGe7nxUbcR2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YrxtEQ6g; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YrxtEQ6g" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-483487335c2so6443065e9.2 for ; Fri, 17 Apr 2026 05:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776429894; x=1777034694; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+eZVvumaL4Znlvx432NO7Lk63ndA9Vnlz6LqVg/cXUQ=; b=YrxtEQ6gxYnF8qyghSnS1plIE0NcBJtLgpYnEhvarpTCdDzOJ/wq8p6DswURxivKUU 9h0m2peUmA2QqAl5ElclXxlTahuhEVtV559Hp/w06tf61a1Y+J6GXopm2DSM+yTQwh0i aqOdZqLSbrS2B79PYclhS0mzLU6UsgytgrCJkxTyYDKThn8FM45PFuP8oA4wQc5+WjuR yCAx2XjyoMD+Y2cWmF+Fcfqk0RXk3UXy0YbvkZxsyu7QzPNo729glDErUAVn34fXM5RM XQbFi4uke4keP4HXj0Vgj0bT63STMqR9Q8Buz/+NeYIRlo1laEMjKzKFnl9aL252+XTf Aeig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776429894; x=1777034694; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+eZVvumaL4Znlvx432NO7Lk63ndA9Vnlz6LqVg/cXUQ=; b=JSihzevv+kljmLWUIshxKvolV1ZJcHaGmJ6k+OJiJZpTeMRHvDZ1m9FGOC9/utWSjW kTo21BwuqqNqYByYsrOPvDKHplbLOaPu6V9a+onIZ8t/8Fz0+MbXOlZhoJIxBzDqpvl6 MV4PrEzrcjILFi1TWzSgqIpH1VbZM6ojHikc1KfpXcQrW0FWo4RaI7r828BjQ+UHQTK6 IOSwCnPOM0UYafIKU/YNythOH3X4eFyPUPzp45WZ8ElrXcemJHxq9o2PnqVAKKGTzSFB NHQPfTCTo1h40gLx4fieYnmdEInqGWLb1a4VaQ9iRYfacXdA1Mo+F/mkmDbWo6FutK6t hS8g== X-Forwarded-Encrypted: i=1; AFNElJ9je1Zy5r4jPnuvEkPzzhEXzKziWQLFUmmSsE513aJBy2L1QKYor4nXomgfJbN1sycfVOsaE6mEcXUjXYc=@vger.kernel.org X-Gm-Message-State: AOJu0YxaX91+dDSxuMLyrNKL6PNZmiExW06jHrXL9BMN+T/AoDqOkKsL j57TaA2QwkXEKaFB/K4SK8012jidTi9rUcsOyq1Q0lP/PnVZWssfJ1GI X-Gm-Gg: AeBDievoGOPjRzEqn+NyMDy2DHLydG39tj5cu/F83o7aKRqmAoz7oXCcj6RCaS/Lk4Z duDmgEldBoncHpdCoqt5W5tk1MFVmk6FjZk8l7NEELQA2/668gzlpLrRKI7gZ2nMQLBHuFbjfgh Dzy3uIFosLExQ55P6RoBR37Dgc/gsj7+Q13fIP6RsBFAQHKFMQJH9XixtQaXP9OQO7fjbtWVH0s EYANG1aHr9gMMio+7Em63aFr3YxeTK1bGFNYlMi90xhM76q6PjZDAVVL/A3hTuM+cyss7ZNxZcB pw8wLu/YRw5WyiS1DGgZ3wt1/ro/AtPnnGUuoe0tw/lNrGCzFBmZWdqXqUIe2Wo8Btc27GRG2Ua TGh2edDDWYRQ4qvtA2HM4YB7L9vTICw1YURV0zRobmRc9hHJbdIsjdpDGM+gxAAUcNMUmglwgF9 ldf1/pTKGNC+YChmKOZquwkMITb/dCJTWcUoMjahcD0NYMshiwIl/ie6oYfDvRaAKJAgDgf6BIV sjZreLo+Rou7wQgzVx+ X-Received: by 2002:a05:600c:8706:b0:488:d6eb:e635 with SMTP id 5b1f17b1804b1-488fb753abdmr42181725e9.12.1776429893542; Fri, 17 Apr 2026 05:44:53 -0700 (PDT) Received: from [127.0.1.1] (cust-east-par-46-193-119-166.cust.wifirst.net. [46.193.119.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc100162sm47416315e9.5.2026.04.17.05.44.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:44:52 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Fri, 17 Apr 2026 14:44:28 +0200 Subject: [PATCH v4 2/3] net: ethtool: add KSZ87xx low-loss cable PHY tunables Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260417-ksz87xx_errata_low_loss_connections-v4-2-6c7044ec4363@exotec.com> References: <20260417-ksz87xx_errata_low_loss_connections-v4-0-6c7044ec4363@exotec.com> In-Reply-To: <20260417-ksz87xx_errata_low_loss_connections-v4-0-6c7044ec4363@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fidelio Lawson X-Mailer: b4 0.15.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776429890; l=2581; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=Fs9VVuBPOJN07xoYLx1JLlEnA16IiWjsvm6UMCkZ0AM=; b=mR4AkNjPhMZn06l06xj9UdqZxxVGoI0Xd+48Hhme7bU98YKoUJMqaMTq2ISA0VHrfL51yhyMl 1G/ru9nOvQ4CYDLg0hVi4SfUTzaTVAnnw8CYJgItHlUjcdHrGDhejF+ X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Introduce vendor-specific PHY tunable identifiers to control the KSZ87xx low-loss cable erratum handling through the ethtool PHY tunable interface. The following tunables are added: - a boolean "short-cable" tunable, applying a documented and conservative preset intended for short or low-loss Ethernet cables; - an integer LPF bandwidth tunable, allowing advanced adjustment of the receiver low-pass filter bandwidth; - an integer DSP EQ initial value tunable, allowing advanced tuning of the PHY equalizer initialization. The actual behavior is implemented by the corresponding PHY and switch drivers. Signed-off-by: Fidelio Lawson --- include/uapi/linux/ethtool.h | 3 +++ net/ethtool/common.c | 3 +++ net/ethtool/ioctl.c | 3 +++ 3 files changed, 9 insertions(+) diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index b74b80508553..081d8f2191b6 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -291,6 +291,9 @@ enum phy_tunable_id { ETHTOOL_PHY_DOWNSHIFT, ETHTOOL_PHY_FAST_LINK_DOWN, ETHTOOL_PHY_EDPD, + ETHTOOL_PHY_SHORT_CABLE_PRESET, + ETHTOOL_PHY_LPF_BW, + ETHTOOL_PHY_DSP_EQ_INIT_VALUE, /* * Add your fresh new phy tunable attribute above and remember to update * phy_tunable_strings[] in net/ethtool/common.c diff --git a/net/ethtool/common.c b/net/ethtool/common.c index e252cf20c22f..9c2fe5b626d6 100644 --- a/net/ethtool/common.c +++ b/net/ethtool/common.c @@ -101,6 +101,9 @@ phy_tunable_strings[__ETHTOOL_PHY_TUNABLE_COUNT][ETH_GS= TRING_LEN] =3D { [ETHTOOL_PHY_DOWNSHIFT] =3D "phy-downshift", [ETHTOOL_PHY_FAST_LINK_DOWN] =3D "phy-fast-link-down", [ETHTOOL_PHY_EDPD] =3D "phy-energy-detect-power-down", + [ETHTOOL_PHY_SHORT_CABLE_PRESET] =3D "phy-short-cable-preset", + [ETHTOOL_PHY_LPF_BW] =3D "phy-lpf-bandwidth", + [ETHTOOL_PHY_DSP_EQ_INIT_VALUE] =3D "phy-dsp-eq-init-value", }; =20 #define __LINK_MODE_NAME(speed, type, duplex) \ diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index ff4b4780d6af..5b66e4a96f67 100644 --- a/net/ethtool/ioctl.c +++ b/net/ethtool/ioctl.c @@ -3109,6 +3109,9 @@ static int ethtool_phy_tunable_valid(const struct eth= tool_tunable *tuna) switch (tuna->id) { case ETHTOOL_PHY_DOWNSHIFT: case ETHTOOL_PHY_FAST_LINK_DOWN: + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + case ETHTOOL_PHY_LPF_BW: + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: if (tuna->len !=3D sizeof(u8) || tuna->type_id !=3D ETHTOOL_TUNABLE_U8) return -EINVAL; --=20 2.53.0 From nobody Tue Jun 16 09:05:07 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7704039D6ED for ; Fri, 17 Apr 2026 12:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776429898; cv=none; b=cozn7rrR79j3NLT9z0lxbNOU6wTui75jSCRn/mNyoTBUY4EuR0qTSA6mvPNJM17jI/UsDFIaWXcRyKIezy4XjJDtEZlgG5GJDEzBBQ3/Vl0RkmB6mZkm7Dpa/YSBaOYOiNgtM/AZQO/EpWWFLct9y1cXPIjA+Kwg7AxaZRLVPcM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776429898; c=relaxed/simple; bh=1JygUzA/h3LiigIAXa4eAjNMynaVQWP1U2qxMTvbsiY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SJS7/nHn5UCzk7Lb2nAlxR0E+sSUvZsog/5U17QsXoMLKc0ruQkTGc08GS0g/k5xEkQVC5WZjJ+/P24f7kPw9sBQoUbW01f50y4TROw4fb9+JaFSzk3UdKED8H6VOqOVlJnuJBFFieykDhOuSlLiKnwhenQ7rtVY0/JAvvXuwtE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fVIL01Tm; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fVIL01Tm" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488e1a8ac40so8909565e9.2 for ; Fri, 17 Apr 2026 05:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776429895; x=1777034695; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5AFGmIxEc8dseQ5H/CWt6cOyXOCtB/D+ayVpHCCwUD0=; b=fVIL01TmuUJpBNjIZsTpLz2LY0+P3YN9TxvCNLuaKgUPSuUGJ5N2lUlFiJNoEq0mMv KS//WC3Q3LJsqvnf2GTSDJ9O4LAbuEXY+kkn1HDZL7drxumAULiWYzgzSDIAA8tXUi5t yfXZK9KfjloEQHDOdkQqx5TXBJjx+O1xBukXy+osULdsR11fiWNzdvjyTiOnf2s1KAdC R5MLwwZNAJ5BiQrIkSdFN6VCrFw+cCo3qMJqqq1+rLVPu21u/84RDkch7SaT+h/WkyKK MR46uHK6M4qqlhfppgAPTwDPMxJ+dp+5dmfIg3C1j2fprN8mfTT2gbO42+5jnN7ig6ko hG+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776429895; x=1777034695; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5AFGmIxEc8dseQ5H/CWt6cOyXOCtB/D+ayVpHCCwUD0=; b=IIDU64UozIZTWi/Ak4CcXkPoDWsg2J7/2MhS16e2puUNb14xbXyanyFAx46kqfmG8s ZSvIPnf8uz7+lY61ReE8TxmR5TjU1FDM7NVfIr/cgbNF74VtsFZ01JvxmGSmQN6mvQEB 9OM9cqDPgo3wTo2byigTBoh+9RA576lHsW4gaq6P3Ka8jF2T6JraTfLIH+sZzC9PowWu hqE9AjmFfiVYwCZvqOEpBdIk7C2O7fQe3CT5tcb1z7MC2Yg2C1p3CtjPwfrx4xMvprTl VvsSTZcbbJGVVwlPuI398YVMtfCJOdji/TKa/3+E04Rkvr0RWrTHZRddbRRBmrV7YcyN UkyA== X-Forwarded-Encrypted: i=1; AFNElJ+Bz5APnasfNnhm4DGjBrcgHK1fBZ3w5jLyBmhxXUF46yQ8Xy37hq1ltZEx1LIHe/Fu4dD3lWM73WKP/Uo=@vger.kernel.org X-Gm-Message-State: AOJu0YxDSlFv5OeSYYl0vy7XCbIMLjaFyRI4o6S5SuxaLY+JUop2EWXT Dv8/JAU7tKqwC6HBck8t5kLqy8MStM7fX3brAX1tCpELNe442bdY/NUn X-Gm-Gg: AeBDietKoogGTgoVHNBoDaCjXd+So34E6YaBoMONrdSplTGTO4VBDYsD4gZHRWHzM8m p4ihKE5rxZcr1INlCO0/kcpxD/0OtGOZ8VFAFzCfCxiP4q5yLBTq2O30WjzQVpM29BMFmzzwSC+ HPQ0+8a6VJCxLQoY7MIVxPugsE45cnmc06qCL7IwbspMQbmMwdqb43nTjbosfGJ37Ik3EU2LPPo 4D6RwhwKVi6a+1MYrEPB/D2EkBde8Bq4y9gdd9ky/T+2UE4Up2etsBtU5bEL1lYR8MUp7HNKsfl W7GFB8EwRbIc+MqIqxeby1q1THHD43azaTtSnMnzCgsJx9NtylfE/tqkv2kf47Z6IwchyhPs6L3 KwweLuCBuRVfjqJzFAXeEW4dI7w61+8q8NJhZVMkNcrGJF7WPSa0VpoG3RTahPb4ejS0LDUeDDk Dbt6DPdLH5govBqF/mo2YksLAPCR0R+X3iItzRDMB21sQgoJjTKl26fE7FXAjB2WIFs8ZxiibKc cBp1ilte6vnHrj1fSOT X-Received: by 2002:a05:600c:c171:b0:485:40c6:f507 with SMTP id 5b1f17b1804b1-488fb793228mr40749305e9.30.1776429894721; Fri, 17 Apr 2026 05:44:54 -0700 (PDT) Received: from [127.0.1.1] (cust-east-par-46-193-119-166.cust.wifirst.net. [46.193.119.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc100162sm47416315e9.5.2026.04.17.05.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:44:53 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Fri, 17 Apr 2026 14:44:29 +0200 Subject: [PATCH v4 3/3] net: phy: micrel: expose KSZ87xx low-loss cable tunables Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260417-ksz87xx_errata_low_loss_connections-v4-3-6c7044ec4363@exotec.com> References: <20260417-ksz87xx_errata_low_loss_connections-v4-0-6c7044ec4363@exotec.com> In-Reply-To: <20260417-ksz87xx_errata_low_loss_connections-v4-0-6c7044ec4363@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fidelio Lawson X-Mailer: b4 0.15.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776429890; l=3380; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=1JygUzA/h3LiigIAXa4eAjNMynaVQWP1U2qxMTvbsiY=; b=uEUSkMD2k307AChDuDvHVSyqyJIsk0BHJKOUHRGZ5ubGe5cm3D73BY9XpUE1GUzThd8dwzBGN lyaAREzL7GKBqlmuqMfgG6n1rSwdr2IrCkWIxVgckx8dhtzWBqtsycY X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Add support for the KSZ87xx low-loss cable PHY tunables in the Micrel PHY driver by implementing get_tunable and set_tunable callbacks. These callbacks expose vendor-specific PHY tunables used to control the KSZ87xx embedded PHY receiver behavior when operating with short or low-loss Ethernet cables. The tunables provide: - a boolean short-cable preset applying known good settings; - an integer LPF bandwidth control; - an integer DSP EQ initial value control. The Micrel PHY driver forwards these tunables via standard phy_read() / phy_write() operations, which are virtualized by the KSZ8 DSA driver and translated into the appropriate indirect switch register accesses. Signed-off-by: Fidelio Lawson --- drivers/net/phy/micrel.c | 54 ++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 54 insertions(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index c6b011a9d636..1852e9bd0e01 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -287,6 +287,12 @@ /* PHY Control 2 / PHY Control (if no PHY Control 1) */ #define MII_KSZPHY_CTRL_2 0x1f #define MII_KSZPHY_CTRL MII_KSZPHY_CTRL_2 + +/* Vendor-specific Clause 22 register, virtualized by KSZ87xx embedded PHY= s DSA driver */ +#define MII_KSZ87XX_SHORT_CABLE 0x1a +#define MII_KSZ87XX_LPF_BW 0x1b +#define MII_KSZ87XX_EQ_INIT 0x1c + /* bitmap of PHY register to set interrupt mode */ #define KSZ8081_CTRL2_HP_MDIX BIT(15) #define KSZ8081_CTRL2_MDI_MDI_X_SELECT BIT(14) @@ -940,6 +946,52 @@ static int ksz8795_match_phy_device(struct phy_device = *phydev, return ksz8051_ksz8795_match_phy_device(phydev, false); } =20 +static int ksz87xx_get_tunable(struct phy_device *phydev, + struct ethtool_tunable *tuna, void *data) +{ + int ret; + + switch (tuna->id) { + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + ret =3D phy_read(phydev, MII_KSZ87XX_SHORT_CABLE); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + case ETHTOOL_PHY_LPF_BW: + ret =3D phy_read(phydev, MII_KSZ87XX_LPF_BW); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: + ret =3D phy_read(phydev, MII_KSZ87XX_EQ_INIT); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + default: + return -EOPNOTSUPP; + } +} + +static int ksz87xx_set_tunable(struct phy_device *phydev, + struct ethtool_tunable *tuna, const void *data) +{ + u8 val =3D *(const u8 *)data; + + switch (tuna->id) { + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + return phy_write(phydev, MII_KSZ87XX_SHORT_CABLE, val); + case ETHTOOL_PHY_LPF_BW: + return phy_write(phydev, MII_KSZ87XX_LPF_BW, val); + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: + return phy_write(phydev, MII_KSZ87XX_EQ_INIT, val); + default: + return -EOPNOTSUPP; + } +} + static int ksz9021_load_values_from_of(struct phy_device *phydev, const struct device_node *of_node, u16 reg, @@ -6809,6 +6861,8 @@ static struct phy_driver ksphy_driver[] =3D { /* PHY_BASIC_FEATURES */ .config_init =3D kszphy_config_init, .match_phy_device =3D ksz8795_match_phy_device, + .get_tunable =3D ksz87xx_get_tunable, + .set_tunable =3D ksz87xx_set_tunable, .suspend =3D genphy_suspend, .resume =3D genphy_resume, }, { --=20 2.53.0