From nobody Tue Jun 16 06:06:07 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5081632B99F for ; Thu, 16 Apr 2026 17:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776360633; cv=none; b=jn3h/nfJ7imVGyLkCTo0nMSwxn0Vg5DyG6T5ho7cEDkzX3xtCgMcOFmTy84H/Pe+0gFZLkslJSB/U2LarsO7a1vcrZgvtyqoxPb/OvdH466ND9G70F/l+8Xs1uc04ET0hIKmLm9uSA9DdFb9F5KKWf01yoWJXaU690ZxAOYWP7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776360633; c=relaxed/simple; bh=AOK7AYkvv1obcIpouo3ENPG0MhGWbHfwfKB3qaKofQw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lO1sIkUapSGgmWExel8ykICgJpWKtMDHVeY2YtUueWN+Kmu2npr239UuN7o7YHXFJ40hDt6FB1cpMF9HH7p7luuaee7GRV7cW0qHbBz+BI5qfka6lZ0duQokrDutqEHlPbWQiNhdLczFl3K+YHI44SYwO/Zg8jemynaiAhV7QEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BWFOuna4; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BWFOuna4" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-827270d50d4so7244255b3a.3 for ; Thu, 16 Apr 2026 10:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776360632; x=1776965432; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lSU4s/m9nFxmJ8D1T8BXP5KkkEUp3UCaNpB+YyLW09Y=; b=BWFOuna4MIAwtAoo1LUGn/YmYW3F4gWzg0+N3JJWSoH6lsJhuRRzHKwBG3yHLCdnPn tpqCUi87kHqXfYFOULBVngpzpYGM20hxnJ+/iGKF315uXI+0l9ZJwoV40u/bo4Cke+aZ pd5Y2Qg8Qsz3xum/Z9l4+lrzucMnU7jxuTZbjC97yx8/cPCXxTsUIQKnaYlrFKLIjvog D9sxhSfmkSnUP1JFRK/6LyjOSEeHEMeU3kfg6dj+EeqmH2b4fU+jDxal0qeccLtrCEUB Dg+VN1AHY4GVPXweu5Ej9KwNwLwlz2FN5tIlNMLZxk21HzHd7lh47QqdUxfAuFn9Fr8I 7y3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776360632; x=1776965432; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lSU4s/m9nFxmJ8D1T8BXP5KkkEUp3UCaNpB+YyLW09Y=; b=rAdcaMZ7oB8QjUnhgM3x5g4IHUSXvKXDey1WBDDTtNK+VbpTAvgSCZVUEQQZjfP07n 4o4vzZkhMrTPzdq0YWEeQDyQ787YtwjaRuW36zSvS1/x/fkrTV4MZ+Z/XGNtTsO8jHlB L+PaSrIJCSzv84KA3+uJs2J03ZIgR/X1HOTszm6ZBRm/rkcAcTo6veagmu36Y3pvcD2H c8VGlq0KG6eVr+iZYKRwMt/1JelOQ4CbA3IMtEKlZG5j0xKnHkJE7a9blkzcmWq+iIGS lKWWlUdTumURCx99N/p62yQiSGYhaO1VRow1gBnLY+J8pNat+auYppKhsQqzvyNApTRD YMjw== X-Forwarded-Encrypted: i=1; AFNElJ9t5PGjGSTYHKmAn9QmfRw734QKNdK4gLslXl8xkaDrgqsJWyk+rq00+iwla/OqusA1WJzEqusNerRBD+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzO9niprhAEXA6hKAVi2l6jr3Dk1fjHmMAryHnNvkFCFwEKfROM kznKAtpGJpc80C+JpLaGIz8YQjMCoCYzOGaEl2Jg8kllKX0y81OvC7xr X-Gm-Gg: AeBDiet5T8J7CCT7SlG+ZOw+oGkACaomHvOOlF9bf+ywQ5Rqg0NBnKMEMcy3Ymcdr4t rFkw5eNVlB3OpTFHspKUbYTkTkncKlpaRHie+s1tt2no2fhxKjzS6b4XbnCriIxC4LfXhJvBXlX Evbt6j8q1p86M9N2CXpYLwvd9aGzm43t6iRvTZpHnCih6lCTyGD6EVgCeJtFZASN23xE+HhujoM 5XB9LqKi6lArCScTGHnlHLzmu4SZMBPHfvArfo6snCoTURFLNHMLBT6Te/7wWH1DmTDWF5t3qR4 Mw/eJxrYj3H074J1F8tlLfBmkRRp2ZZmgNBqM9+jQqZzKcgtd0ZrYhTu7PNYBnCUl6HFN5ipdDd Lco4EnT7vvVQasCepOCBsrivszvPFijrvnldgqGFCuHXlDuY6P9As7SqFErcRf2+NOKvsg2N/ii zBEpEts0IspSDtB0J0WADZZpuvbMIgI6RXQKLc X-Received: by 2002:a05:6a00:8011:b0:82a:6461:6d15 with SMTP id d2e1a72fcca58-82f888ad495mr218697b3a.46.1776360631546; Thu, 16 Apr 2026 10:30:31 -0700 (PDT) Received: from lgs.. ([2409:893d:11a8:8d82:9994:1f65:38d8:cb81]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8571893esm729229b3a.16.2026.04.16.10.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 10:30:31 -0700 (PDT) From: Guangshuo Li To: Mauro Carvalho Chehab , Hans Verkuil , Guangshuo Li , Kees Cook , Jonathan Corbet , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] [media] marvell-cam: disable PCI device on remove Date: Fri, 17 Apr 2026 01:30:15 +0800 Message-ID: <20260416173015.3981161-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During manual code audit, we found that cafe_pci_probe() enables the PCI device with pci_enable_device(), and its probe error path properly calls pci_disable_device() on failure. However, cafe_pci_remove() tears down the controller and frees the driver data without disabling the PCI device, leaving the remove path inconsistent with probe cleanup. Add the missing pci_disable_device() call to cafe_pci_remove(). Fixes: abfa3df36c01 ("[media] marvell-cam: Separate out the Marvell camera = core") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/media/platform/marvell/cafe-driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/marvell/cafe-driver.c b/drivers/media/p= latform/marvell/cafe-driver.c index 632c15572aa8..22034df6cba9 100644 --- a/drivers/media/platform/marvell/cafe-driver.c +++ b/drivers/media/platform/marvell/cafe-driver.c @@ -609,6 +609,7 @@ static void cafe_pci_remove(struct pci_dev *pdev) return; } cafe_shutdown(cam); + pci_disable_device(pdev); kfree(cam); } =20 --=20 2.43.0