From nobody Tue Jun 16 06:05:23 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF07C2DEA9B for ; Thu, 16 Apr 2026 16:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776358789; cv=none; b=HHM1nXTTqnsdvAQuONW/tTPNt8j7hN5BrozrqDXop/TzrqjEXDtSqyJ8kUqM63MoPmkBX5m5U7zjz4NVyJXcTSgkGm1H3RPibnfQ3iXvGJZ00wDiSo34bemQy3dEBhyJafRAYwisle3OQUp0UPrlJ/l3l9KnNMaPoxq5Jb0+2LA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776358789; c=relaxed/simple; bh=1LP+9Y9TG4oK4f0ZkbP0a0/ld5plxckV7HRW4ZFOBCc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=u2zcRUIRmJ1Nyp37Yp99AzeRKl/MpLG1NpM/m+HtBBdVGEJ5euS3FBeClUOTi2L+E6I2UsnOg+UmAzquqlOkn+/JFUKEDuOdwYZ/3tffHBOYr6AYb8OAORgOgQhqNpnoQcMeBUNq9zjbPn/MJxOtS0SuGakn8KTjDefP4HJkVYU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j8Nktlp8; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j8Nktlp8" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2b2589c26e3so73845285ad.1 for ; Thu, 16 Apr 2026 09:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776358788; x=1776963588; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VksxkcPuGa1fBZOzll7HizxJVJENQAeYC1HuFM93zwo=; b=j8Nktlp8PDB+71AU24VxK0+bQ7JFQw1NN2DJ77fCnHzUsS7MD1/qHkPdISdIxOTC/F 06HaMbyI5T2LxgB1pyCMVUKwozkahynsMRFxTp/1V9JjMgAgMkOK2/kr1yHud8vDERc3 HXFkiKxHOsKVzsDGpKBLJzm2Hp7x8XROIjGVaxxrhs731GavfEsG/tgtYEw9yU4GX5U+ hZF/hBxt1WugNXw1A8aAjOZncAlPpuTs9pB4iwDsrS4dhESIEFA6bl5eyfcmbDEGsdfL sHqDOB1nlcvJWE/wwPa1+jtKqRPwRllS6FQcNAg+6sqaDq8cDQGTVqKekKvsqbieT7qv oHqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776358788; x=1776963588; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VksxkcPuGa1fBZOzll7HizxJVJENQAeYC1HuFM93zwo=; b=IjpjSuwGPp5R/mZVUov1aLNcWeUJU/dl+hQikEU/5j6sKxdVoY4aEttaXK8q6l1tR3 SHIPi3RqhuZqSbA6O8irWYUy51QHi1fl+fgEosrLjgMiWmkR0yL2SmeXAHNxK3v+5zQc QlKS5dGqUMu26wIUKBjhKLM0aInpxw5HhPdN/ippyjkyG4vNI281X9zzJguQJdHuumk2 +q1QYJ9K/kBuysSHmhE7ZJswy4nptRQrqvt/pq62ihv/YZxHPKhkWS4C5qxWsj9Zead3 ImMu8DbfY8DeZCOlDpa1mP+3U3yX6KuR6IJccl8tb9dHL0uC7sFbZTEPzM2gsVrl5iF2 BQHA== X-Forwarded-Encrypted: i=1; AFNElJ/XpFEE2zXNXbjUOhQKoE75AjB7DeJrCSVYHoVENdsQPBpg8nNf50UXow8oiiM1anXw44QN6XmztZi3Q0U=@vger.kernel.org X-Gm-Message-State: AOJu0YxG/Gnk17E5KKozGB3uWU+OCoF+pDvmE3AqSB1Gs0JPu4nyeBwi /au7gq4KjsrVT277f1TqdBQNMxpwY7ggqTDECWM9fhzSz/CFCDZH7i3i X-Gm-Gg: AeBDieuZhvUCb7+oH5ECT8Gu+U8QKe5EF0pQj5RcRQT6E4QoDjO4kmNCH9ZmYr0UlY3 hFseRPL65pCcz7t6s52zst2E9VptVQzRu+bnQgB2ZUuGBkyRbQj/3N5XQrSJLk27cxoX1DZGpdE vKDBFiQk4sKBrTye8F4YhFKVYLwff+7UbuXh9bGNZ8SvcIUlIAh5KiT5q53wvFvgGyR+sP7utFL EMm27CvoerKo2KoOBSg0q4PpSTM0dsz3Sn544U2BUuDWGqp/Ubj3U54xBQbX1Xp3acQJCcwbdSY qF3ZsGUnLulDe7kjhNWqqTdT/K1IihWeNezB6ebHXW9nPrnvQs7w/euQb2BIEHfRgdTHODVuo5P CaNvaBuRaOaaRp/jqo9mD+Xgkg6M/5KMJxMbZ5gxCzu/iMzS47iaInWOm83aZmykhb/9ENOg1Zr ZIPs2zry/qWIa4rkbiltZxbc0ilq6kee7Ihp3SPEr66A== X-Received: by 2002:a17:902:b588:b0:2b2:4c92:c389 with SMTP id d9443c01a7336-2b2d5a6e445mr206661275ad.34.1776358788087; Thu, 16 Apr 2026 09:59:48 -0700 (PDT) Received: from lgs.. ([223.80.110.69]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b4780f0428sm59683665ad.9.2026.04.16.09.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 09:59:47 -0700 (PDT) From: Guangshuo Li To: Matthew Wilcox , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , James Bottomley , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] [SCSI] advansys: fix host resource leak in EISA probe error path Date: Fri, 17 Apr 2026 00:59:35 +0800 Message-ID: <20260416165935.3958686-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A manual code audit found that advansys_eisa_probe() frees saved Scsi_Host objects directly in its error path. Those hosts have already been successfully initialized by advansys_board_found(), so freeing them directly bypasses the normal teardown path and leaks host resources such as IRQs, DMA or MMIO resources, and the Scsi_Host release path. Fix this by releasing the saved hosts with advansys_release() and dropping their corresponding I/O regions before freeing the probe data. Fixes: d361db483241 ("[SCSI] advansys: Sort out irq number mess") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/scsi/advansys.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index fcf059bf41e8..022a8190ae31 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -11373,9 +11373,17 @@ static int advansys_eisa_probe(struct device *dev) return 0; =20 free_data: - kfree(data->host[0]); - kfree(data->host[1]); - kfree(data); + for (i =3D 0; i < 2; i++) { + struct Scsi_Host *shost =3D data->host[i]; + int ioport; + + if (!shost) + continue; + + ioport =3D shost->io_port; + advansys_release(shost); + release_region(ioport, ASC_IOADR_GAP); + } fail: return err; } --=20 2.43.0