From nobody Tue Jun 16 06:05:47 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7741725393E for ; Thu, 16 Apr 2026 15:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776354899; cv=none; b=Z0io0hScUqY51e2qSQvWpnaWxhsWLTxHEPHlj8/hIko2Vt/FCf+7LDE40xgxkQHvyzH+mZQetiFXLu1ry60z4FZAQsZYhJeJUA57v++DTnVxYuiC2wUhnZNdjVivQ64e/Vk8TQ7n62EKSjyKD+gqBWgxbWFHrTg7o6YRCgwyP3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776354899; c=relaxed/simple; bh=8EDhl73uGgy3sX1dJvVF0X9HKBJU7fvPKNAkIO+qzqg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Xa+1PHuM8T9iipUBdwwMx2rCqFByoyMAUzeZ+as0xhrCCdRdTOqQmaclqcuwrfT2FkedxV/IXImfNvhd8Lu9xlei7kua41LwUr3asb4KfsFBrzpfHVs8nCFhHB0n/VRxfWLKoTcO0eIrPWUQLdqAUIjRDrafYox6Lv9RPVV46Co= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NLfVqC9O; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NLfVqC9O" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-35da9692ec3so7208056a91.1 for ; Thu, 16 Apr 2026 08:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776354898; x=1776959698; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Z5HAQkIF6Z7dNeQ4wY+TYJo8oiocNsiCAdUSK5J3aP8=; b=NLfVqC9Oixw2e9to1/qIqVwYtbWpBuAw8mX6X9Yd2HbJyZo0GWrB5dAFerccHWkNIl R7fQelnoEli46EQdRZijYLUHQ4ANwr1TuYQlcbSHx9fnBo9Obo/4doj8rdMKrRlUGfSm syfM5sx1QdimjrFReAsdRrW+NUjcCvIawNWkRdvCdMgAwtUcTWVQ3dUskOFIPMoFCQR6 mVLp/G+kC0c97pgslgqczncEeZY9LuPUNmxRNuP2SXV3vtCssFzwVsuOWLqpQ7IvEhjo YeqO+b9u+kUoXfoqdNiWhrAqZBhEhU6cHyMfXJzMevbjgyyz1o/fD8/8Pm61zAV/LZXl u6+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776354898; x=1776959698; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z5HAQkIF6Z7dNeQ4wY+TYJo8oiocNsiCAdUSK5J3aP8=; b=MiVw1upkbI+ZpoY/QJVkAl3QgUS8X5XIIjJO0NT76E/T9QC8SxhbJNiJZFGtuRi0GR 2YDpVCLxyS0oaMqvAtOpqfSVBJD0EO980WxCTgWreM2LUgvJrPZVt20Xc0iRCkAixzIW E9Z/vjErsU6/sCRoYnRogcD/7SQkuSbF1EfmRIiMhnb/MjlRCl0ydmOxIs7rHaJYKHjI 9VZQ6l9OeGzxbcy1v+2hIv8zpUUDi5YAhDOCCH6eXCdQhMNXsD90TbXJmdx+/mBYPsUq n5VAqsobmZ8BD8Dmfc5SnKW7u/FPrRb79QjULZEAQtnZDtzHs7fTYUyGvc1MONSv43Op sDeg== X-Forwarded-Encrypted: i=1; AFNElJ+s6Lw/GXXGcz8kswgJj4nDZLTd2fEAB4dEPsv3W3nYjLNyMvItE3CPn0TIfFyGowWpOqqskXBvBTdFsfY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywi8mNp3wpb1/F5cgpPOnjvoDj6GacbarRzCZjKLXT3okbj1qAi 7xm5KJbRrvgAsCFlIbnHR1qN1KXwMIdayJb6L4K0CkD/oq8c+/FpjTJF7w61L2RIYlM3xnEn X-Gm-Gg: AeBDiesPKqvBNpItfkCgEPF80UIdzq9zic7iBkOLFDThvSy845ms70IlKuC+MocAtr5 Zn7vgQRS9dpiCh+oCRljdOTZz7OQPhI+w4UIs10RCYGxwlUjWPxvPjCk39/7hqNqm4Lx7RQvtPo it5jgkagGgpjTN/lYoS2YYLO7sYycztjqRb46RTBU0oIPhO8Lweh6cGq4CVYPpPLtiBAwKDBe12 KhE5vQ3rlj1d4oVE9w6MJPQnLzfSjJskHogefUhduQeTCtITQ8obwwoZgM6AqXfQSWG2dyxbbqp NH56WGZXDC7YCyKnA2OVjE1EgVW+qIBL1I0UwXdZ7mCogGNngac1BDLNjxB5gT01TiuHnD5lrVY ckdOK7+DzsSMdrP7Pf+j4nMYMN/2W9yAGPXIMReh9SYgHQuKjLYR9imMQzctwfQmF4pzPn3v7yQ 1Dy0Cbr0/Kldc2njUONCCUpvIJXA/HwTyNCmuW X-Received: by 2002:a17:903:1a24:b0:2b4:63c8:ce18 with SMTP id d9443c01a7336-2b463c8db7emr176217665ad.12.1776354897842; Thu, 16 Apr 2026 08:54:57 -0700 (PDT) Received: from lgs.. ([2409:893d:1123:1f7b:1c05:52ee:e972:f3bc]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b4782b69cdsm81555185ad.76.2026.04.16.08.54.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 08:54:57 -0700 (PDT) From: Guangshuo Li To: Greg Kroah-Hartman , Yaxing Guo , linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] uio: fix IRQ vector leak on probe failure and remove Date: Thu, 16 Apr 2026 23:54:43 +0800 Message-ID: <20260416155443.3949056-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" probe() allocates MSI/MSI-X vectors with pci_alloc_irq_vectors(), but neither the error path nor remove() releases them with pci_free_irq_vectors(). Unlike drivers using pcim_enable_device(), this driver uses pci_enable_device(), so the IRQ vectors are not managed automatically and must be freed explicitly. Add pci_free_irq_vectors() to the probe error path after successful vector allocation and to remove(). The issue was identified by a static analysis tool I developed. Fixes: 3397c3cd859a ("uio: Add SVA support for PCI devices via uio_pci_gene= ric_sva.c") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/uio/uio_pci_generic_sva.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/uio/uio_pci_generic_sva.c b/drivers/uio/uio_pci_generi= c_sva.c index 4a46acd994a8..ea531f9a164c 100644 --- a/drivers/uio/uio_pci_generic_sva.c +++ b/drivers/uio/uio_pci_generic_sva.c @@ -62,7 +62,7 @@ static int uio_pci_sva_release(struct uio_info *info, str= uct inode *inode) static int probe(struct pci_dev *pdev, const struct pci_device_id *id) { struct uio_pci_sva_dev *udev; - int ret, i, irq =3D 0; + int ret, i, irq =3D 0, have_irq_vectors =3D 0; =20 ret =3D pci_enable_device(pdev); if (ret) { @@ -83,6 +83,7 @@ static int probe(struct pci_dev *pdev, const struct pci_d= evice_id *id) dev_err(&pdev->dev, "Failed to get MSI vector\n"); ret =3D irq; goto out_disable; + have_irq_vectors =3D 1; } } else dev_warn(&pdev->dev, @@ -139,6 +140,8 @@ static int probe(struct pci_dev *pdev, const struct pci= _device_id *id) out_free: kfree(udev); out_disable: + if (have_irq_vectors) + pci_free_irq_vectors(pdev); pci_disable_device(pdev); =20 return ret; @@ -148,6 +151,7 @@ static void remove(struct pci_dev *pdev) { struct uio_pci_sva_dev *udev =3D pci_get_drvdata(pdev); =20 + pci_free_irq_vectors(pdev); pci_release_regions(pdev); pci_disable_device(pdev); kfree(udev); --=20 2.43.0