From nobody Tue Jun 16 05:02:47 2026 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D31C039B4A9 for ; Thu, 16 Apr 2026 09:57:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776333435; cv=none; b=hVyNKHawwGZl4nl8N9rQvINcLdRhFeFFo70EqV3iO8wBcLrp3Yy+8If4xTGD8EYdXovrRh4sts1je520u9m6z45mwIuysLZjaL9u/KkctR/n7q57DdLchLY8Mdn9KEbGTLe/UAfb2pIPjMlpgc1MeIeIetyDk8TW1Zak7n6b+QA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776333435; c=relaxed/simple; bh=B35GEUiYL/i4rKfP8Gn+tSIfYFuWGyIXIcU6FNxorf0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jY7eaIbP4cil4wfjYG7RUNn+mh5gPnlEAlBHBYLEw2SbJelyFJot1JKDOsgyQMeNJl6OduvtojddOdA0HdEB0hzTV1ymu06lcaaNdaC5/ZRiUCxOq6LfcpX1bUhJjdhvRlcjcgSHTQ8pg7I1B50PMKv3yDMo9SqTXIJysR1atbI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com; spf=pass smtp.mailfrom=arista.com; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b=Aof3L7DW; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arista.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="Aof3L7DW" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-12736a0147cso599005c88.1 for ; Thu, 16 Apr 2026 02:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1776333433; x=1776938233; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BVEo1CGXYrQb+Ske7PtqTrPoqQ9eYUg9aVr/T0Vf6Tw=; b=Aof3L7DWupwoJcKDUGZaU2bEMfpkIB7IYKua15lVjH1MBdhi1qwc8OrxirdAmHbJd1 iKIrizLxfAeRNdga/oIW3mqCXMlMKMD3IqOL7CRU48omxrLVkJcOfsXXNLjc+JPSoOIP 2/T6ci1ORsNz/Wg97svCUI9q/H2d6IK6GnahNfcV62YD8PeVR50q4kIHL5TKR9QNDJeX jFgb8fJrbwX1sIFwlOG7gzqkoDiyeKGC57ECEdGaG+/rnPpliQxHMwg7IVPas/6u9rfs ay6ICQjEdt60OTXOJv5yMd8ahln81PhHGISYhJ7LvLnd5Ds1f4aqvgGU5Y9u6L+YF+gS oO0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776333433; x=1776938233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BVEo1CGXYrQb+Ske7PtqTrPoqQ9eYUg9aVr/T0Vf6Tw=; b=gK2zK0bIyrPK+viiJScG3HDT5ZUTNYA9rzVw/wS+jPodIqBG8t/jvKZDNFUirIee+C Ak1JKphzK/jhztOEqg0rj4JHBm1dHIQkPClHobukl/GzcGbG10o542lgBiabAkBRhGpr CSa4W7OB7C6xguAHkIYf+B2fzmloi9/+wtnqSQGp9v/DEpee3tuyn0gYHBdw8dW79EHF ieLBrT5Jcke/oT4OfWcEHqQZ9xteIzQekLpielQfaju8xQXiHYbrb1vbkvsgtgvCIsOV o+AUMYbG4jXLyb/B+Uk9dLzgh8l36JyMrItdjpTIGevn59lPSGW/1GWuZTCIyxsGc1xr 0hoQ== X-Forwarded-Encrypted: i=1; AFNElJ8499pLC3I+w5bBhFA+xaQmIHMYHM9+86jQtPfGfPc65aY45lZSns59u1VVXEwnCGRBAvC0LuGAErLKaF0=@vger.kernel.org X-Gm-Message-State: AOJu0YyJCeuZSGk8lhsAKR55HRi71NBeqJz45eYhwm8qMwb41CJlg4i0 v0pqILN7tjZ4KzBTBNz+TK+O+Lbwnqepw2bK8R362CxSQK5mYRegYPCPFfx/DXPs1w== X-Gm-Gg: AeBDievrJPzN05m9nPJLBLTKWCnEOk3k8z3u79a73+DFRaH8R/xgIo5vCifjgrrDCbh 1m924Ghw0+p9BTCSaEkLOHYABZfxgzy4rYsPOcvF95sfi57YNF4BCOb36eE+VvHqVB9RntMZqSX qgNbp9+SloQig7K6Z0MeVj5b0C96b1+zpbthqz1mkzS+qZPfTenaj4inCCM2agfJ8nfzVQ1DQpv cbNXhXy3KHtqBPuyVh+6/Nyb9hJpXuu1jIO4o7SP+w2USVGk1y+UONjQ4jZ/P/qhKYNdl3zj+lL 7bbvPjZwDRpkTM7aA6C9aPb1sc7O437y9UwHLJMcQlbXlrBZP4Jt/cqWs6vEo1C7H9FMbUdve3h lS0e4LBv/lh36miTjC9xbxM24+hmT2WJJCdpFcRYaD9xmLoGC0GacuohM3Pagf/t3AEH2qKX+Cq MrdNZPd7FKfHKkufmdLBHVsDali6C3MWDGZy+untZ8hdzJuY8Em1qyv6+h8ts= X-Received: by 2002:a05:7022:48e:b0:12a:6ab6:8a64 with SMTP id a92af1059eb24-12c652c1211mr357227c88.0.1776333432722; Thu, 16 Apr 2026 02:57:12 -0700 (PDT) Received: from adriana-schoodic-rtc.sjc.aristanetworks.com ([74.123.28.10]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c5f3f3d93sm4532913c88.15.2026.04.16.02.57.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 02:57:12 -0700 (PDT) From: Adriana Stancu To: alexandre.belloni@bootlin.com Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Adriana Stancu Subject: [PATCH v2 1/2] dt-bindings: rtc: ti,bq32k: Add delay on rtc reads Date: Thu, 16 Apr 2026 02:57:05 -0700 Message-ID: <20260416095706.3212158-2-adriana@arista.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260416095706.3212158-1-adriana@arista.com> References: <20260416092414.3210383-1-adriana@arista.com> <20260416095706.3212158-1-adriana@arista.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a configurable "ti,read-settle-us" property to resolve a limitation where aggressive I2C polling prevents the BQ32000's internal register to update. This ensures the hardware has sufficient idle time to update its buffer, preventing stale data reads on systems where the "interrupts" are not configured. Signed-off-by: Adriana Stancu --- Documentation/devicetree/bindings/rtc/ti,bq32000.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml b/Docume= ntation/devicetree/bindings/rtc/ti,bq32000.yaml index bf9c1c4ddb7e..46403f0c85a5 100644 --- a/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml +++ b/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml @@ -29,6 +29,15 @@ properties: =20 trickle-diode-disable: true =20 + ti,read-settle-us: + default: 0 + description: + Delay in microseconds to wait before reading RTC registers. + Aggressive I2C polling on systems without an interrupt line + can prevent the BQ32000's internal refresh cycle, leading to + stale data. This delay ensures the hardware has sufficient + idle time to update its registers. + required: - compatible - reg --=20 2.51.0 From nobody Tue Jun 16 05:02:47 2026 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB7C439D6F2 for ; Thu, 16 Apr 2026 09:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776333437; cv=none; b=R/Ldq9+s7hjakrQBEL/eiMLZujzCiVwTCcCygMYEriyYt40h1uSE3s4PaqIv4IRiFVzlOIvhMaXwls7MvIMEa18xz4WTvNByUsB5GqcZWLoD2giSJJk1XK03Nm67RwCD/aVU1D/jOZ/h8erC3alXtVgMycSv+QIiCKHmci+sGa8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776333437; c=relaxed/simple; bh=lIJnDyanoQRdooXW+rb4vRnTiHA4NZZ2a5UsiOLgCzQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OXM965C5shWPaMwopDCZf6MbXmAGhjhkq962gtO7btqCP4i6GM8vL9AJYCmSR+TgYLq+d4pSEms4Qzf/LBjt20OVSXb1OTZ3WhK50dcz+Nz/Ys92LsMl/LVOCY32YTqhO4QL3AeIY5eVANpDBZ8G/bJ90W6e8mi7gHQlpEPWqxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com; spf=pass smtp.mailfrom=arista.com; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b=A7xhCwCP; arc=none smtp.client-ip=74.125.82.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arista.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="A7xhCwCP" Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-2bd801b4078so649407eec.2 for ; Thu, 16 Apr 2026 02:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1776333435; x=1776938235; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H/1T705jUCHUuc7zYF9p5WCGH43XsT88FDPreDZ7P4Y=; b=A7xhCwCPhwfdNhXwpyVgqBtP5J7dey86XN3zXBRoSA1zyAn8nrZxohuS1t3a6F4Jye yKzbL7P/odW4m+A6E3OvRcOVfmx+JCgSUhHJtUDlFijLhfjF9GzR+Yy5lU76cAIzmcoh f0meYorTbcBqjlKGRjjWwo2anNpES6Dcy6LeVDLp7D9ljeW8yGVhhayCvzY+2M7IxEMD FZhRFV8WbS5lMyrAtPzl7CunAhIwnxHxPLRDMOHUJNPP6sAxhWwePLeTn6ArcWYBDtpw SWeiPuVan5eO1uTbp8RhROUouxAsW+aZCzg9vm6CiWrdBTLAXBQ4yna6okVS2a8gDa9w AClQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776333435; x=1776938235; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H/1T705jUCHUuc7zYF9p5WCGH43XsT88FDPreDZ7P4Y=; b=VF3qwYr4Wl3ohbKbSb7u4xy2yMqnM6uaqbDdMmEgsn6dsf3ERCN3dP5DlBUp+ibZs7 7K/qzu9a7yoSV5Yv41/hb9YkLs4x/enL0CpDhYNpTuLsCdnMyC1o6xKrqqcOWxHbOIGT 82eflQchwDrxXp+Stw3uCcYuaoNG6AOvlFQi3iZzktQym42b0blhiDgAgRY/Cev5Zh4D I4rCzBXBLu9Zbnjl4qq2Wlezon/ZmKQiWpiRysLqLtpy5manoYoZNXhP28KNa/x99Z6x 2SdcQwUuL/NJcrhaSdCnN3jXqQdUNkhxCEOOx14zZoymDHQnZ9Amhg7fyMB9b/ZltJmw qQ+Q== X-Forwarded-Encrypted: i=1; AFNElJ/FPQAkq9AlCijJ5mFR5/oAv0Pr8OZqjm4UQw/CykqDkwqtbWrN4DmseeP0MRUpSWSxVj1YIguBMK3XVUI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8G3rMetvzT7vMrsGkNbJmNR/gNXBGM7kxfpdTondGmscdbi7I NlKzXxN0xhpCgETQbLbYDqf00ricBe9gP0zkTa5+JJQ1HYu2bI12VbPhDmKf794+DKFV0vmaHw4 sHQaU4G3t X-Gm-Gg: AeBDievq9JH2GM20iJLrwtfYXZGtoNFjulJv/ERRXmQMOvPeo0Qe1zaCusOksR4s2jb uGDdqZnIqrkmTqTNLKZU4Jj+KyKyVjgmskW3SO2f/oA8MR7FbNrmpVcNRTQWRV26ykTYdo4tAGo PlOzm/7CDXSllNmwC+MKHYk4QeejMIsOsq2J3WyoLeEgExyFtdJKNZj3zZ3lQP0ErVwpyDVrCjb TqDdEli/1Klj7hvSMl1zh4NXT9ZPEROh4dNh0TSSQpU4Nwhaqq6TWMQl4ip2M2qqoJMZPQYPHBX GgpGgwcD5o/efQ/UC9dCW5aqS3MgghQVv49j6gsy1MEA5zaNOu3x/tVpxThfLa04jf9nKkh6dz8 DQg4sYV95gVJn44xwe4FREHGqmanWwW2mGUVNPdnLE+F7HueC7Fnp0EwqpxW2fVuKmM7DmxT+zA expzfikBL7o4BHp/0GZ1lPRUNm8a1AZQKG3wgKQzRVwogI97HHnUe2XR/hGv4= X-Received: by 2002:a05:7022:6888:b0:119:e56b:c3f1 with SMTP id a92af1059eb24-12c658ed58cmr333493c88.1.1776333434608; Thu, 16 Apr 2026 02:57:14 -0700 (PDT) Received: from adriana-schoodic-rtc.sjc.aristanetworks.com ([74.123.28.10]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c5f3f3d93sm4532913c88.15.2026.04.16.02.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 02:57:14 -0700 (PDT) From: Adriana Stancu To: alexandre.belloni@bootlin.com Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Adriana Stancu Subject: [PATCH v2 2/2] rtc: bq32000: add configurable delay between RTC reads Date: Thu, 16 Apr 2026 02:57:06 -0700 Message-ID: <20260416095706.3212158-3-adriana@arista.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260416095706.3212158-1-adriana@arista.com> References: <20260416092414.3210383-1-adriana@arista.com> <20260416095706.3212158-1-adriana@arista.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When the RTC is used on systems without a interrupt line, userspace tools like "hwclock" fall back to a frequent polling loop to synchronize with the edge of the next second. On the BQ32000, this aggressive polling can temporarly lock the register refresh cycle, because the continuous transfers prevent the hardware from updating the buffer. This results in stale data reads or select() timeouts in userspace. This patch introduces a configurable settle delay via "ti,read-settle-us" property. If this property is specified, the driver uses a delay before reading the RTC registers. This provides a sufficient idle time for the hardware to sync with the register buffer. Signed-off-by: Adriana Stancu --- drivers/rtc/rtc-bq32k.c | 34 ++++++++++++++++++++++++++++------ 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c index 7ad34539be4d..0cbfa0909732 100644 --- a/drivers/rtc/rtc-bq32k.c +++ b/drivers/rtc/rtc-bq32k.c @@ -16,6 +16,7 @@ #include #include #include +#include =20 #define BQ32K_SECONDS 0x00 /* Seconds register address */ #define BQ32K_SECONDS_MASK 0x7F /* Mask over seconds value */ @@ -48,6 +49,11 @@ struct bq32k_regs { uint8_t years; }; =20 +struct bq32k_data { + struct rtc_device *rtc; + u32 read_delay_us; +}; + static struct i2c_driver bq32k_driver; =20 static int bq32k_read(struct device *dev, void *data, uint8_t off, uint8_t= len) @@ -89,9 +95,17 @@ static int bq32k_write(struct device *dev, void *data, u= int8_t off, uint8_t len) =20 static int bq32k_rtc_read_time(struct device *dev, struct rtc_time *tm) { + struct bq32k_data *bq32k =3D dev_get_drvdata(dev); struct bq32k_regs regs; int error; =20 + /* + * When the device doesn't have the interrupt connected, prevent + * userpace from polling the RTC registers to frequently. + */ + if (bq32k && bq32k->read_delay_us) + usleep_range(bq32k->read_delay_us, bq32k->read_delay_us + 50); + error =3D bq32k_read(dev, ®s, 0, sizeof(regs)); if (error) return error; @@ -253,13 +267,18 @@ static void bq32k_sysfs_unregister(struct device *dev) static int bq32k_probe(struct i2c_client *client) { struct device *dev =3D &client->dev; - struct rtc_device *rtc; + struct bq32k_data *bq32k; uint8_t reg; int error; + uint32_t settle_us =3D 0; =20 if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; =20 + bq32k =3D devm_kzalloc(dev, sizeof(*bq32k), GFP_KERNEL); + if (!bq32k) + return -ENOMEM; + /* Check Oscillator Stop flag */ error =3D bq32k_read(dev, ®, BQ32K_SECONDS, 1); if (!error && (reg & BQ32K_STOP)) { @@ -280,10 +299,13 @@ static int bq32k_probe(struct i2c_client *client) if (client->dev.of_node) trickle_charger_of_init(dev, client->dev.of_node); =20 - rtc =3D devm_rtc_device_register(&client->dev, bq32k_driver.driver.name, - &bq32k_rtc_ops, THIS_MODULE); - if (IS_ERR(rtc)) - return PTR_ERR(rtc); + bq32k->rtc =3D devm_rtc_device_register(&client->dev, bq32k_driver.driver= .name, + &bq32k_rtc_ops, THIS_MODULE); + if (IS_ERR(bq32k->rtc)) + return PTR_ERR(bq32k->rtc); + + device_property_read_u32(dev, "ti,read-settle-us", &settle_us); + bq32k->read_delay_us =3D settle_us; =20 error =3D bq32k_sysfs_register(&client->dev); if (error) { @@ -293,7 +315,7 @@ static int bq32k_probe(struct i2c_client *client) } =20 =20 - i2c_set_clientdata(client, rtc); + i2c_set_clientdata(client, bq32k); =20 return 0; } --=20 2.51.0