From nobody Tue Jun 16 04:39:20 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47E503803E4 for ; Thu, 16 Apr 2026 08:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776329690; cv=none; b=Ef6UY8QNsacjg+DfdNaXtgSfMEpmv/Jh67RecvI+Z9L/esc71Aj8Af97MGHsJxfbfxMZZ1MREsQM5v231v+LmIO5t7EvGrUM9zeZyR5oUrMZfNliQ0GWoUkVPdDxb2a3O9S8wTIxExdpyx4FS/5x0oVbojyqzWpP2aVEqv8/fsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776329690; c=relaxed/simple; bh=q9wTAGWYDDfJtse60PgErxcPegVG1EyAledoe9xo9Dg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=jRWXT3xQpeRglYgGbRQbic0mVLVXMijyGl8XoSwX+de1ZyfmQc3mCc6Dq0V2vZo6nYUifwuJLEE/J2Ga2irBwAwgAsi6TDj7Quj4gnuOmyb9dpg98WSO372HYaY6Nf7hluoIlIv+UBAvco8SrCyFuWkDXUT+D8BNZSvKYORCNUI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HV5rDvlr; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HV5rDvlr" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-823c56765fdso4275760b3a.1 for ; Thu, 16 Apr 2026 01:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776329689; x=1776934489; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=soPgzKHQzbpttKVgQUGoTjuDozEgeyvok7n04bohCKk=; b=HV5rDvlr9RM/q0ksjJiMt9SC9h5sBjf4/OGgJw5wYh13eALHEw3mHFUK0aEiGpE5XI tnFBCrQOlXtqgdiDCqlm2OhjDPv3SXivR8apwSQ3pqb+o1XmBIi2WcDP8r49d9lxodkd wwt3a6h9ydArrMt7PDuPKhIJ1JPPjKVsgJcJfeSkmVgQmz4bBY9jkcAVa5WbNbvlDVM/ NT4venVSbzpA177rDEmsoO7lRawAViA4ToFTfZDEdZhm5qOGYZlFVSWb6GJfUFYj1jTv o9TkwIT49gyjzPNj1rZgAExVyF0osaKwPxKeHnlaYLBgad5+SOV0QAJR/+dfNqxvpuXE /Xyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776329689; x=1776934489; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=soPgzKHQzbpttKVgQUGoTjuDozEgeyvok7n04bohCKk=; b=cRacnRSWZ6dQamqzUEKvqPXNV7XUfg96/bK/3oeOnsexZzYScm8RdBMIRZxcTxoT1k dXflOZ8Fsp8FdIzx6b0wC6vLUW5bF41O29mEA400jC3c9zhKwf1cB1zI0P4GijDJ7hzi VSIW8plw6ZXjeNH1gSVxEfPez+uTmG5mRSANaOO65E1wBKPlz2wTJvvQiI5D71L/L22l Z8tyIKfBjGkOsAJg65S1JlLlIVnhZLZyQB/4v//5I+baV5bUhXL0nVeT9u9p43J5hO/P Vdp1eCxlXx3V9NvUreiSRUZtjBCPhotejohKC7lmcbZl8MDa4Tx+c/rgDj6v0zQTeJVM kuzw== X-Forwarded-Encrypted: i=1; AFNElJ/9LFT+gCcAj4QitzXF6U6QsR5MRS+1lt9gf/54qecAfeZG3b1VIbLGv48o2cdNsBKz/vrkY1xp4xG6AxE=@vger.kernel.org X-Gm-Message-State: AOJu0YxFeTYVs4frRRiRvROH6iJRVh+Dn8t0O+7nxQG7Sj8EPhEmESkt uBSle4g9ihrd01hRv5j1l0hVAJGthL8+5RwlLIsAax3MCHKbpXrlP0GG X-Gm-Gg: AeBDieu1pypHOCNy91v4tyNvxiW3t03/yJbebzotSDZ1eCiEfWFG1jA++fcqmK56Ed/ 4/2Cm6MlMnmZg9iIySjk5cdrU4/9yzB8S69NzvfQrgsraTtpWNJR8svvKBz75hirG8Ja1iGmUCY /da5aLneYR7V8779KUlqup2VS6lq7faF9qXkQUEavToV7jmLj2tjFOB0aAbLiN59DP0+nPWf0t6 w4h4hZH1/4BZGP4Rt+uuszxTxuwRwlvuMyW9/w/uxT561qPN9Bam57Wtt3QI3hWRrwxQcaiN6ZJ peLNcK4fCRLHa5I/Jf3erg9mBHbTZOJzDXbmYH+OApLvMWPkDtnIYP9kdlt3aiXqySUV13k38G5 Fq0VCjpyFOtU3alhucECk1n1unf7+FrdFANgZtsvCvquUnnl4AoINpdoUgnEx9L9tk9RN5Fvgyp KegMyZAQFTSbi+qasVKMLHREvfWXZjRud5ZrEGAN1kqFM= X-Received: by 2002:a05:6a00:4507:b0:82d:62ed:b01d with SMTP id d2e1a72fcca58-82f0c2bd986mr23384195b3a.45.1776329688581; Thu, 16 Apr 2026 01:54:48 -0700 (PDT) Received: from xiao.mioffice.cn ([43.224.245.230]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f67469dc3sm4806917b3a.58.2026.04.16.01.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 01:54:47 -0700 (PDT) From: Xiang Gao To: peterz@infradead.org, mingo@redhat.com, will@kernel.org, boqun@kernel.org Cc: longman@redhat.com, linux-kernel@vger.kernel.org, Xiang Gao Subject: [PATCH] lockdep: fix NULL pointer dereference in __lock_set_class() Date: Thu, 16 Apr 2026 16:54:43 +0800 Message-Id: <20260416085443.927247-1-gxxa03070307@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Xiang Gao register_lock_class() can return NULL on failure (e.g., exceeding MAX_LOCKDEP_KEYS or lock_keys_in_use overflow). __lock_set_class() uses the return value directly in pointer arithmetic without a NULL check: class =3D register_lock_class(lock, subclass, 0); hlock->class_idx =3D class - lock_classes; If class is NULL, this computes a garbage negative offset that corrupts hlock->class_idx (a bitfield). Any subsequent hlock_class() call on this hlock returns a garbage pointer, leading to memory corruption or a crash. The other call site in __lock_acquire() (line 5112) already handles this correctly with an explicit NULL check. Add the same guard here. Signed-off-by: Xiang Gao Reviewed-by: Dmitry Ilvokhin Reviewed-by: Waiman Long --- kernel/locking/lockdep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 2d4c5bab5af8..e0de81114824 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -5437,6 +5437,8 @@ __lock_set_class(struct lockdep_map *lock, const char= *name, lock->wait_type_outer, lock->lock_type); class =3D register_lock_class(lock, subclass, 0); + if (!class) + return 0; hlock->class_idx =3D class - lock_classes; =20 curr->lockdep_depth =3D i; --=20 2.34.1