From nobody Tue Jun 16 05:02:06 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011071.outbound.protection.outlook.com [40.93.194.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD18F37E2E7; Thu, 16 Apr 2026 07:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776324135; cv=fail; b=nE/QljwwaSxXfS1pjk9bpQ63f8E5V6bKFl+HgQk0nPhnImZxlX39tDte/jZ46obJlkhyyiSe8MvhX5Pd0H77dBFaP6XkEFa0cWFzZUcAK3FQ5BVby14Ihs0YZm3zHjziOMYYvcqayUCa+oXo3cUB3EL8jWGj61XJ83maItQJVhk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776324135; c=relaxed/simple; bh=pkNeg2elSOzrkiK7egsavmH3sCXesC1uliM896U4gKs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=IsvjUfHbXBpa/HvAJmoQv9Hs7/lt2uTyU7EmeuHt3Fn9TkMQgychZZBgD9RMtboytf1WQ6zt1RBIU5vJdiA9J2gVZjYIdiPFvqhgx0xtCgmwc4DhZRcAp8bQTB4SGahDVZsYDWLg6gOj1O75SwxzcuTuI2acr9RXAgQNSkmj3GI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=WL4rRjrG; arc=fail smtp.client-ip=40.93.194.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="WL4rRjrG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YaKvEoXoj0lJYGp8iE1/vxlXr2eGba+oKcCR6MX+j9sBPqxvBteeTgWidGdd2bz2G6MX+2Vo0FtjC0ksXbbMtChdVtHNAdnmOUc6fMZCCw/nktQTJAqy6zIX4KSgRiBwTgZW5CA5ZcHQJF0HalFX2S4vAn4Kdn7hoAip0KwpMn/cJGa3GrX35JW6FuTlTLGDLDPkjm65yw1hd/jkfZ6//Lf1vUQlcG9ZsNnxlH6d8eGYzltHV2QKjxERQzwTxBiHscJQP+VogX2LpOT3m3vOmgPwFCIMtiOlDDH66prHvkp4Y/i6BsMwFLUKLw4rf/9TEd91s2WoCJyhJ6qagaw99Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NF6agQjYaAKkWyO0ZWyQTvCgMSS5thyqle4j+DPYXbI=; b=KUrKLgWrg4lmRb95jNSW+/QrVx5LrUCjRGpk6kpvD37CTLfkVnCUG+yiI1saFy1Df4g8TIk3t16p9mTB9U0N1MCs/vunyoXYMbbPKShoRwxzK+sgeDSsJKtJ85jQ9dDvA+pFNKmP6bmD3EJxDvxTO5afUlPNgBGX+Fv9VIBCVanv2EaZtAvuT01I16miUOEVH6tQyoPj2/z8K2PHFMEwFA2TEtBcMvq3SdItq4sNqPetwa4Sl2XLOoGqtV2Fmfz9wVoMbKA21X5VqBGMW3TSup+GJHa1E1fD9jAJbZidMwop7OemPGE2qDx4sStELadEtb02ibiip/J158KG/36xkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NF6agQjYaAKkWyO0ZWyQTvCgMSS5thyqle4j+DPYXbI=; b=WL4rRjrGE25b+pJ10K2yr3NiuZj661APYw53cmc6nMXnl+yA1Eo72k5m+f3fIOwcGyrMSS6PbeDz8Kbo8+ExcCwDt5Jt7erao+967MDQWAlsTDg2aX/crsTxAX9HDsRHqepoBY6RQR+bqAULwwsqYxzxUhfyqECKCmC59MsTOORXYStCZFEc6jSSFUN+Q9/D3NuNptJBTBizANUyxQqvGyBvY9lMWnZKvoKTzTpra2SpqkC6o9NRSOVgmDLVorhOSlm2d0P0se5JFUISMYf0ySADGnUlpxM5KwdDnMwbb6ferJnZndG3mBYhHqNGwScsPb0ssuah3caJwC8zwIvvTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from BLAPR03MB5458.namprd03.prod.outlook.com (2603:10b6:208:29d::17) by MW4PR03MB7011.namprd03.prod.outlook.com (2603:10b6:303:1a6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Thu, 16 Apr 2026 07:22:11 +0000 Received: from BLAPR03MB5458.namprd03.prod.outlook.com ([fe80::7eda:fa34:15f9:e656]) by BLAPR03MB5458.namprd03.prod.outlook.com ([fe80::7eda:fa34:15f9:e656%6]) with mapi id 15.20.9769.046; Thu, 16 Apr 2026 07:22:11 +0000 From: Muhammad Amirul Asyraf Mohamad Jamian To: Dinh Nguyen Cc: Mahesh Rao , Matthew Gerlach , Anders Hedlund , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 1/2] firmware: stratix10-svc: Return -EOPNOTSUPP when ATF async unsupported Date: Thu, 16 Apr 2026 00:22:06 -0700 Message-Id: <20260416072207.27074-2-muhammad.amirul.asyraf.mohamad.jamian@altera.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20260416072207.27074-1-muhammad.amirul.asyraf.mohamad.jamian@altera.com> References: <20260416072207.27074-1-muhammad.amirul.asyraf.mohamad.jamian@altera.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0181.namprd03.prod.outlook.com (2603:10b6:a03:2ef::6) To BLAPR03MB5458.namprd03.prod.outlook.com (2603:10b6:208:29d::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR03MB5458:EE_|MW4PR03MB7011:EE_ X-MS-Office365-Filtering-Correlation-Id: cbcef418-2afe-4c5a-25a8-08de9b88e03d X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|22082099003|18002099003|56012099003|55112099003; X-Microsoft-Antispam-Message-Info: HjPUleMGEBRpaPFkQlNhxCkmuSfxk6EBAtF2F6cWkbePKBjwcFTFIsTrls4oR2Rai/4hAqpSEZ6B6+9xA9CqKBb/IOiwPkFNmqiq611yKm4Wggyc/lkcKjbtWdYNLUuQ96uUounegovHGiKdJgjnEF4idpW35hOFj/gUaqQOeL7Jon8MFi4vgrueBdlIUzZ17hooJR6aomwKf5wUCQjNq6kQ5BGzP7tYJuroPOmiuSdVpeifLPQyfl8xl2JaQvcCdVNYJ/e+S6A/NkqRKbAvlamqAH68w5xPa1tJKWoQgT3LfOo/urmQBANjKJu6qMfgknCuKde83oK2n8D3wVrN9zWsC2xsyJlhKqDFWPTr9QGsqm+iLq1QMbSTvoWfAAqCEEf3HFzDpbDOvnNjJD4wBiWuK5HN268tTP8OwUddthsI9vqKrNUJ/Tfkmys/kItQnZiiRtPKSB7wtl4Nx3Z6LgMDxBJvz7FaEAonSXSKXDz1y8tK2kQ0StgfksZFZm6/ZhOwQ9EkOVThAXX8sREXsOlgaiKOPH98mZEbI7+25C81LiytAVpz4d8ryXgVTmdHdRkAYUWZl6JB7YlDgfUW0+CGbRtZp86EHJvfWGzBQnmJudIIatFqdZoU/uj0RF5qzvbrnrPpsDcZKeRaJD8BCt/T2CtEEPHEQ6s2nzumPDkAMz/mXR7HkIlg2wkXovJei81Zn1mMkpP9JWyFqvvSyfEIxUMzg/t9jsVMzdtdsFE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR03MB5458.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(22082099003)(18002099003)(56012099003)(55112099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wKYiosGDwjk3O0/+tdFOeatqOZe9zhSVAQzXTQcuF1B861innU/8g/hv2z0z?= =?us-ascii?Q?jz95HcvRtiNyAUeMmxiMUZ7wPfK1EsBuch8l0Y6iMGZ2J6boMtRsWLaW63RM?= =?us-ascii?Q?6iCL/dotFifM3MDpavgtpjHgfdw7ZgOcrFefZOgngnV7aTQOENKzTDZqcV4Q?= =?us-ascii?Q?Y/zBMIpjhknSTpfCLBgGesTQ7JUCWvS2Rh2Ii3Z+DOLmlf6M9e3D6Es5c503?= =?us-ascii?Q?ln+Iodv4Vez9sIFIemnIJhMCC4NgzjHQL4S+EVgxumAWXuOOYSJIzFDWHsCF?= =?us-ascii?Q?gP7WJMYFoEaeImRqhNviY0e44E12hH24rV96dq+O/Ten5DZ92M8a+VkAmi2x?= =?us-ascii?Q?USF5lOquv1OMQ3Df4MkhqcRNllZk9RpU5kTQJDZXZVv8L2Pz4VKhpxodNFhi?= =?us-ascii?Q?r9vUJGpfw28N7IUunEKH48p7h7lKlk8zKTjUDnHkkvA+6ZeMxD8NanqYFCae?= =?us-ascii?Q?MwFyn82XD321vbpHj1x7Ma828wPKtLLUdUfXwNWIX+yJzZgZk1TiagCQVKPR?= =?us-ascii?Q?+2JE9m/pAD0CtWr2zwRemEFKoeDnJ7ewKAyYqW7U/ER+KwAYeqXbqLizrlyG?= =?us-ascii?Q?8lk+4feN5hLviXsakkYAMwssiCKmDhNGVFG/W82ypaq6IZ3cmIpjiJ5SEykp?= =?us-ascii?Q?iZHGHlxsZ+ImnHcnbj4fay1Yx+W7kElZV/W8B6SekkMW/Yw968euF+qquFSE?= =?us-ascii?Q?CsOKIDXZEiCp2ChcnUA8DeotghosuCE9vH5OZI0Mxib5NFUKHe7Es3UqxRbo?= =?us-ascii?Q?nAlJ3OlhtSNDddtLwEpg4bBpliWRVITCTDMrz/A+U6Einf6ndTmsRcoy99I7?= =?us-ascii?Q?8MbsK9poqZjX7/Zl27z2/whXwBychwERAWt74rTKHrBXaG9E0U9H/zXhFHDq?= =?us-ascii?Q?Znyz1FHLrs341soW2yoUA+LJRHVsLC+w+8v8Grim7QLwcUporMrCcAWrNua0?= =?us-ascii?Q?nn1QvIJFO0C4ON7NzlM6tLBPxzeOw3Ox8Su6uhZuzFBZ4kSiZJIcfTVw4/ya?= =?us-ascii?Q?rstIqQS/Zs6SwFJUyVi90qPxi/wPRyjK/D/yylSWGD4r5KlvP2IOQ1Q9mBT3?= =?us-ascii?Q?sa0E0X1kMdtR0lg6Lx78BOH3GAe5W1eJ1QtCwCK5fYuaOmgeG6DcKvaXS7Pp?= =?us-ascii?Q?iXIdzYICeglKoAEA6QoC7maloJJ5Dx63Veo+kJwbRgyTGv8jIJWeihFgnZl/?= =?us-ascii?Q?dLFjok6a8SbbKpyTtgwe+C8Adn+g6MSNklTCqW5U12gPYQHKJaNrbGbBPVue?= =?us-ascii?Q?hkGnbc3ocUklKeNT/0AG5f3oKZzo6T42ZHlh2+gZcFxw2XS0roAY5YnUlUw/?= =?us-ascii?Q?L9sWKmHShVUTz8K97I08gzDhYZQR5PGu+1w+YTypwm6qrn3XJmrjGjkGN1BR?= =?us-ascii?Q?aKWubhtyhy2KyV6mEIFJSP3Bx347NK5dlR3M5Q1UmS45IsWDLSPiE1l3NAjL?= =?us-ascii?Q?yEDjK+3VGSDHw6nMcTOxB/uIPPdy9Kn9z2+g8mqUCs3EtHnvqKLEQAmlnrO1?= =?us-ascii?Q?D7JB7whUuCz7L7SFWOmvDa/+8kfPYrO0pb315542wWw4a2T7PMooGAg4jWz5?= =?us-ascii?Q?lEG7b+b2pJtas/g6FK1WO6t4li+ZG6G1nz26kF3EixRsMkIALCIYg2KF1y4D?= =?us-ascii?Q?39iITe81BsdupFEIT6nUENlEhIQ84vmSCczxmhKbdVlnxIrU+k/xoLfIWGcH?= =?us-ascii?Q?2adbDOIX/rgo1D2Ek/d2ne9KiaWjkP6Q4jCktMOWNjiIfHkuwfgcIrrPgktW?= =?us-ascii?Q?46s7UWwXEIt+D0qKritAN7EgSn7U9Z0TwDqlt9u0IiV4xvZQWkIZ+nZX8wOT?= X-MS-Exchange-AntiSpam-MessageData-1: B5PhEnUuV2sM4VC85qSbcFyjHoHhEAtqrnA= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbcef418-2afe-4c5a-25a8-08de9b88e03d X-MS-Exchange-CrossTenant-AuthSource: BLAPR03MB5458.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2026 07:22:11.4543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oNohv0h2+sQdkRc8AB5rBO9OnQBJ+FXpBM9k+KdryObX5Nqo6u2WQRh7Mc1mbA/5mk7n75H9VS7rt6Q60SsHVi4qe0MP+hUWmBL5Uz3YhzUcI8MzJ/D26NhJ4BTn18mg5MY3v/0kbalndG27gjMgWDYqj6IAD+CT0TUrPa92vFE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB7011 Content-Type: text/plain; charset="utf-8" Add a 'supported' flag to struct stratix10_async_ctrl to indicate whether the secure firmware supports SIP SVC v3 asynchronous communication. When the ATF version check in stratix10_svc_async_init() fails, set supported=3Dfalse and return -EOPNOTSUPP instead of -EINVAL. This allows callers to distinguish between "async not supported by this ATF version" (-EOPNOTSUPP) and "programming error / bad argument" (-EINVAL), and take appropriate action (e.g. fall back to synchronous V1 SMC path) rather than treating both as fatal. Also update stratix10_svc_add_async_client() to return -EOPNOTSUPP immediately when async is not supported, rather than -EINVAL from the !actrl->initialized check, so client drivers receive a consistent and meaningful error code. This patch is a prerequisite for the following fix and must be applied together with it to correctly restore functionality on old ATF versions. Fixes: bcb9f4f07061 ("firmware: stratix10-svc: Add support for async commun= ication") Cc: stable@vger.kernel.org Suggested-by: Anders Hedlund Signed-off-by: Mahesh Rao Signed-off-by: Muhammad Amirul Asyraf Mohamad Jamian --- drivers/firmware/stratix10-svc.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-= svc.c index 5a76cf3fc83a..739642923ac6 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -212,6 +212,7 @@ struct stratix10_async_chan { /** * struct stratix10_async_ctrl - Control structure for Stratix10 * asynchronous operations + * @supported: Flag indicating whether the system supports async operations * @initialized: Flag indicating whether the control structure has * been initialized * @invoke_fn: Function pointer for invoking Stratix10 service calls @@ -228,6 +229,7 @@ struct stratix10_async_chan { */ =20 struct stratix10_async_ctrl { + bool supported; bool initialized; void (*invoke_fn)(struct stratix10_async_ctrl *actrl, const struct arm_smccc_1_2_regs *args, @@ -1103,6 +1105,7 @@ EXPORT_SYMBOL_GPL(stratix10_svc_request_channel_bynam= e); * Return: 0 on success, or a negative error code on failure: * -EINVAL if the channel is NULL or the async controller is * not initialized. + * -EOPNOTSUPP if async operations are not supported. * -EALREADY if the async channel is already allocated. * -ENOMEM if memory allocation fails. * Other negative values if ID allocation fails. @@ -1121,6 +1124,9 @@ int stratix10_svc_add_async_client(struct stratix10_s= vc_chan *chan, ctrl =3D chan->ctrl; actrl =3D &ctrl->actrl; =20 + if (!actrl->supported) + return -EOPNOTSUPP; + if (!actrl->initialized) { dev_err(ctrl->dev, "Async controller not initialized\n"); return -EINVAL; @@ -1562,6 +1568,7 @@ static inline void stratix10_smc_1_2(struct stratix10= _async_ctrl *actrl, * initialized, -ENOMEM if memory allocation fails, * -EADDRINUSE if the client ID is already reserved, or other * negative error codes on failure. + * -EOPNOTSUPP if system doesn't support async operations. */ static int stratix10_svc_async_init(struct stratix10_svc_controller *contr= oller) { @@ -1585,10 +1592,12 @@ static int stratix10_svc_async_init(struct stratix1= 0_svc_controller *controller) !(res.a1 > ASYNC_ATF_MINIMUM_MAJOR_VERSION || (res.a1 =3D=3D ASYNC_ATF_MINIMUM_MAJOR_VERSION && res.a2 >=3D ASYNC_ATF_MINIMUM_MINOR_VERSION))) { - dev_err(dev, - "Intel Service Layer Driver: ATF version is not compatible for async op= eration\n"); - return -EINVAL; + dev_info(dev, + "Intel Service Layer Driver: ATF version is not compatible for async o= peration\n"); + actrl->supported =3D false; + return -EOPNOTSUPP; } + actrl->supported =3D true; =20 actrl->invoke_fn =3D stratix10_smc_1_2; =20 --=20 2.43.7 From nobody Tue Jun 16 05:02:06 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011071.outbound.protection.outlook.com [40.93.194.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A493738228C; Thu, 16 Apr 2026 07:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776324137; cv=fail; b=DcHSWg2EIbKvTh+xDnMvJshYW9iEpm4qfrkNkwZfDHrVX1SzCLF5pL0Y5xkH5juE6YZwXDHKVjeBZ9ppQtnTnSm1cleRpElkj3WmQeJNbtp1+oCSh+RhkgLMdy5+fyAuH2P9EKPwWeEJCO8YFiE+OEtUqdEIlX6/tg8MZe6r+kc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776324137; c=relaxed/simple; bh=4HZmKs9yo9BVnYxb5NP05DCdXR5csIoeVir0Ju4Ux1w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=ZUPPJ4v/UUZVPQ0vEh8QdS2A/znQKzYSmkgct+f6K9QWbRP/C48/d9bMeP5WVBQ9U4HLvciC2EYPSYodm8r4EECcs2jstN8tvDn2XLanqqivGZKQiid1/Mhn9ZW+IKCMGG3D3ObrbNdcZ7JetcquXKIhN56vEqpzfC8lrNwa1/M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=fzrz/Bg/; arc=fail smtp.client-ip=40.93.194.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="fzrz/Bg/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SHZL6sjZb7/lcb0gVte4Xd4E5P2KXPR31DcNoW1HNT9XDCfVASK5BMwnww+lS51InysPo/jOHUzYmJkmG5bxQwP1DkWKzZk+Irk5dezEkUbEBaZVxmXEZrxFvaNBw/JA+d4Bs5slZ5BZqJXSahDzEauNelh276BB21rSxbL/DQDjwGShHek+39h4mtjHZ8gL+a58DcWeioyspMCU+MlOLRiVX1U/Ku0mQgkkjJPGLRPGcCi8D+4KaMqvn8G0rL4fsPES+OlaHqPcz8BZjUQL2iEQpY8fVV4FtdWDpdkvdOn+EQY9DgLy1rkd7+Iyf1cvXNUTFHRGB+78bqSOzmME7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=93/fuW3IXcQ7Yc7lcoE/OBFH/3cCv6qH47KmwUI5RnA=; b=aVqDZP0OqrYjnsv4z6OCZ7tVc7uS38c4BjlTUJCL1n/JbJXRs1Fg0+oD3hwiu6wv4YVdWJ/HmnmB0zV9ssKxXlevlBg1M/1keGF1RbZuvqa3hxMGDiKCIVYkc0BncfdLTTAumMbvbh/BOb+vyBhchUXGRhPWwVt/YfflKMyx+QpbDZ+VNAwFrybz5cQU4u9ZB+aNLy7RUADXxZhoe5K1fQTgTSHRHKLz5qxQOHPX8KrdLHpT2boA25gFkYKF+dzpG3LSOdDECNFT60D7tbA9kZJO2fF/4673+A7hXSFNMJeMqnfwgYeGlRxIA26cSmLvwfzoT8/OYxb3foNS4VrALw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=93/fuW3IXcQ7Yc7lcoE/OBFH/3cCv6qH47KmwUI5RnA=; b=fzrz/Bg/L28GxOzHCyzggTa7hZPJ//sDAWYeJw+nD+R91YtLEIPK3L8ZgSG1x65nR27dkr4fPx5g4YytENKe5p08bNZQD4IjrFaBIjMaqTZyuIo+wXkaARasxby3jGfmYv9LhW0f1Ne26ZpzJ9wqQiJX7/6iSWBSEytkFqLjJ12dgxiXqsG76Pa0yFtgENO+WEkH1DyZWhouqA1jIVLkYHuyT2ADyZ2H7Bh0c4pRtl/nZK4n4yIeUoavWPEkdQl6UYTczQ//g89T1FDn7w45lN3qYQXM/7BlsFWg/P9VKR/D/4+44GC0mbfrtieBixW1DEth1233UTM45hj0UfDXOQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from BLAPR03MB5458.namprd03.prod.outlook.com (2603:10b6:208:29d::17) by MW4PR03MB7011.namprd03.prod.outlook.com (2603:10b6:303:1a6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Thu, 16 Apr 2026 07:22:13 +0000 Received: from BLAPR03MB5458.namprd03.prod.outlook.com ([fe80::7eda:fa34:15f9:e656]) by BLAPR03MB5458.namprd03.prod.outlook.com ([fe80::7eda:fa34:15f9:e656%6]) with mapi id 15.20.9769.046; Thu, 16 Apr 2026 07:22:13 +0000 From: Muhammad Amirul Asyraf Mohamad Jamian To: Dinh Nguyen Cc: Mahesh Rao , Matthew Gerlach , Anders Hedlund , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 2/2] firmware: stratix10-svc: Don't fail probe when async ops unsupported Date: Thu, 16 Apr 2026 00:22:07 -0700 Message-Id: <20260416072207.27074-3-muhammad.amirul.asyraf.mohamad.jamian@altera.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20260416072207.27074-1-muhammad.amirul.asyraf.mohamad.jamian@altera.com> References: <20260416072207.27074-1-muhammad.amirul.asyraf.mohamad.jamian@altera.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0181.namprd03.prod.outlook.com (2603:10b6:a03:2ef::6) To BLAPR03MB5458.namprd03.prod.outlook.com (2603:10b6:208:29d::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR03MB5458:EE_|MW4PR03MB7011:EE_ X-MS-Office365-Filtering-Correlation-Id: e8410a79-e65f-4e0c-91f2-08de9b88e16a X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|22082099003|18002099003|56012099003|55112099003; X-Microsoft-Antispam-Message-Info: ZCovWRgikW2ctgde5ilNK/XZZEJbTRqseahD9NfLbAtkoYUIqp6OAs5UZ0Tj7RxXCSK93dVKdOJ7/sJNx+vCA0ZBifc8mmMTk1yu1ccCSZjzyCy4OPSzSejHdzokbTj1Qm+iWLJCXJ+eYsmlfA4J8wygEn/XBRXEbSwSX7FpSVZXBeueoBPtJZLbkN5FRdwwn3QZhaZv22Oxg8Rj869dUmWsUIb1UCsGdob8z2xOeWFxO/yhPKEN9OCqmjnaD4YkDwIXKnxI2fm/HSbgsD5miMhYZN3LNnw50diX0UcwAvHJbkoupx+DTqLi7P7xO/BmwkeauBmUdyDRS8R8utfD7osoOZ/vwM+NokygrDT4tlIMfG21fmTjzGuLtUG4fveE3eRVQ0zjaD04KdsDseuLf9HVjeJKLg62ka5PsW5yD+yjfdaWRNHWw2shPJxow3jQHkAPk6/t+VplsTFmwFUtZ3z+RLg4IXWzjRQ4vqdhiTv7rReby8pWRIrM3VOvwx6PL5rsKxO2czDdqxh3zuGxCunozyYkxc2iGgY/IN2T00fUkoUht6DVwCZmUcJXtTLARtMEh0tVN+ZVNJX/eRLSh/RyDUCUt9HLyO0qe6oV1RA0F6rQBasHqexK7wC+TV2SH6TGBxZcYG5/BWZ3mVzFnndkejC/60yp1FzPj+BcrfvOwWHsIm4dg/d6pn+tCBX79gELYXJJa+ToUeKwJNdLl0wof152njIxsOumuwg6M1U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR03MB5458.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(22082099003)(18002099003)(56012099003)(55112099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZuNlRKvZ1+jAtdpY7MFwE3gorsbBBv3iWriJ2Hau6es/2CefXdvVlyuHCEFc?= =?us-ascii?Q?eiUSqnJvSpc3UvncI0Tj/vSL0yXuRz5iNvcoWeQtQKtk5zXX1rf7jRhgRDcC?= =?us-ascii?Q?TaaDysjq0HyjLjoGK51QWyiC30g4hqrzss+YPjC3Uco+4fZivezh43KS0JrG?= =?us-ascii?Q?RnB37H1A1FGoLd8RTlrDLLi+wQ8VJGHxNjAza5uX4HGQiMHXNUdyvPXU1iHJ?= =?us-ascii?Q?1VWPFuWure/FYkoHgvekL+5h8vqqtNijYOtCTBEznw8tdw145JrNjHSOy7NT?= =?us-ascii?Q?gA203NEgOtTZTyD91nXSs8UuHDT3KRsA+Fu2Dgu7YM238XC4tuvC4XyaCi6v?= =?us-ascii?Q?cdNUTlbUDaCiW1rLkjKFGyAxsqe8ZdY7dL5O5WxZaGiLKO0e2BEigvhqfq0a?= =?us-ascii?Q?GdTiSrEUX2pwu+vx2+baQl0UU6Isit92lQprNaOmS2EZ8jnZaOE7IX0qZdTy?= =?us-ascii?Q?NtFveXavC9mAzirdHHhnLuYqsR0yZXa8rNIMHfSbd7p7RlNLRN0aPtFjQsby?= =?us-ascii?Q?U/pFMgDs/7dWZdjMNyC1JJAyT1VbvTzNX+Gi1d0pZHibW1uUHlzbPyXj2ayg?= =?us-ascii?Q?GSfe4Cm/43zzMEM7llXsC3EfO9raZorOMBFcF/xiI6rfeZC94yIFwlNJiaE7?= =?us-ascii?Q?ccrIBOEMaoDv3n32Bk48405bvekKFJ6EFqlYgeDklesTEZd0k5xd6YMIDweT?= =?us-ascii?Q?xtj/6GDTXes3Zlwz2aAINJ8FltyYVP1Jnfmkb+Vaa4FnqvSCgsEsqUh3IYDU?= =?us-ascii?Q?3bcTqJphPI2+bCesO5N892N21VA75sdB/wHlObwyD5JYks0rid3SuMEcUyvk?= =?us-ascii?Q?k4wR/Sf/lnx/Xztu/AyJR8g2TCAoV6QISnsiamyCDBxcp2IH1r31J8RmTtxZ?= =?us-ascii?Q?3Eaq6uZJpKUu6HwXEjr/PUFy4wbCId+iv3nGatifvxhV67CRH7nlzgSFH4Qo?= =?us-ascii?Q?jBruFMEBWgkfDXZxA905MZ1oEoejjlhOURax9Lx3Bfhfa6ypqBqhsCCDapCb?= =?us-ascii?Q?soOvupSKlKgPpF2q5flWTT5llr7pQ53WQ6CnRbbUleSMFyfb5JUrJA7CFXZX?= =?us-ascii?Q?V5ZzeeRBVBjChZlU0LBTbHuHZjEe/sapPZPCYtcg+s8OK4USsoaE5/vHqRpI?= =?us-ascii?Q?DD9C3VjkOqilhn9uvlX0v5Vdygtru7maaqkMa43gbUbJlHkh1qVPwTqcs2Hd?= =?us-ascii?Q?Dkmq3RYLMibTjKZvZ8udup2u1QOX5vBy/bSN8+p5GaltQvfydodNOzO/3PNM?= =?us-ascii?Q?Dgi0bMz0RmLzgqGm4EhhCvQ0VVU15yzLHbbr6UKrsFebKjkj0EF/FfHLEq3z?= =?us-ascii?Q?YDcPT2b14LABmXI360f87VnLGa/4bW1+fuucB8pi+nEgt8lf319fT6fIjhnN?= =?us-ascii?Q?IDWSvH7p2d3eYIDGeza38ffCv0Nux7Y5jacdhlDLKDmAsMz9U0V9yxKERBsG?= =?us-ascii?Q?qm6blp/x2jDsNr0BytsquLcJjGmvB2GWsEkDd66to02iPBqJvDFSgRts9cAw?= =?us-ascii?Q?yvjfTtalbRhbv68aTmTOHrPP3rGBuhM6EitAmlumPcMi+hlNR983gtWwn2h8?= =?us-ascii?Q?4dsrm1eEQewz0VLvyBwXPK4DXDsCWE9TM8ZaZizw3kJOb+skm5hvDoUwlDor?= =?us-ascii?Q?5TcsE+Z5h5iSYuSx2+w3McExaUl6IbsXMTefU6UD6E6ipE1q1zKZ9AcKbRS/?= =?us-ascii?Q?lnAWDgEXyx8kNLnigLzouba+KVGBYo+RH3rUTNuVOHxLXghxbMCLNchFQB6C?= =?us-ascii?Q?17wqn8oGBxhvJwOprHmeMpLlt86GXURXlAe81gJwYngKW8N1Fxw40Mw5+Dur?= X-MS-Exchange-AntiSpam-MessageData-1: 40B4GIHVv8IZHQBEwU/Vq9j8u01Zu9MR2gk= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8410a79-e65f-4e0c-91f2-08de9b88e16a X-MS-Exchange-CrossTenant-AuthSource: BLAPR03MB5458.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2026 07:22:13.4557 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RVaH0U4YBgSfFzvdyxvQtVwv+mYo3OtNCzmor1CuFf5mpkOLZMWUh6QQDN5XnxJahkcKztttWgneCPWDmAfZuoVJxwQtHNFTRNGZaa1PwXoTPpWPA8fRzupxdNLG3VxdY2g2DOGjQ5+IHpkZAKiHeKRlIit243iX6M9Q/GVxe2E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB7011 Content-Type: text/plain; charset="utf-8" When the ATF version is too old to support SIP SVC v3 asynchronous operations (e.g. ATF 2.5), stratix10_svc_async_init() returns -EOPNOTSUPP. The probe function currently treats any non-zero return as fatal and aborts, logging: stratix10-svc firmware:svc: Intel Service Layer Driver: ATF version \ is not compatible for async operation stratix10-svc firmware:svc: probe with driver stratix10-svc failed \ with error -95 This prevents the SVC driver from loading entirely, causing all dependent client drivers (hwmon, RSU, FCS) to also fail to probe even though they can operate correctly via the synchronous V1 SMC path. Fix this by treating -EOPNOTSUPP from stratix10_svc_async_init() as a non-fatal degraded condition. The driver loads in sync-only mode and logs: stratix10-svc firmware:svc: Intel Service Layer Driver Initialized \ (sync-only mode) Fixes: bcb9f4f07061 ("firmware: stratix10-svc: Add support for async commun= ication") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Amirul Asyraf Mohamad Jamian --- drivers/firmware/stratix10-svc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-= svc.c index 739642923ac6..4924f6402d00 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -1953,10 +1953,14 @@ static int stratix10_svc_drv_probe(struct platform_= device *pdev) init_completion(&controller->complete_status); =20 ret =3D stratix10_svc_async_init(controller); - if (ret) { + if (ret =3D=3D -EOPNOTSUPP) { + dev_info(dev, "Intel Service Layer Driver Initialized (sync-only mode)\n= "); + } else if (ret) { dev_dbg(dev, "Intel Service Layer Driver: Error on stratix10_svc_async_i= nit %d\n", ret); goto err_destroy_pool; + } else { + dev_info(dev, "Intel Service Layer Driver Initialized\n"); } =20 fifo_size =3D sizeof(struct stratix10_svc_data) * SVC_NUM_DATA_IN_FIFO; --=20 2.43.7