From nobody Wed Jun 10 17:50:14 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D93623988FF for ; Thu, 16 Apr 2026 11:59:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340800; cv=none; b=W7uZZeGOMHsl7QNAA+YN1wxQZ0KgqErNVAedqGEebF+XUtg3UdpWdSShQ4gr2JlCcIVtJiiCJP1FMacCWlkPUrYyTTUAhPIsTHjE1HeiweogKJkXomwPwg+HSn2zUWwUp1zXOg1TEQ344LdCk/eCDDd5TLWmcl/xcYGLq5oHFcw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340800; c=relaxed/simple; bh=QhcT7I7/aMxwjiRWv+lMSZ9O1nf1QgKhkc5pxVQ9Aic=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rqud8pO7J4qHs9ysHKuKF+SWgcylcVr3TnrOEhspkYJslcQHdH/WK588fIjT2bXzKyBKnUWAp0XCam+k+G8tfQRRGzd9Woo5C6XtxY2o+VmAa4HxIRI9xozuWoJqJCIqyjvhqrSFbh618Yuuc1OXuAm+CKptOUQd/zU/ARSnBwk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XI3jzBu2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RmhbYUmV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XI3jzBu2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RmhbYUmV" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G8xiB74124964 for ; Thu, 16 Apr 2026 11:59:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EHpvbENcsLtgvr2XEbf0CXHSig5EkRvJvVRMbKysza0=; b=XI3jzBu2q+89hWn2 du21tHY8EWhr4GTFPD/rSiV/f8y8pMwMQDvpcX/R+HZ1QYoCLWsWU1x2HCT4Xc78 VHrlUwTcQZflGeHOZ7vhkYASfig29q1DM7j4OyPaOGoanQLgCMYEpmcEeJhpeO3t 9Zr1t6GxHrfwDNhLDTpokQh48qRUCEvJYNe5a/PCvLInoK+kEIzKoInHwbm30bwj VtAZV4lFyl7MjTOMeZTOGrI6XfLVkIyyZSLsXIm6Fum6C6PfmDN5XhRESHu1SGYp P3UwbLD5MiU6OArmTVlRJWYUW5FhF59lx+KqaSfCSAN8Lcc8M/J3S9GEE2AWkZJe Gqy2Mg== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djvrf8k2n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 11:59:55 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c795e0001ffso853610a12.2 for ; Thu, 16 Apr 2026 04:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340794; x=1776945594; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EHpvbENcsLtgvr2XEbf0CXHSig5EkRvJvVRMbKysza0=; b=RmhbYUmVhp0pXEIGaDsTDdHFGrq9ngMno/pr5NYB01kuVgGW0Ka4NLdW59TiRW3JrA JUs9tw8e+VH3zQEq5BRE8W1iLO1pMRCDMLTSU28Un1OafpQcgsbvEoXF0X5YVOiX3U5g p2v1kuIgTE03HQeeNRTSpiWCwYA4xfOQW30gyicus5EYjmQWoCXpBkZg6dDZiUYpmb8g 7KJ0UWKcPz2WDn7k74V6jH2hpS7qpamqtlGKFOe1YkqrFJ7YL+xOXI3sbfMs5W7Ngl+D 0635VUwfvGwtaXp5fC2ukS45sT5ygGREu2jRkz5fmjqQ6puefci9Sd0nSMzD1qRJi51W tD+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340794; x=1776945594; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EHpvbENcsLtgvr2XEbf0CXHSig5EkRvJvVRMbKysza0=; b=NfuIHPc1fwcPpVl2JG0QYTw/ZByxn8nqmXiYahO6KoixxF/e+tGG5N0A/67QUVMEbC 6vENswpSTTykpTeERC7vubk1vKtdVoBFw72mRnjUfWQZ1IaEspJGxvBrHpjrsQftSraD EeBNWfIh8XMn9A9ljJ3UctckZ0q1cMcadC8XrrzsVVu7z3GUHYFe1vvpzEs9MLetH56Y 4+lNMAmyoKU3qlRmFJBFeHu1zWyXUo/KQ4XbpBIcd+JCeZxOI5JlRUnkWHAcUPNF9kq7 dIkmL82Kz4b4t3cyOjE3iMDyDevD6ilUZNk3Xy04OPVHhdbOsKczf+Zx8d62a50U99U1 jiAA== X-Forwarded-Encrypted: i=1; AFNElJ8NhT+yjQjUIn7jhsQbjup+zONQZ4EPE9ckHDFk7DTAg5beeGJitf0MJJYsAYVKm0Qg5HJ398ND0LVJxoM=@vger.kernel.org X-Gm-Message-State: AOJu0YxSaTfOr+2gAH4RalWceQQpfMHbyH9n+uV4UwHEjlHxzJ/4qaDW gv6gGCNCk+SPd5NZBoaUDpS5/m51Ie4eOCQuQJcwjuskPPHPc1gnIt8lwN1QkxptVZKKOJa0D3i o8JyC/hXXdPkWGdOdllAnYUdVFs0tsZVlMUx/b7wwjwIbzvi1UkFYfD6pZUZe5jPoglNS+WBM73 o= X-Gm-Gg: AeBDiesQuCSx69bpGNZ7zFzxhhWf7iKjSa8/7rZFo0eKaRDiEucdujgI2Kgs+h9pXAR bZ4RfHXdDa2DKpzUYLOuQmoOFvg3nl8VMp+tpjaDKIyufk+opMQW99RaVxpQvObhdg1seVgj++g jFFNcD8tSJvAywcgwbjIc9atNUQqtqtkNhR4wJPzumjQn6QNK1GIJ0XhbybJnTH3JU5JOMPHx3h 58wA9H2UJbGDUGYQ79CmvkOO3gTuRw5Vyjh9SgzGGirbFF7CsYZ8uNQU0CclPdQOHwyiIIiXebl QOJRk5PnvZYb4IJzfj7Wej5bOOPRFTOh+gBQppuJMzU4a7xm2TH3ptXcLPLISYFaYLUfku7TNb2 fqs0AUvwik81fEhr6h8TqFSFdR7FM0nCloKgNMfn7VTkYVmgASHJsPrBzJQ== X-Received: by 2002:a05:6a00:4601:b0:82c:212a:8023 with SMTP id d2e1a72fcca58-82f0c12fe20mr25366125b3a.11.1776340794493; Thu, 16 Apr 2026 04:59:54 -0700 (PDT) X-Received: by 2002:a05:6a00:4601:b0:82c:212a:8023 with SMTP id d2e1a72fcca58-82f0c12fe20mr25366111b3a.11.1776340793904; Thu, 16 Apr 2026 04:59:53 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.04.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 04:59:53 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:18 +0530 Subject: [PATCH v5 01/13] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-1-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=2738; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=QhcT7I7/aMxwjiRWv+lMSZ9O1nf1QgKhkc5pxVQ9Aic=; b=8WzfBJpvJinzib77N/gNAbcdq+bEhlbv3p4u0qPurYA2X0X4j/xA+ShU0KRMJ3dQbjWIb2Of6 872NP3H6/gZBorI42sR5SNkpiXqtnQtO5K9jW+tWcUVv5XQK/waTlSr X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-GUID: bIuSdvmEvDlfeGtBEtRP2qkVlZcYH2ix X-Proofpoint-ORIG-GUID: bIuSdvmEvDlfeGtBEtRP2qkVlZcYH2ix X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExMyBTYWx0ZWRfXzhlZA4GK225m KkXjeMV1ifx2Lz+92dBZEWDMLqcLCRZj2FZvKidph+vEflQjijUT5u3UKizpsODxq/VdM+3mCQr 2SDCtezC9tmKv+Ta+MquG5QU1y9S6sxfocrP+NQhc6qakaPhcYQLRnkfecykcFuRqkhDeDFCWSP bBh6r3P4VIZzKH+BMm5OUG3RBrNs4UW6JJQDVakhCVuwHt72OJtCiQBViE/CteEvs7h8l7562qg gtTVcMtpGBl8FBdyX99KNIzxF78//iv/AULgwtEnJ8qCB8xDcpa/5G2NCcncb6Rt/SEwflPJNRx rTdL7X77pP41fA7HeeMXR+ZdIn+5udZC1lDCwtDvZ3Ev2+QA6sRoaKXhuL73IUdsG/FHqgkpTx8 0ZVS+Nkog5pF1hlrYSx4w4PmNwgQExEOAtLXQ7ccStgA3CsBMmnqsbJwYLnMvu2dO2H01XV+iXD HYBvu3b13t9oTL8wq/A== X-Authority-Analysis: v=2.4 cv=YtE/gYYX c=1 sm=1 tr=0 ts=69e0cf3b cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=nlf9mDh_Z9TmLa7YYksA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160113 The DT bindings for inline-crypto engine do not specify the UFS_PHY_GDSC power-domain and iface clock. Without enabling the iface clock and the associated power-domain the ICE hardware cannot function correctly and leads to unclocked hardware accesses being observed during probe. Fix the DT bindings for inline-crypto engine to require the UFS_PHY_GDSC power-domain and iface clock for new devices (Eliza and Milos) introduced in the current release (7.1) with yet-to-stabilize ABI, while preserving backward compatibility for older devices. Fixes: 618195a7ac3df ("dt-bindings: crypto: qcom,inline-crypto-engine: Docu= ment the Eliza ICE") Fixes: 85faec1e85555 ("dt-bindings: crypto: qcom,inline-crypto-engine: docu= ment the Milos ICE") Reviewed-by: Kuldeep Singh Reviewed-by: Krzysztof Kozlowski Signed-off-by: Harshal Dev --- .../bindings/crypto/qcom,inline-crypto-engine.yaml | 35 ++++++++++++++++++= +++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-en= gine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-eng= ine.yaml index 876bf90ed96e..ccb6b8dd8e11 100644 --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.ya= ml +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.ya= ml @@ -30,6 +30,16 @@ properties: maxItems: 1 =20 clocks: + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + items: + - const: core + - const: iface + + power-domains: maxItems: 1 =20 operating-points-v2: true @@ -44,6 +54,25 @@ required: =20 additionalProperties: false =20 +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,eliza-inline-crypto-engine + - qcom,milos-inline-crypto-engine + + then: + required: + - power-domains + - clock-names + properties: + clocks: + minItems: 2 + clock-names: + minItems: 2 + examples: - | #include @@ -52,7 +81,11 @@ examples: compatible =3D "qcom,sm8550-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x01d88000 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; =20 operating-points-v2 =3D <&ice_opp_table>; =20 --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59BBA393DDA for ; Thu, 16 Apr 2026 12:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340806; cv=none; b=bBGAddo0aMKXBjR6z+YBjKi/b1gWj5ODibRIFV5wp3wPvRDbzUyFGwgII6bwkW+Lxw2atgETFIcK5ChDTxBpR4Z8F3iRAcAdE9/VHSDKTcQ5gyVeZaaJVuPTrrHFcUlv6ofu09WK8fXmSwfAP54gONsjlyb2pIqWSZdGA74YfVs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340806; c=relaxed/simple; bh=k98Sd+IuX8Zn4GRN74V93GHVqiBr7BdRALamjqjLJpY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WB6MqFGx0hbCUMueYvTcEnfNY0ONWgw/SlWXs0SrAj8CoPA7gIT14G8aFupmb+z5DbIJHkzk0/95GlzFhhVMav1IU2xy9ZX++L/1tI2GzAIuvBM2xZgJXGx67GyMLbJmyHex+eELwNZlvqSSzjFKxcrZUqyHcQjiRZ/pJP43d5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FUdq2MpR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H09TE/Ne; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FUdq2MpR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H09TE/Ne" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G9NG9l1554426 for ; Thu, 16 Apr 2026 12:00:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= t4D3kKEXk5KVz/5AiBoL0eMglz9Da/HUz+0qxKgAV6E=; b=FUdq2MpRUYWfcoXg pFy8xh4XH/w3CiG/5L58x0mjDfCzAixVD0a4reKeqSSMmPfxF4MkS9+7PDZrWD3Y v0S7+mnkgThC1pmzNjX8iyTY8I+hb/wv7F68C6e8j36fSMdrx7QAs1ONpEIV8eWz +OBNVO0CjnzhM3arm5adaeinkhV2Ixtf5FG0Qrp1sP2jujA74j9kNxE4GkPLd4q+ VVssIlrot9BrioU49VrrVvJTvo2h/9hL85CPPirNYcubJqDNyPF3DRGOBwwzsBjY TmhKKnsq5NiHyLQRnAGhZzw7DJtrtn9vT/0n3dtWqMtSkBsRhkvihDhsO5Nnc30O dZ931w== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djrsn9hv5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:00:04 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82f85179263so22785b3a.3 for ; Thu, 16 Apr 2026 05:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340804; x=1776945604; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=t4D3kKEXk5KVz/5AiBoL0eMglz9Da/HUz+0qxKgAV6E=; b=H09TE/NekCzEhf+GW1SR8OBe3jaG95qf8q37g3enBQEH9/1feV6Qe8Jk3ph3YKtp+k thfwza43OZn58j7jHtKVTUZ5z70Q/wgm6yE227QjF2VWRzrpxWpWGMPI/ZwZAnY3RcK7 AnYHFi4rd9649i0RTyij+CZsoOShNIJh0x5KNnSFXRCXJBipFtkaEmVyT2caGPTCr41O kAhj64zacPZmq33jnFXfBfWx3B2ROUD9cDKAnfbttYcVLRhNO3ZM75HJzSaDAIgbJTWS Epke3TXjM06vcgdJmpgRPcqWuaX4zt5oV9z3QAwBhydB9PS7oUEtCU9uohXCI9XNvHhC CbsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340804; x=1776945604; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=t4D3kKEXk5KVz/5AiBoL0eMglz9Da/HUz+0qxKgAV6E=; b=iGCUR6Z2Z2FPvckpDxvJLCQBc0ya72J2sn4gJhp89hA3yOU6bqE7igyoEkIbMI4GOH z/EXh3v+fve90pB3Zu9pLGpKX4TgB31Jjfr03TyGQk7bemtCkA0nNbWRzyQA6ZdOidBJ M5ct1k/L9LLgQkVx1itip1bZ+4Dy0/nxCNGak7P3TIByeZz3srywILDuBmKhJz0XRbhI fPOVrlyyeNrHIw3Zb7G3wXM4FfqGXlFqPS+D0iIuAFYbhm5PurVilcGjIRlBSiAkiLkS 71+DOznBM57ufhAP75icbAWE/aO0DRzvfdlMKuLWeIaVF+FCimDX++qyfGRGgXZQMRos /rlQ== X-Forwarded-Encrypted: i=1; AFNElJ9qPIW5Wcw42Il8K5JGBDYy5/yLWAsWauWoEPMRzy/G0x68Bm2gpXpactJR99iVW7xYWfi2f1CLoUeQxhY=@vger.kernel.org X-Gm-Message-State: AOJu0YyEZeJcGpRoMdao3FvDe2lhKjqeo7n6YwaXhMh+y9Kt0gMecH5o HriLrem1wCG75ztxsTB3SUgIrrDGIr/2a9nzJGlNUl6e6tvBlCZFWD064qpOxOCv1yzEGREz9Gv i2fDSQLpv4jZIt9Q0asSdPFkh89PXCZ9b3UCuu/TxYHE9EBzC6m9k00oRmt9Ix0eGqdE= X-Gm-Gg: AeBDiesc94ATGNgAKhm1q2PtvwqM43gGF9LubmuC58/dh7DoBFboJ03rq8r5bMZqCJk NoL7Qx9hWxfiFRvYHyuG74DtzeoYr37NFIN2BpONQ8pQz2sj5J9GE5qdUztIZoIg8w5c3nt9CW4 /4v6FmD5ByhHV+qIDAoyAOuyZ/cYJh+dMFfSFhPeNGNS2tVJ5gQiz2KmxshEA6Q57lz5irI56cV g0KlpaaPnKR2QT+BYWUGcygqPPuQBz2Qlz4kEtImg+mbYVwllewFAqKVqSSLQKGh0ZuiuS0dRRe w1U0pbLeJeZOkkkAw13QG5dW0+Kbv/3E5HNqj7GJtID3GNBvfhvmG2R8CLilbzHerMb68PIlo// DMkOVZ3WjybJBTubT6o+9TUvZq8VmpA3brQUlrqyXo/aOC6/VURter7gQnA== X-Received: by 2002:a05:6a00:400b:b0:82c:6b46:271d with SMTP id d2e1a72fcca58-82f0c2efb17mr27197899b3a.48.1776340803733; Thu, 16 Apr 2026 05:00:03 -0700 (PDT) X-Received: by 2002:a05:6a00:400b:b0:82c:6b46:271d with SMTP id d2e1a72fcca58-82f0c2efb17mr27197857b3a.48.1776340803124; Thu, 16 Apr 2026 05:00:03 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.04.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:00:02 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:19 +0530 Subject: [PATCH v5 02/13] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-2-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev , Manivannan Sadhasivam X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=2680; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=k98Sd+IuX8Zn4GRN74V93GHVqiBr7BdRALamjqjLJpY=; b=oe/UGWbm2S1UOJmEZXb7xFis/im2RDqGaiAutBClGq+FEU5aI480XpHFOMuqVF1yWN8lLG2SI bZ1qVSG4I6DDC/RvkWQyFhOWLOVI3rpzkJH6M8PO/F1jeBmMyfU6ihW X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-ORIG-GUID: pXsDcxA7YgHHB6SUrOcX89vclb2xngAc X-Proofpoint-GUID: pXsDcxA7YgHHB6SUrOcX89vclb2xngAc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExMyBTYWx0ZWRfXzelrq5+TR2v3 pPyOlKTVKRkfL5xjL+LVS2MZVKTC0HbfmACyFhkPG+tw6OQgCfxDy2Y40GOcpA/73SxUMibZ//8 rLSqZiFTKO4h2TXrgJL2V54q3CjRkAw+gUVpZoBzsm8iycpx8zmztYZ2qHaeSFXwxVN+zzJbLRF vQDc9VGG6VuwnpVyXG3ZitmXx69zJ+69Pfnrgn5yehOoxlxUkezeQyakxTA4SIr/MUS2iCv7NuK SyXu3vAT2BdpiY5Fzmq6QuCsmaN7xLZ1/iMgr3Xn2BhILFz05H3HY7U/zIU0iMdSxVPWi6bov+o 7WSREyDCpYMa6/Kbyo5T3qNY3Y8zbMUEcVKB7NBh75eNDVCsJuBageW4Eu+EwMOuf7ublWxwuP4 cuXOjEJnbdPXIi0wvjBYsf5Aj8s825VuT8pD18EEd3VNkV1T/7Kuf8XnzMBFOHIbs1Rlvs/s1Qy oPMfr1XuJQ6sGX9JS1w== X-Authority-Analysis: v=2.4 cv=EojiaycA c=1 sm=1 tr=0 ts=69e0cf44 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=DGDWbsvPyNGGEFbMfx4A:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160113 Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver de-coupled from the QCOM UFS driver, it explicitly votes for its required clocks during probe. For scenarios where the 'clk_ignore_unused' flag is not passed on the kernel command line, to avoid potential unclocked ICE hardware register access during probe the ICE driver should additionally vote on the 'iface' clock. Also update the suspend and resume callbacks to handle un-voting and voting on the 'iface' clock. Fixes: 2afbf43a4aec6 ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicate= d driver") Reviewed-by: Manivannan Sadhasivam Reviewed-by: Kuldeep Singh Reviewed-by: Konrad Dybcio Signed-off-by: Harshal Dev --- drivers/soc/qcom/ice.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c index b203bc685cad..bf4ab2d9e5c0 100644 --- a/drivers/soc/qcom/ice.c +++ b/drivers/soc/qcom/ice.c @@ -108,6 +108,7 @@ struct qcom_ice { void __iomem *base; =20 struct clk *core_clk; + struct clk *iface_clk; bool use_hwkm; bool hwkm_init_complete; u8 hwkm_version; @@ -312,8 +313,13 @@ int qcom_ice_resume(struct qcom_ice *ice) =20 err =3D clk_prepare_enable(ice->core_clk); if (err) { - dev_err(dev, "failed to enable core clock (%d)\n", - err); + dev_err(dev, "Failed to enable core clock: %d\n", err); + return err; + } + + err =3D clk_prepare_enable(ice->iface_clk); + if (err) { + dev_err(dev, "Failed to enable iface clock: %d\n", err); return err; } qcom_ice_hwkm_init(ice); @@ -323,6 +329,7 @@ EXPORT_SYMBOL_GPL(qcom_ice_resume); =20 int qcom_ice_suspend(struct qcom_ice *ice) { + clk_disable_unprepare(ice->iface_clk); clk_disable_unprepare(ice->core_clk); ice->hwkm_init_complete =3D false; =20 @@ -579,11 +586,17 @@ static struct qcom_ice *qcom_ice_create(struct device= *dev, engine->core_clk =3D devm_clk_get_optional_enabled(dev, "ice_core_clk"); if (!engine->core_clk) engine->core_clk =3D devm_clk_get_optional_enabled(dev, "ice"); + if (!engine->core_clk) + engine->core_clk =3D devm_clk_get_optional_enabled(dev, "core"); if (!engine->core_clk) engine->core_clk =3D devm_clk_get_enabled(dev, NULL); if (IS_ERR(engine->core_clk)) return ERR_CAST(engine->core_clk); =20 + engine->iface_clk =3D devm_clk_get_optional_enabled(dev, "iface"); + if (IS_ERR(engine->iface_clk)) + return ERR_CAST(engine->iface_clk); + if (!qcom_ice_check_supported(engine)) return ERR_PTR(-EOPNOTSUPP); =20 --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BBBB3B47CD for ; Thu, 16 Apr 2026 12:00:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340817; cv=none; b=LbvXkawMVg2kuCNd0w/FEcg92PQmzC3QM0KO5UbjJHI4z4JOPfcWLsMVccP9L8zSm7PQzhhVafILLP1+3cABZVKS/iDGc3U33M6lzeKnsXAahUm0tDZLugwXFOsmLW40hjd1Y4U/lPGPwX+jaaJFgWrZ92JjXfLATN4mgY/yPas= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340817; c=relaxed/simple; bh=QE8CNKbUxHV06s503gk28Y3re8Qm1iszOwW9njMEFI4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VBvHMEeEFSbiE19+HUKWJDj8mDd9ltc0rJfivFUww9lFw92LMDEENkwkreJrMfjkHrT6zxY3WX92+YI3lG1GcCHZFUaUgVhfDMQS1i7K9avJ4X6AdzrxODHO1/meBhgIoywutYgd18GReuk+5Qugq8TfY1a8vbZprNohV0cfF6Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MZfn+elt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SM4ALTuM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MZfn+elt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SM4ALTuM" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G8CU5m2576024 for ; Thu, 16 Apr 2026 12:00:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Yc98Heos262Glwo4M0c+bKKH3aIaHhX/ZC3SOXWuFWQ=; b=MZfn+eltiMvFlBuq uUtyZjGsVMXw46hZKEbgobU3pTBhj/OjtKW3i1GCROscmP2R8LAFGVNIUobvH3UP B9miZ1Qt1StMQFqkn8qZstLUdbZTsV4Q5vAtbekk2UxJmgTCMExkDJFzNnv5npW0 haO1QxdKgh4o9xWDRvT5DWdgUaZGFiEWmSKGowhVcK8Rv5PSxbyVBJT+HK6Uj1iU Rh8yJe1gtQrtwI6sig8nSWT157BmZ0lOSdKcto1HsMVWhdGbwuNSGByMS4ivv5KQ rol5kY2u3kFgjWunRhM1S1OPQzSRanrf4MkmKa6l4uWGIcZ3Xhh8TpvJvBfApC/9 IvY4og== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djv27gu4r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:00:13 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c76b0e04285so3511161a12.3 for ; Thu, 16 Apr 2026 05:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340813; x=1776945613; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Yc98Heos262Glwo4M0c+bKKH3aIaHhX/ZC3SOXWuFWQ=; b=SM4ALTuMcAF85FZcuDH/ID+yG7lwhIdCqMWR6tv546wfrPLwC0PsiZsmgkzxeRY6gk c1axYYpP5qxS5uA/AFpWxbTglGDHX/YhThzYEXMzggqHI9o/ag3QPtn5Jpd/jslgCpAs yka6h+t2uiTnxkQYianYlip8sfeRIl7Izay4tEYUSASPAoAIVTH1iqbF7YJqqqGzBW4M Ov/55E5pdevZF8zrDlfBsxBHw5/GTtH+w42N6NJGWVmQEj9ALFjQS3Zk5qT7P2Z21k+T XAGJHtwKZyGXzCVtvwDtQmbu2EgETrqK4IFvLEBdVCiVrML7DTgbOUDKGsgtInE7jJbQ nTbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340813; x=1776945613; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Yc98Heos262Glwo4M0c+bKKH3aIaHhX/ZC3SOXWuFWQ=; b=NMMfUBBRfGdEGEprb2/CruBK6CGXgJjpTWob8pZct1OW2AHrQlI/9RikGBE2BcnWOd wI6LQcAsTscABW3thq3cJFe8qG6qQuTqjAeq+IWDaZUNGVq7kF2MLROo+ztC9JqF+3ti 942oXRsrF1CNqUHLAyDPbAAZ3/N2JOcR/EvVxio+iP+j1I9kCm01RNz9uApTeZkH6Vyf 5MlEc2f3wCr028VVsohn47+IQhsva0eCKTXvihZ4tFIAJoF94zYHRGDcc5RmbGIakDyq pUy7FwVoe4fv62G81AY1iaVkQ3hLv2D/UzGzVGqfcxLTZlXkfZgHTvjwJyYdnlkltdrc EY4w== X-Forwarded-Encrypted: i=1; AFNElJ9Td5Q8cfCXGeqs5XRg7mQlofEcu9nXvtlus2Xb8kPI0RYrVJt2qNIt74zLpAjFR/xQyUIqW+Ep45VKAFo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm9EnT3yOpLzgrPK5+x2oOlxyKDuIhLy+Yg4vjHMf7o5cyFqfq rOLflH1F2Ipe5s20jrNrB5ScXWhssby+Sd9Ff0Dn2J+nEV/K/uLWWNM09cIvTWDiCcJZ1eZzb9f fsWaqUY/H1p2rKAjyqeIzNrO41wi2O7qZUyCxMzYMcDxY3g/8eAPEh2OOyxZfdPquj8Q= X-Gm-Gg: AeBDiet947nbVAYSt7KR7a7256mbyQhr3Whnw5r0q50YATzf8GgLB78K/SXjXWqRqBg pjAiNy4WyKZlygWeyKCza2W1WAl2qPmMT++Xle4K1fN+DElF4RrrEl81Q+begvAcXZfOWxnz6fg e0jAc8omsrU4iC+7xn3M6IrtW86YR3vVTtVJfi1Zbyw0bhJG/WvFEVvqG3mjPIhaj0ywM6IGF/J JnW48VfZz8KwC6Tms662JfJw3WaZd7EaIOC8ToYcGF2rBrHbz4ENLZnyXSHNPd8LSIsbCrfn8eb F1fUp4+xyjQIRFWHxYvouUt9hAKcNKP54bNbbTArjzZV+Ds1pZLqnSYqxAnfivr+/iV1SnTo/LN pBLzE60mYvgit466ia9756qQlM6+3DKdhBwlRlOTGKPHt0C7GpYFREeHFYw== X-Received: by 2002:a05:6a20:7294:b0:39b:d9f1:6d05 with SMTP id adf61e73a8af0-39fe40e0678mr28808073637.53.1776340812754; Thu, 16 Apr 2026 05:00:12 -0700 (PDT) X-Received: by 2002:a05:6a20:7294:b0:39b:d9f1:6d05 with SMTP id adf61e73a8af0-39fe40e0678mr28808003637.53.1776340812212; Thu, 16 Apr 2026 05:00:12 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.05.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:00:11 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:20 +0530 Subject: [PATCH v5 03/13] arm64: dts: qcom: kaanapali: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-3-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=1530; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=QE8CNKbUxHV06s503gk28Y3re8Qm1iszOwW9njMEFI4=; b=hlZbO11yX1CFG/dQ6xbqMmRTnRitXdbCOfRoswT0t1xEnqyCIZLpK8N2n0TW2y+WtS56ObNhK eGSNi1JM7w7DoSyjo9zJ9BFbbavE8M093eC954b+M58KXu1UhHJ2bJh X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=PJQ/P/qC c=1 sm=1 tr=0 ts=69e0cf4e cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: 9qLcKoSnJefdJejD-sC_dEXBbjKWE5i4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExMyBTYWx0ZWRfX/IX9eBakcJB4 nPrGxOzbT+q4pvQosVeO7NsjcVZv/Jqihw93azweP4+VJdXon5EITfFY7e3HOBba8Peq/AYCOfW 2GidmUmgxZhW+HBFiMlJXfSUApANJfD5rFf5tgMcNP1ZxCyaC8GMhxMiHA/R6IhUOEjwjEQMjAp XhNicQY9pE/femyeW6wqLjY2d30E73m+ZFDZ/cKZi8ScIzy+iYvc8OKuSVAmDSYwtOHp4fGrTgE QzIl336FU50gGKNM15KO1HUIazbNft4bzzM7kQq1se9jerovEhJSFWW5UFFOoK9s7MSJUYdCLO4 hJm+jeoZgGMtE2HlkZ31BSKOgluymHHdjHuFF8WctX6CxHXLmeM8Wvf6QKOc8gQnn7hN0Ki8Mgm g/zwKeVT7PlTpq9Lf+Vcl4th9GeCFdyxl0DytvlI7wxBMkNJLVrPfyRCn3XBPBuRuDKF1gR11xu CklJw02f1/PkB3lbS2A== X-Proofpoint-ORIG-GUID: 9qLcKoSnJefdJejD-sC_dEXBbjKWE5i4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160113 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for kaanapali. Fixes: 2eeb5767d53f4 ("arm64: dts: qcom: Introduce Kaanapali SoC") Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/kaanapali.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/= qcom/kaanapali.dtsi index 7cc326aa1a1a..14e362a4899b 100644 --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi @@ -2538,7 +2538,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 tcsr_mutex: hwlock@1f40000 { --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D58DB3A6F18 for ; Thu, 16 Apr 2026 12:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340825; cv=none; b=ELik8DwlIGVajurI9gaVu4Zy9tVYU0GjUCxNMtWgnKgdQK2r75SaN2N7zgb2bZOTq2rstwYtsKeJXa55cBcOXDPiG7jDVNu7K18itILGAVu9GI4z5LXiHJTs09vlzhxyaWzzRyKR0/TbncdKA7ljhZOqgZMnmUjXgCNbZem7Ykg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340825; c=relaxed/simple; bh=WoZmdcsES0kVFqgFOLWDNt7rW2ibjnMYVhqmjTrduxY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qYPGZi//gyjrvc2VS/Pi6lIKxZfhUDlbkXDjlqVkNUyjCXaTIYXGnspTEf9siCvhh13Iz2ai/dJ9haKhgFztcmAASdBH91LP4SRlDRNxQB78MF7hqpC5JML35Hy9RkEy9dhwTJpLFsypUaVRE5tLGYh2qC/8mlu5Nd0kDfz3zXM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=blF2X0/n; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=W/F/FaDj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="blF2X0/n"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="W/F/FaDj" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G6OneG2651836 for ; Thu, 16 Apr 2026 12:00:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cdM6xkgTl4qUH9SkEuho0KJ2Ezd/MNfY0LaRCpzflp8=; b=blF2X0/n1o73Igc+ hoQLaZ24RsP2vUB/bWyWPAPPb9+SGupsdavtwi+UKXSwx3YRtIzEN2qIbVx85xYD bKIl/5r/P4dt7qsmQlhiUMOqbi3eN6mi4yIt3CNgIuVaapk1Dbg3mn4A5+2O++eF h6+FWZ7b7ohNDgM07Dn5B6jqKaiO1Kh9pRTng/u0Ikzh6WJZcvCzv80zLiRPMNlt G7jVO0jSsnRnV5blhpCEtr00T5hvPvSwsEZvSYJLUjEDKkeFE5cvDxgchDYSiq8f EZY/kF1ErN9O0ZuXCmojYcbTwK8WpzSg6If+9lh51mCcg9/JcSlC7i7xbGojOZwU KsZqsw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djtfuh5pk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:00:22 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-bce224720d8so4380115a12.1 for ; Thu, 16 Apr 2026 05:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340822; x=1776945622; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cdM6xkgTl4qUH9SkEuho0KJ2Ezd/MNfY0LaRCpzflp8=; b=W/F/FaDjakl1N6RCXS4hrtnmkkPhiHAGvotC3yzH5sGmIRIP49uZuUZZZ3wLB6J7KN FA3zsBAPHOdnAENUuSsCJ5Sg8E5PLpYKlBOXqB09icmZZx6giR9zF7SZyj6KX7g329nt Khd8uB6owTLTMLfx2HDQHfqDxf8bd8pd2OUpx/x+/EuVP3ROl6eqbtCR2+q2wVY8mCws oMnftBTwO3VazWy/ztheI8vcDffSFLRdBxcak2RuuKGQrPlZsMX48jpxI5FloxRtDYNL DFF2ldDhug9hz3mLMdOrBUnjSUn4+H3vXOg+nq9zGgDzjFcWmN1n7qRIaUO6hVo2A4wA kBOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340822; x=1776945622; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cdM6xkgTl4qUH9SkEuho0KJ2Ezd/MNfY0LaRCpzflp8=; b=kW67EBYt9WMb5jhAw4GVqX5dSBHfs3oimaJ3oiLbQ34c1bklunm7YO+RY+77jfNTRZ IuHbjcAt4RKHALVyzXC/E/JSek0YX7siTXjxP8XPvieW2Iw1fcrYrF95OlubJRMZwLcH OcvxRjbSi1IylZI58voKe1sw7mvPBvEplhcrKpx6hnQDehRkIEqp2wHW07frLcsM5/ke N9YY29bORSPLESZzPQijRoWX0KqigLB5y3ynMIz7csmsGoZe59/Q+Z+o6YS66rQKThcj UpYJEy8njYryjkIkxDGcRCE2W+ldXc32GJAjk6QoleKMm18xVRp41M+TOmcENo7QNJVT 8GfA== X-Forwarded-Encrypted: i=1; AFNElJ/YYJBxoVBBnA6oraDwB1BigJAB7Ut5uElnyuAJI64UI2k4JZ+RC81AR2i0XVOnEAII+V/0ECs7NB+f0PI=@vger.kernel.org X-Gm-Message-State: AOJu0YzTk8IMqkV06OQIcQyQoLR8NtaXE/0WItYyYlSG8UB2e1adZeev iRkWlJUz2DOZ2OuFhkUeV2eFXLsX29G6b0Vvf/2xdCc6QX5i2y76xUdOjpQj4P51aF8tTVtR7Nb YqoC+6yubG2t2/2MYGEAffOs6vqMvd9ETAakfnils46yguDhrNZL0bDsglnkiohO1eFU= X-Gm-Gg: AeBDietm97mkrc6eTdfMJlwB62OT+fJcGxfKu/A1LG2+Z0PCCG1lM2OeRlWev6xYfx0 9lr5LW3hI1iGZbH8SwQ6bDLQGpXjqjHPNP8VNSeJAMwAWD4uyjidSMu1C+sugANQ1yS4xNEm5ZO YPDmlvuS2L4vMfNzkOlc5sQTqTGmG1683k4j6faQyQM5LPMZD63DbYbzDk4y7dkm32MmvE5aEj7 27XYqat3cOUY6At2aQQXikQYMeBHrMnaWUVB1jrpsaWXY4COYlrmjX0VnSrZt4BHCMrSBifFT2/ q1VbP3Sk63OUYJ5DIPE1t6zrvyGKxEvGJYRq3yCGS2amUxAN4Fk3QQM7RBzGQDsT3J3macvHYiB PsiwO+hFl/ogpHNAYrwiuranDd3pNI9rvjvip3A7IQihAlllncW/BgNthZg== X-Received: by 2002:a05:6a20:6a27:b0:39c:2bcb:4197 with SMTP id adf61e73a8af0-39fe3f8b573mr28395553637.30.1776340822007; Thu, 16 Apr 2026 05:00:22 -0700 (PDT) X-Received: by 2002:a05:6a20:6a27:b0:39c:2bcb:4197 with SMTP id adf61e73a8af0-39fe3f8b573mr28395462637.30.1776340821330; Thu, 16 Apr 2026 05:00:21 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.05.00.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:00:20 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:21 +0530 Subject: [PATCH v5 04/13] arm64: dts: qcom: lemans: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-4-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=1575; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=WoZmdcsES0kVFqgFOLWDNt7rW2ibjnMYVhqmjTrduxY=; b=pb1FuQxvTSvTtFtNSn3aakvjrTq921tbTyrt+lJTWSUPXIUkJOZ2PbX2FnB84iBfcHaMWa2jO remJRi5jMlNA8YKTEqZFohDiorv9WeOQV5MYy7jbYZ2yWCRpkc+Z4GY X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-ORIG-GUID: 5HA-sYcpu-dmMxLpBPuyuIf3vazizz67 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExNCBTYWx0ZWRfX+Zpt3YhQpUX7 jyFulanQdbA+Xh7oROrxueEFOFNSNVbnDikmTUccqHB8JYRW7lb5VEwMXz9fpEvEKA52wes4B1V RS/jOhiEgT34ua1IiCympDJj9Uh7bauf63Zoj1Ca6j4HlfoW3E59JxRSoiQ1dN5VSdcG1zFNz8i xo6gRPlFc+vn4cP9Suq1IOcngqgGwdCPGTtpemuD2Dm8GBCQvLP8HQjPBzd362UyckxR7/tn3Hg suQ6MP0N2/Ls4hV9eFYJcPu405m2DMino+bbteZTbhedbjGq4W7AFsZ6PKUet8Q/vatW4h+v/Ac kJLLN+WiV9Dt9J71IYYXy99a7YcWMrZ/5xfUsbt5shkBgwBwHYNC+dUzU2mwTleBI9tCkb9ip/R Nj3Jdjsl48Xcmlz7PeuYBTbE0e7ijsX8gRwj93hykfU32fyion9BISJLX79LYjgg+kT1VckgpT3 RykcZ+92e7MejECYwQQ== X-Proofpoint-GUID: 5HA-sYcpu-dmMxLpBPuyuIf3vazizz67 X-Authority-Analysis: v=2.4 cv=KrF9H2WN c=1 sm=1 tr=0 ts=69e0cf56 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160114 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for lemans. Fixes: 96272ba7103d4 ("arm64: dts: qcom: sa8775p: enable the inline crypto = engine") Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh Signed-off-by: Harshal Dev Reviewed-by: Bartosz Golaszewski --- arch/arm64/boot/dts/qcom/lemans.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qco= m/lemans.dtsi index fe6e76351823..d83cad26a20f 100644 --- a/arch/arm64/boot/dts/qcom/lemans.dtsi +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi @@ -2758,7 +2758,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sa8775p-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF2EE3264E5 for ; Thu, 16 Apr 2026 12:00:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340834; cv=none; b=Rmy4O1Z8EYvt6lsrmog0/ObFhoBO+K2IV9pqo7qnfGbNQf0dtXy+K0PWivtP1/TBFMv8vkr/SxoT6wDu0wjilQBDyv7rRlmIqS+1t2ubShsd2QplGw9bxMTO7IwC3kCzk4Dsb67Auily0/hW50MDoXGZKsNEv0BBfyUIGIkptz8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340834; c=relaxed/simple; bh=Hlr/X1jpHVRbaIJRwUKkEuQoVBfs2TtNCkWyFOX+H0k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tXeh7vcZVCMvZM7aLqw3RbVDiH1K4vj9Ql7YFaYzZAdPJP0ekpgVmhS+4J1Wxg92TjB1uwQI8CSRxPYtlOgJlRr12Tq/hLzGuTDj8DftUgfpLxjM4o5cPe03OBKlR4WZvbfnypfyJl+suFvB4Nov8xzXAy4qkqTf7pjP9EXamF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XIiuIxU4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=egydE3wy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XIiuIxU4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="egydE3wy" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63GAXrTx1245112 for ; Thu, 16 Apr 2026 12:00:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 75vHHvRKh5QqiO/9HH7clEC0d88m2FYIfhh7wjkOHaA=; b=XIiuIxU47t7m/G2e kcnb5/TgVtstAGoQvzeFt51q1g4YjBGqEh/23T6wZJq6gydUbQQxXSTxEUC0ih/B 9OJ5Z2wuL6RxjB0zw0Vd7qMTiWn3yLdH38gGmhVj1XEHeZRwERTkFWDV6X3j64aE I7urs//UNJsbCtVfnvC3ab/4WFNKSF3J+0GFmFYT/d8eoOJt8H4lRBnEZnGwuwxe RbIQbE1zGNt7ez5AYgTEqFlypbNZGGq6YsWDeEbZgyVpFymbSvvfBQHtnntvTqaO dXw1+9C7jdKVL3DHLgzFhFpGU2XG0SI9vwZrwKtKI597oitN+NvkWebfl7k8PDPn 0tVHrg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djx4k87wk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:00:32 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82f5f48458eso1303448b3a.3 for ; Thu, 16 Apr 2026 05:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340832; x=1776945632; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=75vHHvRKh5QqiO/9HH7clEC0d88m2FYIfhh7wjkOHaA=; b=egydE3wyJQyjLxGCCcf3+Q1d3XQIBwFOPvN38pd0hmh1cn0j6hx9MKLq5EdCtGSg+t LcBclILxOj0tYMQ4lvmG/3FOaqtL421Suc63wKcyt5BCyYpskrgYZIGwk7V5fLUNkQDv qu+7ySumNhd4VZR4trMSUBELvCHa0jY5a4bGjvHiNhvXRSqkBWSSoh316eoiq+/7pbKh jEtITx6yBHd1kv8hyKyVyjnxvv37aXt/MtOIXuVUC05bsIH9Xfrb5NgjPz87ICfF+B3O kp19jRsc3ej+ZxHFvgtFrYpopK4dQVVPOc8i2UT470kOyVKbwLlF+hX8tnyoa8x59qm8 DYrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340832; x=1776945632; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=75vHHvRKh5QqiO/9HH7clEC0d88m2FYIfhh7wjkOHaA=; b=q0Tmbpj2HWXXZAMNbb+VCZ9JXhvZUevZAwgA0MW9SIIrZlJFWhZAAU6wurul49OjY8 147pPYZGvGiIOZmj7mziACmcuWxuymMqe+B8/AZTetVy/UUSRPUW9MUZq84ga5XVswc3 29dbz9s3FUMfOs6aYHNPKFZmyMA/7bmR65GDVNdEgqKb0jZRgPVBBaEeow4WdHn2SmTM MFVewY3OMOWr5THMlwc517MtgReWKvsIvyazHlHHXAljTaHP8ZMz7rp/YBeZZiD27/lP j1V6r1+HYbLmCg2GMLL5p9vfrpXqzNzjn+6UEZOTB6axPPCS258mteLJ3f33RDbXSCoy o1ow== X-Forwarded-Encrypted: i=1; AFNElJ8aKuPkWapsIkbw0CRQ/9djPU7z8u0gAn7A93YuBC9YxIlQ2/84gijKoS6B+zmvq+iDIY+cwOcZREIbqTM=@vger.kernel.org X-Gm-Message-State: AOJu0YwhjU/Z9+ud/hfaDIHekaiKQbskCzNnBkpRqFvJgAltDXBqOvaY s1NkWMjw6PayUPWY6c6KP/C8oXhB/JwaxcUh1wxXiaBj+OxbtCBgl2Ml4qj9N7d6CzTzU+B4ZqS f0bygrTFczHEcVfQ29RPF9S9etxt9apFfHRaWxfwqCIhvNxnPB+HPF47ReLDlfqN1/94= X-Gm-Gg: AeBDies1IWvS3XN6NnuoujQLjzqLL6S5u1PZz6ytSBRiWPmU/sEz74HA9ZkNtIkj8FD /GVLxf5B/T/hBJ7Ws9LTxzFRvAOnHTlo3wVAkMbCq36lOiujLpyafVJPDAlBs6PxvWHpMTt3wuX oFQp+THq5Fuv90DJP6OGtHkg6obTQYwM7BSPEFL9oc6rZ272J8p0qocD/on67l+dsJ/JAH8iEYF bJPmzV3BDSVcGYl0of2JxSrkP/rPDQwtlhn8YrB4S3vxN2cUdnGvUzx8sAEQwK4EmzOSRbSG/ph B6zhZ+63NlMJUuDU6p7xbPag8GU/3UjlqPMmT2F7rkthRm9IHEj7Bra+TfVg+XNS8lcHyfPB5ia uyGkzLYT2ZMPbCvgO1mnkIA82hLoBd6kAtoT0zYKJEjjWxmJWJ9euvcSEXQ== X-Received: by 2002:a05:6a00:b80c:b0:82f:111:7e60 with SMTP id d2e1a72fcca58-82f0c323e1bmr26983970b3a.37.1776340831397; Thu, 16 Apr 2026 05:00:31 -0700 (PDT) X-Received: by 2002:a05:6a00:b80c:b0:82f:111:7e60 with SMTP id d2e1a72fcca58-82f0c323e1bmr26983909b3a.37.1776340830676; Thu, 16 Apr 2026 05:00:30 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.05.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:00:30 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:22 +0530 Subject: [PATCH v5 05/13] arm64: dts: qcom: monaco: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-5-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=1577; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=Hlr/X1jpHVRbaIJRwUKkEuQoVBfs2TtNCkWyFOX+H0k=; b=zFyeQLK3DLVgiR5gu6pCRZC5+dp/ErhpmDvpqGo6E2IkbAquIt88z96g7d+DygajjIS6u7RVK WGCJQzkPlupDsQ7PGqZW3SnMujqYl+TqRcantn2qo77qaZV6FzUhVO1 X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-GUID: wmxNKgxxN0fk_kwsaCUh2wEnbJRAMhgf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExNCBTYWx0ZWRfX0cld+1rF3uB/ cnVto26T+cIHrsc+PSxIp/uAwMvHkAxYS50wJagify8Ps7nEM57bPQ0Cnh7cm6htH589WH0Le97 lVXx83o6JvmTtVd1vnBiVt3DvsIZ46bUgkFU3S28HMJ8gZqYkGjYw1MQBznlUgAnIAKwRvB5+ey REXn5yG9kWTs1ImtznZvTdagog8W+nDmVnBFSxhtlB4Cvvwj++riHAx3P/1h5Y5KVsG8nzBiL5s ws9OZAnkWFORJ+znT33qAE4eJbO2cavV4ZzOSoFfQFWvzhRXKcZvVx6TeS9vGCZesEklzZH8aA8 A+3rpmQN4M94QAnQwPvTb7UEQ749Tz/Rewd7OWl5fXe+rHYXOSudlf3S2tRhaTRFVl9px+KU+ja H9YZwv1AtzNXC8F+ngqlYOVUyEw8pIdH6O3w7cuea+Se3saFnzsLUWZNdHukEEAL9Oe4JcdVu31 /1zpqiLpu+JzXKSk/zg== X-Authority-Analysis: v=2.4 cv=H47rBeYi c=1 sm=1 tr=0 ts=69e0cf60 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: wmxNKgxxN0fk_kwsaCUh2wEnbJRAMhgf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160114 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for monaco. Fixes: cc9d29aad876d ("arm64: dts: qcom: qcs8300: enable the inline crypto = engine") Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/monaco.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qco= m/monaco.dtsi index 7b1d57460f1e..fa13210fc539 100644 --- a/arch/arm64/boot/dts/qcom/monaco.dtsi +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi @@ -2737,7 +2737,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,qcs8300-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 crypto: crypto@1dfa000 { --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8179B38C2C1 for ; Thu, 16 Apr 2026 12:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340843; cv=none; b=mt1r3LF5tdWrEVk3hzcEjWXp9bGpdFUuMeaHdU5hytvFHPhp8fYa15KRReWcK80J9uKZbLCdfquy3mHr42iX3silAltBKjYfvhuNQ4HbhhZ5K85/9GsY2YnFkbsXAq3aI3fUeaQyFj3F3OHYbuktTGrhBFOXJGi2YKPnnDbBC7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340843; c=relaxed/simple; bh=LEbiblCKcyL2p/bVLgNgGMJciZnwnEoCuE0intdil4Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QLJAyZcks5yaMhyFlMAhTmJVmkacH7H2Iip/ydCAAKD1QdaQpVEESg+zNDCX00rqTirh/pEGE0DR4xq3G1IiNji2a6sXDiF5Pyv5EbJL+pY0ohMP6rjXcHfk0gf8wXtS1IAAN2z3P30x76YGOOwNr/9I8LMOTs9LkG6vkdPXMCc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i/BzPB16; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LFFTgF4I; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i/BzPB16"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LFFTgF4I" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G6OnOE2651839 for ; Thu, 16 Apr 2026 12:00:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 86A3Mpzo70ON5GHVzRh2OgwDHBFC164e1PdRbOxYstE=; b=i/BzPB167eoItYdU 9OoC66BGxpkflwVC2uvnkrsOoVDRXiZdEytwbPwbRadYLEiWCoFmWjM0V695gknW XklNgvRRubAxzmP6p4nkhWH8nZyS75Nj5M6wfchtsI/d1eGxTezGSoXys/fpXHjl GKf78gravvqSzS+s2jDu4Sb3u3PNZWh9jIz+RoKjDEl09zXnZEqvFHWFr/DmsvQD Z9BLLhc/3z6RGXEwTBElkjS0w5RWijrB76E01lmctzbIEvyOb1jTU0rdud4ROfiG rh7tG0Fg5/w/+FhG9Vwx7pm7lYBMrPhO9IJMUIrBWxhxHiyRg4VODqHs3xHl6NtJ ytSyMw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djtfuh5qw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:00:41 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82f3eaf4b9aso2356254b3a.0 for ; Thu, 16 Apr 2026 05:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340841; x=1776945641; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=86A3Mpzo70ON5GHVzRh2OgwDHBFC164e1PdRbOxYstE=; b=LFFTgF4IIFR0IZjG/WWsfMy2cpfUqRpwLtmdoS1N/SBl2xtr5NirUBHthH9TVlCrMP 7VNuK4dgJjcFYcMYlIzLHS8JbW/eJIJSaoXr159J8vfJ6Jnn7f3Ok6vjAdnFablP0Dhf lFIGWN6HxZFvvKnieh97nXxQRS/9C4gzmCCImgnhe69w/cQ5cwXe1rTQ3GjKB9ehAnZH Zptn0/vW/JSlJfMAVQbRI+QOB3v+MLDyReiChvpg573ZYtdWpkGaAa3IDxzmbavlalVq WpgWaiAvIzAB7EecsvmHiTygQ7B9v/GN5o+RpiPVgKrL2/nO0Y88Bx/qtqrd9/tY9vtn lXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340841; x=1776945641; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=86A3Mpzo70ON5GHVzRh2OgwDHBFC164e1PdRbOxYstE=; b=SG22Eg792uIPW+oy2OUrm/IUaGATwj17N73uDjaYmRcA9qhYb7O6if3Ygj8WoNAXp/ XHdPh5ny1nYSdAQQ1oOKFdfan3iMPgu74hclKxTm6sWZrPZzneqSOYMy9AB0f+ecIPLj wrOZf9gjWT7xbdOVFko/0TWiZ5pkVGxPyp8Y1dRRD6QfclHRyhHdWnDv7yMgRZBhUT5n xxJFjl0xt0lT+GBIYrq3n8QV8Qjg8WENemMfpx9jl0vzSl1k25NLmJkvCC8kA39fhNgT OpB0hmn+9sDrrZ+9cRuojvrjdcLzk4ACFZDn7f7mJQOyEBDmIAWnp1ea2ft4bKXt53kZ uLAg== X-Forwarded-Encrypted: i=1; AFNElJ+RypH/OqxR6jSeXpS5imcrbXLIP5yr2kUcQNBr9/pTYD1qp9kk15+2z7UuhqV3fABJHTUSIKVcvsiedqI=@vger.kernel.org X-Gm-Message-State: AOJu0YzSZYDRNsqcZWJtteqGX7GAYijBGS48+aYoEUL91lMqg7FjIMQf fhmAvWx7J0lHvPfTDnnj7mMV1c2MCA3VUdkH8GXsGPVxGOYsQ5CyMPa/y9bI80O6Wd8VOs52Eef MsYsx3KBB4gjBVPjPND+Bmkeo38/cGsoYgHHWErV0sbVQWtRABNE/NM6JS+JHTto7IKg= X-Gm-Gg: AeBDietk+FGK4kjBlc7QMwoQtXzo+3VNdWQ/Et5FMNsLzPEDK0FaZIBenQUSNnFEzuq CouOG80+OrSLGtynyvEc5Zi29ylUt9nRneAFbKQ3MREaD/74Asj5sM3JAzaMvpXSW5TRLD0z9kU /kRQP8TLE5c6u6hhJIDeh7q6VGYOlxFwc4OsNNoiZQj8yu+GpWL66TDPWsdxgQiYvkdvmqiWobb 8JZgw8OuHaIQZ/nFh8q9RfhNDacakhANpKCsNokfjCaRL7N7Y1AsQoofXaQ9NDpVdA5p3Gr2m6q 0/YtjbKvrzZBPUtfirBXySpiWdNnoJlF/7uaNn1W4IgAKE42kmhgqvdT7gnu+XuZiu2LEdyE7Fm icnn2I2q50b6plEJAQFn0L44nUYil3n4lHanrXxLMbaJjTyD/5E64w5YcMA== X-Received: by 2002:a05:6a00:2190:b0:82a:1529:2b4f with SMTP id d2e1a72fcca58-82f0c3256e2mr25219035b3a.44.1776340840907; Thu, 16 Apr 2026 05:00:40 -0700 (PDT) X-Received: by 2002:a05:6a00:2190:b0:82a:1529:2b4f with SMTP id d2e1a72fcca58-82f0c3256e2mr25218961b3a.44.1776340840181; Thu, 16 Apr 2026 05:00:40 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.05.00.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:00:39 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:23 +0530 Subject: [PATCH v5 06/13] arm64: dts: qcom: sc7180: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-6-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=1533; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=LEbiblCKcyL2p/bVLgNgGMJciZnwnEoCuE0intdil4Y=; b=0l5AV8MgWXyQHRAPJBcMxCawIilnbY7Jw1JjX7zKCnHnHb9BcISfQr55Jx094Ha34FtuH7hbB gNsHb725uU5BQ1/rJke8nrt1o3JL8W8fkfqg+kx7UO6zQIGyANEnVvO X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-ORIG-GUID: C6CDwWuYqo6mN-DVtL9zkEdz0JV-bTuC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExNCBTYWx0ZWRfX2+lFjvBdRc4O WdEAJhwBmWbWJvmbSS+lDBqcXWZwtVqBCdQ13raeafiSkPn6mmCo+G5rVz4hfoScXVVp0FZB1w7 gtfn3vhBImuqB/cd2UKgzru6q3I1Mf2qfDaOxfIROvLA0GHhXMO6Impr4xYvuIj858jD/SFGtQv 65/kzll8EAGADWi0YpWPA7M8nmB5B9M0iGf8K0PT2XiA2KlEmbjtpf6bzbpL1uADU51JqijWMY4 ZTKH0B1Dyvqn31TiWYHH2x91mW/Ocjr8dpPw9HDjP/p0Ht7hXN6gxu5Lc5+JGK/TNJqW/t/bB89 vhRJVnVNY3MDeFJODDvrlqP3HYYOYcJLmpea60Od8VCSQvBUy0yCW++H2wREEAG6g8pmpvSYG2Y zx++LD2szgtGhwKzAIZJpx6Urnbgfj5ApS/qD7iRXGkh+ZzJvywJJm21vLXHHVX6hlQ9SPuBL6Z B/jxf/7gN9DNGKys24A== X-Proofpoint-GUID: C6CDwWuYqo6mN-DVtL9zkEdz0JV-bTuC X-Authority-Analysis: v=2.4 cv=KrF9H2WN c=1 sm=1 tr=0 ts=69e0cf69 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160114 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sc7180. Fixes: 858536d9dc946 ("arm64: dts: qcom: sc7180: Add UFS nodes") Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index a4b17564469e..94a699cc2688 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1605,7 +1605,11 @@ ice: crypto@1d90000 { compatible =3D "qcom,sc7180-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d90000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 ipa: ipa@1e40000 { --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E07DC3B38A3 for ; Thu, 16 Apr 2026 12:00:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340853; cv=none; b=uVMGDki59e9Ho92ard32u/ITWeCVVfeuSYnJ4If7AD7J7jVf1x3ysgga8YDi1agmWQ4EE3F/lSdpyMNHBdBO6nWzzapAXetF5++CJiTyrDK2+uiS1hTSCqSuSULY4RoL/a01irUfmEcxw9kvYZjI+aEb525OpLiLp5EdoSscjWQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340853; c=relaxed/simple; bh=9W3DEzLqDL23ck7MFEmKisVL2SWOD/GMIjoH+WN7/4s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m1zgWCPb+j7XM00mvvRa90oQ5q8evh4eVsYVIaVpTIENt/Uf4D3nxiivz+3PDhmmquPFcLoP8KPBpHl14HVeEQ2MHu/K4EGgPjJiobJSUNjK7kbgniIvIvbBZAvOcsCUVfgnDF5eqm3d8YwIHRbU8AHKAEC4dM5lBCSNjo9QDwE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ApFwi31T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DotVKl5C; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ApFwi31T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DotVKl5C" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G8UcIs3089376 for ; Thu, 16 Apr 2026 12:00:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LOconiE3DhsyHprWuZ6bExEpIKAinAlDtyF6NGNx6bk=; b=ApFwi31TWRrWByPP MMD9HEIEoh1TpD7HYjihzNPxM1bzClMmfG7WNSzdNxroMRMuY6OFbNMpn2Y4GIUJ QXiRDZTB6FINlGh1Tu61YltMtzECcf7KivAQMS+phMb0c/Xsnrw7ZaZ0xWDQmEho taPTfhWqvEn5X5ozwr0YhXc6hZtB0vzC9uSJ+PvuzGdHRNOwZYgsTSxb9pUBnrZG XdL9Fx99CF4yrz5anImYRtPPI4akUZRXtx3yNsl6mJkpRmi4AqCGvUenbPFA7/lB zglkgLohmDpxfMwvyaSsBBh6ivb6S3ohHr178Ri1wO158OZpqu9mEE8eDwtfH8QR MYWgWQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djp6aa0jc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:00:51 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b6097ca315bso12673492a12.3 for ; Thu, 16 Apr 2026 05:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340850; x=1776945650; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LOconiE3DhsyHprWuZ6bExEpIKAinAlDtyF6NGNx6bk=; b=DotVKl5COFm8UgXDkGdysjzZ6hp0DFiUnKj2egzqQhvH3fopTLn4WPKTx96CuJQyCJ i8UbWJC92G5hD8LBpGvaI6rlPt71ZAbRL5Coy56ZK8BPkNNFTZFuQKUKvCDv3t//Mg3s jLjzhv356N8jdLsssRkUkqUt4m9zLT/8Hczs9CvPplJLXzkbpacJyB7BJGxmBPYR1Oz1 p+OG8H9Zs3K0i6Um03zLh79YPQ3Iase4s2uVwUVivLtNyR8veS0KGgBSI5Cl24LNoLbT Mf8CvqzBl+ADPfMkoP6cpERoc0eXGk9sXBXYn+jCunvBXnw1DDhbt/0+6RytztPOqd7V cYlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340850; x=1776945650; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LOconiE3DhsyHprWuZ6bExEpIKAinAlDtyF6NGNx6bk=; b=SjPYhFFh5PVXixs25UPHE46FSJl2vZTKTZ5EiU2KeuxOcWSKj7C2Nl9/7DZ/GYIKY8 MCCKyBX4b+XUVJYcTkxfmsoNXI+kfU7EtwEVhOA7QvQo0t7NHtGrAk9FCCb2EQ6XjECI pnNRzAgKOd5+Dx098zjNOlpq1ONKcWeB+rLCA+n0Vm96yM1JmzSHfIuB22e5lv7N8m5j udqXug5E3prdyF6bJu4UVPYyJID4PoEepJttRXmNRJbZmdqMvt/Cm533gSp3PbLmFuWW oRPwUwqTBSHjPDpFzff/SdAXbTfyyTEV7dNcWATYUk6FAE09hiPjzvpclOsbBQFmmP6R zLaA== X-Forwarded-Encrypted: i=1; AFNElJ9foL6kwnSvCXGjUMEeU3nU+0+awEtSslDyWcg/aVXc/HqlDpgHObx5Mud1Y5OOyslxSv4Hj6fk0yoPfMA=@vger.kernel.org X-Gm-Message-State: AOJu0YywAkoMu79o8gXvCZq36GpgQSDbGNVPFl0ywH294hZpk8wPjx0D j1H2MpFZmfdKfcUI789JS7rOBmME+YqCNctscFoDsA2c8DZvBa+4CNT4ytCI0vXQ6NjUmgsS9P9 DDHarmPWQ7xtjoobH2H+orEuO7lMWOin4XvftVRzM0RqLmfDK7guip4I+cE1eKRgF0Cg= X-Gm-Gg: AeBDieunMr7OufSN/x/caUM1Va9Un0b3IwL9QCu91VW/41yl+UrUL3gTpbR/6NFniVx XeRmi2ukogAMBDKrXtkg0MO+r2S+sGsJejPTH/F+jY9QUiYm1T9k5mWRR3kL5bCf8RFnr9YijTU G5EzjcpclNKEne/YlK3qnS8Rwl6/uzZF06Nyd78aXNDMcDkEipFT+mN47vMQ/Q2wNEiXRCWn+0/ NO6HKwSsg74z4bhI6bbgVKOHtDxeNduE8/Fpl4Gjt456DYfHXkzSqIZw979G6Xgm5nJo1dYZCGP QfLPQfz1T9JoLovB49qZmyqOTh3xsUrILZZqoCxL1pNHD/d2KdJYHZw+ILdyP9o5bTA+gRFVgv+ D0/cf0mDcxkxmNrSscEhvwB49nvvQsLOMatkx6UBT6v9Uvwip1G2MvuaF6A== X-Received: by 2002:a05:6a00:ccd:b0:82f:623f:e5b3 with SMTP id d2e1a72fcca58-82f623ff57amr8689242b3a.34.1776340850247; Thu, 16 Apr 2026 05:00:50 -0700 (PDT) X-Received: by 2002:a05:6a00:ccd:b0:82f:623f:e5b3 with SMTP id d2e1a72fcca58-82f623ff57amr8689136b3a.34.1776340849405; Thu, 16 Apr 2026 05:00:49 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.05.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:00:48 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:24 +0530 Subject: [PATCH v5 07/13] arm64: dts: qcom: kodiak: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-7-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=1633; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=9W3DEzLqDL23ck7MFEmKisVL2SWOD/GMIjoH+WN7/4s=; b=5OBI0q8kmiY819jpq+CIVl0FcflmkpbwmJfrEdZ3TG//uuc4B0feoLKbtHRgt8qw+/n1/LI1J Bj4KXuJKFYABZNFesQ8H5b1E1uNaUBL+09gs3edwY2mlHwbwFHBiKcP X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-ORIG-GUID: SnYQlPNjkUFsZ4PL42Eg74S2q3N-FWzY X-Authority-Analysis: v=2.4 cv=NuvhtcdJ c=1 sm=1 tr=0 ts=69e0cf73 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: SnYQlPNjkUFsZ4PL42Eg74S2q3N-FWzY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExNCBTYWx0ZWRfXxxE4fsKmEUHq k9paN5EIHi4a4ZCVw5WWAwkSrmONWqvrwIzygKNMb1shSknsIurJfp0LE9FrogvB809I7DB00F9 Jpbl+e6AOXfAn5ueyoaNQrN263Hz8VvTRq1WWiqBpAFGM/5whHkhQmdyFN+5GvzWtpgbYeHcjSO pjZhOR7Vt5GhKqaB2DWtVgeVg0EpbPcS5PT/fN9LQmsUcJTF22lI034LmsK9lXIjhhg4lb8eqDB uvRZ/jQLM2tPqOB/PrLsxzi2olCkDUhyNAFM6CQiaHRpZDXOzvoeDSJuMz3XqOnnWu+zh8IzpzO XdLu/yb2nNbBsNhK3KsLhzaczO7MQQ8DqlSFJ8z2iTUf4OzvE3ClpfVW5pxYuWDSvGtPPpbncOQ ud3DXdR0aaqZrzLgHrCR7TdOPr8hz1nni3LaDLaA1rjNotNWB5wQQGPou1Copf1XyTGsdYp6OIW SntOu9l90tYEOf4b1jg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 impostorscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160114 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for kodiak. Fixes: dfd5ee7b34bb7 ("arm64: dts: qcom: sc7280: Add inline crypto engine") Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh Tested-by: Kuldeep Singh Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/kodiak.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qco= m/kodiak.dtsi index 988ca5f7c8a0..55fc256501c5 100644 --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi @@ -2579,7 +2579,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sc7280-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2B1F3793C1 for ; Thu, 16 Apr 2026 12:01:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340863; cv=none; b=BjF2BNHu8x69GXr+znFmC5VgRyPgg3XrdkEMef229HM07CrLw4AoVrxPUXmUXWM3AvlPkWYJcC+h8q3v9YIhnNEEjjbCkmsek1g1jBGVgoZNggCCUY56N9wJaEUXLLMOD6AD13SgzqJksIgUc0/gFGgeHb685accn3ChwmUgas8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340863; c=relaxed/simple; bh=mFv/QysmUlFYxGHzNJM0PX9yoMSbOWdo3h4+nR7jJ3I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S3qTOr8as9VVmJkhbl/ctv3YuYqcV3eEyNPeV2FvW2JD9wi5j+hZciPJN/KtPDvmV9XmQBXYIlU7/38b2Z2WdhjdSKDKfub6PsOy8YmW40kLZU3nRR+VRIwNafYr2RNFNZpqQe7p+r8tNmvs4D2SDO81Bz95kA2VM44ZIpiUGQk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dIGlN83U; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FwTzo6BX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dIGlN83U"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FwTzo6BX" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63GBvXBO1668126 for ; Thu, 16 Apr 2026 12:01:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 85Cq5M1441DLnhTBkum4V1OGWT2xKQ9wJzNrmEMCJpk=; b=dIGlN83UuJm0iqoy 0TaMlt8IYUmusOD87mQj5Qh5x272ngFR2IyP0C0fDgy9C1sWNRod8XUdOkVEV8H7 30DG1AjQSemZmXeXxXi+A5L2gEbJY+mXAjAqDdWumI/Xh1hM0lGzhhe2OpiPhyOt NNGSBBbde+1ozWpMm5CNqBfoBrX/i2QEJWHWHDj3ZXAOZYVdKZtAhtQ2U2LInXf2 cbLPasSEnUnGZ4+fRSQ7t6YrZpmvxKexj3ZnBjIKut+POumMQohsmsbldhOSLmgY NSSWSKRBWaSHjs24cKktNc/ehC9WWENFeJulws7psCfTFevISFkSL/X7hcXwhyHv a/CVvA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djtd9174k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:01:00 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82f780a13c9so470845b3a.0 for ; Thu, 16 Apr 2026 05:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340860; x=1776945660; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=85Cq5M1441DLnhTBkum4V1OGWT2xKQ9wJzNrmEMCJpk=; b=FwTzo6BXV5Fd15LlBrbFvMt33h9Zr65Y42O4hAURkH06AvwfOtsOd8uAstGjtjZ6vi vBaalSK+2k2QfzybyKzVVaPR4JxD8dW63yYbK5Up3ZUcVE5Occz9DzCoqVIgUoXulAR+ KotaB3LHuoPIPtEdsYDKYkyTIv7fIEyEEQYKL1DubpsBMrYpR2x3WAXAU51tmpcmSOLJ 4S9f15ucD4SX8eMLsGkArSOabvTneawajerJDzxlNLl4MhGTBoJSA1thN0Tx5Fp67W8u CRUqkyQlVtH17Jc6NdcGCkkRUquVTVUATXsTTgxC0ITmrqjKH1VQbN72Pd9H1UvH0yk2 mtew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340860; x=1776945660; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=85Cq5M1441DLnhTBkum4V1OGWT2xKQ9wJzNrmEMCJpk=; b=saDJ2R2rMp2M9nxjs9Ffq2dRUrXGMS6L013P+1cBeusSV8FPWGV+5fRaGXdmlvx2IX lBhtTd7SK7RTNfevdDI9vI6LfLLlDmLCwxL9GR5tbItfzCl1JHQp/mZk/RTiwbhZTn0a oLjjnXBhHCFCB8G9ZY4pneeJwaWnWKbUZFTOdlAMGfXhap6ttuQLjmBeEzYzjHKrFzTt thmK0v13q8ckKxMB4fuz4A/U3WsQ5IhEFE+QH7LqFIxnhKCO/rLUj3O//ZrLRxLJ0s1Z 6lFAGsK8PYwUhpH5c8Itq61KiUVAwLFq2dy9LY137nXIhcG41wU5Xh4hkBeLcMxX6Cme twLw== X-Forwarded-Encrypted: i=1; AFNElJ8y9H+TIzTL9LEDrJRQ47tAttT368tSq1VcVh8B/JPzQCkqYiakWoS30rKmpeIcW8CGpL+fYMpdBT5Xltc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd1kuWG2ra4GPsRIdbqdXAu9Uk7Ft2pYh1fWuoKM72D6SYbgEZ 6ah6/uHNDb18OF/hQbJ8L7OW+GsDNu3YyE6Qi9HI8lXKBZzPNVNk1ATpQOhkcYJsbQaeikoLJDy I7b7NSVfQ4ETIxI3ll0EP/M4Em+drNbHXrGXHbvV+0iHBq5g1jlxgyeUliVH1ag8+bAE= X-Gm-Gg: AeBDieveMmbKqxRdx2WRLbwHSlC0pwGn/s6maTx9iUMTh+j41J6minBOmjckgw5r90N giUfEOpl8PT6hyQq1wOnvKtqtrRlPDhztyZScKqfm4Rj7MxvRzl24+O9e8IvynPZgPC/hfzgv09 y6Y4I945WfT+bdlopGobFqCMIyu4pxxDeRPzwumLwvoScYiDhJKEZrjNsKfTL831YTh/uWsbqY3 +xiiYfXTuggZW0xZ30vnoVc2whCGGXayUVlLdczs76xBUdm1Ye6HsIqJIK9xhPmMioqnDMheJCL zj/+YoczcV5RNrh87GtmMrRnxLqQrwb7QK46kMU4iNqpIVQQ9lFGFiMvcYPTkv3S2ZZLqOEoe2/ 3hQVUAm+fdYQbc1SzaWFCUJ2E+0VWPpXmQ9117RX1yhdGO/gZWhmm1BKbkg== X-Received: by 2002:a05:6a00:2d82:b0:82f:1f43:7190 with SMTP id d2e1a72fcca58-82f763f4d7emr3075780b3a.3.1776340859226; Thu, 16 Apr 2026 05:00:59 -0700 (PDT) X-Received: by 2002:a05:6a00:2d82:b0:82f:1f43:7190 with SMTP id d2e1a72fcca58-82f763f4d7emr3075724b3a.3.1776340858597; Thu, 16 Apr 2026 05:00:58 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.05.00.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:00:58 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:25 +0530 Subject: [PATCH v5 08/13] arm64: dts: qcom: sm8450: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-8-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=1568; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=mFv/QysmUlFYxGHzNJM0PX9yoMSbOWdo3h4+nR7jJ3I=; b=6rIUbOHa3Mobdn5ElNpC5oH5siqhNSrqb7TZ7HbHFAKFaavnA3CE8Sb2Uf+bWE8h4UnvT9sEN B5e2IrAXoFCD6SjGogwZ02WRbJobAmOpzTFQ2P4KUzKy4mchl2MV01A X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExNCBTYWx0ZWRfXxVSHSKTYGUG0 PQw1bpZYTVMSoNqvSckmpJGWVQlTVjKgZBif75Kn8RQODRzAM8r8E2wbZ02Mc8fBqN/ClYzXOhc aDnbjVqoXXLaHdVrrB38wisajS7k3ADYG1sAMvJYPvAPL56e3SfvzDhdSCWDi9DJRBuDFZBr04b U+XFfRSxokLRif89K0EC+JggBLa380sjyS5AcKnF49SM3HqAqm/zps9kF+Ob6xHs/COSHRFQWHR L9+5u7QniO0G+BG/DSi2CGQh8h3KUtsfAjicpJ70pqstB7BDjtLoHLtXVTF8nmwl7lvZ71V37Rr 93430cBLY/QZOa8/8xX5jRFEdwSKG2wl1WB9mb0WuCId5jDOhQ+yXJQ8GbizLRLsPNUHN6oGoZ4 cUXelT30C3OwOYyrvznU3mErOx5oCz+UqW/NAVyEgBmqSKcQL9hhxePgju6B8C6cDjWKMx0U1f5 393sfvI+I0134BErHbw== X-Authority-Analysis: v=2.4 cv=avuCzyZV c=1 sm=1 tr=0 ts=69e0cf7c cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: y_IMxHbsgPhGX2TBy9zwn6cldnHA7tsT X-Proofpoint-ORIG-GUID: y_IMxHbsgPhGX2TBy9zwn6cldnHA7tsT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 bulkscore=0 priorityscore=1501 adultscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160114 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8450. Fixes: 86b0aef435851 ("arm64: dts: qcom: sm8450: Use standalone ICE node fo= r UFS") Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qco= m/sm8450.dtsi index 03bf30b53f28..9528baedf8ae 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -5374,7 +5374,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sm8450-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E9A0348469 for ; Thu, 16 Apr 2026 12:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340873; cv=none; b=S+v78YG512eJawJnkqVW7rgU3bR4a3JC20Q+sTJhh223AXO9nRlIIBzRz2GTPFDP5919fuJM5CjkTliiUoOqsnkYyhSW4VHqlZutxhYIoOoxHQrDHd97Q/UDMnq0p485S/T9zoZVwqEQVeorL0WaHgfvhOCTZBzRQJkcAx5wk/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340873; c=relaxed/simple; bh=z99JMkf1pnX2Nke7sOx3xwAS/Jwb310G7tQUUNdVAiU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AWJ8tVNsBzRe8YJWI3kIuDUcjaxTJsG9esFol/r2GNZFINt9geoMUjW95dwf0v/gR9cNRCRhC6v/sLGnEoJeoG5uchrHZ+6jriEpn3Xb0/1XSN05LdJRsBi1zMVedH9dkdULo1HkGBaLdFn7jcp/RGKaczDbeTg80evJ24Qyi1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WiREz2qc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Vlb0Jjhs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WiREz2qc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Vlb0Jjhs" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G8xsp94125508 for ; Thu, 16 Apr 2026 12:01:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J0vIm3ILY0qd7lApxZdqueJQwm3beMzxpl/RYFhS7+w=; b=WiREz2qcJmzdyVRR UfcgZ6fCamnFQYCPPCIBCq4rMTpT0Hg49vwj36xRJS4evRaXZwPeoinApoBkS0ab mimn5aqa4Z6UgIAer8i0aC6m+3cJEN96Y5O12U/Qi5CRy46WwobJQaDUo8OFQQyV LM90/qqv74yBaqwC6/PbWuulKEIvtq4SCXVG58f4f1cKQ3qwa3erLYCtFcg9jwBw FVBYdC0U/xIgqi0FwH0onf6du9Fc0tQawsjR09st9sSz22ukYr7ZeIUd9FWyTN+3 vxGXvA3yHw0iWQiguGsnMA7rzNkQ4aMUXTRV+ZJmbNhzeuydPTarzwISF2yCYM2t cjLbyw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djvrf8k7m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:01:10 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82c89d4ce16so5488488b3a.2 for ; Thu, 16 Apr 2026 05:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340870; x=1776945670; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J0vIm3ILY0qd7lApxZdqueJQwm3beMzxpl/RYFhS7+w=; b=Vlb0Jjhs4dIhIu99QuAGv6AsAHqvQFnmWwuYqdLkamW+oOI/hOFDg7bjEjwKV4vKVC Zu/AJy/o8iA7gxWiBjTEXxUnbvyAB8r9OtGsFmASUzPBKcuWngpEGxQOEPIRqMBDJlkq Mb70oVYZH0NN2deFEORHEWQG3V5cMXZuwnz7CK9WkcpMybik0ycYOp3P8w2Qvuigo+EF gloJ+AAJgHdpS4lqdZ7+CUEWGMzRlBBC9M71C8e9cRXz/9Pwe3XKJ4Q6wTANAPU7vFRh EHAxp5UEco+PEmo0KoMP6G8M25Qw5GnJFIRdeLDHuA+Fh/z7c8N0QgF/dOphpwv6by/p 3xGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340870; x=1776945670; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J0vIm3ILY0qd7lApxZdqueJQwm3beMzxpl/RYFhS7+w=; b=It4NX7MjB79fEySq7zz5yaHYT2y900MozwFEXmMSsJHicpkMRDrCrdXtZfZIcyg/Mm UGRVXQgg1455dE2sCo1VKXcuhMRcsPY86MGE/5BZkIs+I62ZbKiRCLdTOABF71Llffn8 QtCUktGn8g6jtpjmz37btXR4Tt6bS+l7mo/CeE+ExbdK9R3w+rSPZm6g0ehjbvu6Eftf 0KvvT0w7+D2MkROgMEI42kpI2Hq1WgYh/1zOLZnFEFo7U2ZksaphoDqZn4nb4f0YLxVl IdGuIXLpveq/bAU/tK3N9WGjlOW4hx9q53ePkC+kI4P0BVv+MZL+Www+1ZPbQRCjCaSZ Zt0w== X-Forwarded-Encrypted: i=1; AFNElJ+ZpWPSoyMx8kWz0cC+EbGh4xoupbS3W6BaymhZ2EDuBlR5M8+HNx6iTfE3IxENYlP9S5UN+GeyWI8+qKg=@vger.kernel.org X-Gm-Message-State: AOJu0YxPup4uIpQIPB2nIlDcGp0WeHJ0DGboAPgB7+pSkB1NOve6l/9j Mbw9MkEA3dmOYpdZQ94ljxtv1xMlf3FeR1kaIcH0Q7SfknnscDaX0qGRAbPvghQXUPdkZYHm2SJ CYeNNJbs9kQmrknol7TIbeY9ymQOr+QJguynXQTsydpShnHu173JNOhWMKHGJfLw/imo= X-Gm-Gg: AeBDietNDXOxr/URJURmtkjYsAKF76B9vB3bsc7PzDEbXBDTYEbQrLm9g1FljF4Eq9p QIlh9PXbN+tVCKVYCT2+xGVX84zB1YbXdBSPxkmANcbM1KYnRpPtfs/iRlpUIiF2pWTjdXADRNL +YMPmQ9nZhwYaYIDRPTOI1yXvsYUrhQeBTX9X3gDJRA8TKIgogUjRoLclgMhJJCwTJpr37TQRhl 5wppTZfHPzMs1oCwkWh7WHUFuWXMCpcQGe8B0LSKLsPN996FoauoBtU0ZKiHjAdbK49LfYdTfnX IJ0yfP76CvZgvOgi5ihEAXXBb6VTL45gTuBvH6RSlB8+ce+yglsUnQfgt0h5v13E9eJ0ei/qL/T GQ/8zaRBOt/2otZ0di88ikFN7+oIRptnqQJPnrsWcBvvpk7zAyx1pBDXCoQ== X-Received: by 2002:a05:6a00:e13:b0:823:3079:7c7 with SMTP id d2e1a72fcca58-82f0c2f7a36mr27612285b3a.29.1776340868699; Thu, 16 Apr 2026 05:01:08 -0700 (PDT) X-Received: by 2002:a05:6a00:e13:b0:823:3079:7c7 with SMTP id d2e1a72fcca58-82f0c2f7a36mr27612162b3a.29.1776340867803; Thu, 16 Apr 2026 05:01:07 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.05.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:01:07 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:26 +0530 Subject: [PATCH v5 09/13] arm64: dts: qcom: sm8550: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-9-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=1513; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=z99JMkf1pnX2Nke7sOx3xwAS/Jwb310G7tQUUNdVAiU=; b=XnVWyzluOpdMBMeal8wz/S0LJ0FymNUpqE3V14EQVZk4ct28WkuNED24E+P+K1rdKIdlIIVhp zQcyr7IZU75A1E1MCF8BA1pYW0jhLqfuHpHAC4Gr0sUk1UijDXThHog X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-GUID: 8B08VqjGSOQ2v4UTRmpABieXnQTFP1gT X-Proofpoint-ORIG-GUID: 8B08VqjGSOQ2v4UTRmpABieXnQTFP1gT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExNCBTYWx0ZWRfXydryssbcx5wh 6fVAxAjAoToaQIFjddfDQ1pi/dupJM35fzB2DPp+w9wdb8m5sAEl92A+L3gdU31ThHmh2gdk8uA GnQn9xJzhxPncTI890tCZgDOnhaXVYu6WvZMsTvCds2hVGilJOBKhJnWyUmoQXxqmn4+RfaGK++ Du4XczM+Uq1NBlBF9JkEYOgNII5BQ/bjzh610ezTp5f7UeNchPeryWpnOtPObGxHd8sQUYD6J4C G+PfxCl8/U9FjdS6e7hVVDGqG36Q6mi1WVh0Z/QNldyXfgN6wC5EZPdnABOTwGCEcB80MXIsWuq gTkUainAuRanAQU8nKHtiTDpwARXMt3CDtd8OJd3MGPbnB/xkafy++HkLFKZxS9jhPZeB4JfUmM KAhFSlaKT+ppl/sCH8nTxRSF6a1/m3AfGatQoTALv6JrT2CPOhoCgGS1PuF7PMIQ8k8gbYjDIF0 3RgzI7R9KZBnHVYEtuA== X-Authority-Analysis: v=2.4 cv=YtE/gYYX c=1 sm=1 tr=0 ts=69e0cf86 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160114 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8550. Fixes: b8630c48b43fc ("arm64: dts: qcom: sm8550: Add the Inline Crypto Engi= ne node") Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qco= m/sm8550.dtsi index 912525e9bca6..fe46a5d41fe0 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2465,7 +2465,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 tcsr_mutex: hwlock@1f40000 { --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 037A8389E18 for ; Thu, 16 Apr 2026 12:01:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340881; cv=none; b=j916knOzUehNb2RcZwtoSVrqcS6g2El1gROTobqExUQMI92Bnvr+I9arojmFgJxZG+o3CYOkq69cjdQoEAgmugbooyx6fOIhqRYgBfV8gZngZB1WjfJUAvCuEpxsmspBQh8+lENUVDfgdiXrCD0zUbFClZmyuMMSW6B0Zo13m04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340881; c=relaxed/simple; bh=3P0k4RjA6CyjjnHR/MCVhLicQAWATF/QQmixOrepKjU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NQBY+otjc22NuobAx9NOC9/44FpC+cmCi+hpfWf2QT/OojH37+OQEmfR7Y7KUUxMBOGRqB3V6bXxAo8KLE8HB6pOjsL6By0QjfcvRjJoLA+MrPt/w9Be4ywazuOCh6S6iEK+30b4ryiosjpHT8Ae6XpZZVYuru+DoPmy5SzQNnk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JlDcGTf2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fr5fYrVz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JlDcGTf2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fr5fYrVz" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G8QmVq3089098 for ; Thu, 16 Apr 2026 12:01:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EybqkRSmlEJflSP37PUiHtMv/rrppQ6/7WrpcwwSTDw=; b=JlDcGTf2fE5O51JD qxBtg8HVrvyozYJJg665xKyxft5ZEeSw6mqnagqObWp207f6VXn+cRPCtAJUYWwP uCkk79qKe79qo+PWFUg6C6tId2Ujr7fJ4hnlf8dgLL6/uyncpxcX7VzYnRm5Hj+f 6F4xF2mw01tFeQK0PatOW1x0X9dXWa7AEtrKj2Q4x/LpjS5le4cN71o4FEANl81Z Pm3lyWU1EGOn8p8TgJlpaToX5hOlrkc+M4dtbtDyVRnzQdxGI2tvj5RtoJfq0Eo0 vWEoYFwT4DvV55pbZpfs3bcdAoqqC54BK4XRNuG/3dtMYmeCg1fy7N4bIs08M6m5 lv24pA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djp6aa0my-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:01:19 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82f803658d5so302931b3a.1 for ; Thu, 16 Apr 2026 05:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340878; x=1776945678; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EybqkRSmlEJflSP37PUiHtMv/rrppQ6/7WrpcwwSTDw=; b=fr5fYrVz3/QQRfoyeJ/5VVhqxgR7gPlnITGfqRbuH9g3C43UlFxyY9PnZiE7lfQqTT xp1fZJksbmlduXEnLCa6I7Upun/YOoD0Dq8QRxFct42rDhiYDt7W+wnvwFF+qfsP+zQP M09UncUpCPVs6mTZYQ5qBvinQ/fpAu8RzhbP2gd8lW+M9/eZrXNmpOO6Ss/thrQEDN7c Hsr2fT7RVzyNIhpSTbXZj8ZEexo+ijdMi7Jvl4l8ca0gquMfSgHkYsqxK2xB6Awx5+wM Y++fIly5uA25Yah1Qbt3vLR+sEdTulVtwkO+T3yEu98Hk6fKQc6oI3eAhYqbzmOg+8/8 WVZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340878; x=1776945678; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EybqkRSmlEJflSP37PUiHtMv/rrppQ6/7WrpcwwSTDw=; b=XAWqA+DlAUXp35z/xI9n9+oaLv/oHNLvc+9Q9HKk9G+79VHKJ/L6MFxf7ir5rVu5pu ErcQtqwocXyFNC+WF6QqNxG8HcRlbmyH+7Y6ge8AmlA5c3uVrDsV1lV4pHkMLNrUnAPm Dp31SgrUZWDyCCGjHAzhyQ3TGT2dy2T7gJA+yoPmdEQ21PH1SHO2eKZ7uOkYij5tNVns 7hb4o+lEdDxAaavKo2hD9A7gDGkhGK9g4LkerFAo7GdDKFaqZYhPWrAzieUbk927jqhP 98DEdNNSO5y+5m3tFwxe0tgIiWdFSpiCz0mw0jqjLBZaQqYkBO2S/RWtMqZXnORoAk2L G06w== X-Forwarded-Encrypted: i=1; AFNElJ/DKV9KCmegy/Xg19i4XB72gz7UozxBaRwHH47QOlak1ZVK5DC7N5QUJJ3Oa5/WWE/LGFgYMCGSHjTifGc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywadg9KouCeW/IGQ00AHy6mNU1nQncqHmMUvRkcRyG9R5dvuOZO Jh73wK1RepVkfayMULcuGFYLZNpEY5JxDhCxaDhF0QvyW3PGfr+Nbqy5c1Auqo8/hBwh32wb+qW Wsikoi9j0RJiE2sLzoTy+6fkxQDQ6lAxGs7VHj8mBLL+pqPQV9BCb0iFHA4SPjxtTZlM= X-Gm-Gg: AeBDievH59JBtSpx6HCpqUAUId83lSN9Wb+sts3XW1x9t1QoZ64s7865zAyNLj6cuKp JzmqQAXvn7YvT0P7WMvRNr4r4YEkG94/dJqw3S7uuxGKDDmK/2XSYXxuob9Xj10y6Sx63nkocFs nZezsSkZbt5lXc3GhhZVfsJJ3+gbJSoiY0naKeUP7AzOY2sD3T/tTOvFvYDFLBY3IJnwBRJFfSI pobySb5vrY1BsETEJoRkoHJ3PL2BEmkfQXotF6UpvwVKSDUxo3Hj5uX1Wtpr7LZ6bExQRi+QCaQ dnJTw054sd7rKc9XuF0yEgHCwUNnWpZsmaqFdX1bHrVdMZTCbo4RIMU+NagJeGMrS3Ri8ZZwyGy z7smHwrpSohK98gK8nnD1uSG5FKo6ktF5nU52SbDZVmJHvprf3+iCaP9M0A== X-Received: by 2002:a05:6a00:400b:b0:82c:6b46:271d with SMTP id d2e1a72fcca58-82f0c2efb17mr27205201b3a.48.1776340877893; Thu, 16 Apr 2026 05:01:17 -0700 (PDT) X-Received: by 2002:a05:6a00:400b:b0:82c:6b46:271d with SMTP id d2e1a72fcca58-82f0c2efb17mr27205097b3a.48.1776340877213; Thu, 16 Apr 2026 05:01:17 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.05.01.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:01:16 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:27 +0530 Subject: [PATCH v5 10/13] arm64: dts: qcom: sm8650: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-10-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=1526; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=3P0k4RjA6CyjjnHR/MCVhLicQAWATF/QQmixOrepKjU=; b=uP7x1mpLofRuFo+hN3TkTZ1T46+1bNT1dk/vSUMEfHo2B/SC0FBABO6HW3F3yKHV2Rw20ekUZ /xJeY2mOFpeBCQfyD4JQKJcYQxwAAiRJnRRuN41pzfgqKfHBY36d+F8 X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-ORIG-GUID: nZt8hyrGJsesFR8IcQbFPcZbZ4gPmbEZ X-Authority-Analysis: v=2.4 cv=NuvhtcdJ c=1 sm=1 tr=0 ts=69e0cf8f cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: nZt8hyrGJsesFR8IcQbFPcZbZ4gPmbEZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExNCBTYWx0ZWRfX56YUPTw3ESGl J/VLLHl+lrd9w6O0YH93l1CzhS83608kjqHAm/dGuQrNaqdZ25HH35a7y5jRkbEj0hklpwiL73V awuWuyEVDexkn7QxrICpxh9JK6lJPiax5A2q/2P09ByQD0eW9r10Dh5Eb7rByLS8GNYBz767dwc i6CUOojfIcwB+jtFNkCRBTXVq8nalVfqq7/1xnsql2uSkIuLabkYA40R3+wCenXo2u2NfWfgs+A PqosS0l/CR2RucsU4cYkRsrS76Ig6kHCTXZOaxFIQP4TQWi4fe+4vX1OUUtOTqgMczGzAMUQKR5 6gvKHS/z54HfY/c3izQOxgW1t7qpYFpM5TR17RdTI6/146jbJ+Bob5Y7fhirwuTedorfEWTxlf8 snWIiIvJztlLedtHo3vx3ZG8IaP6PP4o5cqxUrtD+E1CdnZa4sWQFIZ3xTolt2FfMwzoIYJ40e+ WNrrs+ALhWuCTRPinAQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 impostorscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160114 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8650. Fixes: 10e0246712951 ("arm64: dts: qcom: sm8650: add interconnect dependent= device nodes") Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qco= m/sm8650.dtsi index 1604bc8cff37..e2d98cf6adca 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -4081,7 +4081,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A14693B6C1F for ; Thu, 16 Apr 2026 12:01:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340891; cv=none; b=SAlnI/ReHoiemK0tt0nLTAhGAf4mUf2/UdY5IpFUuGCpPowzBgk+7zuCl7pDZ6Ftsn/Ep9HpR8ZoiHP2kAS6Lfs7ssrqPqeS5vWm6Z4zrA+6p/tgGZDfm8Nq768t/ADSkYfNfxleb8YcI7rl3szGBdtD5f7ajIw+X9u+imOW1x0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340891; c=relaxed/simple; bh=vzBr5e4UGGfmcb+i1bWUkJnCUj4+LyIrDlmIKIXz/Gw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cVyVxx7xQKg7KmoWFEV1AK9I0RkvOFc35EFy36/cl3Pshbg0jSCvZBdCOKtVm38FOGa0vzuX8iX1AUH/3m3D5hxWS7dVOKejv3O174THJf97HRkOO7yx6ItfkEvRBjjWbyHAURQLGEUMm3w3/1lReAsk8NN3DTu9ZzRBZOg2Z5E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DoFrV2rX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aEZMrYlS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DoFrV2rX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aEZMrYlS" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G8TnRi862148 for ; Thu, 16 Apr 2026 12:01:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bYKgeLzF+EIJvPu5vjBT9RCwcEcSg4BxDSJhcfSI+V8=; b=DoFrV2rX+Nw4sqI0 ovBTJIEzyPGnlwljWSfSFgRWECqMJh8RdplLNQs/CtaHeiX7c46253Btojft8uiK ipi40wI0GmtK0fiDyD1gdOQU2Udz6L9MNeMcBT6WvAVBSAasKMhO51uwGgySJ8en tKuvc0ncenzwHQDsOoWbljnqeoap31BDwhvOxInh6ECcXGgAUb3KPM8QZaS/B5Rd 0yn8MCbXqemMFwUDK8SEqppQVZvKxmzfHQ3FAytepSe87uUHx2S6eMZ98mwU67RA sjhCbouzfmm4UTtkkXzvwpmBuvLmIwNlnpBd082BCKuklmFVNb3MErX4bApULy88 puatbg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djd0ebrv3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:01:28 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c76b6ccf298so4706731a12.0 for ; Thu, 16 Apr 2026 05:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340888; x=1776945688; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bYKgeLzF+EIJvPu5vjBT9RCwcEcSg4BxDSJhcfSI+V8=; b=aEZMrYlSdV55o6Z8sUtjsVHtDyvCVmLDA5ni9NmP8xCsFxJUGDOqR2ACkW5SoPqFrw 0NNwUYQH63vj+2hAj4qey0wXTPVBIWV9ZqfGbapAXS6iITpxT3LLG6Ly0HMkeGO5YDWN 78OOyb1pmZxYhjbQ/X971pKntU34Qzk26ro6V5jS36kDJpWnb6+Cr/EN5dAEW1rwmYV+ AM54y3xByodTviX+nvM10SdI6oKXm0x1cU1j0RJRKRyxycf3sdnBEZ0PXmjC2CUCXAAq ATxGTaC1XSVo2wqKP8JiM2JV1h2U2LZ7jKDAzaW+/IGepUVigCCr81wGWsk24Q/dMFo3 sukA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340888; x=1776945688; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bYKgeLzF+EIJvPu5vjBT9RCwcEcSg4BxDSJhcfSI+V8=; b=EbZ1itEcqaoSiHYiGOKgnnLaUNH1WzTpdfrCXM362tlT6U4FW+5ixZbawWkUwTG5JI KdWbCOSVuWG6ck9IRfL/bxuxs4of/zIlkDFiXzdYs9t1q8+xbY9jvJQiK3u2je6UKoLU C4t9Air+/8FQi7KbzMMbPJMyS4tcpGdQI42xmPnhTZzQ818Vb9wn09n0SbmRqTOWL2/k dUmRSw8vlAdZp9hByUtnn7oWfJhhSWaewmOJzuLsV2W+Kw0iHuVigm1/iWMY3N7mUbuY lEoGMmjrMled5nRFDROeREObEHltmoThw8n2EVP4kc1ugQNlFnyTRUk2DyNLCVF0NvHW /h8w== X-Forwarded-Encrypted: i=1; AFNElJ/fzBs7d9URZuITLfdZEea1dy7hfFDEfWYXeGeOim9fAfbkE08h243rDv/0fc0YLL5drA11+FWYGOHbJKw=@vger.kernel.org X-Gm-Message-State: AOJu0YzwXR/xbBZM1K74GJW1ChIeT9OzOhrLc9OInbgbEsXJqC5TXF+J 9mLq1untdjX9Pwdyn+IoMDkffJaGRezfpeGkuzZ8AXPgMra1GBSsYWoLUFiqjG+UvDXD1ssXAIk BSpiR67LVgSs0MHQRNI5bWxlc9z6LswED0L2HhuicaJKwcDR150kvidzUP1/3eQabS8Q= X-Gm-Gg: AeBDieuFD5UAJLfCYycQMgEobGCTZJz/XMEUQnO1keVDwMfzzJlSAN5fHEKSmcrF+X3 fESroJGUv0RXU2L44NL15y1XjRZsXdAxKfAYjbI9XC+dyfWBYpAkalGy9SoEYHCQv34mFahNe5O JcFC59vy8C5/UBjwLthw3bhKEN8rR/cQlv3u8UkkaQeIyspkzQfECkUopO0Hqx9QyN3fSTbzOVM Z85z1WcXRLfnsL5sbOV5n5Bvs2NVaRvp/9XVV5iYfjgJSG1jZaxZvnG+11viD6U7DYq42ZrfiEF a/84+85+zy2IYqRMksVxOoM99NHznIIiya4ZK7dTQRgAu93ShNE2z5KZuKH5n+F6qolcu7/qtnD j7UxQTfCt+BnFBzQpkpBN/pGG6XRRHYAL6HAkm3ofi8Hn2vPVM1KnnJiU2g== X-Received: by 2002:a05:6a00:3397:b0:82f:4cc9:1854 with SMTP id d2e1a72fcca58-82f4cc93627mr12796311b3a.49.1776340887530; Thu, 16 Apr 2026 05:01:27 -0700 (PDT) X-Received: by 2002:a05:6a00:3397:b0:82f:4cc9:1854 with SMTP id d2e1a72fcca58-82f4cc93627mr12796207b3a.49.1776340886803; Thu, 16 Apr 2026 05:01:26 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.05.01.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:01:25 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:28 +0530 Subject: [PATCH v5 11/13] arm64: dts: qcom: sm8750: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-11-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=1517; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=vzBr5e4UGGfmcb+i1bWUkJnCUj4+LyIrDlmIKIXz/Gw=; b=x2zFbTpFFbANsslFGvo667vqOM05Wn0sS8CY97j06xPIrAhgsEr39phqEmwXqQ+zOvfQl+YqK 0Lq6nKu/BjiAKj3pRJ3SATMtC+HJJPOOJXZE5im/ykLa+PDowCcXX6/ X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-GUID: SFL7xjx4_amz_I8ttZmNzvI-d1B9o6wv X-Proofpoint-ORIG-GUID: SFL7xjx4_amz_I8ttZmNzvI-d1B9o6wv X-Authority-Analysis: v=2.4 cv=GP441ONK c=1 sm=1 tr=0 ts=69e0cf98 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExNCBTYWx0ZWRfXyOoaRMHPgxfE ac8j5JLPvLf26F8tAhsN1RSiEdGWJuujQ4YJt98kowTM2kciVqvs6nXm2KMI4WlLymnznGPbKFT LM3onCt1WkfIbRm/Sa6qYFoKNCETUQGbe0YOf03p72pgVwv9SeYfIvOA9P01197Dq8vreKr/3sU YyM7+YayS2ck4n6dGceCdEVbjHnpwii/4TZ05vi1yHns1Q20IFW8OFxmsy/MaMv2Mc3kOwdM+ii a9AXPSU6YNAGTeraiOxqkpbsbhWGfik6mL3/U5cKw2ePShGUPlpHgUDEMlcFXPyHsIr3L0WkRJ8 W2sJvGZMTHtThdDPPy3CzYAmc3bL9IhKAG5psMGHdqAl/RusmdJDlIsMtMT1O2P9aoK9ISbHaiF gC0Je0iS4KXdhVArmobHmwusJvfrAVEBUkeVhLfhc6VY+DVesX9SHezBuL9DsdamoKUy3JLAEg4 lxbXzx4ILzLtoZY6FFg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 adultscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160114 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8750. Fixes: b1dac789c650a ("arm64: dts: qcom: sm8750: Add ICE nodes") Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/sm8750.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qco= m/sm8750.dtsi index 18fb52c14acd..099d7fb82ae6 100644 --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi @@ -2086,7 +2086,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC9F33B4E85 for ; Thu, 16 Apr 2026 12:01:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340902; cv=none; b=KB3l9/AlQvLXQJf2p/nBkJorIj+ewLaClvv+VUbzAXpRR7I5vz7i4a++fjt9FAu6BwvqBajG302QYEjja7pc1tKqwhl5BH/msSMAORL9/LMiXLFHhBB649kVsXicRvxvEwjgPpNzjF9g3CEyXeBzYbDU1JMxmpHGqWd6U/9uS1A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340902; c=relaxed/simple; bh=PQIwHe0X6J+SePUM39Gyz3yRIWQ9APF+TtzVUvY/U7k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Kn3QCooG0Bwm4CSVwoE/Ll97+CHawkMD1I/56o/6EaE/lUDQCfV6koVnMEsXqlSkRQMn0HqY8R6WxAGO96riogbO5f1/rjUL9uUqaxwjh5SwTy0B4MIglmbMgteFlabeSgY69Mbx5wLE3jW+r302oRVxtYYZcu2oDoZjxM5562s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jB9YQFM3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GQfVJBgX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jB9YQFM3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GQfVJBgX" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G6oe7h218770 for ; Thu, 16 Apr 2026 12:01:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fueCHsyAjRh96KbAlZA+/8APHV0qXG68Cz2uoDsQdww=; b=jB9YQFM31h/Xptr9 G7rg3Z1YhOmI0+BLx/JGgWZRfX07wDR8WjrxJHaeq6lh6uWQz24yCGZEajh/0S/1 pwPB+TWD62ZwBOhrYXdv2SkM5413s7hlA3NmQsLbHtYc144Ohj+cqmLoSLHwvFp9 4/AxJFnQw+K38T2rSvvh+ju7yEdUnr/61wPbxxspNq1bg12Pomd3qX3X3wkUdqLH bn1W+bkI+M2VBxEFiACNbKcCQCPJpsK/baOZ6SZC0lYF+qB1WrOgFNFMODej1vJl dUGX6wXZiBn0l+Iik30of0lsJUer/VLilYoVCIrIRxOL4mvM8qYwk3H2l4Akjf3s Wgm41A== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djtuyh3bd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:01:39 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c7424d91b2dso4083525a12.1 for ; Thu, 16 Apr 2026 05:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340899; x=1776945699; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fueCHsyAjRh96KbAlZA+/8APHV0qXG68Cz2uoDsQdww=; b=GQfVJBgXqiyUwdY8FcV8Q8aUH+e1i8sm5tUa17sk37cUqHwZmvZLMHz/CTb+484kns mIODt34YCPov7wjFwTusChliqMI7HL+CI1lIQSXgjvXpJsoR82JZIh2GS/SBhKnQNd7V eHwX8JcYxe0GL99X6ffS/J1mh/Pq84BMOrZfmfIDhsPJD6MZ3Qjn81lMmTL2WIos9cQj Pm6TEsnXbdSqSnMcJe0tvXaqu9ztBJEliv5d5VGwVUafTVBqzx0+RPmRWPXYHaxD3jm4 erRDV+givhlKptaO/68IZC7nAtouRlrhwHkLlMgDEvrgUwTcX9Nu/Igela6bLqkoiiYG LDnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340899; x=1776945699; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fueCHsyAjRh96KbAlZA+/8APHV0qXG68Cz2uoDsQdww=; b=V3K8fGkIsmYcd1+1PiXK++rGCUoP9lRBoMuNQPFHpx7h76y8r5t+iuG3cTJcRJefqp LhEMt0uAwRujlh3LwItTBMzYeF+IEVW6/xQ0gBPAPXUu49LS5Pz4Pr3BogTlphaiehtS 2PHy9nGGmCCwrQr720Zcc5FdF68ue+I+5XHDvNdc+hg6Mtx5RKomgrQhquac7EQ1hFzn G/rNGsubbbBTVLORv2bmjuKlzLHbCzl1fl24bOd+1cRh7XlOI2/vMkRvTovAxOzejq0e TA6o2Ulcv02oSBYNhjO8v4CjUw/bPHZOiXLACZlQOrDr4pTxco33aNXcXHA/sh3Fun94 Ba+Q== X-Forwarded-Encrypted: i=1; AFNElJ9+jC/5kmVcBNsaK5sDw0nt1tEkEpyl+C1sJ7Wm9XhqqkfAI5N3cl2JPToOLUxgSW4u58BuiAQc5FujSb0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/ZjfdG9GyWcKSeM/PzFHR69gexeeY5B3V9vNvGWYpYvxXpF3L cVEt5XKwCuMypk86paqJ5TP1+EpZYXr+IEegOg3+C/Lj+0RKWP2VkAbs6pv40xYrxcSWsOJD7+J B0Qnd1PgkBaeDFerByOY8epUjcTb8PPkNkylXXyeGLQh9rAKZIo87YXQGAp69EbIymcE= X-Gm-Gg: AeBDievty+lj1Mo3F4qbZfTnarr3/A0Ioi5UUxYkK/YIqNOn54qYAUG+zqJxcpn+EBI d3k3IccGgkHw2vA/apLc1Jih9RyDx7gsPU8x47KTK+bofQHrMA12d5s9xDrWuU0RJeeC8eCIMcc +jYlkoTf1feFws+otObtGnpCcousHBnBsNsxWrFNW3YewXaQDHU0edtwlEwlonkmfHJSoCxxOWP JZTtQbJA/3KjF97jOdjd61VL/tL96xyU9SGZmoQObqK11mrHMvS8Vy1uj5aRIDynvhReZnhAhBs siyOwlvD/nNR8um36mwOo+YFnDE2UJrL9tGFrR0nHRyGNPR0oqqKcOTyTqLi65Bg01ErofMpl3S FYwgXZKzEl3v0RRCm9pglR3CiumooZrHSGW8lfex2Wv082DymksNZ0OMnWg== X-Received: by 2002:a05:6a20:3954:b0:394:3001:8b59 with SMTP id adf61e73a8af0-39fe409d626mr28689683637.53.1776340898498; Thu, 16 Apr 2026 05:01:38 -0700 (PDT) X-Received: by 2002:a05:6a20:3954:b0:394:3001:8b59 with SMTP id adf61e73a8af0-39fe409d626mr28689585637.53.1776340897666; Thu, 16 Apr 2026 05:01:37 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.05.01.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:01:35 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:29 +0530 Subject: [PATCH v5 12/13] arm64: dts: qcom: milos: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-12-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=1368; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=PQIwHe0X6J+SePUM39Gyz3yRIWQ9APF+TtzVUvY/U7k=; b=VPUV44pQZ3CT/160UiaEEW92uAButbGm/uxJDikFIH4/a170ga6m7ssBE3iekTp+GBUhM68EU kEjLblRtVbJC1VgMqw+sgli1h8jBGuqwmMnKo7kDZDwkjwlQQcIMlxl X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExNCBTYWx0ZWRfX79cpzIz42qw3 mlnRwKRiEuxXfeTBwDRCvYZwwDOLk69i9dsAhQW46aMsJABzTsk92YpNvbEAcThwouGLZTg0QcF znmQoOIxbOgXpvxcIYVFyQj48CRt2tQEDJd6WdLbmbSkrpgWfZCsbBeRq9NyBmj7h4+g2GMBTTQ NBJX5mcNkYLntjvXXiWvR5cipcHRe1jA4tP5we0dH43imQMjYVrIQFMkOkErXUZw67LTgjfDiOl lRDANmBN/gHXkUSJ26X9+BZWcmJULmkn71M8NhyYv0UDxIadl42QeXCw84lm65jkcVMVI8etM0h Qm71m6VFJnsjGbmrfq2ciUHKM7j1xg52kd6v3innbW8W52dlpsaYnDHoF+eBCADiBoulb31XLlS VB7W8DaD268LNXG4zrkAmieXq4v657Exuu5qdmJBj5h4I0fq77c+Ixl6dLsDIgNzrYPpfSXrLAU aPD3e5aEnQRzVOM7UUQ== X-Proofpoint-ORIG-GUID: _xOQp1DOS9Ac9zcbsEO7PlMheLuG549U X-Authority-Analysis: v=2.4 cv=Ipgutr/g c=1 sm=1 tr=0 ts=69e0cfa3 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: _xOQp1DOS9Ac9zcbsEO7PlMheLuG549U X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160114 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for milos. Fixes: 04bb37433330e ("arm64: dts: qcom: milos: Add UFS nodes") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/milos.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom= /milos.dtsi index 4a64a98a434b..a6e463f3885d 100644 --- a/arch/arm64/boot/dts/qcom/milos.dtsi +++ b/arch/arm64/boot/dts/qcom/milos.dtsi @@ -1275,7 +1275,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 tcsr_mutex: hwlock@1f40000 { --=20 2.34.1 From nobody Wed Jun 10 17:50:14 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDEE33B52E6 for ; Thu, 16 Apr 2026 12:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340913; cv=none; b=enCjYcqSvawu8+HAgTLO+8x/QWLHugmSSYI44ss29GA66s9kI58dBur2OVNus78NwoJN/2skJLqITbMyj44KTeYOTZb8lQjGW8EihV0xMYZHoCsT0njfPPU705hMrPUk2T7CBBn5HSMUEaBY3L9xN8G2M91sieKH33/bJcaqmkc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776340913; c=relaxed/simple; bh=VX5sSr67MU3/CpnlojQxc1yhq5+mYZkwNEH+oRw8f8I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gy67tri0rtBmwTcBgIBhKg3/RpE4FDE/7CAYIMjJNDVVjMLJJCc3IXeyYfoktat03RMyRy8ib4fvIwJqDRUCU3ZE7igYlVlRmqqFwZ4ZKrbrzhOOYxtPqN4n+DZNry4+G9z6z5s/o27GQhdqS/+7zSRM+crZgx7aeWH4Cqr48+0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TlSDBoIw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AGw19UvO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TlSDBoIw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AGw19UvO" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G8GJIk862379 for ; Thu, 16 Apr 2026 12:01:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GJ1T7dVN6bkDufKjyOSICvcs5KgSIPrr4Xb0nXCC/yQ=; b=TlSDBoIwKB/GqkZY jZLHurAn9G/osFtmtPUsRisXUB2Loo3YOHUya0j0awCXyS3APayJQNaQWzR7iDt3 k96sTxKcDXnkDzKflGCg/4AaW1HVUGdezFA1I6wIV220zzpVVXwb3iTXH2JTJGuf p7LFOwd6d5sXZj8pjGDZf0WS65hbWwcX5mmRomnD12BJYjyTVDrcnTR91iyvyEgQ KnlkvnM5iFJGe1Wq8Q6TwEwc9HS9tA+zssQ0xBVTZx6HxpvVIq8sDj1APpDF0xg4 htEfKBANs6Hc/3+ISTyuOZThZBXaaavT29r5saiKc4dmTSA5yhLmSgYN6RyaWMw6 AOt6rQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djd0ebrwp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 12:01:50 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82f74f0e3c6so747124b3a.0 for ; Thu, 16 Apr 2026 05:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776340910; x=1776945710; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GJ1T7dVN6bkDufKjyOSICvcs5KgSIPrr4Xb0nXCC/yQ=; b=AGw19UvOyEnGL+1wZ8X07EQtsGd5hBRTqxg4HnOpz7SNAuW3aE3Dto3grj/dtmmWP/ 1bobYg+e7rNSqaazKktcWOZLOqlbnHl+9T5LgOKumpTtLxHd7JlNJb+fZ2w8Tk16nWz2 RR8874m8q+ab18xZhC+1qPDctA5YCUzDqYCmKsgHsXepTJvG9aNmd1+wgcoh8WxBmpA8 E2/UV2WJ4vqY/uj5s8KEAPKYOoFqYFYEDZX4zCS9Ll4u66LRQGE9Cpn6gByyW8rqjvGM iccXwwGNP//JQ2aFuahbuJ4CvNQQr1ZpFw33RMT4WsJJrnk01vcJq8PsHIHP+B63lxkM Rh4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776340910; x=1776945710; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GJ1T7dVN6bkDufKjyOSICvcs5KgSIPrr4Xb0nXCC/yQ=; b=j4M2L6dvhyd+AhWsOvbDL3YgRGnqnGRETv9GXjlb/Iic9mc/BpLKe3EckophGtBRNL R58SSJTPTO5fcv86axAa7od+9bxAVC16hmyrGSNbpEVl5ZmE9ijdqPExZmtshBJVbjwt Rj+z4qtHoK/zHwOK/GnMGoedhYEbw1gydsc4GGO9zoTagDt6aXZdWqsuggax1+sxhSMC vByK3rISpRVPE8Oy11S7F9DNZEwLANNBCtFH3b2/U0jWk4nZcD1/+IoUNSzuuIOyj1o3 IlTua4HaW9NtKABYuqw5rUQYxLoSebJkkG5iUcx9yJ/ET+Yajk/RIuiLcJFyPeivgRR5 KLHQ== X-Forwarded-Encrypted: i=1; AFNElJ9dQRyu8e55H7TrIkMmQ6bIJrNd5e59SdcuBANt4FttD1nd+5//YfvlhADrKMywgbjJA9ojVC/R5tLbxNc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5I8xtvjRthmoXk0psrDzTJpC8sydS5QpPnozwJZDuOY8vdkME WxNI7r3T0ThmNjWNMMpoynBdsCjmzGYX6M4w8YWzQV1t0OrinQMEPKC1RVa0c1qDOtxhMD/vlJ0 2UdvFIu3EGTm8BYCBMP0fgHfQuMBjdVP4uW9yEVOwflMR1YftCeCypSzSQ2M/bLosCHM= X-Gm-Gg: AeBDietOp5ULeSrgxIPePEFhvyUWoTh0qzcOtHAJ7OzphwbCL5ZhfN1clZJgn2y21pC W7MggNUFJLGOX76wcyWlwOr5KmKFt3Un0Vma3O/Z6JubYgQXf0LUlszThA35A09Kc6FAZ5Q4590 jS0NVDY85USNk266ckImI/X0Y4i5hiE4+ptkCHiIvZhO0uX5PioCyecqO0iUOr96JeVtyOHQPst fccehl1mkf4O6D/0tn4DX92EptCAteigHGQYXXRL18LRr1W9/K9slgP9N8v04LKVBOymPJTMRrN XN8kl0K4hBxECLpNDIiEj2Hd+jO0JNlETEGnUG2kf52E0SVy5/LfESXvAgLsep1knrSp4KSThP/ S6bwoD0IWXnkWtB4et7Aqslye6V3zOWwQCPWNhOBGsyzkZdSudgRVYK9iKQ== X-Received: by 2002:a05:6a00:886:b0:82f:592f:2ed7 with SMTP id d2e1a72fcca58-82f592f35f5mr10651294b3a.45.1776340908936; Thu, 16 Apr 2026 05:01:48 -0700 (PDT) X-Received: by 2002:a05:6a00:886:b0:82f:592f:2ed7 with SMTP id d2e1a72fcca58-82f592f35f5mr10651206b3a.45.1776340908214; Thu, 16 Apr 2026 05:01:48 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f673e0f15sm6335937b3a.35.2026.04.16.05.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:01:46 -0700 (PDT) From: Harshal Dev Date: Thu, 16 Apr 2026 17:29:30 +0530 Subject: [PATCH v5 13/13] arm64: dts: qcom: eliza: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-qcom_ice_power_and_clk_vote-v5-13-5ccf5d7e2846@oss.qualcomm.com> References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776340775; l=1388; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=VX5sSr67MU3/CpnlojQxc1yhq5+mYZkwNEH+oRw8f8I=; b=M1qOa1hwZmKz1mi5IFUm46eqntN0RI7xEMv6TyeT4H3YLNyB4ZYvMjT+ilSsGkwud7FusKpU2 haes6YfXDd9ACWrx4HGp4PkPp8JlraGY9WdBlte2btIV0x6Tx17VuPa X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-GUID: kUvalR6UpZZWwVMF849BYOKO9dD5Y4ny X-Proofpoint-ORIG-GUID: kUvalR6UpZZWwVMF849BYOKO9dD5Y4ny X-Authority-Analysis: v=2.4 cv=GP441ONK c=1 sm=1 tr=0 ts=69e0cfae cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDExNCBTYWx0ZWRfX/Uy+o4ng6hmd vHe7VzaewVc50jUyXVK9PNNxKTVN0+cuQQswpgaLTSKXMIHRNYO4uZLauoUEXuqxklICHUIP4ni Myg5CobNOBz0iHzVKpb5jFbGRA1zt/zXZEZBkEAn67EqAnFx9Nx6y2nawRaoJBCW4CLy0wfRwPI a0rJr8wFTabbZOj8NzeJE/YXiMBTgZhrl6po7GxR4svonYYL3o6J7YAoAJJR64zanDgAZE2ZAUb lDit8iXa5J7unaLpOhuru3Vd2dhlQtkOX5OsijUOG8gqIlIq1AwjMR1CPKIs4KYd/SSmaZCCKz7 l48FJV7tCbOPmZmZRLjATcTeCt+7KohIY1xHFRAqF8o3C2ZLbr9JAZz+s4wo9UH8SvizU6jPfaZ 6n0qOKTNS5XeE+GMxJ/2JuSrLhXgyl8og1WcNS6eGkIrmeP7e1tMbbBmEWieJgXtjnsbS4BKjA8 ZIjEHw6owRL9ko+pcHg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 adultscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160114 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for eliza. Fixes: af20af39fc09b ("arm64: dts: qcom: Introduce Eliza Soc base dtsi") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/eliza.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom= /eliza.dtsi index 4a7a0ac40ce6..7e97361a5dc5 100644 --- a/arch/arm64/boot/dts/qcom/eliza.dtsi +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi @@ -843,7 +843,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 tcsr_mutex: hwlock@1f40000 { --=20 2.34.1