From nobody Tue Jun 16 05:24:41 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63E51224B15 for ; Thu, 16 Apr 2026 11:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776339987; cv=none; b=QNEZjfy8r0SKhw47st0iJxt6fp02X+A0t3t/61PcJj3ptQ05lg1WhXHVhrEH0Grqn1BUAmX5J1/4DyRwiWbGizsxHvKbauVGBwKskgCZ0zpjVlTACfE5q/lpZojigVrm9Jm65a+NrxX03B0X6X3NOFjvRmDHfJN6ZJB9PUfWzBI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776339987; c=relaxed/simple; bh=XB1YmbfqO9Kx+UK9NAZHUwfreTrkYt0BW/+tigI6sTM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=NJCrSjbFXndHBUn67VJGTEZeOZ+VcybVBWHUxWzub3hmUtaG76aB/Hf/605tZCYJUDU7mETOuRfnhMCSG1W83ZtAOYc7Yus91hQ0I9UH+LGiYTT7/eU3SD02MQYffbBaEzs1k20JyiiiT//5D5QSqDALbhDkqWwlawwuep3vnWw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YsHd59RL; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YsHd59RL" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35e563b0ee7so253860a91.1 for ; Thu, 16 Apr 2026 04:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776339985; x=1776944785; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=8Ak+ZDEB7WeybsrLIOMHRS67N6O7QONYYPEi13P7yBA=; b=YsHd59RLfT8TgMEKzG+SHZohG68tHP3bIHun/RMZx32EfIYT2kkZi1KYWh74wbJIa3 donfcUFwcdtZsU8o7r9TpuWP12xL0DyPEZHNhmLvoiFbhTrwgYUrh8KxtQrnBn1NhNOb niJROhnS/leHWroweZSEGmMAzrp+6fBTFMeJd3z96CyOUTBgjb8ND1XDuxSCA9z6r3AF f7IELBvRowN0uV7WNZTi4KRdOWGxb1Q20/0j7d54pjtuArDSG1HgxK1c9hLNEVjkgaQU 0OrbVBgynDXLIYd8YOFEJaXbMnXQ6rG0BirTrO2HccXtlhh2kJCotzmcK8jMMToGWuDN pEkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776339985; x=1776944785; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8Ak+ZDEB7WeybsrLIOMHRS67N6O7QONYYPEi13P7yBA=; b=rEYXPewb6EIkZyp+skBbsIHZb4kT2NqyKXVmJ3eEufdTH2jwbl8WU0EQnJEoOyC74n EDvyCApnrvVmOIRDfbnt8SViTiHOpBrHzQYSEoqxx2gpx9noy5u36OuZe8M9Sy/MmkSQ b3Ur+WW1v8NQ1PN6sbvznlfLK/y0LI+IQEq/fan1djJ+taWvsU73uop+YX/5j+myNNxQ URMscBrcJ7TYivsCNPz7cxXD2dg1aUi0hOq+qI81U2j2ROnlsx65SOtAWdwtN9thxWJp wFXxtEhFHSU8D/IbPKRfGWtCYW0POHXeGTh76HR/Eu8GgXRG+bO41Jl50db8o9ugn8Ox SqmA== X-Forwarded-Encrypted: i=1; AFNElJ9xqOmC7idJUhUEgU9kQnHcZ1Z/wYKI52Vngg/kC6J4Sv7cvtASG7aPEHAPux1nenVKvYTw3W7qAcZXBd0=@vger.kernel.org X-Gm-Message-State: AOJu0YzsthstsB4NwLTnOo4eNdK2bsKRGQUUv8TMZorASN9LYgyUpF0N u3g7sUm1B1YvqwqajjiTrejkzC4A+eWIWKZlSl/H8KyU/5SB5+pw2qWe X-Gm-Gg: AeBDievOLqrPBw+ZNcO1xlxFcaszOcFxL/bjLaqKAKvSG0sh68KrW9e+5SEnM+GidOU V6ixb+TuZLrWFOYIJ3VDBAVlxS01pCo3l1Z2cw1PFbvS6JnGNQeUF1YnSylNfJa73glMK/oyQll iQfbBJz0It7y/NYA0IJLT4pe6e+S7aGxoUq1hMDzJpyEx0LTJgNx4v3ycsEYc1SrD53993U9sW1 RMk9pcvCnoCCujlX3Pben0cxNdrdwaGBjMklbQJfkFXjPtOx9rawXNk6WG1LU1vA2dAaMii6MCc A6wjn9NQwVp5O24WFLNtZh9upvxadajpZcrrrk++eD1WF5clqerRvZEFeEu5J03fi+3p16cO23F LXaTybZC888Vc3Ghs/1KNU37cha0MjYXXeiBTUP3JlTefQpirEKYdKIJleJC3Mmt3LcwRDefjYi Wh+RNpMjVihPazQLhEQlGXsWk4fyxVmKwcv4wUPaAia2crTyO8be3Gi76mNxvORjUTjgd96kUim n26YIMb3gDPql1tXi7TUUOPMKSnAZc= X-Received: by 2002:a17:90b:3952:b0:35d:aa02:d776 with SMTP id 98e67ed59e1d1-36135c6d422mr1195562a91.2.1776339984508; Thu, 16 Apr 2026 04:46:24 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36132d01150sm3055586a91.14.2026.04.16.04.46.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 04:46:24 -0700 (PDT) From: Felix Gu Date: Thu, 16 Apr 2026 19:46:20 +0800 Subject: [PATCH] spi: mtk-snfi: fix memory leak in probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-mtk-snfi-v1-1-fafccfd288f9@gmail.com> X-B4-Tracking: v=1; b=H4sIAAvM4GkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDE0NT3dySbN3ivLRMXTNTw0RLCxMDA6OkRCWg8oKi1LTMCrBR0bG1tQB NXuIaWgAAAA== X-Change-ID: 20260415-mtk-snfi-651a984002ba To: Mark Brown , Matthias Brugger , AngeloGioacchino Del Regno , Xiangsheng Hou Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776339982; l=1399; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=XB1YmbfqO9Kx+UK9NAZHUwfreTrkYt0BW/+tigI6sTM=; b=HdxlppJCMd5S7npIE2p7HIyJ3C1bLlGGm6txyaDjoKu/faflIykPEP+jl5yqiUDjiXFBSkwmA W+GU00d+C+uCf5klSZDikIGK9NNNS+RbAUxEafQxqJZTlPGQhcbnlqW X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= ms->buf is allocated in mtk_snand_setup_pagefmt() but was not freed on the following error paths. Fixes: 2b1e19811a8e ("spi: mtk-snfi: Change default page format to setup de= fault setting") Signed-off-by: Felix Gu --- drivers/spi/spi-mtk-snfi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-mtk-snfi.c b/drivers/spi/spi-mtk-snfi.c index 73fa84475f0e..a728cf571b78 100644 --- a/drivers/spi/spi-mtk-snfi.c +++ b/drivers/spi/spi-mtk-snfi.c @@ -1447,14 +1447,14 @@ static int mtk_snand_probe(struct platform_device *= pdev) ret =3D nand_ecc_register_on_host_hw_engine(&ms->ecc_eng); if (ret) { dev_err(&pdev->dev, "failed to register ecc engine.\n"); - goto release_ecc; + goto free_buf; } =20 ret =3D devm_add_action_or_reset(&pdev->dev, mtk_unregister_ecc_engine, &ms->ecc_eng); if (ret) { dev_err_probe(&pdev->dev, ret, "failed to add ECC unregister action\n"); - goto release_ecc; + goto free_buf; } =20 ctlr->num_chipselect =3D 1; @@ -1469,6 +1469,8 @@ static int mtk_snand_probe(struct platform_device *pd= ev) } =20 return 0; +free_buf: + kfree(ms->buf); release_ecc: mtk_ecc_release(ms->ecc); return ret; --- base-commit: 936c21068d7ade00325e40d82bfd2f3f29d9f659 change-id: 20260415-mtk-snfi-651a984002ba Best regards, --=20 Felix Gu