From nobody Tue Jun 16 05:00:07 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB48026560B for ; Thu, 16 Apr 2026 13:37:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776346650; cv=none; b=UHzixNR7H3Ygt8I1WuuXlsFuG3hfVg+/Go69TPrnTW79maJYk122w9iYUDX11HY+0K0E/3f8kH6EWxIDdH1aWAXrelCJdoJ/TI1jGbMJFF5GcKh5ikSgm1Q3q3QqxA/gUObfhiZUGCc7HCkGJblAZDm+vi0dmONaCkkJw1VYXiY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776346650; c=relaxed/simple; bh=TDWR+eKGZ6caELc8JQbNeT/BZzn78biakeSPP++Nm+Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=LP0y7cW0fgQ8F9e8mBIf0RN1lFkBFpx5QQWdhbmRKSk9kM8UajFW7WQG+SGe71b7njY+HCduwx5LslrhM5JBZSbLMahgCJkwOU4hxE2x9qrBH2BrEOPJcOmOnJXjakSAnciG1vRBp4Q8QI8aWxH7SExY1RwS8s/L8vm3u0hdYEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Mqjwed+I; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mqjwed+I" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2b45cb89f7eso30408365ad.0 for ; Thu, 16 Apr 2026 06:37:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776346648; x=1776951448; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=lZMYklE0oIcY7A30/kkaKk7kqGcT3s+a+U2u9EfvBxQ=; b=Mqjwed+Ihm4ynretE4athnT/YOeLqknDwEleSwS4V7rgcepcqrFA75/VeFWt71m587 KJV6u0QkDdf6Gf3n4hEfqog/Hqarc4NKRMftbDvuAHkEs1hXQHWkxPnzlvXDYgGAjsB5 67pbwCZOQI1W5rYhe4xMUPQxdjiKqDwvn5EZ8+Qr7eelzjROWZZl7DdOqe2UK8btxgRt 25Jid6aYMiSByXkMW4A7AHDu/O7IB3XPnj3Zj0ENocwFsxHDMqZBplPqw0Vw9x5Va9/s fVX/RJiRWVfv/bypmhhY/jahcGzeUYv2Hyh5Z7QxztRRRV0C/xaTL9vM1BVKhfzVhua+ VKPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776346648; x=1776951448; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lZMYklE0oIcY7A30/kkaKk7kqGcT3s+a+U2u9EfvBxQ=; b=dBtMqVDyMw5OTujkfMchYTrAxbsZfQO+g7YZDX2jJW8XdJT+99SQndn7QlSHY9reCC TDj+NUPsctn4jqBqTr8CqfviEUF/D6ueo1wu/RHrt5olObwdC5ta7XYsq5WVom9WrxPB mhZodfytrDkF8X4howQZ1jlLAqkt9CCpwoGa+mFdJtdn+31XP62gMw6rojlXgInLP6x9 SeSO0q8OLKmVl3Pnlxu6A3ccDc6NZ1Bja7vcDz3pPm1AO2CvpTmznSZfH6MtTYEBFrvL GOAJMzaxZkcO98mGy8uNAhAqql38TMJfBbl2P72+cMvKiIo5Cf16LcSNCT5K/e9F563C toCQ== X-Forwarded-Encrypted: i=1; AFNElJ+T/6V2vQrPIvnbuHmds7vxOe1Wf0uM9vbqX6PBEpvi0q7FBX2Uhg44E3p/oM2IkKdLWOH926jAcau0V5Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwRrk61A2+VJPN/0j26ynsu3ee9BpWDn/N29c2FCtBJwL0UF50Q eGEuoT8V8PO3kOAKCEznr+E+814XdDP9b5K7FGHj2Xk8tSTh4sv3Hu4ep88ffmZes1Q= X-Gm-Gg: AeBDiesqCDUNhmHRiICFjabESCEPuUyqkdXC07P9QFVQSuAfVqKp8XzM92QNWYMGXCE 98YipMPAJEvscB2jygiq4KcSvq+5MUG+njO9Qlp92BdHYSlpME0vnPYc255GC7XefaXqM6Eburg tgUYskHEg7sjMHlbdZkhl2bQYfIDPwd2N7ON3prpQ0K6aCxZirQ79ic/ySfNm33Sb/JgeAD+kuD F0GeI7w9nTqmCS8Mhf5n4GMowKYeML+69ZCDpsvQRqR2tOdHsL5Kbq/5Q5xgjLOfK/4ddF3WeWu tHo7TkeL1l+A54IUVrJQ0p5Wtx89vafALJ5VdSk6NfQE2DNptj2GFWaB5WTw6oY2cDhhtWPKrDe ddXzljJKjMl/sg5Ez3aLvHZYNA9q0mXa6BRTAz6OOw1llbJJm8AUfJ+PPBwAA/klhVGl04UuBjO BI+tqmb9ydgDuf23yRh7mfTD7Z/2flJv2q7iUCbB66STrfA7rJltafHJmPIgiYXcnnnZa0gJZAA Od5RT+qES+7bqFiFGqeYUcuHI1VN3kUYkufGrj6OA== X-Received: by 2002:a17:903:3a8b:b0:2b0:5626:f75d with SMTP id d9443c01a7336-2b2d5a1c699mr267563285ad.26.1776346647760; Thu, 16 Apr 2026 06:37:27 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b478130350sm55925335ad.34.2026.04.16.06.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 06:37:27 -0700 (PDT) From: Felix Gu Date: Thu, 16 Apr 2026 21:37:23 +0800 Subject: [PATCH] accel/amdxdna: Fix memory leak in amdxdna_iommu_alloc() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-amdxdna-v1-1-30c13008365c@gmail.com> X-B4-Tracking: v=1; b=H4sIABLm4GkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDE0Mz3cTclIqUvETdNBOzFAMTU0Njg8REJaDqgqLUtMwKsEnRsbW1AMw GBvtZAAAA X-Change-ID: 20260416-amdxdna-f46d045130aa To: Min Ma , Lizhi Hou , Oded Gabbay , "Mario Limonciello (AMD)" Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776346646; l=1223; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=TDWR+eKGZ6caELc8JQbNeT/BZzn78biakeSPP++Nm+Y=; b=VaZ3ya7AglXqREpLZ5ruBdQsHnbPOCale0d1J0dl8eh/ZuF3MAy4VO4p8VlHSSS2SOsNdTbB6 vLkK8BAoS25AvtoIdTrXXnwO8SVhgYBfyB20vjQBiPsgx6CNhQ9hk7W X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In amdxdna_iommu_alloc(), if iommu_map() fails after successfully allocating both iova and cpu_addr, the code jumps to free_iova which only frees the iova, leaking the allocated pages. Fixes: ece3e8980907 ("accel/amdxdna: Allow forcing IOVA-based DMA via modul= e parameter") Signed-off-by: Felix Gu Reviewed-by: Lizhi Hou --- drivers/accel/amdxdna/amdxdna_iommu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/accel/amdxdna/amdxdna_iommu.c b/drivers/accel/amdxdna/= amdxdna_iommu.c index 4626434d4180..a2e8d8ac0901 100644 --- a/drivers/accel/amdxdna/amdxdna_iommu.c +++ b/drivers/accel/amdxdna/amdxdna_iommu.c @@ -110,10 +110,12 @@ void *amdxdna_iommu_alloc(struct amdxdna_dev *xdna, s= ize_t size, dma_addr_t *dma iova_align(&xdna->iovad, size), IOMMU_READ | IOMMU_WRITE, GFP_KERNEL); if (ret) - goto free_iova; + goto free_cpu_addr; =20 return cpu_addr; =20 +free_cpu_addr: + free_pages((unsigned long)cpu_addr, get_order(size)); free_iova: __free_iova(&xdna->iovad, iova); return ERR_PTR(ret); --- base-commit: 936c21068d7ade00325e40d82bfd2f3f29d9f659 change-id: 20260416-amdxdna-f46d045130aa Best regards, --=20 Felix Gu