From nobody Tue Jun 16 03:46:18 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE996388E41 for ; Wed, 15 Apr 2026 22:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291854; cv=none; b=YGJi/gkxZcP0PCM57gYPiIFnK61P3drUb2O8uxnWhyAdAMJboGAS3fUrqIa5VZzSam1Yn+ZGq7RacxgVvyfZQPiFl+mbpRkZMevCfohLu5HacLfp01GlJev9WyLgojZibDraS25PEVGnfYsAJJGl4onr0oJT2oL4Hlez7PtkoWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291854; c=relaxed/simple; bh=x7DJEKRPkvno2qyGO3A3yODK+J7oodJwny7atGhOcS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pSzt2gvu9YcJxagKbrFCbpDyR9dIMsCUzzgpEdDvJnNpZuNGuOZySVXhxTOo893ke9udsIkpURuP0BKWhKX9qDGkt/N1XYMq1t+MYAPJrcb7Z9E4ItuD8wP7+hIHab5wM0YERBFWo9txrhRWvERANug7SWR3Ar2hRiRH1iY0wj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FBkh5rUU; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FBkh5rUU" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48334ee0aeaso71913305e9.1 for ; Wed, 15 Apr 2026 15:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291851; x=1776896651; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v8fkw0tJYXQBqzi8PNd+3IupG6ZyEyB99KznRWlHdP4=; b=FBkh5rUUCE5g2zJCRnzxW0scoCYlWisuGHT10QRsfv2P/XifSUhL4wBUbYHLrOPDbj BveTl6tKudRoyOXj1Of3HTjPElqSD1KbGpUEFB9ohF6IZWUJFIoR8mgt2LgCdKRS9PEc 8y0rW5p6EYhrXJG2P881mgb9EkLZ000Xdq7gwxqeUi8GB9PRRsPXLP8OwUEQFnHx68Fg kTq/K4h4iHoLwgwO85wqwaiZ/MHkELSaxLg8psYwTSPhdN+529J/63BW8gY16FOohUMD WhW8w4ZFdHojEabgNsgbJ5nVsFYmK1CxAwt9GRsjFiUGWKHCelVIwnyCuMO7Lo3YRlO3 Jqrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291851; x=1776896651; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=v8fkw0tJYXQBqzi8PNd+3IupG6ZyEyB99KznRWlHdP4=; b=cQiVPpa6zBnyJ0CindNIDqqssdzoiV26jwKRJI4wAgCgxbjd4QKJTDqf9JqhA8Byyi thrAjCgpXOZ0MxWIPkAOO5wDmGC0p+3Wvq8dcsoLkpvrT0bHgiQTbrirU7G++g41B4iq NpB+b34EP9xBvxAHHtEsNumof/IQIJP9pcw8WXFXZ82quUYtU7zzxaii+ViPHpy5RGkb 09KplC9pJvUY/lfG7epHzFMdivWxxQGkmHOmn7WS2xlZT5hNaga/1MEUGTxUGG4/RaDP iWokDjte5a0eJo2iZvFhMi0Pq4qgrloptwi2cUFcc2OIxzrwL+CtGO5G1HWFwIvR4gCC 5HpA== X-Forwarded-Encrypted: i=1; AFNElJ/k67oAzxwRUaUZM3L2DBaMDNoFfx7rwE9sZMbmeM6A1CTJ/NylHqYP4dah6PJhRvLuV4hsNU2Afpj1Beo=@vger.kernel.org X-Gm-Message-State: AOJu0YyzzqjY9pvj/K4m/tbpe7Kv3nCEUpKVGOpgZNZStp+YyEf+8+Q3 i5PDAZZXl3VhkZjAPaWwk//87fY61IgXO+pt3bdvV0el4JD+EetGxg4= X-Gm-Gg: AeBDiev85AeM3igJfistTyJJffqDjHRSOtXwFBdro/MGsJ3q2a5WnS1j9Vn87P/l0Sy iUL8aCvm02V66PLBi5NkXMB9u1DO8ERHn5AiZGa4KTSR2/Y4b5JEXqldaZNlBlEWIRcP6BcoBI9 p6Nj1NRBHnaUtRlHdLljMOmQGYbPNr0y9bHJ6c8KlFHdSsx1AjUgq0ZoNIzIsEpqzNb2K/l/Wzf oQwWb3x4sFPOy7KFea0x4EkkaQWAq+44JTAl4QnzG6isphIAEWiQSvTu+48SMjezUA5V6lvPi49 Ub+rKQ7TbQ6JYlnPAw5UnlL7prLE27y78gw+aI9ab8m+mUxGz/3vo1XjauiZM8DfkZvi00Bk6Ag zjiAgeAajnSiUBkoPFvJuj5z1o/zLL622BBI+VRls8jHr/cr0kP8KlZwNxVK2KTRN1I+WqKTzwm yelVI= X-Received: by 2002:a05:600c:8b27:b0:486:f634:ef1 with SMTP id 5b1f17b1804b1-488d687664emr304397125e9.17.1776291851255; Wed, 15 Apr 2026 15:24:11 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f5818da1sm1932785e9.6.2026.04.15.15.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:24:10 -0700 (PDT) From: Tristan Madani To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] wifi: wl18xx: fix OOB read from firmware rx_ba_link_id in BA event handler Date: Wed, 15 Apr 2026 22:24:07 +0000 Message-ID: <20260415222409.1542989-2-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222409.1542989-1-tristmd@gmail.com> References: <20260415222409.1542989-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristan Madani The firmware-controlled rx_ba_link_id (u8) is used to index the 16-entry wl->links[] array without bounds checking in the BA window size change event handler. An out-of-range value causes OOB reads and an immediate pointer dereference of the OOB wlvif field. Add bounds validation consistent with all other HLID consumers in the driver. Fixes: d4392269f7ce ("wlcore: Add RX_BA_WIN_SIZE_CHANGE_EVENT event") Signed-off-by: Tristan Madani --- drivers/net/wireless/ti/wl18xx/event.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/ti/wl18xx/event.c b/drivers/net/wireless/= ti/wl18xx/event.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/ti/wl18xx/event.c +++ b/drivers/net/wireless/ti/wl18xx/event.c @@ -211,6 +211,12 @@ int wl18xx_process_mailbox_events(struct wl1271 *wl) u8 win_size =3D mbox->rx_ba_win_size; const u8 *addr; + if (link_id >=3D WLCORE_MAX_LINKS) { + wl1271_error("BA event: invalid link_id %u\n", + link_id); + goto out; + } + wlvif =3D wl->links[link_id].wlvif; vif =3D wl12xx_wlvif_to_vif(wlvif); From nobody Tue Jun 16 03:46:18 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8D5C395D9D for ; Wed, 15 Apr 2026 22:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291856; cv=none; b=i/hbL7Ck4P6UFfHDcq5vAEUCtmhp2bsuMnbUXiZw37/17Ll0lP9wQOwEz74PtTKBSZy7H8xdTWCUCxzmdnhsxq/XZzABwLHvIxhKYUDXU5DUKm0G++zF8NsPr3bkmA7Tb4nJ8Q6jOCvIEPhsoDzWie9VlwToVA1bjYDfbNFrmE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291856; c=relaxed/simple; bh=FG4ynTXsoV92GU20iHTgPOQKBDGoeebi289r44xzP20=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IpkSRq2Vzzi3NGkWnXWRxlBR5wKqiWvF3lpBGzcKf0WdQDftnL80gALTuAJZ6bTrmGpLZdZaTdn9SamO88oWrYyP4KTKQN810Bap7wh25DdUYDDyCDspKkPcxDOMfk7mlZfzaY6iKEDso5lWAD4kWMxjBUvPgvNl1R+OItYbqSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pjm15ymv; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pjm15ymv" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so68314375e9.0 for ; Wed, 15 Apr 2026 15:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291852; x=1776896652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DyhVpWUhRmCqE8V12/aslzLb+WVCcpoPPQA9jie/7lQ=; b=Pjm15ymv9vomF+TpSe6QJgz4sZ4QHWVPkSItXX95uAngoIxsHF7IT1/b11hvbsv0YC 8RDERqD06UGszFTKJCcEF58BOjzTHOItlVtoXsojHbX9NKFtSeoSY7jMuYzTvG/9ng6A svZZqiY4ZT5kPnk2EXqo7QPgvZSsHaFtIbk7ih6ChKcag7uG+8B4aQ3GOymEa3F3X20k dNAW8cDqepevQ6KbTkcYWuoM0ptwzFkpkAChrzpyJXsEWHwS5eleEz7rsxMeZfkx5tRb ZjHR/1eWTjSzWKF5gpZQQdtlWhSJY/UTXQcGXYOhbqLp+v9ZgzBz7X9zBOKfBUdwsj6a bgBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291852; x=1776896652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DyhVpWUhRmCqE8V12/aslzLb+WVCcpoPPQA9jie/7lQ=; b=SWiEpzRdeVxsgBaM1TlgEMnCYSMhHXfYRJM5HzYjokjJYrs1XN0XaffS2MfzXm6Tod lx3qXbiLdb11qKMc7JCqsCCqRSzxN4dMxxJfVhvu2HwmoNrrQyJ189bllraCTtWTNUx6 nMtDLRP2UGiNAo559lpoHevkDGeUKm3mjrEf68F1cTF7NW5gmz4i+ZTCEhSDLhZloux1 KRRcvL+7tZtYpym+o5D1h9XgmVe65r6ZygZYCSqm4NhiULilt1Imyf+zEY4ccv8Y8sem G1ZknVOLOGooJVyyS4KqkwWhdrqZpG/vl/V+jO0NoPAs39nd70lMPRO1Y3RQA15ZJ6pZ jdtg== X-Forwarded-Encrypted: i=1; AFNElJ+wNFOy6xJirZ3ZVBm1OciAnW3ELqS5Y0neGpt68a8IB+RU6yeTXEQC8Ccx/njA7MJd+o399Dvr6YoqZ0o=@vger.kernel.org X-Gm-Message-State: AOJu0YxJmABjwru/1RvhpzhLkL2fMt9aPifbYtm/fQiSeGdoGuVR3X4J 14vg9df04hinPtSgtxBb19l+FbPnAogtAZWSJ7uTiglJ+gILTuJkIPg= X-Gm-Gg: AeBDietCtPw7U4/xU+GHBRH+ngnbXhGVi5/SVH/evh/+LxKNQA2x4pGhxTU0/Ei7a7O +7DubdP5Y92TKiT7DVedQcFB2OJNiXz23IHliYYnoCX+WPyToPkI4B6J/ZOjtvK4/jUFLGRuVs7 EIcFxSp2zrOY15Qu83fseytT9cJANICwNhWJUVzGRy7o/VATR+m1bZp98SqbTd3qt2Edrh0itxX PZopHKw+G1OfvFXjqU1sZCxXUsjFtlHD301BhwOVjHf9iGUga+aEP1n5EtwBmZrs2Fqlesv0lbm V1/NWyNo5XfHvpshjhbx8ULmi2bvcXnkMmoOIcLnOMY0FmWG1jPqrNX5KvJHkvMRiYxEfm1n6+2 DnAauHbIqu87FZHjo48yywCIK3tagFdZTOivJRzIdN5by3EGfNbe+nr4zhuhL0EUFaII/akG4eL ZdG0c= X-Received: by 2002:a05:600c:3f19:b0:485:3ff1:d5ed with SMTP id 5b1f17b1804b1-488d67bbc2amr303603745e9.1.1776291851991; Wed, 15 Apr 2026 15:24:11 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f5818da1sm1932785e9.6.2026.04.15.15.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:24:11 -0700 (PDT) From: Tristan Madani To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] wifi: wlcore: fix OOB read from firmware max_buff_size in logger handler Date: Wed, 15 Apr 2026 22:24:08 +0000 Message-ID: <20260415222409.1542989-3-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222409.1542989-1-tristmd@gmail.com> References: <20260415222409.1542989-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristan Madani The firmware-controlled max_buff_size field is used to compute buffer offsets in wlcore_event_fw_logger() without validation against the 4128-byte kernel allocation. An inflated value causes out-of-bounds reads from kernel heap, with the data written to the debugfs-accessible fwlog ring buffer. Cap max_buff_size at the allocation size minus the header offset. Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") Signed-off-by: Tristan Madani --- drivers/net/wireless/ti/wlcore/event.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/ti/wlcore/event.c b/drivers/net/wireless/= ti/wlcore/event.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/ti/wlcore/event.c +++ b/drivers/net/wireless/ti/wlcore/event.c @@ -62,6 +62,13 @@ void wlcore_event_fw_logger(struct wl1271 *wl) if (actual_len =3D=3D 0) goto free_out; + if (le32_to_cpu(fw_log.max_buff_size) > + WL18XX_LOGGER_SDIO_BUFF_MAX - WL18XX_LOGGER_BUFF_OFFSET) { + wl1271_error("fw logger: max_buff_size %u exceeds buffer\n", + le32_to_cpu(fw_log.max_buff_size)); + goto free_out; + } + /* Calculate the internal pointer to the fwlog structure */ addr_ptr =3D internal_fw_addrbase + addr; From nobody Tue Jun 16 03:46:18 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7893039B4AE for ; Wed, 15 Apr 2026 22:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291855; cv=none; b=duU9fEZPM6k/GQwMxxMBpWGJdD5Y1N0Cr3ylO+XtAG+fDIuRB+XgOj8hVxqM2+mrOhVPBKyD5EcJNIO41KmNzqvhCdholAQwiRNBs2XFloZuABRiEtHIRlnN7er7sqtyXP1W0vXJXEro/f1P6EuXwwi7cxuVhiA6d1oSYIQlgkc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291855; c=relaxed/simple; bh=3NtyoA1+rIxC6eOqlCUu6L5JyAy/EPsSeH2SVhd3LFs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A2jxLogI/kFQ/pJWtQZyQRajxgZbeKd+oRo0jVVXN7sXm9FGY1TPy8yXRUN1i/5bGINQVRgjYXQuRoDSCNu6zFH0ecINKOIFDjL19rf0zT7JDT0TG9xtVkRPgDwY/Nx4suneBX9XFmjk1kKjFptniCBQFlGkceqaHJ8L+r5fL6Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T1Jy6fJU; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T1Jy6fJU" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-488a29e6110so77763575e9.3 for ; Wed, 15 Apr 2026 15:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291853; x=1776896653; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+Tt0YKW321XbT71CwRPCUmwYnUbE6Bqe7J0z7izkIPc=; b=T1Jy6fJU/s01b6lbjaOZdBXvIieaA/wkKYCZvZttCo4f25v3ANCFpfqGj0ZauLckhV hAsYPdnDhtPeaqtMYMPoDBzeUVcLK220XzREauPuqBVx+8bqcLohXwbb4NafVP88cAm+ p3YloC4sjMU+y/Fppj7E9cyZCL4IIjuRFFOXrqyANiWigyHbVWp/5ULwmiTVSgtwEYLo A07k3qrWJg/ThYzjewqcSm6tUwbW5NEIRWKtGAGd4x2uqz6IUQtWvNaxrcrFArZxsNGC CqLIvX83oaxpY3/4V7MWm9ANyuz6RSRoK/hDdyGfY7pqF1RHeslJXGkup6H5ZmZGwBHb oK5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291853; x=1776896653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+Tt0YKW321XbT71CwRPCUmwYnUbE6Bqe7J0z7izkIPc=; b=sd4VuHWmaWqeUB+d6eOZVTRhnFVCRnLYQq94Fr4EIV2vNvMBw+dyg/T1js2Xgwa03+ g+bDWfkai3fsfiCgKPA4bSK7wQzanU6OpzA/cppB+WgTRBZngVhgFZszNtVAe9EnliQR MYvO4xbrrt9Y+BfusV6j4NAboLhzoK7blYzY1i6iQawKlnLajaGKCI4FOcZmc8Bb74Yf BgkxCIRWKybFkx6g7tnlfpiUemU1cq8LEXKIaiuUAbvMNt8qop073zph81ZejS5gGOyC IrstpQ7W47VMN/tDTHCK2OxYnU4Ry2k9onEiepDZ3fXTSoYCnFA5iaQl4oh6bMy6DljF 5/kQ== X-Forwarded-Encrypted: i=1; AFNElJ8d+NOia/iYzZqk3BTawp5zWxGfVXNorqeVdLfIVo6TlAC8uPY0HTWjwObWKk1wDC1fP/wgNJlB83qS6eE=@vger.kernel.org X-Gm-Message-State: AOJu0YzeKreIqO+w0dPLwJig07CueFFGBSoEdc74/Ynuq1oT6mf/ed+B jMqJVZwsAoA/f0jAkY0wZS7GMZ7l0vfT6krnasr9CdYDnzQAJiyjSVs= X-Gm-Gg: AeBDiet8ZCz6ZbRwPpSyXy8hnPF2Z+Ti8JACDms+i17g9jhA3cdjlfaDiIXBoGJc3Gn qjURuMqOsAwHNy/7P6FYC0Z4BFQY9vKVxwFBgu2O2ar5X3DOGvUn7WvhMcvG0KlgqPQV9nADfz5 jvcMsgTDc3PzMdUR4Ckqyo87gx1bx9Po0RQFZ+eLZKcNk0NqLZ+XS1ZS7ZZzCq/+rJREzt6QCrK xrtl6o/YRS98W1RsgFPa59BazXDG0LClaH1szMPxT5fZ02FzYx4IHn9Welb9bRF4YO6kF1VgGCT bNoXnxawOUB5ParBrTG4E24vqL2HM4uVfiMYTVKtMDVlB+sTHWmmhVWG6Npyv+ITYWifw16AuPB zeBBXaxS1Vcq3sq5/+EgD8+d2MfUBT0iX8kj3XKJMlRyUf3UlAt4vEbrH5PJkISCrgsbsd5l03J ImTEE= X-Received: by 2002:a05:600c:8595:b0:485:3b00:f93b with SMTP id 5b1f17b1804b1-488d6ab8082mr239160085e9.31.1776291852777; Wed, 15 Apr 2026 15:24:12 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f5818da1sm1932785e9.6.2026.04.15.15.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:24:12 -0700 (PDT) From: Tristan Madani To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] wifi: wl18xx: fix OOB read from firmware SSID/password lengths in smart config event Date: Wed, 15 Apr 2026 22:24:09 +0000 Message-ID: <20260415222409.1542989-4-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222409.1542989-1-tristmd@gmail.com> References: <20260415222409.1542989-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristan Madani The firmware-controlled sc_ssid_len and sc_pwd_len values are used as nla_put sizes from fixed-size mailbox buffers (32 and 64 bytes) without bounds checking. Values exceeding the buffer sizes cause out-of-bounds reads delivered to userspace via nl80211 vendor events. Clamp the lengths to the mailbox buffer sizes before use. Fixes: e93e15fb47e5 ("wlcore/wl18xx: handle smart config events") Signed-off-by: Tristan Madani --- drivers/net/wireless/ti/wl18xx/event.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ti/wl18xx/event.c b/drivers/net/wireless/= ti/wl18xx/event.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/ti/wl18xx/event.c +++ b/drivers/net/wireless/ti/wl18xx/event.c @@ -82,6 +82,9 @@ static int wlcore_smart_config_decode_event(struct wl1271= *wl, { struct sk_buff *skb; + ssid_len =3D min_t(u8, ssid_len, 32); + pwd_len =3D min_t(u8, pwd_len, 64); + wl1271_debug(DEBUG_EVENT, "SMART_CONFIG_DECODE_EVENT_ID"); wl1271_dump_ascii(DEBUG_EVENT, "SSID:", ssid, ssid_len);