From nobody Tue Jun 16 03:48:00 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 227473845D9 for ; Wed, 15 Apr 2026 20:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776286237; cv=none; b=kmaU3gwlV2GGLL2alH3u+zN8jirZbxwnlqppktp4R6dwJKo7L2WgqvbHF+9oZ2HITVLN+WpXdILBR3sgVfTNkcmJwXh6IjLgiuBlhUxBYKt3clzFsJeD0joa2Uxeu7+qWKyxoA51vlPkn/4QQLcvCRqtWtoD3KiNH8UL5k8/nKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776286237; c=relaxed/simple; bh=xUvGExRn1JIMhaMrVeZ8FlE5z2gqEEdKQ9vRaXSYa/8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jzDwdyzGlxrudJJI4tlY4A31FpAHmC/lrrx+xU/RCpu64WgXAUhbBNAqQUuwZLVLmUrbXI6ar/3/x4gqBTYysW9PZdNi8LID/VvFCMIrcDnrY8mHl3FIxlGKxd/lO1tufrcbxStOvckL7xFpXyHKbXVwikF6njVzo2RI1QdF6tY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PqlwaBma; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PqlwaBma" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-488a88aeec9so96386865e9.2 for ; Wed, 15 Apr 2026 13:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776286234; x=1776891034; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=X5UjgvnDtHGKM9cTBMyUbG1NygpM0dsNdRiJlKXvD/0=; b=PqlwaBmamoBcMvYTKR/0JijP1Na64KaSm+TpsQjWZTIG1EfLv5e09ej/IocvvqdVCp fZBUclCJsNHTGGmlnT+7N3zsxxWhnzdaVzH3+Y08haMpKROwY+gpLc9I9ahEMQpEDkq+ zVekzLVxHfnct92mSzaAf2EqQaVs1h8MUFxLOMfx9HOt7PLfcDvQwz+Xs2hoVQOg3AoH 9oVNCSuJBDxaZUvOVi9WXB+UaUDMoDD26ib2bRYtWBDppHMoSHX2hdc3sqyiCYfvao/o UQW20fKh6BEaw2OW75M+axgNofkH40YS67/DvCOd1O+qtygE1mNtW4Aehw0M+fRUvxXQ 0TXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776286234; x=1776891034; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X5UjgvnDtHGKM9cTBMyUbG1NygpM0dsNdRiJlKXvD/0=; b=LitTdR6AFdF5Q1PbGtpNmEAEGc8EOikzJTiCI5ldtyJce4pmQk3F8jMDDb/BdKzzL3 rJv49k/AqmRX+lRCN1GvnAzpmxjsgYDSrNTR+2r6gEpt7557+gmzU+Jhmgy4qsg6xphA HgIAzh2uITHd8DM64D36X6qtWUAv1GlPw6HHagO2IgAst1+LYuy4+tkS/whbPDDuBQ97 i39hJ1PaatSI2Fd+IuY3IiRCnA6Y3js+OL9afnf49V7VZzJBr63J1NUBmNR2Jd3K0z/r 0sWTX0NUn38mQ31M8M8NSwiZlD+5cH6liR4QEJ5t2g9PSQoJ+Bg6f+iyhlX2SjhkjaJZ Y+Rg== X-Forwarded-Encrypted: i=1; AFNElJ8ZWalL0bN9QgQnRtgdJDZmWf+wqN8pd1wsZeJSTNtzo2EBClOYUQFAVKbEriSP8DRH/igyZhiPMcEEQDo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9aroYZB2mVbCezK9/i98SHA+NqqP6fPQGGUru2yJXHXlNHYAm z6J5Fy5s7nw/+OSdDNcVcn7UYvCdOzGHEV94nAaQDMN1Hk55lGnvKHcohtff2w== X-Gm-Gg: AeBDietPzF2M1YFM0jiHx43TIZOHQAPVqpQJONLM2bZVWK/DpuIuaTNa5pc2FCX1EIf Sgnf8Wvk6FfHz7P2lYOHGWIEH9H29E0zUBfS/o7c/Plq9gXNjG1SpEwjtCKvm7Yh6W5oM4LeIUY D97iAzW+4YGlJUea/PgeOk87gQYUSoK27W+r4YG5UxJG9FiFp0WKFSdr/lMEcJC/WL3SpNUmCyY yNYsZ3kw7uiNa20kR0ss9hsUUbL6CGLUGqejLDE6Vnd1J9bHENbX85oarMy8eF6yOfpZ3qjvbnD wv3nNLTgHaU95S0FMis5LxCCbEc572kFhHGZmd0ngYlCoTki/ejsqszG4WpBLosFtglldfVebgI k7X+Q0ZP+DsPgIlCULZEWUE2EsHVZy3nLOld1zsRJDWwMn4ctPLw8uTiClN97AXTsANEfVN2HuT S+hA22aWcepuCi83NWSYt0wBhwkECe9g== X-Received: by 2002:a05:600c:c0da:b0:488:b187:d898 with SMTP id 5b1f17b1804b1-488d685b6e8mr280744715e9.14.1776286234407; Wed, 15 Apr 2026 13:50:34 -0700 (PDT) Received: from fedora-dev ([46.10.223.24]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0e9c668sm43399925e9.4.2026.04.15.13.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 13:50:33 -0700 (PDT) From: "Nikola Z. Ivanov" To: wsa+renesas@sang-engineering.com Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, "Nikola Z. Ivanov" Subject: [PATCH] i2c: Compare the return value of gpiod_get_direction against GPIO_LINE_DIRECTION_OUT Date: Wed, 15 Apr 2026 23:50:21 +0300 Message-ID: <20260415205021.1174764-1-zlatistiv@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The GPIO_LINE_DIRECTION_* definitions have just recently been exposed to gpio consumers.h by breaking them out in a separate defs.h file. Use this to validate the gpio direction instead of the hard-coded literal. Signed-off-by: Nikola Z. Ivanov --- drivers/i2c/i2c-core-base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 9c46147e3506..a2132d70fb36 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -445,8 +445,7 @@ static int i2c_init_recovery(struct i2c_adapter *adap) bri->set_scl =3D set_scl_gpio_value; if (bri->sda_gpiod) { bri->get_sda =3D get_sda_gpio_value; - /* FIXME: add proper flag instead of '0' once available */ - if (gpiod_get_direction(bri->sda_gpiod) =3D=3D 0) + if (gpiod_get_direction(bri->sda_gpiod) =3D=3D GPIO_LINE_DIRECTION_OUT) bri->set_sda =3D set_sda_gpio_value; } } else if (bri->recover_bus =3D=3D i2c_generic_scl_recovery) { --=20 2.53.0