From nobody Tue Jun 16 03:47:19 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0453486341 for ; Wed, 15 Apr 2026 19:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776281708; cv=none; b=nyODpD86zyksNWRClm9dyG9TsBXf5WGbEaDPAZkk9bzIH+CWF0wgF6UmDUfi96x+37JoESecGsrEFF2f6jzVXbuzqQ1U2Pk0eh5khhRQoXtuQKkvA/hF+qWXRt0m2+a5CFvkx2P7zBUDOGPx6yJjh6Au9AlLRP6ZN3/J33kCtm8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776281708; c=relaxed/simple; bh=QKiuHytyr5W0ReeO7ZYtKETgmvg/d8OewD1s8ol8EZw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=h1ZnNm/mYtxDenVyjE+WNH9h5iP8pyDsnv5OeQMGvfS6jW3xsQImvt0n5PC3TZxmwBjgUYaTFK40AbGoDzrfVS2ux0Icl5NxG2oS93tvzXorGasjJtntn+pwhYBdT01XaYke1H/eiEyUTEV0Z/550to0hXD/DYvgleK/IMMwQdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XoOVbzhf; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XoOVbzhf" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-35d9f68d011so4668794a91.2 for ; Wed, 15 Apr 2026 12:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776281706; x=1776886506; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hNsRiK7vCQLT5zngArE0NDO8in1o6VglpgtkmLZqYxY=; b=XoOVbzhf/2LDbyO954CyaHpuxuFUxioOLliKeV7lwE1uNZbESRtpZR5onuM6+VQEWl NGarltyb5QDtu106AIriTXDT93CWqRoep+SyXCeFu0wEcVYNmM+C/hqIj7s9HViQnbp0 djIVW5wu/1hbBFlfUcRRVKsH3LN7SYMYYPwXN/sAQDsNsh+wcc0wfgi5TQ013Nr8mT+E OC1uTRWn6JyoYyf4uR2ju3Q3MXSud0aMHeoYK1J+7NvVHejPOUMOlVuqv+y0QQLxo14w bHjtHpPRT7mo1gL+kP/yN7m8RHSk2MyXfRiLztPYBoOAcr2TP0juurICjQobkzk6tAuH Xexw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776281706; x=1776886506; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hNsRiK7vCQLT5zngArE0NDO8in1o6VglpgtkmLZqYxY=; b=o+b9ut6Ya8ZU2OPR/EVqP57kL8HSzB9GeGUjkE3wX5VblGqtXXlj9rWBW228pLVa9P 9gLCIv7l37GAjJd6gnh83eSwp9X1wfYYaybYWeMHik4w8CwFgC9twyjyrnE77urfGm6m uYAbfFw5KAKlS2OpMcwy5kgGv5KM6+cRUk1kN4cLNUzC9DFmQgYyHeQho0NxyOb2F9/s pBk2027k5HZOvCG5uiL9tL8EgEZxJRocIob3WLWEUyEDdwe0G8stRqmt+M4qb2mRhM+U SnNl4eCyHNQuhJSoqDGs7z6i0PkKQFDQQUTT+SbbDqGq/WcHxkRNPMWVdIF4D5i7T4w1 ag1w== X-Forwarded-Encrypted: i=1; AFNElJ+fvMOs0Dn9J0u3rQtZs4+tfsKkPDKJpuXHMWmSGiyXDsGb2IxMUOH9FCLFlAbaH39KLKbw/oeOVaQEnxI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8RRjm/8UIoTleNP5QInuh7MeodKd5gOXXfqplu+eBGCFQCR4P WQ2uFJJn+dymS8dyKCIWRi+im8uhkV5QMNmWQ1Uy0xUh0Ox7uQ27GsRB X-Gm-Gg: AeBDietceA/z74/MK91JZ0ReL8/u7ytadSbbdkrc0IwCFe6QIjOLtmKWAyfca581Cjs IVaoaBjY7fKqQdmTYkKIQT76KIqGOVUK9wJb+Ll2O5j2CEQ4oJr4Nbcagb/38jprps90eF1NfGw i39A0cnVC+MNk14L7r7WW6oTy2r6ngn4WrYiH+uoi2rSj0iV2fihSAUX1M7j6uPWnO5UV2Kt5mp YswW2y0qr/h+wTRWwtOZLVo3aSh4nIL8ne2NArQ1S5W4WIT9WRz5WpyVHI3I85mqb+8ksk3TaZ4 gYm2NJz931WzcJ20VFAPu5WLALNqpC8Gpz/r3tvoSf94tlTM+t7VqDjbwXhryaKArZgcpkLkt1R T8OheuEZmjDZ5TkuZwb4FmsJghaXdrA8PI0KngccKYSa1I7Szu5O/CzAl93jvaEtiFZPb5QQCIx MTjQRNW7omItrmEU0HBJsclBW40TWqB5//Pfk= X-Received: by 2002:a17:90b:1a91:b0:35b:e4d8:e21d with SMTP id 98e67ed59e1d1-35e4250f263mr20794094a91.2.1776281706281; Wed, 15 Apr 2026 12:35:06 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:93ee:194:b07d:a9b2]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fd1fe9fcesm3198430a91.2.2026.04.15.12.35.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 12:35:05 -0700 (PDT) From: Guangshuo Li To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Guangshuo Li , Andrew Morton , Stas Sergeev , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] x86/rtc: fix failed fallback RTC device registration handling Date: Thu, 16 Apr 2026 03:34:55 +0800 Message-ID: <20260415193455.3869807-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in add_rtc_cmos(), the embedded struct device in rtc_device has already been initialized by device_initialize(), but the failure path ignores the error without dropping the device reference for the current platform device: add_rtc_cmos() -> platform_device_register(&rtc_device) -> device_initialize(&rtc_device.dev) -> setup_pdev_dma_masks(&rtc_device) -> platform_device_add(&rtc_device) This leads to a reference leak when platform_device_register() fails. It also causes add_rtc_cmos() to report success unconditionally and log that the fallback platform RTC device was registered even when the registration failed. Fix this by checking the return value, calling platform_device_put() on failure, and only printing the success message after successful registration. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 1da2e3d679a8e ("provide rtc_cmos platform device") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- arch/x86/kernel/rtc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/rtc.c b/arch/x86/kernel/rtc.c index 314b062a15de..4761c5b0234f 100644 --- a/arch/x86/kernel/rtc.c +++ b/arch/x86/kernel/rtc.c @@ -139,7 +139,11 @@ static __init int add_rtc_cmos(void) if (!x86_platform.legacy.rtc) return -ENODEV; =20 - platform_device_register(&rtc_device); + ret =3D platform_device_register(&rtc_device); + if (ret) { + platform_device_put(&rtc_device); + return ret; + } dev_info(&rtc_device.dev, "registered fallback platform RTC device\n"); =20 return 0; --=20 2.43.0