From nobody Tue Jun 16 03:47:18 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23CFA382F34 for ; Wed, 15 Apr 2026 19:10:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776280216; cv=none; b=CIrX4rjR8aCt3rarEK53CCgwvNkNOV0MeBECoGY73ZL76Jpxjx+Lk78nk7tNl8DCHOujbwxHytGoaheJobHZg3LN1hppDSJPQEdH2WImegfTXVh46BBllhapCTKepgWssHPwB9QwR/AY5sMO/Slaa8xP5Gq8AvaXYeB9rbyKRn4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776280216; c=relaxed/simple; bh=EHnhESO1Tx/OJNq6G8Y2HbREZZHJK7I6MopoJjS56d0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=U6H5mkJnQWChfIcflI7M0xSu/gvd2XXj4rYrY8LLYZpaihCx2NxVQzpPaxhveYNRX8TxMLA5ex4jQ7AGxb/k4ysZJJOhDzL7Dp2acWBK99TGTG5JXncLb5XNV8tFz9MWn/93q7yXG2h2Q/1rAINyRXtNbK8VRamwN+EYyfGTdqw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JUMTIqyD; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JUMTIqyD" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-35fbca04006so1809257a91.1 for ; Wed, 15 Apr 2026 12:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776280213; x=1776885013; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LTqrfv4BEcpMmcd4d3ppiH5KBkdSGHZGeXMM12mQixA=; b=JUMTIqyDIATG+tzvtLpOSPwhRZiFGvkUy8gz8vZyTZlLt9Qm4ur8sogteyfRf4ZmNh D02DMhvdBf1KOgVLrSLLZA2gMvLfyil4zia2vkqnO+r2obc/Y66iFJHomlrVKBkpSfG0 Qp7sCWBIbG0odU0DtYiwa2LplwsZuMnoRkt4C9+NJTTIO7mKJbeVfPeMdtlHUdVs6OYE SWkvbY8Z0q+lWpLX9kYlknPCZNJo4YYMGTcmDUtuCsEqLlqC6C+duhyBy1zOSVAwnS+5 rndF0m3KhIklbqbp5vyVzTB4FKkLWWuoX8m1l/ScYzKzP65EqSXQG4dQVnn6pS+gfJKe GAnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776280213; x=1776885013; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LTqrfv4BEcpMmcd4d3ppiH5KBkdSGHZGeXMM12mQixA=; b=qGUkxNFt5fH0nGhQPEJ8Qv8Co4fVGfgsrw16UxsMsk1Tt8+5fDGAkoDla0WGwvYaKw 1hvL6+f1hlzK9At+Ci32CAeQtcTbTLtJPG0u4g2XRFKH/bmwA84pn0uBpBMi5TYHdg5X 9UjHsR10VL/5Sau7yN07IahQlVEAalDF9oxXGrNnqY7Pd6aOP+l2bw932FmiVOFulvIo YJIGB9aICuGINbXMd5DNsAFX8h3mnVdZKB2NN4yGFRwMUhLsf689OTtbqOi6ZfPiE9Ge dbqhlw1SZadIrd1xWzsVbyWx42ZZ1hbzTr/pa3tIOecY+nHSaKEUjoLsJA+QYAZEmGTx HMhg== X-Forwarded-Encrypted: i=1; AFNElJ9BQv1V610GzsOb1eaMwrW+LwX82EOavbBW37bUPaYXzyOLptdR2cDMq38eqgt6EmurwPnRwnXTK+Qspaw=@vger.kernel.org X-Gm-Message-State: AOJu0YxGrBybBeN8P4zHOGq/uBjNAal1chGnEHQ8pmvA0YybIjN+pcqx RXjNcRL2GySE92agUZYzN7OS4JWNmrgWjYMtJw0hSfpv+06nuZPPKZdfdobN+kkYsnIbww== X-Gm-Gg: AeBDievj82pXj4s25XZSbrD7RbMCD3wsf7IS/XqIQnwYVwOxtFLm4XESZOiI1FzgbHC SuXdppb+zsb2jB1H+KNYgofhoEdez9HK7VBEh3PDSJ9Mgbl+QK1EX8bryBfwATlmw06gYGdPAyO 2s7SYQpvfM5sudFLkLo9H3qryItI0CXPSRR4HXQI3nB7MB9t9DtDrDFS+Kdxj056MiDRyFbIqg4 KIeWxYUs6wj7ro4bM/Jc70B4QgK0wNiNqJce1m7jsMbFj8imoDeRrimjFGb591hEPQlGUayON20 t5M/IKB3VkBq34dDO9wO9nJ0mgO7K3jhDk/Jq6txS7fti7gSAT1p8RCRcp3SCdeRutrF7TFqqq+ +LyCEJ8HGSmE+45p6lOIQeLk5on9b9LtJ99u5kVL1Er/6gDNl0hPbBzkqyreu5KcbrOWZPVUz1m Y/6z7tdIE1pgLPTn7tvvpQnTkAMpRqfpiOKZAUjiBTSqXKsg== X-Received: by 2002:a17:90b:350b:b0:35d:a2d3:5c44 with SMTP id 98e67ed59e1d1-35e428581f9mr22426248a91.28.1776280213582; Wed, 15 Apr 2026 12:10:13 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:93ee:194:b07d:a9b2]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fd3074758sm2759890a91.1.2026.04.15.12.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 12:10:13 -0700 (PDT) From: Guangshuo Li To: Helge Deller , Guangshuo Li , Andriy Skulysh , Paul Mundt , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] fbdev: hitfb: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 03:10:03 +0800 Message-ID: <20260415191003.3829558-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in hitfb_init(), the embedded struct device in hitfb_device has already been initialized by device_initialize(), but the failure path only unregisters the platform driver and does not drop the device reference for the current platform device: hitfb_init() -> platform_device_register(&hitfb_device) -> device_initialize(&hitfb_device.dev) -> setup_pdev_dma_masks(&hitfb_device) -> platform_device_add(&hitfb_device) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before unregistering the platform driver. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 048839dc548a5 ("video: hitfb suspend/resume and updates.") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/video/fbdev/hitfb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/hitfb.c b/drivers/video/fbdev/hitfb.c index 97db325df2b4..29708c2d506d 100644 --- a/drivers/video/fbdev/hitfb.c +++ b/drivers/video/fbdev/hitfb.c @@ -495,8 +495,10 @@ static int __init hitfb_init(void) ret =3D platform_driver_register(&hitfb_driver); if (!ret) { ret =3D platform_device_register(&hitfb_device); - if (ret) + if (ret) { + platform_device_put(&hitfb_device); platform_driver_unregister(&hitfb_driver); + } } return ret; } --=20 2.43.0