From nobody Tue Jun 16 03:48:17 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8874383C9E for ; Wed, 15 Apr 2026 19:07:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776280071; cv=none; b=PyTJdHY/oiCkxCYyg6l/8u4WnV1uJmnWfidNDBcSTKntIpB4eEfMfb5vqidYVkkNPEjZQxqwvrIQdwFh0/ByjjQdJg8jaxwplzA7tPPbzzUJ3le/J1oaN/kUz4YWSHZR6nzP1g6WK15wGodwJ4fLauS9ihXw3gdHO2/wOtDjR/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776280071; c=relaxed/simple; bh=MQ/sUqpism27LsU0EGoWQQpbieUlKUv3I6sun9A9TAo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lYtyqfI2ysd/DyEpijMUZkKegYYhecCKIMfNgLr6AFnTmAhzuJS2tmzH8qVF3Ak5B3NVMt4mW2LLJcWfugxY/0qSRzRhZzGhlodbkiY32HLcNkELnlCKXgeRu9IezRs/tkTeVqV5IzY3IKPmx3dHUztjVGWeuG73XOHBhuJDAXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LNkTn3fB; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LNkTn3fB" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2b2589c26e3so64397045ad.1 for ; Wed, 15 Apr 2026 12:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776280069; x=1776884869; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PDtRvz4EVThH1+OkwbQhx5LhEh7Xl5HdhpT/91cyYas=; b=LNkTn3fBV9tYuTD6LWYr8LE0O+pvQT+z1WDCZURwKg1pcCaQFebJ7k2uNVTwIUGUmg E3PkHHftn48OGQ7q/zuzuJaV+ZJWKXHkNSERRGP2sfkkvToepOiCJLyPQgq7d8+YshEu 9MLKZ/oNTZn9uwMVUiWIfpF7Pn3Mp+biJ3+sEQWz61hKBqQ2u+OXR50fobUxwjNzjtps nbN3ri4N7Q7e75MZFNmC+H3i3Dky13tfCfl8lyBe9Q25ECnJTafcT3XO0mTn7DD/kEuR GCxY0+PibliVZRSqh7p01n/o7/yCmhJXJpwXlexzef8xgtLsOy7SFSgLlIJiIb9ZJ8d3 6sHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776280069; x=1776884869; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PDtRvz4EVThH1+OkwbQhx5LhEh7Xl5HdhpT/91cyYas=; b=MsFyq2uo4ZH/399dWcNTPGC9Hbe9WZnPYa0F5M8CZ33uihKKFVm3eZHMAxW3YzrbE5 l85Q6V5xZ5yLhRXrhCGnYOcNOIMomdVDKk02DJikvDSm3jubyL4pSg2JpL2voWysrgMk weiO1ds2S+8dCghG/zgD83twbjCSuBW7Q/sv7IAUpYViUwxCMEqFbGyzoTqCM9btgqVu ejNsuspzKO3iXKiqomn0UvsKbXJsOaOhL8BGg1wHx5bHmi8VlIwXDjZ3voIz18XuB4Gt z6J/1ByBcb1+fScGw96SFNZJEebhPxvfKwkkl90QsxxhvWF0Ewft+npg/eKfcWtZNXf6 U8Rw== X-Forwarded-Encrypted: i=1; AFNElJ88ZDRr/XtX5WGOBxo8+/CQ6MZo9HYzWmTavq2s4XPeazpTv1xmr0GJCeh5DIAng70Ogj2uAngQUg+lvtQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyTATI8Ta5jSzlOh+qzBRqCsQAu8uJ2a34/oim8W8bu0lnPVrIQ 4G3BjNk4HGL9vSiDRqFAH4fs67lZxQaDRLB5XfTtoKjQ/7JnHEquBFAR X-Gm-Gg: AeBDiesVIas3f6T5nSRri801ffNWj4YqujyLSG+ZYtWJyJhPvlJUcT0+yRSbdhCd2rl QY6fQLwB6U3TPxCC+0BunI/CwsCTyfXV9gNxaCjpdF6UrtGa5qfi+qnGEtrO7u4LCbGU9NqP0/C abXyzhrMkIrYTAsDL8pLuuFIQX8Z+YWWMyaXnQhhRViC9zjpIoAVWKchjqTs4D+Gxz7CZArH6xC VQa5Kf1yDVo1bqFTR3yjuJR+VIyQ/W7rLx3HsC732xdDeg6LYpPDm3MLD3Cwq+1gVHdxsPm4Kan e35+EFih+eqK9dW/peY+uiofjSo5TEFSvtmoXAV7yGmmIkJX0RhcJRE0ZVPLd+0ixnJVm80Lhw6 srCWCz2VCyJiksVXdvv22XRGDPCp7MKb9VqcSOgZYBi1cdrqiu2wTe5oegSy627qKaq/V6aUtvi QxPP0xV4WNs9Uqdcqovz3StXG1NM+wTlkwZlo= X-Received: by 2002:a17:902:9341:b0:2b0:4fb6:85ce with SMTP id d9443c01a7336-2b2d5a45a0bmr183001445ad.21.1776280068622; Wed, 15 Apr 2026 12:07:48 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:93ee:194:b07d:a9b2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b4782b53e2sm41305185ad.74.2026.04.15.12.07.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 12:07:48 -0700 (PDT) From: Guangshuo Li To: Helge Deller , Guangshuo Li , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] fbdev: dnfb: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 03:07:38 +0800 Message-ID: <20260415190738.3821974-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in dnfb_init(), the embedded struct device in dnfb_device has already been initialized by device_initialize(), but the failure path only unregisters the platform driver and does not drop the device reference for the current platform device: dnfb_init() -> platform_device_register(&dnfb_device) -> device_initialize(&dnfb_device.dev) -> setup_pdev_dma_masks(&dnfb_device) -> platform_device_add(&dnfb_device) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before unregistering the platform driver. The issue was identified by a static analysis tool I developed and confirmed by manual review. Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/video/fbdev/dnfb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/dnfb.c b/drivers/video/fbdev/dnfb.c index c4d24540d9ef..72a9c47418f8 100644 --- a/drivers/video/fbdev/dnfb.c +++ b/drivers/video/fbdev/dnfb.c @@ -296,8 +296,10 @@ static int __init dnfb_init(void) =20 if (!ret) { ret =3D platform_device_register(&dnfb_device); - if (ret) + if (ret) { + platform_device_put(&dnfb_device); platform_driver_unregister(&dnfb_driver); + } } return ret; } --=20 2.43.0