From nobody Tue Jun 16 03:48:18 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F1B837FF73 for ; Wed, 15 Apr 2026 18:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776279235; cv=none; b=FKtcR5jw0+B8HVtIZ313pVIZrN2+paizJMb6KE747gMze0hEDUh0oNCL6g+A0jc0dvpb1kxeycrHEW42twqZApe+S30loN59MAgQPzbT5D1sbRX8KopZPbA5UlwNHOxVqakal+L+YEcrkLM497ZKePOMnbAdJC9JnTS5uwDTlXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776279235; c=relaxed/simple; bh=wXf+CtXMOHb6XNnOuHfGJXshs49io3F3XFjW0t392rQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bHKP/byULg53k9N2jyBGP4fxPawiD9dIbyHctiiFT/PNEFeL96r2ZYje5ikXWkngSMxpWlCMxOCONzX5xqE7TqbLGZhqlNu2N9wGDDk4IXMWwitSDh4r/8NOZ6f5ux6ugZbV9Y1T9c+Ocu89uW6vw68ubbvkr6AdthIsemY/TLA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P9os1uoC; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P9os1uoC" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-354bc7c2c46so4460609a91.0 for ; Wed, 15 Apr 2026 11:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776279232; x=1776884032; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ic39KQsDtjbejfoaSX2BWNXeNHAHmD9Tq1YFCoyddVU=; b=P9os1uoC8LhzUgsGqx/OygwsJXPSu5+qwOUuCMn4qLBdcGfVEBVzG6yTM6CJO2ODMe jGXDJnt+koJmimMxyoJ36qw/2uO0Uwttt5+uTq5HnCiRemCeqtymQfpCdsqpGwHDCOd1 gp4C5pNHzaFfwRVhr6bte/YS9oXjLhC91X8m5kPYfdt1vg/tLS5mrCrweW5a4IkpKZne 95L92krvHDe9jisjuGQxFRG1ZLOkfDASqySuGfgRS8+Zti5E7uiZj8Pv/hLJ5cTxy21c +s9UKYNkAELvsmNshYLrLhJz33LSOKpzTDLYDxIjG9pyOUzuq1hTM9UlidYyTa9Yy5i4 1OPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776279232; x=1776884032; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ic39KQsDtjbejfoaSX2BWNXeNHAHmD9Tq1YFCoyddVU=; b=AEywCBbbbdyoV1ye8Rv/8GA4P+pJkjHHxwMlNdJCSVflymAuCQd1EPQbAhclImdH06 8cLh+tHOXmx03G0uR3OeQfKAPI+JDo2BTFqneBuEJCtYEjBTBnJu6C9ozWlLX5NENzuA boNoQpskq5afRcJWIuyYtBKg/CIBg5PswfxhYe1ILXsa5mQS174jo3ybj79HtdsGveOB C1m7EwQNa3UeyBQIa40V1VlBAm9qrKNgiuOS4f/lg4rLYVnac02E/mDvj5Uvljbc+lvk Ofxkiv4eaNjTXPwUNrUPT6rLHl/5ZFq+DSjQ8xpOEANUkDwyWZBppmGcMeWhFHhWlAyx LucA== X-Forwarded-Encrypted: i=1; AFNElJ9Nm5FhMm5G/0nqG30eqMNSfR9/R14H9aDYKsO5UfICTTYd+PeGBYOVepPBOjDFlRyLfYrVW3jjfTr3qbk=@vger.kernel.org X-Gm-Message-State: AOJu0YwV6c0mIZwroksJxZQ8w3/qAFdLpUbPKPcZc9t1wHwDQuF/sogD TQzFsUVfa+HdnRCEwbLrLlz++MFiP9aQuZ8hvmFXdeP8ncc3o9FLkF9R X-Gm-Gg: AeBDietlLxBy46aF3L2j+z2Ut7JU1c5B2rQlFHDBq4jkch5JBll6VWGSFu8yQA1RxUm ExHFFTUPqs5FKLmMjZL+7m9BgUzDGkfrD24wiHQIB1GtiKhdw1Kiv9fCnWcHpFsq06Z9zKUZZXo Agg5yCrk0wLLLw4f7N+n3aPlnKaymmz5MiHt/LB/C76YJ0PxC0HwZYlpD+UEVIvySmLxeZAAhko Ebc8UGOBTmtzOYR4+OxsW0T9aAgZxuaUD0wsV6QH7VO394YfTZUJeMRYcG74eCpbuThiunDdNxF r1fM9PmtiMtKeqir1S3EIWomXCeyTDXYj42rwGmTDxnbwcbsL6x2N91JqK5HPoveopSWdxU705E HEOV5v6FCCZp84Dv0k9icd1GD0IBRPPjrK3uEzDup7WkcWBsoLGmn5OV+L787NEv9L443JFCz/o +ijakZ3wtbGaQg0t3fsazSB/wJGAFFD0DCnCw= X-Received: by 2002:a17:90b:3b52:b0:35f:c1cc:feee with SMTP id 98e67ed59e1d1-35fc1cd0410mr9788933a91.3.1776279232224; Wed, 15 Apr 2026 11:53:52 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:93ee:194:b07d:a9b2]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fd20d0c3bsm2834619a91.9.2026.04.15.11.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 11:53:51 -0700 (PDT) From: Guangshuo Li To: Greg Kroah-Hartman , Jiri Slaby , Guangshuo Li , Russell King , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] serial: 8250_hub6: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 02:53:39 +0800 Message-ID: <20260415185339.3804023-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in hub6_init(), the embedded struct device in hub6_device has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: hub6_init() -> platform_device_register(&hub6_device) -> device_initialize(&hub6_device.dev) -> setup_pdev_dma_masks(&hub6_device) -> platform_device_add(&hub6_device) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: ec9f47cd6a14c ("[PATCH] Serial: Split 8250 port table") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/tty/serial/8250/8250_hub6.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_hub6.c b/drivers/tty/serial/8250/= 8250_hub6.c index 273f59b9bca5..005dd6bec3da 100644 --- a/drivers/tty/serial/8250/8250_hub6.c +++ b/drivers/tty/serial/8250/8250_hub6.c @@ -43,9 +43,14 @@ static struct platform_device hub6_device =3D { =20 static int __init hub6_init(void) { - return platform_device_register(&hub6_device); -} + int ret; + + ret =3D platform_device_register(&hub6_device); + if (ret) + platform_device_put(&hub6_device); =20 + return ret; +} module_init(hub6_init); =20 MODULE_AUTHOR("Russell King"); --=20 2.43.0