From nobody Tue Jun 16 03:48:32 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B15E345731 for ; Wed, 15 Apr 2026 18:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776278930; cv=none; b=uY9RQothaZO04CrhWIThvL6KUM2R0kNvbcwqwfA1rsdq/FQ3NdOmdkffRwqY6FCJfkfOZnffKLfd6inUhWlaMwBXbMEhehnLun8qVf5ruQt72Are1UwhtFegPz9m3rC0nQwunjJv2NiSwO7/UGf/31NHhBXuMfQnhmIQopBuwvg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776278930; c=relaxed/simple; bh=8jS45grgwD9AuchmvvovcOD11olnelHkn7VzLhgRL/4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=O5RK5ZhpAgHqVDwPdckbIWNJcbNpvbMWQ0zBAToeK605fmEHpeBRGlnBNyYNxw8uYOA3qDYdynOH8y2727PWccVq60sUhrZRIFQOEGFQ5LSwZgYTGkhdOl13b935c8iGqQkivQBUcMzsyWx2BkSe1DTJCLQE6bAYkawlXK/wqQM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MU5MAMEb; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MU5MAMEb" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c648bc907ebso4988843a12.3 for ; Wed, 15 Apr 2026 11:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776278929; x=1776883729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fpeiV1qmh0y7e3ItJrqeH+Ewf1lI+cym8OkHjOuiZhs=; b=MU5MAMEbkCnG5CbixzwSyXZpxsGZ/JYwOLnDO2lTMzGMHQbkkqVPaZkfYLITraDSjo HDDIAT/OASrXQKALtTksXY8fIdffwf9xQdPT/B1pNF8QvgPYMNcetnPSN7yzoL/g/Nhd EZHdwYazAK96BsXerbtk/UeG2le2KLZXLBFFZm8dZqSDpNEFYIZu8FHW1ga49CjZMVlc 3wVf1a+dNSi1As49qW2Ipfw/E9xZXw2lpzED8gnNZFW0rV84vnVa7+etRKqR+JMLeFv9 44kHHZEKYho43addMMiVJcUaK0L94pZZ+IsLuSErLqeOWG8Q6Fo5tIN58TP580b4sv7r DKmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776278929; x=1776883729; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fpeiV1qmh0y7e3ItJrqeH+Ewf1lI+cym8OkHjOuiZhs=; b=BhP94HQLsYOgeRY9DA85AdcpcnUh3y9cDQuw9WbjVWgy8OFIUK2LzDRdqe3WBHsazb r9B5ZXx7Hv277/42lLsrjXhcohS6Jt3sQaaJaKIUqcJGTmTzteUE2Mg7q01Wo3ThxZjU pBXYI+pjngK8xqF12jHsrqAp/IiZ36fQdk9pqf+tzksIVPpLlLGy/rw1I1brcYKRs+ka ht97/lyGiY6NwY5jz5pLKfWdSxM1K9/39EG0nYNmjXd22t6d68cOTAdfUXlUeAgAVeiP IqQLvwkqXDaeXeueAUWlbgI788pCYzKCXCItq54mOInO23UTpEadgxzQIL+hwCAFHqPx gJWw== X-Forwarded-Encrypted: i=1; AFNElJ+H5BhSYOhNxkrPlCIPB7Hw2YPcs8GT/PQskSlFRTXbbwlGEPCdKHr3lCPqmQ5tEqTYQ+P4Cw1Y2Juj2m8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyy53jVzj8zGDiu7oH0raYk8iakO6w3sjZN/ONd6Gny5RnKCK2i yRmfzXDanV3AF6nAOo6ejfg2itQlFzt63gCcHTKXKOiMjtbIRTpPGUuh X-Gm-Gg: AeBDieu5+OHESXtxmgogJJjedjkD09DL4z4AQP7M4MCTXOnTSIgm1f1+oaydWQ/rZj+ Ll6InAqyTFI+Br7/0JobRsLDPHCFbnoH293+R8EBAX/I6lQ1brimqpAXKocVG3N0Iic23wPQ6Zc nmqpeLaYRUB7HnFzsDzhazvlZdYLZ47Ab2sLNIoDWXvMIMR1VHuwtMDN3movO7lU7P1bh1JF6Yx llBAg+gaZ8GRPItTDrzG8G9J8kn7zoy9tbBIdlAjxOqzMMMWtWvjRCyatSDQzEl92XPp1x4iWUz k+WeeXPVHeXioXHGHCEK7ZSLqM0wUWIoNKXsHkN2oA+HVBQBwEWtjxPMJSHrwb7V4pVVCbYT9hq uiWz80LijlDRBsTicZ5s02xO0arjkZv2jVps9NonVgXng8eDleXPd1AhKQoSunFBUo0KKN3tJE7 bJm3SBvyO6JUzfku48myVgwbIUOd9P53DoKXE= X-Received: by 2002:a17:903:b0e:b0:2b4:5cea:f61c with SMTP id d9443c01a7336-2b45ceaf83emr141942895ad.4.1776278928666; Wed, 15 Apr 2026 11:48:48 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:93ee:194:b07d:a9b2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b478109a4dsm29936525ad.18.2026.04.15.11.48.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 11:48:48 -0700 (PDT) From: Guangshuo Li To: Greg Kroah-Hartman , Jiri Slaby , Guangshuo Li , Russell King , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] serial: 8250_fourport: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 02:48:39 +0800 Message-ID: <20260415184839.3796326-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in fourport_init(), the embedded struct device in fourport_device has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: fourport_init() -> platform_device_register(&fourport_device) -> device_initialize(&fourport_device.dev) -> setup_pdev_dma_masks(&fourport_device) -> platform_device_add(&fourport_device) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: ec9f47cd6a14c ("[PATCH] Serial: Split 8250 port table") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/tty/serial/8250/8250_fourport.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_fourport.c b/drivers/tty/serial/8= 250/8250_fourport.c index 3215b9b7afde..a65bc7316655 100644 --- a/drivers/tty/serial/8250/8250_fourport.c +++ b/drivers/tty/serial/8250/8250_fourport.c @@ -34,7 +34,13 @@ static struct platform_device fourport_device =3D { =20 static int __init fourport_init(void) { - return platform_device_register(&fourport_device); + int ret; + + ret =3D platform_device_register(&fourport_device); + if (ret) + platform_device_put(&fourport_device); + + return ret; } =20 module_init(fourport_init); --=20 2.43.0